[GIT PULL] Follow-up patches of cleanup-makefile

[GIT PULL] Follow-up patches of cleanup-makefile

[Akira Yokosawa]

Hi Paul,

These are follow-up patches of the previous patch series.
They will suppress warning messages and streamline messages displayed
during build.

I hope you like them.

                                                Thanks, Akira
          
--- 
The following changes since commit ca71bc6cf0bf303257b589d7edf251d627e90ce3:

  Fix typo in epigram attribution (2016-06-07 13:30:31 -0700)

are available in the git repository at:

  https://github.com/akiyks/perfbook.git cleanup-makefile-v2

for you to fetch changes up to 35e4d20da570eab7e6ca6a59b92ab438d2efd7b2:

  Makefile: Use wildcard for .dot files (2016-06-08 23:05:39 +0900)

----------------------------------------------------------------
Akira Yokosawa (3):
      build scripts: Suppress warning messages
      Hide sources of unused figures
      Makefile: Use wildcard for .dot files

 Makefile                                           |  58 +++---
 SMPdesign/lockdeq.fig                              | 219 ---------------------
 .../MoreThanOneValue-15CPU-noresp.eps              |   0
 .../MoreThanOneValue-15CPU-noresp.fig              |   0
 .../rcuimpl/{ => .unused}/RCUpreemptCounters.fig   |   0
 cartoons/{ => .unused}/patterns.fig                |   0
 cartoons/{ => .unused}/patterns.svg                |   0
 utilities/runfirstlatex.sh                         |   2 +-
 utilities/runlatex.sh                              |  16 +-
 9 files changed, 32 insertions(+), 263 deletions(-)
 delete mode 100644 SMPdesign/lockdeq.fig
 rename advsync/{ => .unused}/MoreThanOneValue-15CPU-noresp.eps (100%)
 rename advsync/{ => .unused}/MoreThanOneValue-15CPU-noresp.fig (100%)
 rename appendix/rcuimpl/{ => .unused}/RCUpreemptCounters.fig (100%)
 rename cartoons/{ => .unused}/patterns.fig (100%)
 rename cartoons/{ => .unused}/patterns.svg (100%)

Re: [GIT PULL] Follow-up patches of cleanup-makefile

[Paul E. McKenney]

On Wed, Jun 08, 2016 at 11:36:14PM +0900, Akira Yokosawa wrote:
> Hi Paul,
> 
> These are follow-up patches of the previous patch series.
> They will suppress warning messages and streamline messages displayed
> during build.
> 
> I hope you like them.

I pulled them in, but I am getting the following when I do "make clean":

Makefile:124: target `SMPdesign/DiningPhilosopher5.pdf' given more than once in the same rule.
Makefile:124: target `SMPdesign/DiningPhilosopher5TB.pdf' given more than once in the same rule.
Makefile:124: target `SMPdesign/DiningPhilosopher4part-b.pdf' given more than once in the same rule.
Makefile:124: target `SMPdesign/DiningPhilosopher5PEM.pdf' given more than once in the same rule.
Makefile:124: target `advsync/store15tred.pdf' given more than once in the same rule.

But I was getting them before these changes, so I pushed them out.

Which raises a question:  What should we be doing to test Makefile changes?

I am guessing something like this:

	git clone git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/perfbook.git
	cd perfbook
	make -j16
	# check output
	make distclean
	# check output
	make -j16 1c
	# check output
	make distclean
	make -j16 hb
	# check output

Is there some way of automating the checking of output?

BTW, the reason I was so quick to accept your changes last week was that
I -really- -really- like the fact that make -j now works.  This makes
building from an empty archive much nicer.  But the above errors do
underscore the need to test Makefile changes.  ;-)

							Thanx, Paul

> --- 
> The following changes since commit ca71bc6cf0bf303257b589d7edf251d627e90ce3:
> 
>   Fix typo in epigram attribution (2016-06-07 13:30:31 -0700)
> 
> are available in the git repository at:
> 
>   https://github.com/akiyks/perfbook.git cleanup-makefile-v2
> 
> for you to fetch changes up to 35e4d20da570eab7e6ca6a59b92ab438d2efd7b2:
> 
>   Makefile: Use wildcard for .dot files (2016-06-08 23:05:39 +0900)
> 
> ----------------------------------------------------------------
> Akira Yokosawa (3):
>       build scripts: Suppress warning messages
>       Hide sources of unused figures
>       Makefile: Use wildcard for .dot files
> 
>  Makefile                                           |  58 +++---
>  SMPdesign/lockdeq.fig                              | 219 ---------------------
>  .../MoreThanOneValue-15CPU-noresp.eps              |   0
>  .../MoreThanOneValue-15CPU-noresp.fig              |   0
>  .../rcuimpl/{ => .unused}/RCUpreemptCounters.fig   |   0
>  cartoons/{ => .unused}/patterns.fig                |   0
>  cartoons/{ => .unused}/patterns.svg                |   0
>  utilities/runfirstlatex.sh                         |   2 +-
>  utilities/runlatex.sh                              |  16 +-
>  9 files changed, 32 insertions(+), 263 deletions(-)
>  delete mode 100644 SMPdesign/lockdeq.fig
>  rename advsync/{ => .unused}/MoreThanOneValue-15CPU-noresp.eps (100%)
>  rename advsync/{ => .unused}/MoreThanOneValue-15CPU-noresp.fig (100%)
>  rename appendix/rcuimpl/{ => .unused}/RCUpreemptCounters.fig (100%)
>  rename cartoons/{ => .unused}/patterns.fig (100%)
>  rename cartoons/{ => .unused}/patterns.svg (100%)
> 

Re: [GIT PULL] Follow-up patches of cleanup-makefile

[Akira Yokosawa]

On 2016/06/10 1:17, Paul E. McKenney wrote:
> On Wed, Jun 08, 2016 at 11:36:14PM +0900, Akira Yokosawa wrote:
>> Hi Paul,
>>
>> These are follow-up patches of the previous patch series.
>> They will suppress warning messages and streamline messages displayed
>> during build.
>>
>> I hope you like them.
> 
> I pulled them in, but I am getting the following when I do "make clean":
> 
> Makefile:124: target `SMPdesign/DiningPhilosopher5.pdf' given more than once in the same rule.
> Makefile:124: target `SMPdesign/DiningPhilosopher5TB.pdf' given more than once in the same rule.
> Makefile:124: target `SMPdesign/DiningPhilosopher4part-b.pdf' given more than once in the same rule.
> Makefile:124: target `SMPdesign/DiningPhilosopher5PEM.pdf' given more than once in the same rule.
> Makefile:124: target `advsync/store15tred.pdf' given more than once in the same rule.

I can't reproduce these warnings.
I tested with GNU Make 4.1 and GNU Make 3.81 on Ubuntu 16.04, Ubuntu 14.04 and Ubuntu 12.04.

Which version of make are you using?

> 
> But I was getting them before these changes, so I pushed them out.
> 
> Which raises a question:  What should we be doing to test Makefile changes?
> 
> I am guessing something like this:
> 
> 	git clone git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/perfbook.git
> 	cd perfbook
> 	make -j16
> 	# check output
> 	make distclean
> 	# check output
> 	make -j16 1c
> 	# check output
> 	make distclean
> 	make -j16 hb
> 	# check output
> 
> Is there some way of automating the checking of output?

Well, the output should depend on the environment.
Automating the checking would be not so simple...

> BTW, the reason I was so quick to accept your changes last week was that
> I -really- -really- like the fact that make -j now works.  This makes
> building from an empty archive much nicer.  But the above errors do
> underscore the need to test Makefile changes.  ;-)

Yes. In the past cleanup of build scripts, I made several regressions.

Or should we introduce 'configure' approach to check the existence and
versions of necessary tools?

                                                      Thanks, Akira

> 
> 							Thanx, Paul
> 
>> --- 
>> The following changes since commit ca71bc6cf0bf303257b589d7edf251d627e90ce3:
>>
>>   Fix typo in epigram attribution (2016-06-07 13:30:31 -0700)
>>
>> are available in the git repository at:
>>
>>   https://github.com/akiyks/perfbook.git cleanup-makefile-v2
>>
>> for you to fetch changes up to 35e4d20da570eab7e6ca6a59b92ab438d2efd7b2:
>>
>>   Makefile: Use wildcard for .dot files (2016-06-08 23:05:39 +0900)
>>
>> ----------------------------------------------------------------
>> Akira Yokosawa (3):
>>       build scripts: Suppress warning messages
>>       Hide sources of unused figures
>>       Makefile: Use wildcard for .dot files
>>
>>  Makefile                                           |  58 +++---
>>  SMPdesign/lockdeq.fig                              | 219 ---------------------
>>  .../MoreThanOneValue-15CPU-noresp.eps              |   0
>>  .../MoreThanOneValue-15CPU-noresp.fig              |   0
>>  .../rcuimpl/{ => .unused}/RCUpreemptCounters.fig   |   0
>>  cartoons/{ => .unused}/patterns.fig                |   0
>>  cartoons/{ => .unused}/patterns.svg                |   0
>>  utilities/runfirstlatex.sh                         |   2 +-
>>  utilities/runlatex.sh                              |  16 +-
>>  9 files changed, 32 insertions(+), 263 deletions(-)
>>  delete mode 100644 SMPdesign/lockdeq.fig
>>  rename advsync/{ => .unused}/MoreThanOneValue-15CPU-noresp.eps (100%)
>>  rename advsync/{ => .unused}/MoreThanOneValue-15CPU-noresp.fig (100%)
>>  rename appendix/rcuimpl/{ => .unused}/RCUpreemptCounters.fig (100%)
>>  rename cartoons/{ => .unused}/patterns.fig (100%)
>>  rename cartoons/{ => .unused}/patterns.svg (100%)
>>
> 
> 

Re: [GIT PULL] Follow-up patches of cleanup-makefile

[Paul E. McKenney]

On Fri, Jun 10, 2016 at 07:09:29AM +0900, Akira Yokosawa wrote:
> On 2016/06/10 1:17, Paul E. McKenney wrote:
> > On Wed, Jun 08, 2016 at 11:36:14PM +0900, Akira Yokosawa wrote:
> >> Hi Paul,
> >>
> >> These are follow-up patches of the previous patch series.
> >> They will suppress warning messages and streamline messages displayed
> >> during build.
> >>
> >> I hope you like them.
> > 
> > I pulled them in, but I am getting the following when I do "make clean":
> > 
> > Makefile:124: target `SMPdesign/DiningPhilosopher5.pdf' given more than once in the same rule.
> > Makefile:124: target `SMPdesign/DiningPhilosopher5TB.pdf' given more than once in the same rule.
> > Makefile:124: target `SMPdesign/DiningPhilosopher4part-b.pdf' given more than once in the same rule.
> > Makefile:124: target `SMPdesign/DiningPhilosopher5PEM.pdf' given more than once in the same rule.
> > Makefile:124: target `advsync/store15tred.pdf' given more than once in the same rule.
> 
> I can't reproduce these warnings.
> I tested with GNU Make 4.1 and GNU Make 3.81 on Ubuntu 16.04, Ubuntu 14.04 and Ubuntu 12.04.
> 
> Which version of make are you using?

$ make -v
GNU Make 3.81
Copyright (C) 2006  Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.

This program built for x86_64-pc-linux-gnu

> > But I was getting them before these changes, so I pushed them out.
> > 
> > Which raises a question:  What should we be doing to test Makefile changes?
> > 
> > I am guessing something like this:
> > 
> > 	git clone git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/perfbook.git
> > 	cd perfbook
> > 	make -j16
> > 	# check output
> > 	make distclean
> > 	# check output
> > 	make -j16 1c
> > 	# check output
> > 	make distclean
> > 	make -j16 hb
> > 	# check output
> > 
> > Is there some way of automating the checking of output?
> 
> Well, the output should depend on the environment.
> Automating the checking would be not so simple...

No argument here, but I was hoping...

> > BTW, the reason I was so quick to accept your changes last week was that
> > I -really- -really- like the fact that make -j now works.  This makes
> > building from an empty archive much nicer.  But the above errors do
> > underscore the need to test Makefile changes.  ;-)
> 
> Yes. In the past cleanup of build scripts, I made several regressions.
> 
> Or should we introduce 'configure' approach to check the existence and
> versions of necessary tools?

Let's see what the actual bug really is before settling on any particular
solution.  ;-)

							Thanx, Paul

> >> --- 
> >> The following changes since commit ca71bc6cf0bf303257b589d7edf251d627e90ce3:
> >>
> >>   Fix typo in epigram attribution (2016-06-07 13:30:31 -0700)
> >>
> >> are available in the git repository at:
> >>
> >>   https://github.com/akiyks/perfbook.git cleanup-makefile-v2
> >>
> >> for you to fetch changes up to 35e4d20da570eab7e6ca6a59b92ab438d2efd7b2:
> >>
> >>   Makefile: Use wildcard for .dot files (2016-06-08 23:05:39 +0900)
> >>
> >> ----------------------------------------------------------------
> >> Akira Yokosawa (3):
> >>       build scripts: Suppress warning messages
> >>       Hide sources of unused figures
> >>       Makefile: Use wildcard for .dot files
> >>
> >>  Makefile                                           |  58 +++---
> >>  SMPdesign/lockdeq.fig                              | 219 ---------------------
> >>  .../MoreThanOneValue-15CPU-noresp.eps              |   0
> >>  .../MoreThanOneValue-15CPU-noresp.fig              |   0
> >>  .../rcuimpl/{ => .unused}/RCUpreemptCounters.fig   |   0
> >>  cartoons/{ => .unused}/patterns.fig                |   0
> >>  cartoons/{ => .unused}/patterns.svg                |   0
> >>  utilities/runfirstlatex.sh                         |   2 +-
> >>  utilities/runlatex.sh                              |  16 +-
> >>  9 files changed, 32 insertions(+), 263 deletions(-)
> >>  delete mode 100644 SMPdesign/lockdeq.fig
> >>  rename advsync/{ => .unused}/MoreThanOneValue-15CPU-noresp.eps (100%)
> >>  rename advsync/{ => .unused}/MoreThanOneValue-15CPU-noresp.fig (100%)
> >>  rename appendix/rcuimpl/{ => .unused}/RCUpreemptCounters.fig (100%)
> >>  rename cartoons/{ => .unused}/patterns.fig (100%)
> >>  rename cartoons/{ => .unused}/patterns.svg (100%)
> >>
> > 
> > 
> 

Re: [GIT PULL] Follow-up patches of cleanup-makefile

[Akira Yokosawa]

On 2016/06/09 16:07:56 -0700, Paul E. McKenney wrote:
> On Fri, Jun 10, 2016 at 07:09:29AM +0900, Akira Yokosawa wrote:
>> On 2016/06/10 1:17, Paul E. McKenney wrote:
>>> On Wed, Jun 08, 2016 at 11:36:14PM +0900, Akira Yokosawa wrote:
>>>> Hi Paul,
>>>>
>>>> These are follow-up patches of the previous patch series.
>>>> They will suppress warning messages and streamline messages displayed
>>>> during build.
>>>>
>>>> I hope you like them.
>>>
>>> I pulled them in, but I am getting the following when I do "make clean":
>>>
>>> Makefile:124: target `SMPdesign/DiningPhilosopher5.pdf' given more than once in the same rule.
>>> Makefile:124: target `SMPdesign/DiningPhilosopher5TB.pdf' given more than once in the same rule.
>>> Makefile:124: target `SMPdesign/DiningPhilosopher4part-b.pdf' given more than once in the same rule.
>>> Makefile:124: target `SMPdesign/DiningPhilosopher5PEM.pdf' given more than once in the same rule.
>>> Makefile:124: target `advsync/store15tred.pdf' given more than once in the same rule.
>>
>> I can't reproduce these warnings.
>> I tested with GNU Make 4.1 and GNU Make 3.81 on Ubuntu 16.04, Ubuntu 14.04 and Ubuntu 12.04.
>>
>> Which version of make are you using?
> 
> $ make -v
> GNU Make 3.81
> Copyright (C) 2006  Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.
> There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
> PARTICULAR PURPOSE.
> 
> This program built for x86_64-pc-linux-gnu
> 

Now, I have found some problems in Makefile.
I'm sending a patch in reply to this email.
It might have some effect on the warning messages.
Can you give it a try?

                                                  Thanks, Akira

>>> But I was getting them before these changes, so I pushed them out.
>>>
>>> Which raises a question:  What should we be doing to test Makefile changes?
>>>
>>> I am guessing something like this:
>>>
>>> 	git clone git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/perfbook.git
>>> 	cd perfbook
>>> 	make -j16
>>> 	# check output
>>> 	make distclean
>>> 	# check output
>>> 	make -j16 1c
>>> 	# check output
>>> 	make distclean
>>> 	make -j16 hb
>>> 	# check output
>>>
>>> Is there some way of automating the checking of output?
>>
>> Well, the output should depend on the environment.
>> Automating the checking would be not so simple...
> 
> No argument here, but I was hoping...
> 
>>> BTW, the reason I was so quick to accept your changes last week was that
>>> I -really- -really- like the fact that make -j now works.  This makes
>>> building from an empty archive much nicer.  But the above errors do
>>> underscore the need to test Makefile changes.  ;-)
>>
>> Yes. In the past cleanup of build scripts, I made several regressions.
>>
>> Or should we introduce 'configure' approach to check the existence and
>> versions of necessary tools?
> 
> Let's see what the actual bug really is before settling on any particular
> solution.  ;-)
> 
> 							Thanx, Paul
> 
>>>> --- 
>>>> The following changes since commit ca71bc6cf0bf303257b589d7edf251d627e90ce3:
>>>>
>>>>   Fix typo in epigram attribution (2016-06-07 13:30:31 -0700)
>>>>
>>>> are available in the git repository at:
>>>>
>>>>   https://github.com/akiyks/perfbook.git cleanup-makefile-v2
>>>>
>>>> for you to fetch changes up to 35e4d20da570eab7e6ca6a59b92ab438d2efd7b2:
>>>>
>>>>   Makefile: Use wildcard for .dot files (2016-06-08 23:05:39 +0900)
>>>>
>>>> ----------------------------------------------------------------
>>>> Akira Yokosawa (3):
>>>>       build scripts: Suppress warning messages
>>>>       Hide sources of unused figures
>>>>       Makefile: Use wildcard for .dot files
>>>>
>>>>  Makefile                                           |  58 +++---
>>>>  SMPdesign/lockdeq.fig                              | 219 ---------------------
>>>>  .../MoreThanOneValue-15CPU-noresp.eps              |   0
>>>>  .../MoreThanOneValue-15CPU-noresp.fig              |   0
>>>>  .../rcuimpl/{ => .unused}/RCUpreemptCounters.fig   |   0
>>>>  cartoons/{ => .unused}/patterns.fig                |   0
>>>>  cartoons/{ => .unused}/patterns.svg                |   0
>>>>  utilities/runfirstlatex.sh                         |   2 +-
>>>>  utilities/runlatex.sh                              |  16 +-
>>>>  9 files changed, 32 insertions(+), 263 deletions(-)
>>>>  delete mode 100644 SMPdesign/lockdeq.fig
>>>>  rename advsync/{ => .unused}/MoreThanOneValue-15CPU-noresp.eps (100%)
>>>>  rename advsync/{ => .unused}/MoreThanOneValue-15CPU-noresp.fig (100%)
>>>>  rename appendix/rcuimpl/{ => .unused}/RCUpreemptCounters.fig (100%)
>>>>  rename cartoons/{ => .unused}/patterns.fig (100%)
>>>>  rename cartoons/{ => .unused}/patterns.svg (100%)
>>>>
>>>
>>>
>>
> 
> 

[PATCH] Makefile: Possible fix for warning of duplicated target

[Akira Yokosawa]

From ad4c29bc05026135cb56f66e79585b6788c2a3aa Mon Sep 17 00:00:00 2001
From: Akira Yokosawa <akiyks@gmail.com>
Date: Fri, 10 Jun 2016 23:26:01 +0900
Subject: [PATCH] Makefile: Possible fix for warning of duplicated target

This commit fixes use of flavors of variables in Makefile.
We should use "simply expanded variables" for variables
which are referenced in definitions of other variables.

Reported-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
---
 Makefile | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/Makefile b/Makefile
index 446c5f8..b508e61 100644
--- a/Makefile
+++ b/Makefile
@@ -5,29 +5,29 @@ LATEXSOURCES = \
 	*/*.tex \
 	*/*/*.tex

-EPSSOURCES_FROM_TEX = \
+EPSSOURCES_FROM_TEX := \
 	SMPdesign/DiningPhilosopher5.eps \
 	SMPdesign/DiningPhilosopher5TB.eps \
 	SMPdesign/DiningPhilosopher4part-b.eps \
 	SMPdesign/DiningPhilosopher5PEM.eps

-DOTSOURCES = $(wildcard */*.dot)
+DOTSOURCES := $(wildcard */*.dot)

 EPSSOURCES_FROM_DOT := $(DOTSOURCES:%.dot=%.eps)

-EPSSOURCES_DUP = \
+EPSSOURCES_DUP := \
 	$(wildcard */*.eps) \
 	$(wildcard */*/*.eps) \
 	$(EPSSOURCES_FROM_TEX) \
 	$(EPSSOURCES_FROM_DOT)

-EPSSOURCES = $(sort $(EPSSOURCES_DUP))
+EPSSOURCES := $(sort $(EPSSOURCES_DUP))

 PDFTARGETS_OF_EPS := $(EPSSOURCES:%.eps=%.pdf)

 BIBSOURCES = bib/*.bib

-SVGSOURCES = $(wildcard */*.svg)
+SVGSOURCES := $(wildcard */*.svg)

 PDFTARGETS_OF_SVG := $(SVGSOURCES:%.svg=%.pdf)

-- 
1.9.1

Re: [PATCH] Makefile: Possible fix for warning of duplicated target

[Paul E. McKenney]

On Fri, Jun 10, 2016 at 11:46:27PM +0900, Akira Yokosawa wrote:
> >From ad4c29bc05026135cb56f66e79585b6788c2a3aa Mon Sep 17 00:00:00 2001
> From: Akira Yokosawa <akiyks@gmail.com>
> Date: Fri, 10 Jun 2016 23:26:01 +0900
> Subject: [PATCH] Makefile: Possible fix for warning of duplicated target
> 
> This commit fixes use of flavors of variables in Makefile.
> We should use "simply expanded variables" for variables
> which are referenced in definitions of other variables.
> 
> Reported-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Akira Yokosawa <akiyks@gmail.com>

This gets rid of the warnings, thank you!  Queued and pushed.

							Thanx, Paul

> ---
>  Makefile | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 446c5f8..b508e61 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -5,29 +5,29 @@ LATEXSOURCES = \
>  	*/*.tex \
>  	*/*/*.tex
> 
> -EPSSOURCES_FROM_TEX = \
> +EPSSOURCES_FROM_TEX := \
>  	SMPdesign/DiningPhilosopher5.eps \
>  	SMPdesign/DiningPhilosopher5TB.eps \
>  	SMPdesign/DiningPhilosopher4part-b.eps \
>  	SMPdesign/DiningPhilosopher5PEM.eps
> 
> -DOTSOURCES = $(wildcard */*.dot)
> +DOTSOURCES := $(wildcard */*.dot)
> 
>  EPSSOURCES_FROM_DOT := $(DOTSOURCES:%.dot=%.eps)
> 
> -EPSSOURCES_DUP = \
> +EPSSOURCES_DUP := \
>  	$(wildcard */*.eps) \
>  	$(wildcard */*/*.eps) \
>  	$(EPSSOURCES_FROM_TEX) \
>  	$(EPSSOURCES_FROM_DOT)
> 
> -EPSSOURCES = $(sort $(EPSSOURCES_DUP))
> +EPSSOURCES := $(sort $(EPSSOURCES_DUP))
> 
>  PDFTARGETS_OF_EPS := $(EPSSOURCES:%.eps=%.pdf)
> 
>  BIBSOURCES = bib/*.bib
> 
> -SVGSOURCES = $(wildcard */*.svg)
> +SVGSOURCES := $(wildcard */*.svg)
> 
>  PDFTARGETS_OF_SVG := $(SVGSOURCES:%.svg=%.pdf)
> 
> -- 
> 1.9.1
> 
>