* Re: [PATCH] mac80211: Fix radiotap header channel flag for 6GHz band
[not found] <010101747ab7b9c0-45fa1c2a-3bb5-44e8-8e6d-457cad2e9845-000000@us-west-2.amazonses.com>
@ 2020-09-11 7:36 ` Johannes Berg
2020-09-11 20:50 ` Aloka Dixit
[not found] ` <010101747eef4d8b-8b5fdae5-790f-4d19-a2df-fba00350baa3-000000@us-west-2.amazonses.com>
0 siblings, 2 replies; 6+ messages in thread
From: Johannes Berg @ 2020-09-11 7:36 UTC (permalink / raw)
To: Aloka Dixit; +Cc: linux-wireless
On Fri, 2020-09-11 at 01:11 +0000, Aloka Dixit wrote:
> Radiotap header field 'Channel flags' has '2 GHz spectrum' set to
> 'true' for 6GHz packet.
> Change it to 5GHz as there isn't a separate option available for 6GHz.
>
> Signed-off-by: Aloka Dixit <alokad@codeaurora.org>
> ---
> net/mac80211/rx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
> index 836cde516a18..a959ebf56852 100644
> --- a/net/mac80211/rx.c
> +++ b/net/mac80211/rx.c
> @@ -451,7 +451,8 @@ ieee80211_add_rx_radiotap_header(struct ieee80211_local *local,
> else if (status->bw == RATE_INFO_BW_5)
> channel_flags |= IEEE80211_CHAN_QUARTER;
>
> - if (status->band == NL80211_BAND_5GHZ)
> + if (status->band == NL80211_BAND_5GHZ ||
> + status->band == NL80211_BAND_6GHZ)
> channel_flags |= IEEE80211_CHAN_OFDM | IEEE80211_CHAN_5GHZ;
I guess we should just not set any of those flags?
Not that anything even cares ... so there's no point in adding a 6GHz
flag to radiotap.
johannes
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mac80211: Fix radiotap header channel flag for 6GHz band
2020-09-11 7:36 ` [PATCH] mac80211: Fix radiotap header channel flag for 6GHz band Johannes Berg
@ 2020-09-11 20:50 ` Aloka Dixit
[not found] ` <010101747eef4d8b-8b5fdae5-790f-4d19-a2df-fba00350baa3-000000@us-west-2.amazonses.com>
1 sibling, 0 replies; 6+ messages in thread
From: Aloka Dixit @ 2020-09-11 20:50 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless, linux-wireless-owner
On 2020-09-11 00:36, Johannes Berg wrote:
> On Fri, 2020-09-11 at 01:11 +0000, Aloka Dixit wrote:
>> Radiotap header field 'Channel flags' has '2 GHz spectrum' set to
>> 'true' for 6GHz packet.
>> Change it to 5GHz as there isn't a separate option available for 6GHz.
>>
>> Signed-off-by: Aloka Dixit <alokad@codeaurora.org>
>> ---
>> net/mac80211/rx.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
>> index 836cde516a18..a959ebf56852 100644
>> --- a/net/mac80211/rx.c
>> +++ b/net/mac80211/rx.c
>> @@ -451,7 +451,8 @@ ieee80211_add_rx_radiotap_header(struct
>> ieee80211_local *local,
>> else if (status->bw == RATE_INFO_BW_5)
>> channel_flags |= IEEE80211_CHAN_QUARTER;
>>
>> - if (status->band == NL80211_BAND_5GHZ)
>> + if (status->band == NL80211_BAND_5GHZ ||
>> + status->band == NL80211_BAND_6GHZ)
>> channel_flags |= IEEE80211_CHAN_OFDM | IEEE80211_CHAN_5GHZ;
>
> I guess we should just not set any of those flags?
>
> Not that anything even cares ... so there's no point in adding a 6GHz
> flag to radiotap.
>
> johannes
Separate flag for 6GHz would have been best option, but I still think
better to set 5GHz as 6GHz frequencies start in 5GHz range.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread[parent not found: <010101747eef4d8b-8b5fdae5-790f-4d19-a2df-fba00350baa3-000000@us-west-2.amazonses.com>]
* Re: [PATCH] mac80211: Fix radiotap header channel flag for 6GHz band
[not found] ` <010101747eef4d8b-8b5fdae5-790f-4d19-a2df-fba00350baa3-000000@us-west-2.amazonses.com>
@ 2020-09-11 20:52 ` Johannes Berg
2020-09-14 9:14 ` Arend Van Spriel
0 siblings, 1 reply; 6+ messages in thread
From: Johannes Berg @ 2020-09-11 20:52 UTC (permalink / raw)
To: Aloka Dixit; +Cc: linux-wireless, linux-wireless-owner
On Fri, 2020-09-11 at 20:50 +0000, Aloka Dixit wrote:
>
> > Not that anything even cares ... so there's no point in adding a 6GHz
> > flag to radiotap.
> >
> Separate flag for 6GHz would have been best option, but I still think
> better to set 5GHz as 6GHz frequencies start in 5GHz range.
But why? wireshark probably needs to be adjusted anyway, so it can just
look at the frequency instead? And it would pretend that it's now an
"11a" frame ... so that clearly never was important, since that hasn't
been true since HT.
johannes
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mac80211: Fix radiotap header channel flag for 6GHz band
2020-09-11 20:52 ` Johannes Berg
@ 2020-09-14 9:14 ` Arend Van Spriel
2020-09-20 18:53 ` Aloka Dixit
0 siblings, 1 reply; 6+ messages in thread
From: Arend Van Spriel @ 2020-09-14 9:14 UTC (permalink / raw)
To: Johannes Berg, Aloka Dixit; +Cc: linux-wireless, linux-wireless-owner
[-- Attachment #1: Type: text/plain, Size: 756 bytes --]
On 9/11/2020 10:52 PM, Johannes Berg wrote:
> On Fri, 2020-09-11 at 20:50 +0000, Aloka Dixit wrote:
>>
>>> Not that anything even cares ... so there's no point in adding a 6GHz
>>> flag to radiotap.
>>>
>> Separate flag for 6GHz would have been best option, but I still think
>> better to set 5GHz as 6GHz frequencies start in 5GHz range.
>
> But why? wireshark probably needs to be adjusted anyway, so it can just
> look at the frequency instead? And it would pretend that it's now an
> "11a" frame ... so that clearly never was important, since that hasn't
> been true since HT.
It has been couple of month ago that I looked into wireshark about this
and I think it is already ignoring the band flags and just looks at the
frequency.
Regards,
Arend
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4176 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mac80211: Fix radiotap header channel flag for 6GHz band
2020-09-14 9:14 ` Arend Van Spriel
@ 2020-09-20 18:53 ` Aloka Dixit
0 siblings, 0 replies; 6+ messages in thread
From: Aloka Dixit @ 2020-09-20 18:53 UTC (permalink / raw)
To: Arend Van Spriel; +Cc: Johannes Berg, linux-wireless, linux-wireless-owner
On 2020-09-14 02:14, Arend Van Spriel wrote:
> On 9/11/2020 10:52 PM, Johannes Berg wrote:
>> On Fri, 2020-09-11 at 20:50 +0000, Aloka Dixit wrote:
>>>
>>>> Not that anything even cares ... so there's no point in adding a
>>>> 6GHz
>>>> flag to radiotap.
>>>>
>>> Separate flag for 6GHz would have been best option, but I still think
>>> better to set 5GHz as 6GHz frequencies start in 5GHz range.
>>
>> But why? wireshark probably needs to be adjusted anyway, so it can
>> just
>> look at the frequency instead? And it would pretend that it's now an
>> "11a" frame ... so that clearly never was important, since that hasn't
>> been true since HT.
>
> It has been couple of month ago that I looked into wireshark about
> this and I think it is already ignoring the band flags and just looks
> at the frequency.
>
> Regards,
> Arend
Ok, thanks for letting me know!
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] mac80211: Fix radiotap header channel flag for 6GHz band
@ 2020-09-11 1:11 Aloka Dixit
0 siblings, 0 replies; 6+ messages in thread
From: Aloka Dixit @ 2020-09-11 1:11 UTC (permalink / raw)
To: johannes; +Cc: linux-wireless, Aloka Dixit
Radiotap header field 'Channel flags' has '2 GHz spectrum' set to
'true' for 6GHz packet.
Change it to 5GHz as there isn't a separate option available for 6GHz.
Signed-off-by: Aloka Dixit <alokad@codeaurora.org>
---
net/mac80211/rx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
index 836cde516a18..a959ebf56852 100644
--- a/net/mac80211/rx.c
+++ b/net/mac80211/rx.c
@@ -451,7 +451,8 @@ ieee80211_add_rx_radiotap_header(struct ieee80211_local *local,
else if (status->bw == RATE_INFO_BW_5)
channel_flags |= IEEE80211_CHAN_QUARTER;
- if (status->band == NL80211_BAND_5GHZ)
+ if (status->band == NL80211_BAND_5GHZ ||
+ status->band == NL80211_BAND_6GHZ)
channel_flags |= IEEE80211_CHAN_OFDM | IEEE80211_CHAN_5GHZ;
else if (status->encoding != RX_ENC_LEGACY)
channel_flags |= IEEE80211_CHAN_DYN | IEEE80211_CHAN_2GHZ;
--
2.25.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-20 18:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <010101747ab7b9c0-45fa1c2a-3bb5-44e8-8e6d-457cad2e9845-000000@us-west-2.amazonses.com>
2020-09-11 7:36 ` [PATCH] mac80211: Fix radiotap header channel flag for 6GHz band Johannes Berg
2020-09-11 20:50 ` Aloka Dixit
[not found] ` <010101747eef4d8b-8b5fdae5-790f-4d19-a2df-fba00350baa3-000000@us-west-2.amazonses.com>
2020-09-11 20:52 ` Johannes Berg
2020-09-14 9:14 ` Arend Van Spriel
2020-09-20 18:53 ` Aloka Dixit
2020-09-11 1:11 Aloka Dixit
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.