From: Ajit Pandey <ajitp@codeaurora.org>
To: Mark Brown <broonie@kernel.org>
Cc: plai@codeaurora.org, bgoswami@codeaurora.org,
srinivas.kandagatla@linaro.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/7] ASoC: qcom: Add common array to initialize soc based core clocks
Date: Sat, 16 May 2020 23:36:27 +0530 [thread overview]
Message-ID: <1d47fad3-54bc-1b95-8608-d5846e4b9c83@codeaurora.org> (raw)
On 5/14/2020 10:15 PM, Mark Brown wrote:
> On Thu, May 14, 2020 at 10:08:14PM +0530, Ajit Pandey wrote:
>> AHB-I/X bus clocks inside LPASS coreis not a mandatory clocks for
>> SC7180 soc lpass variants, hence make it an optional one.
> Do we need to improve the checks in the rest of the code so that if the
> clock is missing on a SoC where it is actually mandatory we don't end up
> trying to start without it? Perhaps it's more trouble than it's worth
> though.
> Agreed.. adding a case check with soc id or name definately make sense
> to avoid issue with soc where it's a mandatory one, I'll also look if
> this "ahbix-clk" can also be moved with other soc-based clocks array ?
> and can be enabled in soc specific driver.
WARNING: multiple messages have this Message-ID (diff)
From: Ajit Pandey <ajitp@codeaurora.org>
To: Mark Brown <broonie@kernel.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
bgoswami@codeaurora.org, plai@codeaurora.org,
linux-kernel@vger.kernel.org, srinivas.kandagatla@linaro.org
Subject: Re: [PATCH v2 2/7] ASoC: qcom: Add common array to initialize soc based core clocks
Date: Sat, 16 May 2020 23:36:27 +0530 [thread overview]
Message-ID: <1d47fad3-54bc-1b95-8608-d5846e4b9c83@codeaurora.org> (raw)
On 5/14/2020 10:15 PM, Mark Brown wrote:
> On Thu, May 14, 2020 at 10:08:14PM +0530, Ajit Pandey wrote:
>> AHB-I/X bus clocks inside LPASS coreis not a mandatory clocks for
>> SC7180 soc lpass variants, hence make it an optional one.
> Do we need to improve the checks in the rest of the code so that if the
> clock is missing on a SoC where it is actually mandatory we don't end up
> trying to start without it? Perhaps it's more trouble than it's worth
> though.
> Agreed.. adding a case check with soc id or name definately make sense
> to avoid issue with soc where it's a mandatory one, I'll also look if
> this "ahbix-clk" can also be moved with other soc-based clocks array ?
> and can be enabled in soc specific driver.
next reply other threads:[~2020-05-16 18:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 18:06 Ajit Pandey [this message]
2020-05-16 18:06 ` [PATCH v2 2/7] ASoC: qcom: Add common array to initialize soc based core clocks Ajit Pandey
-- strict thread matches above, loose matches on Subject: below --
2020-05-18 9:11 Srinivas Kandagatla
2020-05-18 9:11 ` Srinivas Kandagatla
[not found] <“1586592171-31644-1-git-send-email-ajitp@codeaurora.org”>
2020-05-14 16:38 ` [PATCH v2 0/7] ASoC: QCOM: Add support for SC7180 lpass variant Ajit Pandey
2020-05-14 16:38 ` [PATCH v2 2/7] ASoC: qcom: Add common array to initialize soc based core clocks Ajit Pandey
2020-05-14 16:38 ` Ajit Pandey
2020-05-14 16:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d47fad3-54bc-1b95-8608-d5846e4b9c83@codeaurora.org \
--to=ajitp@codeaurora.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plai@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.