* [U-Boot] [PATCH 1/1] configs: sunxi: enable BLK, DM_MMC for Bananapi @ 2018-03-13 17:37 Heinrich Schuchardt 2018-03-13 18:41 ` Maxime Ripard 0 siblings, 1 reply; 9+ messages in thread From: Heinrich Schuchardt @ 2018-03-13 17:37 UTC (permalink / raw) To: u-boot doc/driver-model/MIGRATION.txt requires to move block drivers to the the driver model by v2018.05 So make the switch for the Bananapi block drivers. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- This patch depends on mmc: sunxi: support cd-inverted https://lists.denx.de/pipermail/u-boot/2018-February/319309.html which has been applied to u-boot-sunxi/master. --- configs/Bananapi_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/Bananapi_defconfig b/configs/Bananapi_defconfig index 52650448091..300110a5cab 100644 --- a/configs/Bananapi_defconfig +++ b/configs/Bananapi_defconfig @@ -17,6 +17,8 @@ CONFIG_SPL_I2C_SUPPORT=y # CONFIG_SPL_EFI_PARTITION is not set CONFIG_NETCONSOLE=y CONFIG_SCSI_AHCI=y +CONFIG_BLK=y +CONFIG_DM_MMC=y CONFIG_ETH_DESIGNWARE=y CONFIG_RGMII=y CONFIG_SUN7I_GMAC=y -- 2.11.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 1/1] configs: sunxi: enable BLK, DM_MMC for Bananapi 2018-03-13 17:37 [U-Boot] [PATCH 1/1] configs: sunxi: enable BLK, DM_MMC for Bananapi Heinrich Schuchardt @ 2018-03-13 18:41 ` Maxime Ripard 2018-03-13 19:09 ` Heinrich Schuchardt 0 siblings, 1 reply; 9+ messages in thread From: Maxime Ripard @ 2018-03-13 18:41 UTC (permalink / raw) To: u-boot Hi, On Tue, Mar 13, 2018 at 06:37:23PM +0100, Heinrich Schuchardt wrote: > doc/driver-model/MIGRATION.txt requires to move block drivers to the > the driver model by v2018.05 > > So make the switch for the Bananapi block drivers. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > This patch depends on > mmc: sunxi: support cd-inverted > https://lists.denx.de/pipermail/u-boot/2018-February/319309.html > which has been applied to u-boot-sunxi/master. > --- > configs/Bananapi_defconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/configs/Bananapi_defconfig b/configs/Bananapi_defconfig > index 52650448091..300110a5cab 100644 > --- a/configs/Bananapi_defconfig > +++ b/configs/Bananapi_defconfig > @@ -17,6 +17,8 @@ CONFIG_SPL_I2C_SUPPORT=y > # CONFIG_SPL_EFI_PARTITION is not set > CONFIG_NETCONSOLE=y > CONFIG_SCSI_AHCI=y > +CONFIG_BLK=y > +CONFIG_DM_MMC=y Please switch all the Allwinner boards at once. Thanks! Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180313/bbf0a9bb/attachment.sig> ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 1/1] configs: sunxi: enable BLK, DM_MMC for Bananapi 2018-03-13 18:41 ` Maxime Ripard @ 2018-03-13 19:09 ` Heinrich Schuchardt 2018-03-14 9:39 ` Maxime Ripard 0 siblings, 1 reply; 9+ messages in thread From: Heinrich Schuchardt @ 2018-03-13 19:09 UTC (permalink / raw) To: u-boot On 03/13/2018 07:41 PM, Maxime Ripard wrote: > Hi, > > On Tue, Mar 13, 2018 at 06:37:23PM +0100, Heinrich Schuchardt wrote: >> doc/driver-model/MIGRATION.txt requires to move block drivers to the >> the driver model by v2018.05 >> >> So make the switch for the Bananapi block drivers. >> >> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> >> --- >> This patch depends on >> mmc: sunxi: support cd-inverted >> https://lists.denx.de/pipermail/u-boot/2018-February/319309.html >> which has been applied to u-boot-sunxi/master. >> --- >> configs/Bananapi_defconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/configs/Bananapi_defconfig b/configs/Bananapi_defconfig >> index 52650448091..300110a5cab 100644 >> --- a/configs/Bananapi_defconfig >> +++ b/configs/Bananapi_defconfig >> @@ -17,6 +17,8 @@ CONFIG_SPL_I2C_SUPPORT=y >> # CONFIG_SPL_EFI_PARTITION is not set >> CONFIG_NETCONSOLE=y >> CONFIG_SCSI_AHCI=y >> +CONFIG_BLK=y >> +CONFIG_DM_MMC=y > > Please switch all the Allwinner boards at once. Hello Maxime, this is the board I possess and have tested. Who would do the testing if I switch all 127 boards? I guess the best way to switch all SUNXI boards would be to make CONFIG_SUNXI select CONFIG_DM, CONFIG_BLK, and CONFIG_DM_MMC. @Simon Looking at doc/driver-model/MIGRATION.txt would it make sense to set: CONFIG_DM_MMC default yes, depends on CONFIG_MMC. CONFIG_DM_SCSI default yes, depends on CONFIG_SCSI. ... CONFIG_BLK selected by CONFIG_DM_MMC | CONFIG_DM_SCSI | .... CONFIG_DM selected by CONFIG_BLK Best regards Heinrich ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 1/1] configs: sunxi: enable BLK, DM_MMC for Bananapi 2018-03-13 19:09 ` Heinrich Schuchardt @ 2018-03-14 9:39 ` Maxime Ripard 2018-03-18 15:20 ` [U-Boot] [PATCH 1/1] configs: sunxi: enable BLK, DM_MMC, DM_SCSI Heinrich Schuchardt 0 siblings, 1 reply; 9+ messages in thread From: Maxime Ripard @ 2018-03-14 9:39 UTC (permalink / raw) To: u-boot On Tue, Mar 13, 2018 at 08:09:18PM +0100, Heinrich Schuchardt wrote: > On 03/13/2018 07:41 PM, Maxime Ripard wrote: > > Hi, > > > > On Tue, Mar 13, 2018 at 06:37:23PM +0100, Heinrich Schuchardt wrote: > >> doc/driver-model/MIGRATION.txt requires to move block drivers to the > >> the driver model by v2018.05 > >> > >> So make the switch for the Bananapi block drivers. > >> > >> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > >> --- > >> This patch depends on > >> mmc: sunxi: support cd-inverted > >> https://lists.denx.de/pipermail/u-boot/2018-February/319309.html > >> which has been applied to u-boot-sunxi/master. > >> --- > >> configs/Bananapi_defconfig | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/configs/Bananapi_defconfig b/configs/Bananapi_defconfig > >> index 52650448091..300110a5cab 100644 > >> --- a/configs/Bananapi_defconfig > >> +++ b/configs/Bananapi_defconfig > >> @@ -17,6 +17,8 @@ CONFIG_SPL_I2C_SUPPORT=y > >> # CONFIG_SPL_EFI_PARTITION is not set > >> CONFIG_NETCONSOLE=y > >> CONFIG_SCSI_AHCI=y > >> +CONFIG_BLK=y > >> +CONFIG_DM_MMC=y > > > > Please switch all the Allwinner boards at once. > > this is the board I possess and have tested. Who would do the testing if > I switch all 127 boards? The alternative you suggest is that you break 126 boards in the next release. This is core changes, and it should have a minimal impact on the boards if one work. > I guess the best way to switch all SUNXI boards would be to make > CONFIG_SUNXI select CONFIG_DM, CONFIG_BLK, and CONFIG_DM_MMC. Imply it at least, yeah. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180314/a066e985/attachment.sig> ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 1/1] configs: sunxi: enable BLK, DM_MMC, DM_SCSI 2018-03-14 9:39 ` Maxime Ripard @ 2018-03-18 15:20 ` Heinrich Schuchardt 2018-03-18 21:21 ` Maxime Ripard 0 siblings, 1 reply; 9+ messages in thread From: Heinrich Schuchardt @ 2018-03-18 15:20 UTC (permalink / raw) To: u-boot doc/driver-model/MIGRATION.txt requires to move block drivers to the the driver model by v2018.05 So make the switch for the SUNXI block drivers. Select BLK, DM_MMC, and DM_SCSI. DM_USB dpends on USB but there is no necessity to make it depend on DISTRO_DEFAULTS. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- arch/arm/Kconfig | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 2c52ff025a..b608f01beb 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -715,13 +715,16 @@ config ARCH_SUNXI select BINMAN select CMD_GPIO select CMD_MMC if MMC - select CMD_USB if DISTRO_DEFAULTS + select CMD_USB if USB select DM + select BLK select DM_ETH select DM_GPIO select DM_KEYBOARD + select DM_MMC + select DM_SCSI select DM_SERIAL - select DM_USB if DISTRO_DEFAULTS + select DM_USB if USB select OF_BOARD_SETUP select OF_CONTROL select OF_SEPARATE -- 2.16.2 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 1/1] configs: sunxi: enable BLK, DM_MMC, DM_SCSI 2018-03-18 15:20 ` [U-Boot] [PATCH 1/1] configs: sunxi: enable BLK, DM_MMC, DM_SCSI Heinrich Schuchardt @ 2018-03-18 21:21 ` Maxime Ripard 2018-03-18 21:49 ` Heinrich Schuchardt 0 siblings, 1 reply; 9+ messages in thread From: Maxime Ripard @ 2018-03-18 21:21 UTC (permalink / raw) To: u-boot Hi, On Sun, Mar 18, 2018 at 04:20:06PM +0100, Heinrich Schuchardt wrote: > doc/driver-model/MIGRATION.txt requires to move block drivers to the > the driver model by v2018.05 > > So make the switch for the SUNXI block drivers. > > Select BLK, DM_MMC, and DM_SCSI. > > DM_USB dpends on USB but there is no necessity to make it depend on > DISTRO_DEFAULTS. That should be a separate patch. > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > arch/arm/Kconfig | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 2c52ff025a..b608f01beb 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -715,13 +715,16 @@ config ARCH_SUNXI > select BINMAN > select CMD_GPIO > select CMD_MMC if MMC > - select CMD_USB if DISTRO_DEFAULTS > + select CMD_USB if USB > select DM > + select BLK You assume here that you always have a block device, which might not be the case (for example if you only have a NAND chip on your board). > select DM_ETH > select DM_GPIO > select DM_KEYBOARD > + select DM_MMC Ditto. > + select DM_SCSI Ditto, with SATA. Thanks! Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180318/23ba7ceb/attachment.sig> ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 1/1] configs: sunxi: enable BLK, DM_MMC, DM_SCSI 2018-03-18 21:21 ` Maxime Ripard @ 2018-03-18 21:49 ` Heinrich Schuchardt 2018-03-20 14:29 ` Maxime Ripard 0 siblings, 1 reply; 9+ messages in thread From: Heinrich Schuchardt @ 2018-03-18 21:49 UTC (permalink / raw) To: u-boot On 03/18/2018 10:21 PM, Maxime Ripard wrote: > Hi, > > On Sun, Mar 18, 2018 at 04:20:06PM +0100, Heinrich Schuchardt wrote: >> doc/driver-model/MIGRATION.txt requires to move block drivers to the >> the driver model by v2018.05 >> >> So make the switch for the SUNXI block drivers. >> >> Select BLK, DM_MMC, and DM_SCSI. >> >> DM_USB dpends on USB but there is no necessity to make it depend on >> DISTRO_DEFAULTS. > > That should be a separate patch. > >> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> >> --- >> arch/arm/Kconfig | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >> index 2c52ff025a..b608f01beb 100644 >> --- a/arch/arm/Kconfig >> +++ b/arch/arm/Kconfig >> @@ -715,13 +715,16 @@ config ARCH_SUNXI >> select BINMAN >> select CMD_GPIO >> select CMD_MMC if MMC >> - select CMD_USB if DISTRO_DEFAULTS >> + select CMD_USB if USB >> select DM >> + select BLK > > You assume here that you always have a block device, which might not > be the case (for example if you only have a NAND chip on your board). I ran a full Travis test for Sunxi boards and could not see any compile error only a time out for one group of boards. BLK is used by #ifdefs in code handling block devices. It has no effect if the block device code is not built. > >> select DM_ETH Here you already select DM_ETH without requiring network. It simply has not effect if there is not network driver built. >> select DM_GPIO >> select DM_KEYBOARD >> + select DM_MMC > > Ditto. DM_MMC only depends on DM not on MMC see drivers/mmc/Kconfig If you don't build MMC code it has no effect. > >> + select DM_SCSI > > > Ditto, with SATA. If you don't build SCSI or ATA code the flag has no effect. Regards Heinrich ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 1/1] configs: sunxi: enable BLK, DM_MMC, DM_SCSI 2018-03-18 21:49 ` Heinrich Schuchardt @ 2018-03-20 14:29 ` Maxime Ripard 2018-03-24 10:35 ` Heinrich Schuchardt 0 siblings, 1 reply; 9+ messages in thread From: Maxime Ripard @ 2018-03-20 14:29 UTC (permalink / raw) To: u-boot On Sun, Mar 18, 2018 at 10:49:57PM +0100, Heinrich Schuchardt wrote: > On 03/18/2018 10:21 PM, Maxime Ripard wrote: > > Hi, > > > > On Sun, Mar 18, 2018 at 04:20:06PM +0100, Heinrich Schuchardt wrote: > >> doc/driver-model/MIGRATION.txt requires to move block drivers to the > >> the driver model by v2018.05 > >> > >> So make the switch for the SUNXI block drivers. > >> > >> Select BLK, DM_MMC, and DM_SCSI. > >> > >> DM_USB dpends on USB but there is no necessity to make it depend on > >> DISTRO_DEFAULTS. > > > > That should be a separate patch. > > > >> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > >> --- > >> arch/arm/Kconfig | 7 +++++-- > >> 1 file changed, 5 insertions(+), 2 deletions(-) > >> > >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > >> index 2c52ff025a..b608f01beb 100644 > >> --- a/arch/arm/Kconfig > >> +++ b/arch/arm/Kconfig > >> @@ -715,13 +715,16 @@ config ARCH_SUNXI > >> select BINMAN > >> select CMD_GPIO > >> select CMD_MMC if MMC > >> - select CMD_USB if DISTRO_DEFAULTS > >> + select CMD_USB if USB > >> select DM > >> + select BLK > > > > You assume here that you always have a block device, which might not > > be the case (for example if you only have a NAND chip on your board). > I ran a full Travis test for Sunxi boards and could not see any compile > error only a time out for one group of boards. > > BLK is used by #ifdefs in code handling block devices. It has no effect > if the block device code is not built. Still, you add some completely unnecessary code in such a case. > > > >> select DM_ETH > > Here you already select DM_ETH without requiring network. It simply has > not effect if there is not network driver built. You're right, it should probably be fixed as well. > >> select DM_GPIO > >> select DM_KEYBOARD > >> + select DM_MMC > > > > Ditto. > > DM_MMC only depends on DM not on MMC see drivers/mmc/Kconfig > If you don't build MMC code it has no effect. But then, you have some dead code. > >> + select DM_SCSI > > > > > > Ditto, with SATA. > > If you don't build SCSI or ATA code the flag has no effect. And same argument here. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 1/1] configs: sunxi: enable BLK, DM_MMC, DM_SCSI 2018-03-20 14:29 ` Maxime Ripard @ 2018-03-24 10:35 ` Heinrich Schuchardt 0 siblings, 0 replies; 9+ messages in thread From: Heinrich Schuchardt @ 2018-03-24 10:35 UTC (permalink / raw) To: u-boot On 03/20/2018 03:29 PM, Maxime Ripard wrote: > On Sun, Mar 18, 2018 at 10:49:57PM +0100, Heinrich Schuchardt wrote: >> On 03/18/2018 10:21 PM, Maxime Ripard wrote: >>> Hi, >>> >>> On Sun, Mar 18, 2018 at 04:20:06PM +0100, Heinrich Schuchardt wrote: >>>> doc/driver-model/MIGRATION.txt requires to move block drivers to the >>>> the driver model by v2018.05 >>>> >>>> So make the switch for the SUNXI block drivers. >>>> >>>> Select BLK, DM_MMC, and DM_SCSI. >>>> >>>> DM_USB dpends on USB but there is no necessity to make it depend on >>>> DISTRO_DEFAULTS. >>> >>> That should be a separate patch. >>> >>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> >>>> --- >>>> arch/arm/Kconfig | 7 +++++-- >>>> 1 file changed, 5 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >>>> index 2c52ff025a..b608f01beb 100644 >>>> --- a/arch/arm/Kconfig >>>> +++ b/arch/arm/Kconfig >>>> @@ -715,13 +715,16 @@ config ARCH_SUNXI >>>> select BINMAN >>>> select CMD_GPIO >>>> select CMD_MMC if MMC >>>> - select CMD_USB if DISTRO_DEFAULTS >>>> + select CMD_USB if USB >>>> select DM >>>> + select BLK >>> >>> You assume here that you always have a block device, which might not >>> be the case (for example if you only have a NAND chip on your board). >> I ran a full Travis test for Sunxi boards and could not see any compile >> error only a time out for one group of boards. >> >> BLK is used by #ifdefs in code handling block devices. It has no effect >> if the block device code is not built. > > Still, you add some completely unnecessary code in such a case. Even if there is no block device I still want to be able to start iPXE via bootefi and to attach an iSCSI drive. This requires BLK. > >>> >>>> select DM_ETH >> >> Here you already select DM_ETH without requiring network. It simply has >> not effect if there is not network driver built. > > You're right, it should probably be fixed as well. > >>>> select DM_GPIO >>>> select DM_KEYBOARD >>>> + select DM_MMC >>> >>> Ditto. >> >> DM_MMC only depends on DM not on MMC see drivers/mmc/Kconfig >> If you don't build MMC code it has no effect. > > But then, you have some dead code. I could not find any. Please, indicate where. Best regards Heinrich > >>>> + select DM_SCSI >>> >>> >>> Ditto, with SATA. >> >> If you don't build SCSI or ATA code the flag has no effect. > > And same argument here. > > Maxime > ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-03-24 10:35 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-03-13 17:37 [U-Boot] [PATCH 1/1] configs: sunxi: enable BLK, DM_MMC for Bananapi Heinrich Schuchardt 2018-03-13 18:41 ` Maxime Ripard 2018-03-13 19:09 ` Heinrich Schuchardt 2018-03-14 9:39 ` Maxime Ripard 2018-03-18 15:20 ` [U-Boot] [PATCH 1/1] configs: sunxi: enable BLK, DM_MMC, DM_SCSI Heinrich Schuchardt 2018-03-18 21:21 ` Maxime Ripard 2018-03-18 21:49 ` Heinrich Schuchardt 2018-03-20 14:29 ` Maxime Ripard 2018-03-24 10:35 ` Heinrich Schuchardt
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.