Re: [PATCH] drm/stm: ltdc: Use simple encoder

From: yannick Fertre <yannick.fertre@foss.st.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Yannick Fertre <yannick.fertre@st.com>,
	Philippe Cornu <philippe.cornu@st.com>,
	Benjamin Gaignard <benjamin.gaignard@linaro.org>,
	Vincent Abriou <vincent.abriou@st.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<linux-amarula@amarulasolutions.com>,
	<linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
	<linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH] drm/stm: ltdc: Use simple encoder
Date: Thu, 4 Mar 2021 09:49:55 +0100	[thread overview]
Message-ID: <1d6ff4e2-9213-6e13-214d-b1705199610e@foss.st.com> (raw)
In-Reply-To: <791a6f75-3603-9b84-c267-76c24fb77ee2@suse.de>

Hi Thomas,
I wait a few days before merging it.
Thank you for your help.

Best regards

Yannick

On 3/4/21 9:21 AM, Thomas Zimmermann wrote:
> Hi,
> 
> shall I merge this patch?
> 
> Am 02.03.21 um 18:57 schrieb Jagan Teki:
>> STM ltdc driver uses an empty implementation for its encoder.
>> Replace the code with the generic simple encoder.
>>
>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>> ---
>>   drivers/gpu/drm/stm/ltdc.c | 12 ++----------
>>   1 file changed, 2 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
>> index 7812094f93d6..aeeb43524ca0 100644
>> --- a/drivers/gpu/drm/stm/ltdc.c
>> +++ b/drivers/gpu/drm/stm/ltdc.c
>> @@ -31,6 +31,7 @@
>>   #include <drm/drm_of.h>
>>   #include <drm/drm_plane_helper.h>
>>   #include <drm/drm_probe_helper.h>
>> +#include <drm/drm_simple_kms_helper.h>
>>   #include <drm/drm_vblank.h>
>>   #include <video/videomode.h>
>> @@ -1020,14 +1021,6 @@ static int ltdc_crtc_init(struct drm_device 
>> *ddev, struct drm_crtc *crtc)
>>       return ret;
>>   }
>> -/*
>> - * DRM_ENCODER
>> - */
>> -
>> -static const struct drm_encoder_funcs ltdc_encoder_funcs = {
>> -    .destroy = drm_encoder_cleanup,
>> -};
>> -
>>   static void ltdc_encoder_disable(struct drm_encoder *encoder)
>>   {
>>       struct drm_device *ddev = encoder->dev;
>> @@ -1088,8 +1081,7 @@ static int ltdc_encoder_init(struct drm_device 
>> *ddev, struct drm_bridge *bridge)
>>       encoder->possible_crtcs = CRTC_MASK;
>>       encoder->possible_clones = 0;    /* No cloning support */
>> -    drm_encoder_init(ddev, encoder, &ltdc_encoder_funcs,
>> -             DRM_MODE_ENCODER_DPI, NULL);
>> +    drm_simple_encoder_init(ddev, encoder, DRM_MODE_ENCODER_DPI);
>>       drm_encoder_helper_add(encoder, &ltdc_encoder_helper_funcs);
>>
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 