* [PATCH] drm/stm: ltdc: Use simple encoder
@ 2021-03-02 17:57 ` Jagan Teki
0 siblings, 0 replies; 16+ messages in thread
From: Jagan Teki @ 2021-03-02 17:57 UTC (permalink / raw)
To: Yannick Fertre, Philippe Cornu, Benjamin Gaignard, Vincent Abriou
Cc: linux-kernel, dri-devel, Jagan Teki, linux-amarula, linux-stm32,
linux-arm-kernel
STM ltdc driver uses an empty implementation for its encoder.
Replace the code with the generic simple encoder.
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
drivers/gpu/drm/stm/ltdc.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
index 7812094f93d6..aeeb43524ca0 100644
--- a/drivers/gpu/drm/stm/ltdc.c
+++ b/drivers/gpu/drm/stm/ltdc.c
@@ -31,6 +31,7 @@
#include <drm/drm_of.h>
#include <drm/drm_plane_helper.h>
#include <drm/drm_probe_helper.h>
+#include <drm/drm_simple_kms_helper.h>
#include <drm/drm_vblank.h>
#include <video/videomode.h>
@@ -1020,14 +1021,6 @@ static int ltdc_crtc_init(struct drm_device *ddev, struct drm_crtc *crtc)
return ret;
}
-/*
- * DRM_ENCODER
- */
-
-static const struct drm_encoder_funcs ltdc_encoder_funcs = {
- .destroy = drm_encoder_cleanup,
-};
-
static void ltdc_encoder_disable(struct drm_encoder *encoder)
{
struct drm_device *ddev = encoder->dev;
@@ -1088,8 +1081,7 @@ static int ltdc_encoder_init(struct drm_device *ddev, struct drm_bridge *bridge)
encoder->possible_crtcs = CRTC_MASK;
encoder->possible_clones = 0; /* No cloning support */
- drm_encoder_init(ddev, encoder, <dc_encoder_funcs,
- DRM_MODE_ENCODER_DPI, NULL);
+ drm_simple_encoder_init(ddev, encoder, DRM_MODE_ENCODER_DPI);
drm_encoder_helper_add(encoder, <dc_encoder_helper_funcs);
--
2.25.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH] drm/stm: ltdc: Use simple encoder
@ 2021-03-02 17:57 ` Jagan Teki
0 siblings, 0 replies; 16+ messages in thread
From: Jagan Teki @ 2021-03-02 17:57 UTC (permalink / raw)
To: Yannick Fertre, Philippe Cornu, Benjamin Gaignard, Vincent Abriou
Cc: dri-devel, linux-stm32, linux-arm-kernel, linux-kernel,
linux-amarula, Jagan Teki
STM ltdc driver uses an empty implementation for its encoder.
Replace the code with the generic simple encoder.
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
drivers/gpu/drm/stm/ltdc.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
index 7812094f93d6..aeeb43524ca0 100644
--- a/drivers/gpu/drm/stm/ltdc.c
+++ b/drivers/gpu/drm/stm/ltdc.c
@@ -31,6 +31,7 @@
#include <drm/drm_of.h>
#include <drm/drm_plane_helper.h>
#include <drm/drm_probe_helper.h>
+#include <drm/drm_simple_kms_helper.h>
#include <drm/drm_vblank.h>
#include <video/videomode.h>
@@ -1020,14 +1021,6 @@ static int ltdc_crtc_init(struct drm_device *ddev, struct drm_crtc *crtc)
return ret;
}
-/*
- * DRM_ENCODER
- */
-
-static const struct drm_encoder_funcs ltdc_encoder_funcs = {
- .destroy = drm_encoder_cleanup,
-};
-
static void ltdc_encoder_disable(struct drm_encoder *encoder)
{
struct drm_device *ddev = encoder->dev;
@@ -1088,8 +1081,7 @@ static int ltdc_encoder_init(struct drm_device *ddev, struct drm_bridge *bridge)
encoder->possible_crtcs = CRTC_MASK;
encoder->possible_clones = 0; /* No cloning support */
- drm_encoder_init(ddev, encoder, <dc_encoder_funcs,
- DRM_MODE_ENCODER_DPI, NULL);
+ drm_simple_encoder_init(ddev, encoder, DRM_MODE_ENCODER_DPI);
drm_encoder_helper_add(encoder, <dc_encoder_helper_funcs);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH] drm/stm: ltdc: Use simple encoder
2021-03-02 17:57 ` Jagan Teki
(?)
@ 2021-03-03 7:46 ` Thomas Zimmermann
-1 siblings, 0 replies; 16+ messages in thread
From: Thomas Zimmermann @ 2021-03-03 7:46 UTC (permalink / raw)
To: Jagan Teki, Yannick Fertre, Philippe Cornu, Benjamin Gaignard,
Vincent Abriou
Cc: linux-kernel, dri-devel, linux-amarula, linux-stm32, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1892 bytes --]
Am 02.03.21 um 18:57 schrieb Jagan Teki:
> STM ltdc driver uses an empty implementation for its encoder.
> Replace the code with the generic simple encoder.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/stm/ltdc.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 7812094f93d6..aeeb43524ca0 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -31,6 +31,7 @@
> #include <drm/drm_of.h>
> #include <drm/drm_plane_helper.h>
> #include <drm/drm_probe_helper.h>
> +#include <drm/drm_simple_kms_helper.h>
> #include <drm/drm_vblank.h>
>
> #include <video/videomode.h>
> @@ -1020,14 +1021,6 @@ static int ltdc_crtc_init(struct drm_device *ddev, struct drm_crtc *crtc)
> return ret;
> }
>
> -/*
> - * DRM_ENCODER
> - */
> -
> -static const struct drm_encoder_funcs ltdc_encoder_funcs = {
> - .destroy = drm_encoder_cleanup,
> -};
> -
> static void ltdc_encoder_disable(struct drm_encoder *encoder)
> {
> struct drm_device *ddev = encoder->dev;
> @@ -1088,8 +1081,7 @@ static int ltdc_encoder_init(struct drm_device *ddev, struct drm_bridge *bridge)
> encoder->possible_crtcs = CRTC_MASK;
> encoder->possible_clones = 0; /* No cloning support */
>
> - drm_encoder_init(ddev, encoder, <dc_encoder_funcs,
> - DRM_MODE_ENCODER_DPI, NULL);
> + drm_simple_encoder_init(ddev, encoder, DRM_MODE_ENCODER_DPI);
>
> drm_encoder_helper_add(encoder, <dc_encoder_helper_funcs);
>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH] drm/stm: ltdc: Use simple encoder
@ 2021-03-03 7:46 ` Thomas Zimmermann
0 siblings, 0 replies; 16+ messages in thread
From: Thomas Zimmermann @ 2021-03-03 7:46 UTC (permalink / raw)
To: Jagan Teki, Yannick Fertre, Philippe Cornu, Benjamin Gaignard,
Vincent Abriou
Cc: linux-arm-kernel, linux-amarula, linux-kernel, dri-devel, linux-stm32
[-- Attachment #1.1.1: Type: text/plain, Size: 1892 bytes --]
Am 02.03.21 um 18:57 schrieb Jagan Teki:
> STM ltdc driver uses an empty implementation for its encoder.
> Replace the code with the generic simple encoder.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/stm/ltdc.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 7812094f93d6..aeeb43524ca0 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -31,6 +31,7 @@
> #include <drm/drm_of.h>
> #include <drm/drm_plane_helper.h>
> #include <drm/drm_probe_helper.h>
> +#include <drm/drm_simple_kms_helper.h>
> #include <drm/drm_vblank.h>
>
> #include <video/videomode.h>
> @@ -1020,14 +1021,6 @@ static int ltdc_crtc_init(struct drm_device *ddev, struct drm_crtc *crtc)
> return ret;
> }
>
> -/*
> - * DRM_ENCODER
> - */
> -
> -static const struct drm_encoder_funcs ltdc_encoder_funcs = {
> - .destroy = drm_encoder_cleanup,
> -};
> -
> static void ltdc_encoder_disable(struct drm_encoder *encoder)
> {
> struct drm_device *ddev = encoder->dev;
> @@ -1088,8 +1081,7 @@ static int ltdc_encoder_init(struct drm_device *ddev, struct drm_bridge *bridge)
> encoder->possible_crtcs = CRTC_MASK;
> encoder->possible_clones = 0; /* No cloning support */
>
> - drm_encoder_init(ddev, encoder, <dc_encoder_funcs,
> - DRM_MODE_ENCODER_DPI, NULL);
> + drm_simple_encoder_init(ddev, encoder, DRM_MODE_ENCODER_DPI);
>
> drm_encoder_helper_add(encoder, <dc_encoder_helper_funcs);
>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH] drm/stm: ltdc: Use simple encoder
@ 2021-03-03 7:46 ` Thomas Zimmermann
0 siblings, 0 replies; 16+ messages in thread
From: Thomas Zimmermann @ 2021-03-03 7:46 UTC (permalink / raw)
To: Jagan Teki, Yannick Fertre, Philippe Cornu, Benjamin Gaignard,
Vincent Abriou
Cc: linux-kernel, dri-devel, linux-amarula, linux-stm32, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 1892 bytes --]
Am 02.03.21 um 18:57 schrieb Jagan Teki:
> STM ltdc driver uses an empty implementation for its encoder.
> Replace the code with the generic simple encoder.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/stm/ltdc.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 7812094f93d6..aeeb43524ca0 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -31,6 +31,7 @@
> #include <drm/drm_of.h>
> #include <drm/drm_plane_helper.h>
> #include <drm/drm_probe_helper.h>
> +#include <drm/drm_simple_kms_helper.h>
> #include <drm/drm_vblank.h>
>
> #include <video/videomode.h>
> @@ -1020,14 +1021,6 @@ static int ltdc_crtc_init(struct drm_device *ddev, struct drm_crtc *crtc)
> return ret;
> }
>
> -/*
> - * DRM_ENCODER
> - */
> -
> -static const struct drm_encoder_funcs ltdc_encoder_funcs = {
> - .destroy = drm_encoder_cleanup,
> -};
> -
> static void ltdc_encoder_disable(struct drm_encoder *encoder)
> {
> struct drm_device *ddev = encoder->dev;
> @@ -1088,8 +1081,7 @@ static int ltdc_encoder_init(struct drm_device *ddev, struct drm_bridge *bridge)
> encoder->possible_crtcs = CRTC_MASK;
> encoder->possible_clones = 0; /* No cloning support */
>
> - drm_encoder_init(ddev, encoder, <dc_encoder_funcs,
> - DRM_MODE_ENCODER_DPI, NULL);
> + drm_simple_encoder_init(ddev, encoder, DRM_MODE_ENCODER_DPI);
>
> drm_encoder_helper_add(encoder, <dc_encoder_helper_funcs);
>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/stm: ltdc: Use simple encoder
2021-03-02 17:57 ` Jagan Teki
` (2 preceding siblings ...)
(?)
@ 2021-03-03 15:42 ` yannick Fertre
-1 siblings, 0 replies; 16+ messages in thread
From: yannick Fertre @ 2021-03-03 15:42 UTC (permalink / raw)
To: dri-devel
Thanks Jagan for the patch.
Tested-by: Yannick Fertre <yannick.fertre@foss.st.com>
On 3/2/21 6:57 PM, Jagan Teki wrote:
> STM ltdc driver uses an empty implementation for its encoder.
> Replace the code with the generic simple encoder.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> drivers/gpu/drm/stm/ltdc.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 7812094f93d6..aeeb43524ca0 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -31,6 +31,7 @@
> #include <drm/drm_of.h>
> #include <drm/drm_plane_helper.h>
> #include <drm/drm_probe_helper.h>
> +#include <drm/drm_simple_kms_helper.h>
> #include <drm/drm_vblank.h>
>
> #include <video/videomode.h>
> @@ -1020,14 +1021,6 @@ static int ltdc_crtc_init(struct drm_device *ddev, struct drm_crtc *crtc)
> return ret;
> }
>
> -/*
> - * DRM_ENCODER
> - */
> -
> -static const struct drm_encoder_funcs ltdc_encoder_funcs = {
> - .destroy = drm_encoder_cleanup,
> -};
> -
> static void ltdc_encoder_disable(struct drm_encoder *encoder)
> {
> struct drm_device *ddev = encoder->dev;
> @@ -1088,8 +1081,7 @@ static int ltdc_encoder_init(struct drm_device *ddev, struct drm_bridge *bridge)
> encoder->possible_crtcs = CRTC_MASK;
> encoder->possible_clones = 0; /* No cloning support */
>
> - drm_encoder_init(ddev, encoder, <dc_encoder_funcs,
> - DRM_MODE_ENCODER_DPI, NULL);
> + drm_simple_encoder_init(ddev, encoder, DRM_MODE_ENCODER_DPI);
>
> drm_encoder_helper_add(encoder, <dc_encoder_helper_funcs);
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH] drm/stm: ltdc: Use simple encoder
2021-03-02 17:57 ` Jagan Teki
(?)
@ 2021-03-04 8:21 ` Thomas Zimmermann
-1 siblings, 0 replies; 16+ messages in thread
From: Thomas Zimmermann @ 2021-03-04 8:21 UTC (permalink / raw)
To: Jagan Teki, Yannick Fertre, Philippe Cornu, Benjamin Gaignard,
Vincent Abriou
Cc: linux-kernel, dri-devel, linux-amarula, linux-stm32, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1869 bytes --]
Hi,
shall I merge this patch?
Am 02.03.21 um 18:57 schrieb Jagan Teki:
> STM ltdc driver uses an empty implementation for its encoder.
> Replace the code with the generic simple encoder.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> drivers/gpu/drm/stm/ltdc.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 7812094f93d6..aeeb43524ca0 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -31,6 +31,7 @@
> #include <drm/drm_of.h>
> #include <drm/drm_plane_helper.h>
> #include <drm/drm_probe_helper.h>
> +#include <drm/drm_simple_kms_helper.h>
> #include <drm/drm_vblank.h>
>
> #include <video/videomode.h>
> @@ -1020,14 +1021,6 @@ static int ltdc_crtc_init(struct drm_device *ddev, struct drm_crtc *crtc)
> return ret;
> }
>
> -/*
> - * DRM_ENCODER
> - */
> -
> -static const struct drm_encoder_funcs ltdc_encoder_funcs = {
> - .destroy = drm_encoder_cleanup,
> -};
> -
> static void ltdc_encoder_disable(struct drm_encoder *encoder)
> {
> struct drm_device *ddev = encoder->dev;
> @@ -1088,8 +1081,7 @@ static int ltdc_encoder_init(struct drm_device *ddev, struct drm_bridge *bridge)
> encoder->possible_crtcs = CRTC_MASK;
> encoder->possible_clones = 0; /* No cloning support */
>
> - drm_encoder_init(ddev, encoder, <dc_encoder_funcs,
> - DRM_MODE_ENCODER_DPI, NULL);
> + drm_simple_encoder_init(ddev, encoder, DRM_MODE_ENCODER_DPI);
>
> drm_encoder_helper_add(encoder, <dc_encoder_helper_funcs);
>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH] drm/stm: ltdc: Use simple encoder
@ 2021-03-04 8:21 ` Thomas Zimmermann
0 siblings, 0 replies; 16+ messages in thread
From: Thomas Zimmermann @ 2021-03-04 8:21 UTC (permalink / raw)
To: Jagan Teki, Yannick Fertre, Philippe Cornu, Benjamin Gaignard,
Vincent Abriou
Cc: linux-arm-kernel, linux-amarula, linux-kernel, dri-devel, linux-stm32
[-- Attachment #1.1.1: Type: text/plain, Size: 1869 bytes --]
Hi,
shall I merge this patch?
Am 02.03.21 um 18:57 schrieb Jagan Teki:
> STM ltdc driver uses an empty implementation for its encoder.
> Replace the code with the generic simple encoder.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> drivers/gpu/drm/stm/ltdc.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 7812094f93d6..aeeb43524ca0 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -31,6 +31,7 @@
> #include <drm/drm_of.h>
> #include <drm/drm_plane_helper.h>
> #include <drm/drm_probe_helper.h>
> +#include <drm/drm_simple_kms_helper.h>
> #include <drm/drm_vblank.h>
>
> #include <video/videomode.h>
> @@ -1020,14 +1021,6 @@ static int ltdc_crtc_init(struct drm_device *ddev, struct drm_crtc *crtc)
> return ret;
> }
>
> -/*
> - * DRM_ENCODER
> - */
> -
> -static const struct drm_encoder_funcs ltdc_encoder_funcs = {
> - .destroy = drm_encoder_cleanup,
> -};
> -
> static void ltdc_encoder_disable(struct drm_encoder *encoder)
> {
> struct drm_device *ddev = encoder->dev;
> @@ -1088,8 +1081,7 @@ static int ltdc_encoder_init(struct drm_device *ddev, struct drm_bridge *bridge)
> encoder->possible_crtcs = CRTC_MASK;
> encoder->possible_clones = 0; /* No cloning support */
>
> - drm_encoder_init(ddev, encoder, <dc_encoder_funcs,
> - DRM_MODE_ENCODER_DPI, NULL);
> + drm_simple_encoder_init(ddev, encoder, DRM_MODE_ENCODER_DPI);
>
> drm_encoder_helper_add(encoder, <dc_encoder_helper_funcs);
>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH] drm/stm: ltdc: Use simple encoder
@ 2021-03-04 8:21 ` Thomas Zimmermann
0 siblings, 0 replies; 16+ messages in thread
From: Thomas Zimmermann @ 2021-03-04 8:21 UTC (permalink / raw)
To: Jagan Teki, Yannick Fertre, Philippe Cornu, Benjamin Gaignard,
Vincent Abriou
Cc: linux-kernel, dri-devel, linux-amarula, linux-stm32, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 1869 bytes --]
Hi,
shall I merge this patch?
Am 02.03.21 um 18:57 schrieb Jagan Teki:
> STM ltdc driver uses an empty implementation for its encoder.
> Replace the code with the generic simple encoder.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> drivers/gpu/drm/stm/ltdc.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 7812094f93d6..aeeb43524ca0 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -31,6 +31,7 @@
> #include <drm/drm_of.h>
> #include <drm/drm_plane_helper.h>
> #include <drm/drm_probe_helper.h>
> +#include <drm/drm_simple_kms_helper.h>
> #include <drm/drm_vblank.h>
>
> #include <video/videomode.h>
> @@ -1020,14 +1021,6 @@ static int ltdc_crtc_init(struct drm_device *ddev, struct drm_crtc *crtc)
> return ret;
> }
>
> -/*
> - * DRM_ENCODER
> - */
> -
> -static const struct drm_encoder_funcs ltdc_encoder_funcs = {
> - .destroy = drm_encoder_cleanup,
> -};
> -
> static void ltdc_encoder_disable(struct drm_encoder *encoder)
> {
> struct drm_device *ddev = encoder->dev;
> @@ -1088,8 +1081,7 @@ static int ltdc_encoder_init(struct drm_device *ddev, struct drm_bridge *bridge)
> encoder->possible_crtcs = CRTC_MASK;
> encoder->possible_clones = 0; /* No cloning support */
>
> - drm_encoder_init(ddev, encoder, <dc_encoder_funcs,
> - DRM_MODE_ENCODER_DPI, NULL);
> + drm_simple_encoder_init(ddev, encoder, DRM_MODE_ENCODER_DPI);
>
> drm_encoder_helper_add(encoder, <dc_encoder_helper_funcs);
>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH] drm/stm: ltdc: Use simple encoder
2021-03-04 8:21 ` Thomas Zimmermann
(?)
@ 2021-03-04 8:49 ` yannick Fertre
-1 siblings, 0 replies; 16+ messages in thread
From: yannick Fertre @ 2021-03-04 8:49 UTC (permalink / raw)
To: Thomas Zimmermann, Jagan Teki, Yannick Fertre, Philippe Cornu,
Benjamin Gaignard, Vincent Abriou
Cc: linux-arm-kernel, linux-amarula, linux-kernel, dri-devel, linux-stm32
Hi Thomas,
I wait a few days before merging it.
Thank you for your help.
Best regards
Yannick
On 3/4/21 9:21 AM, Thomas Zimmermann wrote:
> Hi,
>
> shall I merge this patch?
>
> Am 02.03.21 um 18:57 schrieb Jagan Teki:
>> STM ltdc driver uses an empty implementation for its encoder.
>> Replace the code with the generic simple encoder.
>>
>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>> ---
>> drivers/gpu/drm/stm/ltdc.c | 12 ++----------
>> 1 file changed, 2 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
>> index 7812094f93d6..aeeb43524ca0 100644
>> --- a/drivers/gpu/drm/stm/ltdc.c
>> +++ b/drivers/gpu/drm/stm/ltdc.c
>> @@ -31,6 +31,7 @@
>> #include <drm/drm_of.h>
>> #include <drm/drm_plane_helper.h>
>> #include <drm/drm_probe_helper.h>
>> +#include <drm/drm_simple_kms_helper.h>
>> #include <drm/drm_vblank.h>
>> #include <video/videomode.h>
>> @@ -1020,14 +1021,6 @@ static int ltdc_crtc_init(struct drm_device
>> *ddev, struct drm_crtc *crtc)
>> return ret;
>> }
>> -/*
>> - * DRM_ENCODER
>> - */
>> -
>> -static const struct drm_encoder_funcs ltdc_encoder_funcs = {
>> - .destroy = drm_encoder_cleanup,
>> -};
>> -
>> static void ltdc_encoder_disable(struct drm_encoder *encoder)
>> {
>> struct drm_device *ddev = encoder->dev;
>> @@ -1088,8 +1081,7 @@ static int ltdc_encoder_init(struct drm_device
>> *ddev, struct drm_bridge *bridge)
>> encoder->possible_crtcs = CRTC_MASK;
>> encoder->possible_clones = 0; /* No cloning support */
>> - drm_encoder_init(ddev, encoder, <dc_encoder_funcs,
>> - DRM_MODE_ENCODER_DPI, NULL);
>> + drm_simple_encoder_init(ddev, encoder, DRM_MODE_ENCODER_DPI);
>> drm_encoder_helper_add(encoder, <dc_encoder_helper_funcs);
>>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH] drm/stm: ltdc: Use simple encoder
@ 2021-03-04 8:49 ` yannick Fertre
0 siblings, 0 replies; 16+ messages in thread
From: yannick Fertre @ 2021-03-04 8:49 UTC (permalink / raw)
To: Thomas Zimmermann, Jagan Teki, Yannick Fertre, Philippe Cornu,
Benjamin Gaignard, Vincent Abriou
Cc: dri-devel, linux-amarula, linux-kernel, linux-arm-kernel, linux-stm32
Hi Thomas,
I wait a few days before merging it.
Thank you for your help.
Best regards
Yannick
On 3/4/21 9:21 AM, Thomas Zimmermann wrote:
> Hi,
>
> shall I merge this patch?
>
> Am 02.03.21 um 18:57 schrieb Jagan Teki:
>> STM ltdc driver uses an empty implementation for its encoder.
>> Replace the code with the generic simple encoder.
>>
>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>> ---
>> drivers/gpu/drm/stm/ltdc.c | 12 ++----------
>> 1 file changed, 2 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
>> index 7812094f93d6..aeeb43524ca0 100644
>> --- a/drivers/gpu/drm/stm/ltdc.c
>> +++ b/drivers/gpu/drm/stm/ltdc.c
>> @@ -31,6 +31,7 @@
>> #include <drm/drm_of.h>
>> #include <drm/drm_plane_helper.h>
>> #include <drm/drm_probe_helper.h>
>> +#include <drm/drm_simple_kms_helper.h>
>> #include <drm/drm_vblank.h>
>> #include <video/videomode.h>
>> @@ -1020,14 +1021,6 @@ static int ltdc_crtc_init(struct drm_device
>> *ddev, struct drm_crtc *crtc)
>> return ret;
>> }
>> -/*
>> - * DRM_ENCODER
>> - */
>> -
>> -static const struct drm_encoder_funcs ltdc_encoder_funcs = {
>> - .destroy = drm_encoder_cleanup,
>> -};
>> -
>> static void ltdc_encoder_disable(struct drm_encoder *encoder)
>> {
>> struct drm_device *ddev = encoder->dev;
>> @@ -1088,8 +1081,7 @@ static int ltdc_encoder_init(struct drm_device
>> *ddev, struct drm_bridge *bridge)
>> encoder->possible_crtcs = CRTC_MASK;
>> encoder->possible_clones = 0; /* No cloning support */
>> - drm_encoder_init(ddev, encoder, <dc_encoder_funcs,
>> - DRM_MODE_ENCODER_DPI, NULL);
>> + drm_simple_encoder_init(ddev, encoder, DRM_MODE_ENCODER_DPI);
>> drm_encoder_helper_add(encoder, <dc_encoder_helper_funcs);
>>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH] drm/stm: ltdc: Use simple encoder
@ 2021-03-04 8:49 ` yannick Fertre
0 siblings, 0 replies; 16+ messages in thread
From: yannick Fertre @ 2021-03-04 8:49 UTC (permalink / raw)
To: Thomas Zimmermann, Jagan Teki, Yannick Fertre, Philippe Cornu,
Benjamin Gaignard, Vincent Abriou
Cc: linux-arm-kernel, linux-amarula, linux-kernel, dri-devel, linux-stm32
Hi Thomas,
I wait a few days before merging it.
Thank you for your help.
Best regards
Yannick
On 3/4/21 9:21 AM, Thomas Zimmermann wrote:
> Hi,
>
> shall I merge this patch?
>
> Am 02.03.21 um 18:57 schrieb Jagan Teki:
>> STM ltdc driver uses an empty implementation for its encoder.
>> Replace the code with the generic simple encoder.
>>
>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>> ---
>> drivers/gpu/drm/stm/ltdc.c | 12 ++----------
>> 1 file changed, 2 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
>> index 7812094f93d6..aeeb43524ca0 100644
>> --- a/drivers/gpu/drm/stm/ltdc.c
>> +++ b/drivers/gpu/drm/stm/ltdc.c
>> @@ -31,6 +31,7 @@
>> #include <drm/drm_of.h>
>> #include <drm/drm_plane_helper.h>
>> #include <drm/drm_probe_helper.h>
>> +#include <drm/drm_simple_kms_helper.h>
>> #include <drm/drm_vblank.h>
>> #include <video/videomode.h>
>> @@ -1020,14 +1021,6 @@ static int ltdc_crtc_init(struct drm_device
>> *ddev, struct drm_crtc *crtc)
>> return ret;
>> }
>> -/*
>> - * DRM_ENCODER
>> - */
>> -
>> -static const struct drm_encoder_funcs ltdc_encoder_funcs = {
>> - .destroy = drm_encoder_cleanup,
>> -};
>> -
>> static void ltdc_encoder_disable(struct drm_encoder *encoder)
>> {
>> struct drm_device *ddev = encoder->dev;
>> @@ -1088,8 +1081,7 @@ static int ltdc_encoder_init(struct drm_device
>> *ddev, struct drm_bridge *bridge)
>> encoder->possible_crtcs = CRTC_MASK;
>> encoder->possible_clones = 0; /* No cloning support */
>> - drm_encoder_init(ddev, encoder, <dc_encoder_funcs,
>> - DRM_MODE_ENCODER_DPI, NULL);
>> + drm_simple_encoder_init(ddev, encoder, DRM_MODE_ENCODER_DPI);
>> drm_encoder_helper_add(encoder, <dc_encoder_helper_funcs);
>>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread* RE: [Linux-stm32] [PATCH] drm/stm: ltdc: Use simple encoder
2021-03-04 8:49 ` yannick Fertre
(?)
@ 2021-03-08 10:50 ` Philippe CORNU - foss
-1 siblings, 0 replies; 16+ messages in thread
From: Philippe CORNU - foss @ 2021-03-08 10:50 UTC (permalink / raw)
To: Yannick FERTRE - foss, Thomas Zimmermann, Jagan Teki,
Yannick FERTRE, Philippe CORNU, Benjamin Gaignard,
Vincent ABRIOU
Cc: dri-devel, linux-amarula, linux-kernel, linux-arm-kernel, linux-stm32
Applied on drm-misc-next.
Many thanks Jagan for your patch and many thanks Thomas & Yannick for your reviews & tests.
Philippe :-)
________________________________________
De : Linux-stm32 <linux-stm32-bounces@st-md-mailman.stormreply.com> de la part de Yannick FERTRE - foss
Envoyé : jeudi 4 mars 2021 09:49
À : Thomas Zimmermann; Jagan Teki; Yannick FERTRE; Philippe CORNU; Benjamin Gaignard; Vincent ABRIOU
Cc : dri-devel@lists.freedesktop.org; linux-amarula@amarulasolutions.com; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-stm32@st-md-mailman.stormreply.com
Objet : Re: [Linux-stm32] [PATCH] drm/stm: ltdc: Use simple encoder
Hi Thomas,
I wait a few days before merging it.
Thank you for your help.
Best regards
Yannick
On 3/4/21 9:21 AM, Thomas Zimmermann wrote:
> Hi,
>
> shall I merge this patch?
>
> Am 02.03.21 um 18:57 schrieb Jagan Teki:
>> STM ltdc driver uses an empty implementation for its encoder.
>> Replace the code with the generic simple encoder.
>>
>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>> ---
>> drivers/gpu/drm/stm/ltdc.c | 12 ++----------
>> 1 file changed, 2 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
>> index 7812094f93d6..aeeb43524ca0 100644
>> --- a/drivers/gpu/drm/stm/ltdc.c
>> +++ b/drivers/gpu/drm/stm/ltdc.c
>> @@ -31,6 +31,7 @@
>> #include <drm/drm_of.h>
>> #include <drm/drm_plane_helper.h>
>> #include <drm/drm_probe_helper.h>
>> +#include <drm/drm_simple_kms_helper.h>
>> #include <drm/drm_vblank.h>
>> #include <video/videomode.h>
>> @@ -1020,14 +1021,6 @@ static int ltdc_crtc_init(struct drm_device
>> *ddev, struct drm_crtc *crtc)
>> return ret;
>> }
>> -/*
>> - * DRM_ENCODER
>> - */
>> -
>> -static const struct drm_encoder_funcs ltdc_encoder_funcs = {
>> - .destroy = drm_encoder_cleanup,
>> -};
>> -
>> static void ltdc_encoder_disable(struct drm_encoder *encoder)
>> {
>> struct drm_device *ddev = encoder->dev;
>> @@ -1088,8 +1081,7 @@ static int ltdc_encoder_init(struct drm_device
>> *ddev, struct drm_bridge *bridge)
>> encoder->possible_crtcs = CRTC_MASK;
>> encoder->possible_clones = 0; /* No cloning support */
>> - drm_encoder_init(ddev, encoder, <dc_encoder_funcs,
>> - DRM_MODE_ENCODER_DPI, NULL);
>> + drm_simple_encoder_init(ddev, encoder, DRM_MODE_ENCODER_DPI);
>> drm_encoder_helper_add(encoder, <dc_encoder_helper_funcs);
>>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
_______________________________________________
Linux-stm32 mailing list
Linux-stm32@st-md-mailman.stormreply.com
https://st-md-mailman.stormreply.com/mailman/listinfo/linux-stm32
^ permalink raw reply [flat|nested] 16+ messages in thread* RE: [Linux-stm32] [PATCH] drm/stm: ltdc: Use simple encoder
@ 2021-03-08 10:50 ` Philippe CORNU - foss
0 siblings, 0 replies; 16+ messages in thread
From: Philippe CORNU - foss @ 2021-03-08 10:50 UTC (permalink / raw)
To: Yannick FERTRE - foss, Thomas Zimmermann, Jagan Teki,
Yannick FERTRE, Philippe CORNU, Benjamin Gaignard,
Vincent ABRIOU
Cc: linux-arm-kernel, linux-amarula, linux-kernel, dri-devel, linux-stm32
Applied on drm-misc-next.
Many thanks Jagan for your patch and many thanks Thomas & Yannick for your reviews & tests.
Philippe :-)
________________________________________
De : Linux-stm32 <linux-stm32-bounces@st-md-mailman.stormreply.com> de la part de Yannick FERTRE - foss
Envoyé : jeudi 4 mars 2021 09:49
À : Thomas Zimmermann; Jagan Teki; Yannick FERTRE; Philippe CORNU; Benjamin Gaignard; Vincent ABRIOU
Cc : dri-devel@lists.freedesktop.org; linux-amarula@amarulasolutions.com; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-stm32@st-md-mailman.stormreply.com
Objet : Re: [Linux-stm32] [PATCH] drm/stm: ltdc: Use simple encoder
Hi Thomas,
I wait a few days before merging it.
Thank you for your help.
Best regards
Yannick
On 3/4/21 9:21 AM, Thomas Zimmermann wrote:
> Hi,
>
> shall I merge this patch?
>
> Am 02.03.21 um 18:57 schrieb Jagan Teki:
>> STM ltdc driver uses an empty implementation for its encoder.
>> Replace the code with the generic simple encoder.
>>
>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>> ---
>> drivers/gpu/drm/stm/ltdc.c | 12 ++----------
>> 1 file changed, 2 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
>> index 7812094f93d6..aeeb43524ca0 100644
>> --- a/drivers/gpu/drm/stm/ltdc.c
>> +++ b/drivers/gpu/drm/stm/ltdc.c
>> @@ -31,6 +31,7 @@
>> #include <drm/drm_of.h>
>> #include <drm/drm_plane_helper.h>
>> #include <drm/drm_probe_helper.h>
>> +#include <drm/drm_simple_kms_helper.h>
>> #include <drm/drm_vblank.h>
>> #include <video/videomode.h>
>> @@ -1020,14 +1021,6 @@ static int ltdc_crtc_init(struct drm_device
>> *ddev, struct drm_crtc *crtc)
>> return ret;
>> }
>> -/*
>> - * DRM_ENCODER
>> - */
>> -
>> -static const struct drm_encoder_funcs ltdc_encoder_funcs = {
>> - .destroy = drm_encoder_cleanup,
>> -};
>> -
>> static void ltdc_encoder_disable(struct drm_encoder *encoder)
>> {
>> struct drm_device *ddev = encoder->dev;
>> @@ -1088,8 +1081,7 @@ static int ltdc_encoder_init(struct drm_device
>> *ddev, struct drm_bridge *bridge)
>> encoder->possible_crtcs = CRTC_MASK;
>> encoder->possible_clones = 0; /* No cloning support */
>> - drm_encoder_init(ddev, encoder, <dc_encoder_funcs,
>> - DRM_MODE_ENCODER_DPI, NULL);
>> + drm_simple_encoder_init(ddev, encoder, DRM_MODE_ENCODER_DPI);
>> drm_encoder_helper_add(encoder, <dc_encoder_helper_funcs);
>>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
_______________________________________________
Linux-stm32 mailing list
Linux-stm32@st-md-mailman.stormreply.com
https://st-md-mailman.stormreply.com/mailman/listinfo/linux-stm32
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread* RE: [Linux-stm32] [PATCH] drm/stm: ltdc: Use simple encoder
@ 2021-03-08 10:50 ` Philippe CORNU - foss
0 siblings, 0 replies; 16+ messages in thread
From: Philippe CORNU - foss @ 2021-03-08 10:50 UTC (permalink / raw)
To: Yannick FERTRE - foss, Thomas Zimmermann, Jagan Teki,
Yannick FERTRE, Philippe CORNU, Benjamin Gaignard,
Vincent ABRIOU
Cc: dri-devel, linux-amarula, linux-kernel, linux-arm-kernel, linux-stm32
Applied on drm-misc-next.
Many thanks Jagan for your patch and many thanks Thomas & Yannick for your reviews & tests.
Philippe :-)
________________________________________
De : Linux-stm32 <linux-stm32-bounces@st-md-mailman.stormreply.com> de la part de Yannick FERTRE - foss
Envoyé : jeudi 4 mars 2021 09:49
À : Thomas Zimmermann; Jagan Teki; Yannick FERTRE; Philippe CORNU; Benjamin Gaignard; Vincent ABRIOU
Cc : dri-devel@lists.freedesktop.org; linux-amarula@amarulasolutions.com; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-stm32@st-md-mailman.stormreply.com
Objet : Re: [Linux-stm32] [PATCH] drm/stm: ltdc: Use simple encoder
Hi Thomas,
I wait a few days before merging it.
Thank you for your help.
Best regards
Yannick
On 3/4/21 9:21 AM, Thomas Zimmermann wrote:
> Hi,
>
> shall I merge this patch?
>
> Am 02.03.21 um 18:57 schrieb Jagan Teki:
>> STM ltdc driver uses an empty implementation for its encoder.
>> Replace the code with the generic simple encoder.
>>
>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>> ---
>> drivers/gpu/drm/stm/ltdc.c | 12 ++----------
>> 1 file changed, 2 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
>> index 7812094f93d6..aeeb43524ca0 100644
>> --- a/drivers/gpu/drm/stm/ltdc.c
>> +++ b/drivers/gpu/drm/stm/ltdc.c
>> @@ -31,6 +31,7 @@
>> #include <drm/drm_of.h>
>> #include <drm/drm_plane_helper.h>
>> #include <drm/drm_probe_helper.h>
>> +#include <drm/drm_simple_kms_helper.h>
>> #include <drm/drm_vblank.h>
>> #include <video/videomode.h>
>> @@ -1020,14 +1021,6 @@ static int ltdc_crtc_init(struct drm_device
>> *ddev, struct drm_crtc *crtc)
>> return ret;
>> }
>> -/*
>> - * DRM_ENCODER
>> - */
>> -
>> -static const struct drm_encoder_funcs ltdc_encoder_funcs = {
>> - .destroy = drm_encoder_cleanup,
>> -};
>> -
>> static void ltdc_encoder_disable(struct drm_encoder *encoder)
>> {
>> struct drm_device *ddev = encoder->dev;
>> @@ -1088,8 +1081,7 @@ static int ltdc_encoder_init(struct drm_device
>> *ddev, struct drm_bridge *bridge)
>> encoder->possible_crtcs = CRTC_MASK;
>> encoder->possible_clones = 0; /* No cloning support */
>> - drm_encoder_init(ddev, encoder, <dc_encoder_funcs,
>> - DRM_MODE_ENCODER_DPI, NULL);
>> + drm_simple_encoder_init(ddev, encoder, DRM_MODE_ENCODER_DPI);
>> drm_encoder_helper_add(encoder, <dc_encoder_helper_funcs);
>>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
_______________________________________________
Linux-stm32 mailing list
Linux-stm32@st-md-mailman.stormreply.com
https://st-md-mailman.stormreply.com/mailman/listinfo/linux-stm32
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread