From: Robert Yang <liezhi.yang@windriver.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: Francisco Pedraza <francisco.j.pedraza.gonzalez@intel.com>,
"Limon, Anibal" <anibal.limon@intel.com>,
"Lopez, Mariano" <mariano.lopez@intel.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/8] oeqa/sdkext/devtool.py: remove workspace/sources before running test cases
Date: Tue, 13 Dec 2016 16:31:15 +0800 [thread overview]
Message-ID: <1dbd51fd-cbe1-6b54-b321-cdc05c0dd633@windriver.com> (raw)
In-Reply-To: <1611902.KszYoSQub8@peggleto-mobl.ger.corp.intel.com>
On 12/13/2016 04:21 PM, Paul Eggleton wrote:
> On Tue, 13 Dec 2016 14:47:10 Robert Yang wrote:
>> On 12/13/2016 02:29 PM, Paul Eggleton wrote:
>>> On Tue, 13 Dec 2016 13:56:05 Robert Yang wrote:
>>>> On 12/13/2016 12:45 PM, Paul Eggleton wrote:
>>>>> It seems to me that's what's missing here is a proper teardown process
>>>>> like we have for oe-selftest, so that tests clean up after themselves
>>>>> whether they succeed or fail. I'm unsure as to whether that is part of
>>>>> the plan for the new QA refactoring though.
>>>>
>>>> There is already a 'devtool reset' which can do the cleanup, but it
>>>> can't remove sources as I said in the commit log.
>>>
>>> devtool reset not deleting the source tree is intentional - I don't want
>>
>> Add an option like "devtool reset --force" ? When I met the error, the first
>> I did was check "devtool reset", but there is no way to remove resources,
>> so I have to remove it here to allow multilib test cases runs.
>
> I've considered this and decided against it - it just seems to me that at
> least one person will use it every time until one day when they wipe out their
> source with their changes in it. I'd really rather not be enabling that.
> Besides, in everyday use repeated runs of devtool add / modify on the same
> recipe should be at a minimum, if that's not the case then we have other
> issues to look at.
>
> You say there's no way to remove these, but there is - just delete the files
> explicitly.
>
>> Or maybe fix "devtool add" to check the git repo correclty ? For example,
>> when there is already a repo, just update it rather than clone it again.
>
> Right, that has been suggested - and it's all fine if the source tree is
> unmodified and just a straight update to get from where it is currently to
> match the upstream. However, what if it's not fast-forward, or a different
> repo entirely? What if there are local modifications?
>
>> The multilib + testsdkext would fail without this fix.
>
> Yes, that's why I ultimately said we haven't much choice but to apply this
> patch. We must acknowledge however that the problem exists because the tests
Got it, thanks.
// Robert
> aren't cleaning up after themselves, which should be their responsibility.
>
> Cheers,
> Paul
>
next prev parent reply other threads:[~2016-12-13 8:31 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 6:19 [PATCH 0/8] Fixes for eSDK and testsdkext Robert Yang
2016-11-17 6:19 ` [PATCH 1/8] populate_sdk_ext.bbclass: install multilib targets as populate_sdk does Robert Yang
2016-12-13 4:55 ` Paul Eggleton
2016-12-13 6:03 ` Robert Yang
2016-12-14 2:25 ` Robert Yang
2016-12-14 2:34 ` Paul Eggleton
2016-11-17 6:19 ` [PATCH 2/8] oeqa/sdkext/devtool.py: remove workspace/sources before running test cases Robert Yang
2016-12-13 4:45 ` Paul Eggleton
2016-12-13 5:56 ` Robert Yang
2016-12-13 6:29 ` Paul Eggleton
2016-12-13 6:47 ` Robert Yang
2016-12-13 8:21 ` Paul Eggleton
2016-12-13 8:31 ` Robert Yang [this message]
2016-12-13 13:58 ` Lopez, Mariano
2016-11-17 6:19 ` [PATCH 3/8] oe-publish-sdk: make cmd easier to read Robert Yang
2016-11-17 6:19 ` [PATCH 4/8] oe-publish-sdk: add pyshtables.py to .gitignore Robert Yang
2016-12-13 4:59 ` Paul Eggleton
2016-12-13 6:03 ` Robert Yang
2016-11-17 6:19 ` [PATCH 5/8] oeqa/sdkext/devtool.py: don't reset when the test is failed Robert Yang
2016-12-13 4:48 ` Paul Eggleton
2016-12-13 6:01 ` Robert Yang
2016-12-13 6:33 ` Paul Eggleton
2016-12-13 6:39 ` Robert Yang
2016-12-13 8:07 ` Paul Eggleton
2016-12-13 8:09 ` Robert Yang
2016-11-17 6:19 ` [PATCH 6/8] oeqa/oetest.py: add hasLockedSig() Robert Yang
2016-11-17 6:19 ` [PATCH 7/8] oeqa/sdkext/devtool.py: skip test_extend_autotools_recipe_creation when no libxml2 Robert Yang
2016-11-17 6:19 ` [PATCH 8/8] oe/copy_buildsystem.py: add SDK_LAYERS_EXCLUDE_PATTERN Robert Yang
[not found] ` <20161117065519.7693.7868@do.openembedded.org>
2016-11-17 9:02 ` ✗ patchtest: failure for Fixes for eSDK and testsdkext Burton, Ross
2016-11-17 17:12 ` Paul Eggleton
2016-11-29 7:38 ` Robert Yang
2016-11-29 9:10 ` Paul Eggleton
2016-12-13 2:58 ` [PATCH 0/8] " Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dbd51fd-cbe1-6b54-b321-cdc05c0dd633@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=anibal.limon@intel.com \
--cc=francisco.j.pedraza.gonzalez@intel.com \
--cc=mariano.lopez@intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.