From: Robert Yang <liezhi.yang@windriver.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 5/8] oeqa/sdkext/devtool.py: don't reset when the test is failed
Date: Tue, 13 Dec 2016 16:09:29 +0800 [thread overview]
Message-ID: <d4898605-4cb1-ab19-b7e8-2e5f87fb9b24@windriver.com> (raw)
In-Reply-To: <3698001.Ed7gRfCEom@peggleto-mobl.ger.corp.intel.com>
On 12/13/2016 04:07 PM, Paul Eggleton wrote:
> On Tue, 13 Dec 2016 14:39:46 Robert Yang wrote:
>> On 12/13/2016 02:33 PM, Paul Eggleton wrote:
>>> On Tue, 13 Dec 2016 14:01:08 Robert Yang wrote:
>>>> On 12/13/2016 12:48 PM, Paul Eggleton wrote:
>>>>> On Wed, 16 Nov 2016 22:19:34 Robert Yang wrote:
>>>>>> The contents are helpful to debug when the error happens.
>>>>>
>>>>> In this case removing this is OK because we're operating on an eSDK that
>>>>> the tests install. However, this wouldn't be appropriate for the devtool
>>>>> oe- selftest tests since they are operating on the user's build system
>>>>> itself - not that you probably have any intention of changing those, I
>>>>> just wanted to note that.
>>>>
>>>> Sorry, I don't quite understand, does selftest uses
>>>> oeqa/sdkext/devtool.py,
>>>> please ?
>>>
>>> No, this is for bitbake -c testsdkext.
>>>
>>>> Even if it uses devtool.py, I still think that we need keep the
>>>> error contents for debugging when the error happens. It's very hard to
>>>> debug when there is no error log or no workspace.
>>>
>>> I mean the equivalent oe-selftest tests in oeqa/selftest/devtool.py.
>>>
>>> Actually, I've realised something that applies here as well - leaving the
>>> files around would be OK if we stopped on the first failure, but we don't
>>> -
>>> the next test proceeds after it. How will you be able to rely on what's in
>>> the workspace if several other tests have run afterwards - not to mention
>>> ensure those tests aren't disrupted by the leftover files?
>>
>> That's a problem, but we really need consider debugging, otherwise it's
>> painful when test are failed but nothing left. How about run test cases
>> in different workspaces ?
>
> Currently when I need to debug a test, I tend to either run the test commands
> manually, or comment out the cleanup. If we really want to improve debugging
> then we ought to do it properly - have proper teardown infrastructure and then
> provide a mode that disables it.
Thanks, I will drop the patch atm.
// Robert
>
> Cheers,
> Paul
>
next prev parent reply other threads:[~2016-12-13 8:09 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 6:19 [PATCH 0/8] Fixes for eSDK and testsdkext Robert Yang
2016-11-17 6:19 ` [PATCH 1/8] populate_sdk_ext.bbclass: install multilib targets as populate_sdk does Robert Yang
2016-12-13 4:55 ` Paul Eggleton
2016-12-13 6:03 ` Robert Yang
2016-12-14 2:25 ` Robert Yang
2016-12-14 2:34 ` Paul Eggleton
2016-11-17 6:19 ` [PATCH 2/8] oeqa/sdkext/devtool.py: remove workspace/sources before running test cases Robert Yang
2016-12-13 4:45 ` Paul Eggleton
2016-12-13 5:56 ` Robert Yang
2016-12-13 6:29 ` Paul Eggleton
2016-12-13 6:47 ` Robert Yang
2016-12-13 8:21 ` Paul Eggleton
2016-12-13 8:31 ` Robert Yang
2016-12-13 13:58 ` Lopez, Mariano
2016-11-17 6:19 ` [PATCH 3/8] oe-publish-sdk: make cmd easier to read Robert Yang
2016-11-17 6:19 ` [PATCH 4/8] oe-publish-sdk: add pyshtables.py to .gitignore Robert Yang
2016-12-13 4:59 ` Paul Eggleton
2016-12-13 6:03 ` Robert Yang
2016-11-17 6:19 ` [PATCH 5/8] oeqa/sdkext/devtool.py: don't reset when the test is failed Robert Yang
2016-12-13 4:48 ` Paul Eggleton
2016-12-13 6:01 ` Robert Yang
2016-12-13 6:33 ` Paul Eggleton
2016-12-13 6:39 ` Robert Yang
2016-12-13 8:07 ` Paul Eggleton
2016-12-13 8:09 ` Robert Yang [this message]
2016-11-17 6:19 ` [PATCH 6/8] oeqa/oetest.py: add hasLockedSig() Robert Yang
2016-11-17 6:19 ` [PATCH 7/8] oeqa/sdkext/devtool.py: skip test_extend_autotools_recipe_creation when no libxml2 Robert Yang
2016-11-17 6:19 ` [PATCH 8/8] oe/copy_buildsystem.py: add SDK_LAYERS_EXCLUDE_PATTERN Robert Yang
[not found] ` <20161117065519.7693.7868@do.openembedded.org>
2016-11-17 9:02 ` ✗ patchtest: failure for Fixes for eSDK and testsdkext Burton, Ross
2016-11-17 17:12 ` Paul Eggleton
2016-11-29 7:38 ` Robert Yang
2016-11-29 9:10 ` Paul Eggleton
2016-12-13 2:58 ` [PATCH 0/8] " Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4898605-4cb1-ab19-b7e8-2e5f87fb9b24@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.