All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Robert Yang <liezhi.yang@windriver.com>
Cc: Francisco Pedraza <francisco.j.pedraza.gonzalez@intel.com>,
	"Limon, Anibal" <anibal.limon@intel.com>,
	"Lopez, Mariano" <mariano.lopez@intel.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/8] oeqa/sdkext/devtool.py: remove workspace/sources before running test cases
Date: Tue, 13 Dec 2016 17:45:23 +1300	[thread overview]
Message-ID: <3281082.n0HP4LhUSl@peggleto-mobl.ger.corp.intel.com> (raw)
In-Reply-To: <61246658fe264929d272f4da2f681e0fb95f9809.1479363545.git.liezhi.yang@windriver.com>

On Wed, 16 Nov 2016 22:19:31 Robert Yang wrote:
> Fixed:
> MACHINE = "qemux86-64"
> require conf/multilib.conf
> MULTILIBS = "multilib:lib32"
> DEFAULTTUNE_virtclass-multilib-lib32 = "x86"
> 
> $ bitbake core-image-minimal -cpopulate_sdk_ext
> [snip]
> ERROR: Source tree path
> /path/to/tmp/work/qemux86_64-poky-linux/core-image-minimal/1.0-r0/testsdkex
> t/tc/workspace/sources/v4l2loopback-driver already exists and is not
> empty\n' [snip]
> 
> This is because the test case will run twice
> (environment-setup-core2-64-poky-linux and
> environment-setup-x86-pokymllib32-linux), it would fail in the second
> run, 'devtool reset' can not remove sources, so remove it before running
> test cases.
> 
> [YOCTO #10647]
> 
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  meta/lib/oeqa/sdkext/devtool.py | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta/lib/oeqa/sdkext/devtool.py
> b/meta/lib/oeqa/sdkext/devtool.py index 65f41f6..f101eb6 100644
> --- a/meta/lib/oeqa/sdkext/devtool.py
> +++ b/meta/lib/oeqa/sdkext/devtool.py
> @@ -15,6 +15,9 @@ class DevtoolTest(oeSDKExtTest):
>          self.myapp_cmake_dst = os.path.join(self.tc.sdktestdir,
> "myapp_cmake") shutil.copytree(self.myapp_cmake_src, self.myapp_cmake_dst)
> 
> +        # Clean sources dir to make "git clone" can run again
> +        shutil.rmtree(os.path.join(self.tc.sdktestdir,
> "tc/workspace/sources"), True) +
>      def _test_devtool_build(self, directory):
>          self._run('devtool add myapp %s' % directory)
>          try:

It seems to me that's what's missing here is a proper teardown process like we 
have for oe-selftest, so that tests clean up after themselves whether they 
succeed or fail. I'm unsure as to whether that is part of the plan for the new 
QA refactoring though.

In the absence of that however I guess we don't have much choice but to do 
something like this.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


  reply	other threads:[~2016-12-13  4:45 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-17  6:19 [PATCH 0/8] Fixes for eSDK and testsdkext Robert Yang
2016-11-17  6:19 ` [PATCH 1/8] populate_sdk_ext.bbclass: install multilib targets as populate_sdk does Robert Yang
2016-12-13  4:55   ` Paul Eggleton
2016-12-13  6:03     ` Robert Yang
2016-12-14  2:25     ` Robert Yang
2016-12-14  2:34       ` Paul Eggleton
2016-11-17  6:19 ` [PATCH 2/8] oeqa/sdkext/devtool.py: remove workspace/sources before running test cases Robert Yang
2016-12-13  4:45   ` Paul Eggleton [this message]
2016-12-13  5:56     ` Robert Yang
2016-12-13  6:29       ` Paul Eggleton
2016-12-13  6:47         ` Robert Yang
2016-12-13  8:21           ` Paul Eggleton
2016-12-13  8:31             ` Robert Yang
2016-12-13 13:58     ` Lopez, Mariano
2016-11-17  6:19 ` [PATCH 3/8] oe-publish-sdk: make cmd easier to read Robert Yang
2016-11-17  6:19 ` [PATCH 4/8] oe-publish-sdk: add pyshtables.py to .gitignore Robert Yang
2016-12-13  4:59   ` Paul Eggleton
2016-12-13  6:03     ` Robert Yang
2016-11-17  6:19 ` [PATCH 5/8] oeqa/sdkext/devtool.py: don't reset when the test is failed Robert Yang
2016-12-13  4:48   ` Paul Eggleton
2016-12-13  6:01     ` Robert Yang
2016-12-13  6:33       ` Paul Eggleton
2016-12-13  6:39         ` Robert Yang
2016-12-13  8:07           ` Paul Eggleton
2016-12-13  8:09             ` Robert Yang
2016-11-17  6:19 ` [PATCH 6/8] oeqa/oetest.py: add hasLockedSig() Robert Yang
2016-11-17  6:19 ` [PATCH 7/8] oeqa/sdkext/devtool.py: skip test_extend_autotools_recipe_creation when no libxml2 Robert Yang
2016-11-17  6:19 ` [PATCH 8/8] oe/copy_buildsystem.py: add SDK_LAYERS_EXCLUDE_PATTERN Robert Yang
     [not found] ` <20161117065519.7693.7868@do.openembedded.org>
2016-11-17  9:02   ` ✗ patchtest: failure for Fixes for eSDK and testsdkext Burton, Ross
2016-11-17 17:12     ` Paul Eggleton
2016-11-29  7:38     ` Robert Yang
2016-11-29  9:10       ` Paul Eggleton
2016-12-13  2:58 ` [PATCH 0/8] " Robert Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3281082.n0HP4LhUSl@peggleto-mobl.ger.corp.intel.com \
    --to=paul.eggleton@linux.intel.com \
    --cc=anibal.limon@intel.com \
    --cc=francisco.j.pedraza.gonzalez@intel.com \
    --cc=liezhi.yang@windriver.com \
    --cc=mariano.lopez@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.