From: "Ewan D. Milne" <emilne@redhat.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
James Bottomley <jejb@linux.ibm.com>
Cc: axboe@kernel.dk, Chaitanya.Kulkarni@wdc.com, mst@redhat.com,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org, ssomesh@amazon.com,
Balbir Singh <sblbir@amazon.com>,
hch@lst.de
Subject: Re: [resend v1 5/5] drivers/scsi/sd.c: Convert to use disk_set_capacity
Date: Tue, 07 Jan 2020 16:37:43 -0500 [thread overview]
Message-ID: <1eb9d796f81fffbb0bfe90bff8460bcda34cb04d.camel@redhat.com> (raw)
In-Reply-To: <yq1y2uj283m.fsf@oracle.com>
On Mon, 2020-01-06 at 23:39 -0500, Martin K. Petersen wrote:
> James,
>
> > > We already emit an SDEV_EVT_CAPACITY_CHANGE_REPORTED event if device
> > > capacity changes. However, this event does not automatically cause
> > > revalidation.
> >
> > Which I seem to remember was a deliberate choice: some change
> > capacities occur because the path goes passive and default values get
> > installed.
>
> Yep, it's very tricky territory.
>
Yes, there are some storage arrays that refuse a READ CAPACITY
command in certain ALUA states so you can't get the new capacity anyway.
It might be nice to improve this, though, there are some cases now where
we set the capacity to zero when we revalidate and can't get the value.
-Ewan
WARNING: multiple messages have this Message-ID (diff)
From: "Ewan D. Milne" <emilne@redhat.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
James Bottomley <jejb@linux.ibm.com>
Cc: axboe@kernel.dk, Chaitanya.Kulkarni@wdc.com, mst@redhat.com,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org, ssomesh@amazon.com,
Balbir Singh <sblbir@amazon.com>,
hch@lst.de
Subject: Re: [resend v1 5/5] drivers/scsi/sd.c: Convert to use disk_set_capacity
Date: Tue, 07 Jan 2020 16:37:43 -0500 [thread overview]
Message-ID: <1eb9d796f81fffbb0bfe90bff8460bcda34cb04d.camel@redhat.com> (raw)
In-Reply-To: <yq1y2uj283m.fsf@oracle.com>
On Mon, 2020-01-06 at 23:39 -0500, Martin K. Petersen wrote:
> James,
>
> > > We already emit an SDEV_EVT_CAPACITY_CHANGE_REPORTED event if device
> > > capacity changes. However, this event does not automatically cause
> > > revalidation.
> >
> > Which I seem to remember was a deliberate choice: some change
> > capacities occur because the path goes passive and default values get
> > installed.
>
> Yep, it's very tricky territory.
>
Yes, there are some storage arrays that refuse a READ CAPACITY
command in certain ALUA states so you can't get the new capacity anyway.
It might be nice to improve this, though, there are some cases now where
we set the capacity to zero when we revalidate and can't get the value.
-Ewan
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-01-07 21:38 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 7:53 [resend v1 0/5] Add support for block disk resize notification Balbir Singh
2020-01-02 7:53 ` Balbir Singh
2020-01-02 7:53 ` [resend v1 1/5] block/genhd: Notify udev about capacity change Balbir Singh
2020-01-02 7:53 ` Balbir Singh
2020-01-03 6:16 ` Chaitanya Kulkarni
2020-01-03 6:16 ` Chaitanya Kulkarni
2020-01-04 4:44 ` Singh, Balbir
2020-01-04 4:44 ` Singh, Balbir
2020-01-04 22:32 ` Chaitanya Kulkarni
2020-01-04 22:32 ` Chaitanya Kulkarni
2020-01-08 15:02 ` hch
2020-01-08 15:02 ` hch
2020-01-07 3:32 ` Martin K. Petersen
2020-01-07 3:32 ` Martin K. Petersen
2020-01-07 22:30 ` Singh, Balbir
2020-01-07 22:30 ` Singh, Balbir
2020-01-08 3:15 ` Martin K. Petersen
2020-01-08 3:15 ` Martin K. Petersen
2020-01-08 15:04 ` hch
2020-01-08 15:04 ` hch
2020-01-21 19:57 ` Singh, Balbir
2020-01-21 19:57 ` Singh, Balbir
2020-01-02 7:53 ` [resend v1 2/5] drivers/block/virtio_blk.c: Convert to use disk_set_capacity Balbir Singh
2020-01-02 7:53 ` Balbir Singh
2020-01-02 7:53 ` [resend v1 3/5] drivers/block/xen-blkfront.c: " Balbir Singh
2020-01-02 7:53 ` Balbir Singh
2020-01-02 7:53 ` [resend v1 4/5] drivers/nvme/host/core.c: " Balbir Singh
2020-01-02 7:53 ` Balbir Singh
2020-01-04 22:27 ` Chaitanya Kulkarni
2020-01-04 22:27 ` Chaitanya Kulkarni
2020-01-06 0:46 ` Singh, Balbir
2020-01-06 0:46 ` Singh, Balbir
2020-01-08 15:04 ` hch
2020-01-08 15:04 ` hch
2020-01-09 3:33 ` Martin K. Petersen
2020-01-09 3:33 ` Martin K. Petersen
2020-01-09 13:12 ` Ewan D. Milne
2020-01-09 13:12 ` Ewan D. Milne
2020-01-21 19:52 ` Singh, Balbir
2020-01-21 19:52 ` Singh, Balbir
2020-01-02 7:53 ` [resend v1 5/5] drivers/scsi/sd.c: " Balbir Singh
2020-01-02 7:53 ` Balbir Singh
2020-01-02 22:21 ` Chaitanya Kulkarni
2020-01-02 22:21 ` Chaitanya Kulkarni
2020-01-03 0:23 ` Singh, Balbir
2020-01-03 0:23 ` Singh, Balbir
2020-01-07 3:48 ` Martin K. Petersen
2020-01-07 3:48 ` Martin K. Petersen
2020-01-07 3:57 ` James Bottomley
2020-01-07 3:57 ` James Bottomley
2020-01-07 4:39 ` Martin K. Petersen
2020-01-07 4:39 ` Martin K. Petersen
2020-01-07 21:37 ` Ewan D. Milne [this message]
2020-01-07 21:37 ` Ewan D. Milne
2020-01-08 2:59 ` Martin K. Petersen
2020-01-08 2:59 ` Martin K. Petersen
2020-01-08 21:27 ` Ewan D. Milne
2020-01-08 21:27 ` Ewan D. Milne
2020-01-07 22:28 ` Singh, Balbir
2020-01-07 22:28 ` Singh, Balbir
2020-01-08 3:15 ` Martin K. Petersen
2020-01-08 3:15 ` Martin K. Petersen
2020-01-08 4:20 ` Singh, Balbir
2020-01-08 4:20 ` Singh, Balbir
2020-01-08 21:32 ` Ewan D. Milne
2020-01-08 21:32 ` Ewan D. Milne
2020-01-08 15:06 ` Christoph Hellwig
2020-01-08 15:06 ` Christoph Hellwig
2020-01-09 2:53 ` Martin K. Petersen
2020-01-09 2:53 ` Martin K. Petersen
2020-01-06 5:59 ` [resend v1 0/5] Add support for block disk resize notification Bob Liu
2020-01-06 5:59 ` Bob Liu
2020-01-06 8:47 ` Singh, Balbir
2020-01-06 8:47 ` Singh, Balbir
2020-01-06 9:08 ` Bob Liu
2020-01-06 9:08 ` Bob Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1eb9d796f81fffbb0bfe90bff8460bcda34cb04d.camel@redhat.com \
--to=emilne@redhat.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=mst@redhat.com \
--cc=sblbir@amazon.com \
--cc=ssomesh@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.