From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Singh\, Balbir" <sblbir@amazon.com>
Cc: "martin.petersen\@oracle.com" <martin.petersen@oracle.com>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block\@vger.kernel.org" <linux-block@vger.kernel.org>,
"Sangaraju\, Someswarudu" <ssomesh@amazon.com>,
"jejb\@linux.ibm.com" <jejb@linux.ibm.com>,
"hch\@lst.de" <hch@lst.de>, "axboe\@kernel.dk" <axboe@kernel.dk>,
"mst\@redhat.com" <mst@redhat.com>,
"linux-nvme\@lists.infradead.org"
<linux-nvme@lists.infradead.org>,
"Chaitanya.Kulkarni\@wdc.com" <Chaitanya.Kulkarni@wdc.com>
Subject: Re: [resend v1 5/5] drivers/scsi/sd.c: Convert to use disk_set_capacity
Date: Tue, 07 Jan 2020 22:15:00 -0500 [thread overview]
Message-ID: <yq1blre1vwr.fsf@oracle.com> (raw)
In-Reply-To: <bc0575f1bb565f3955a411032f97163b2a5bd832.camel@amazon.com> (Balbir Singh's message of "Tue, 7 Jan 2020 22:28:29 +0000")
Balbir,
>> We already emit an SDEV_EVT_CAPACITY_CHANGE_REPORTED event if device
>> capacity changes. However, this event does not automatically cause
>> revalidation.
>
> The proposed idea is to not reinforce revalidation, unless explictly
> specified (in the thread before Bob Liu had suggestions). The goal is
> to notify user space of changes via RESIZE. SCSI sd can opt out of
> this IOW, I can remove this if you feel
> SDEV_EVT_CAPACITY_CHANGE_REPORTED is sufficient for current use cases.
I have no particular objection to the code change. I was just observing
that in the context of sd.c, RESIZE=1 is more of a "your request to
resize was successful" notification due to the requirement of an
explicit userland action in case a device reports a capacity change.
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Singh\, Balbir" <sblbir@amazon.com>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
"Chaitanya.Kulkarni@wdc.com" <Chaitanya.Kulkarni@wdc.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"mst@redhat.com" <mst@redhat.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"Sangaraju, Someswarudu" <ssomesh@amazon.com>,
"hch@lst.de" <hch@lst.de>
Subject: Re: [resend v1 5/5] drivers/scsi/sd.c: Convert to use disk_set_capacity
Date: Tue, 07 Jan 2020 22:15:00 -0500 [thread overview]
Message-ID: <yq1blre1vwr.fsf@oracle.com> (raw)
In-Reply-To: <bc0575f1bb565f3955a411032f97163b2a5bd832.camel@amazon.com> (Balbir Singh's message of "Tue, 7 Jan 2020 22:28:29 +0000")
Balbir,
>> We already emit an SDEV_EVT_CAPACITY_CHANGE_REPORTED event if device
>> capacity changes. However, this event does not automatically cause
>> revalidation.
>
> The proposed idea is to not reinforce revalidation, unless explictly
> specified (in the thread before Bob Liu had suggestions). The goal is
> to notify user space of changes via RESIZE. SCSI sd can opt out of
> this IOW, I can remove this if you feel
> SDEV_EVT_CAPACITY_CHANGE_REPORTED is sufficient for current use cases.
I have no particular objection to the code change. I was just observing
that in the context of sd.c, RESIZE=1 is more of a "your request to
resize was successful" notification due to the requirement of an
explicit userland action in case a device reports a capacity change.
--
Martin K. Petersen Oracle Linux Engineering
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-01-08 3:15 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 7:53 [resend v1 0/5] Add support for block disk resize notification Balbir Singh
2020-01-02 7:53 ` Balbir Singh
2020-01-02 7:53 ` [resend v1 1/5] block/genhd: Notify udev about capacity change Balbir Singh
2020-01-02 7:53 ` Balbir Singh
2020-01-03 6:16 ` Chaitanya Kulkarni
2020-01-03 6:16 ` Chaitanya Kulkarni
2020-01-04 4:44 ` Singh, Balbir
2020-01-04 4:44 ` Singh, Balbir
2020-01-04 22:32 ` Chaitanya Kulkarni
2020-01-04 22:32 ` Chaitanya Kulkarni
2020-01-08 15:02 ` hch
2020-01-08 15:02 ` hch
2020-01-07 3:32 ` Martin K. Petersen
2020-01-07 3:32 ` Martin K. Petersen
2020-01-07 22:30 ` Singh, Balbir
2020-01-07 22:30 ` Singh, Balbir
2020-01-08 3:15 ` Martin K. Petersen
2020-01-08 3:15 ` Martin K. Petersen
2020-01-08 15:04 ` hch
2020-01-08 15:04 ` hch
2020-01-21 19:57 ` Singh, Balbir
2020-01-21 19:57 ` Singh, Balbir
2020-01-02 7:53 ` [resend v1 2/5] drivers/block/virtio_blk.c: Convert to use disk_set_capacity Balbir Singh
2020-01-02 7:53 ` Balbir Singh
2020-01-02 7:53 ` [resend v1 3/5] drivers/block/xen-blkfront.c: " Balbir Singh
2020-01-02 7:53 ` Balbir Singh
2020-01-02 7:53 ` [resend v1 4/5] drivers/nvme/host/core.c: " Balbir Singh
2020-01-02 7:53 ` Balbir Singh
2020-01-04 22:27 ` Chaitanya Kulkarni
2020-01-04 22:27 ` Chaitanya Kulkarni
2020-01-06 0:46 ` Singh, Balbir
2020-01-06 0:46 ` Singh, Balbir
2020-01-08 15:04 ` hch
2020-01-08 15:04 ` hch
2020-01-09 3:33 ` Martin K. Petersen
2020-01-09 3:33 ` Martin K. Petersen
2020-01-09 13:12 ` Ewan D. Milne
2020-01-09 13:12 ` Ewan D. Milne
2020-01-21 19:52 ` Singh, Balbir
2020-01-21 19:52 ` Singh, Balbir
2020-01-02 7:53 ` [resend v1 5/5] drivers/scsi/sd.c: " Balbir Singh
2020-01-02 7:53 ` Balbir Singh
2020-01-02 22:21 ` Chaitanya Kulkarni
2020-01-02 22:21 ` Chaitanya Kulkarni
2020-01-03 0:23 ` Singh, Balbir
2020-01-03 0:23 ` Singh, Balbir
2020-01-07 3:48 ` Martin K. Petersen
2020-01-07 3:48 ` Martin K. Petersen
2020-01-07 3:57 ` James Bottomley
2020-01-07 3:57 ` James Bottomley
2020-01-07 4:39 ` Martin K. Petersen
2020-01-07 4:39 ` Martin K. Petersen
2020-01-07 21:37 ` Ewan D. Milne
2020-01-07 21:37 ` Ewan D. Milne
2020-01-08 2:59 ` Martin K. Petersen
2020-01-08 2:59 ` Martin K. Petersen
2020-01-08 21:27 ` Ewan D. Milne
2020-01-08 21:27 ` Ewan D. Milne
2020-01-07 22:28 ` Singh, Balbir
2020-01-07 22:28 ` Singh, Balbir
2020-01-08 3:15 ` Martin K. Petersen [this message]
2020-01-08 3:15 ` Martin K. Petersen
2020-01-08 4:20 ` Singh, Balbir
2020-01-08 4:20 ` Singh, Balbir
2020-01-08 21:32 ` Ewan D. Milne
2020-01-08 21:32 ` Ewan D. Milne
2020-01-08 15:06 ` Christoph Hellwig
2020-01-08 15:06 ` Christoph Hellwig
2020-01-09 2:53 ` Martin K. Petersen
2020-01-09 2:53 ` Martin K. Petersen
2020-01-06 5:59 ` [resend v1 0/5] Add support for block disk resize notification Bob Liu
2020-01-06 5:59 ` Bob Liu
2020-01-06 8:47 ` Singh, Balbir
2020-01-06 8:47 ` Singh, Balbir
2020-01-06 9:08 ` Bob Liu
2020-01-06 9:08 ` Bob Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1blre1vwr.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mst@redhat.com \
--cc=sblbir@amazon.com \
--cc=ssomesh@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.