All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Fastabend <john.fastabend@gmail.com>
To: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>
Cc: "David S . Miller" <davem@davemloft.net>,
	Shuah Khan <shuah@kernel.org>,
	netdev@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf-next v4 3/5] selftests/bpf: test_sockmap, timing improvements
Date: Fri, 1 Jun 2018 07:11:56 -0700	[thread overview]
Message-ID: <1f1895d0-0620-f6df-c3c3-033360bd310e@gmail.com> (raw)
In-Reply-To: <20180531044240.796-4-bhole_prashant_q7@lab.ntt.co.jp>

On 05/30/2018 09:42 PM, Prashant Bhole wrote:
> Currently 10us delay is too low for many tests to succeed. It needs to
> be increased. Also, many corked tests are expected to hit rx timeout
> irrespective of timeout value.
> 
> - This patch sets 1000usec timeout value for corked tests because less
> than that causes broken-pipe error in tx thread. Also sets 1 second
> timeout for all other tests because less than that results in RX
> timeout
> - tests with apply=1 and higher number of iterations were taking lot
> of time. This patch reduces test run time by reducing iterations.
> 
> real    0m12.968s
> user    0m0.219s
> sys     0m14.337s
> 
> Fixes: a18fda1a62c3 ("bpf: reduce runtime of test_sockmap tests")
> Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
> ---

OK seems more reasonable to me. We could probably even go lower
on some of the 'rate' values here if needed (512->128).

Acked-by: John Fastabend <john.fastabend@gmail.com>

WARNING: multiple messages have this Message-ID
From: john.fastabend at gmail.com (John Fastabend)
Subject: [PATCH bpf-next v4 3/5] selftests/bpf: test_sockmap, timing improvements
Date: Fri, 1 Jun 2018 07:11:56 -0700	[thread overview]
Message-ID: <1f1895d0-0620-f6df-c3c3-033360bd310e@gmail.com> (raw)
In-Reply-To: <20180531044240.796-4-bhole_prashant_q7@lab.ntt.co.jp>

On 05/30/2018 09:42 PM, Prashant Bhole wrote:
> Currently 10us delay is too low for many tests to succeed. It needs to
> be increased. Also, many corked tests are expected to hit rx timeout
> irrespective of timeout value.
> 
> - This patch sets 1000usec timeout value for corked tests because less
> than that causes broken-pipe error in tx thread. Also sets 1 second
> timeout for all other tests because less than that results in RX
> timeout
> - tests with apply=1 and higher number of iterations were taking lot
> of time. This patch reduces test run time by reducing iterations.
> 
> real    0m12.968s
> user    0m0.219s
> sys     0m14.337s
> 
> Fixes: a18fda1a62c3 ("bpf: reduce runtime of test_sockmap tests")
> Signed-off-by: Prashant Bhole <bhole_prashant_q7 at lab.ntt.co.jp>
> ---

OK seems more reasonable to me. We could probably even go lower
on some of the 'rate' values here if needed (512->128).

Acked-by: John Fastabend <john.fastabend at gmail.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID
From: john.fastabend@gmail.com (John Fastabend)
Subject: [PATCH bpf-next v4 3/5] selftests/bpf: test_sockmap, timing improvements
Date: Fri, 1 Jun 2018 07:11:56 -0700	[thread overview]
Message-ID: <1f1895d0-0620-f6df-c3c3-033360bd310e@gmail.com> (raw)
Message-ID: <20180601141156.2Xna_XioQz6-hU4YTdXVmqq_vbWfcidvNR_ssyr8v2I@z> (raw)
In-Reply-To: <20180531044240.796-4-bhole_prashant_q7@lab.ntt.co.jp>

On 05/30/2018 09:42 PM, Prashant Bhole wrote:
> Currently 10us delay is too low for many tests to succeed. It needs to
> be increased. Also, many corked tests are expected to hit rx timeout
> irrespective of timeout value.
> 
> - This patch sets 1000usec timeout value for corked tests because less
> than that causes broken-pipe error in tx thread. Also sets 1 second
> timeout for all other tests because less than that results in RX
> timeout
> - tests with apply=1 and higher number of iterations were taking lot
> of time. This patch reduces test run time by reducing iterations.
> 
> real    0m12.968s
> user    0m0.219s
> sys     0m14.337s
> 
> Fixes: a18fda1a62c3 ("bpf: reduce runtime of test_sockmap tests")
> Signed-off-by: Prashant Bhole <bhole_prashant_q7 at lab.ntt.co.jp>
> ---

OK seems more reasonable to me. We could probably even go lower
on some of the 'rate' values here if needed (512->128).

Acked-by: John Fastabend <john.fastabend at gmail.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-06-01 14:12 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-31  4:42 [PATCH bpf-next v4 0/5] fix test_sockmap Prashant Bhole
2018-05-31  4:42 ` Prashant Bhole
2018-05-31  4:42 ` bhole_prashant_q7
2018-05-31  4:42 ` [PATCH bpf-next v4 1/5] selftests/bpf: test_sockmap, check test failure Prashant Bhole
2018-05-31  4:42   ` Prashant Bhole
2018-05-31  4:42   ` bhole_prashant_q7
2018-06-01 14:04   ` John Fastabend
2018-06-01 14:04     ` John Fastabend
2018-06-01 14:04     ` john.fastabend
2018-05-31  4:42 ` [PATCH bpf-next v4 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode Prashant Bhole
2018-05-31  4:42   ` Prashant Bhole
2018-05-31  4:42   ` bhole_prashant_q7
2018-05-31  4:42 ` [PATCH bpf-next v4 3/5] selftests/bpf: test_sockmap, timing improvements Prashant Bhole
2018-05-31  4:42   ` Prashant Bhole
2018-05-31  4:42   ` bhole_prashant_q7
2018-06-01 14:11   ` John Fastabend [this message]
2018-06-01 14:11     ` John Fastabend
2018-06-01 14:11     ` john.fastabend
2018-05-31  4:42 ` [PATCH bpf-next v4 4/5] selftests/bpf: test_sockmap, fix data verification Prashant Bhole
2018-05-31  4:42   ` Prashant Bhole
2018-05-31  4:42   ` bhole_prashant_q7
2018-05-31  4:42 ` [PATCH bpf-next v4 5/5] selftests/bpf: test_sockmap, print additional test options Prashant Bhole
2018-05-31  4:42   ` Prashant Bhole
2018-05-31  4:42   ` bhole_prashant_q7
2018-06-02  4:16 ` [PATCH bpf-next v4 0/5] fix test_sockmap Daniel Borkmann
2018-06-02  4:16   ` Daniel Borkmann
2018-06-02  4:16   ` daniel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f1895d0-0620-f6df-c3c3-033360bd310e@gmail.com \
    --to=john.fastabend@gmail.com \
    --cc=ast@kernel.org \
    --cc=bhole_prashant_q7@lab.ntt.co.jp \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.