All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andries Brouwer <aebr@win.tue.nl>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Andries Brouwer <aebr@win.tue.nl>,
	Norman Diamond <ndiamond@wta.att.ne.jp>,
	linux-kernel@vger.kernel.org, Vojtech Pavlik <vojtech@suse.cz>
Subject: Re: 2.6.0-test5 vs. Japanese keyboards [3]
Date: Wed, 17 Sep 2003 19:22:16 +0200	[thread overview]
Message-ID: <20030917192216.A2164@pclin040.win.tue.nl> (raw)
In-Reply-To: <87vfrr3851.fsf@devron.myhome.or.jp>; from hirofumi@mail.parknet.co.jp on Wed, Sep 17, 2003 at 09:35:22PM +0900

On Wed, Sep 17, 2003 at 09:35:22PM +0900, OGAWA Hirofumi wrote:
> Andries Brouwer <aebr@win.tue.nl> writes:
> 
> > > > OGAWA Hirofumi posted a patch for the yen-sign pipe key on 2003.07.23
> > > > for test1 but his patch still didn't get into test3.

> > until 2.4 the value of NR_KEYS was 128, while 2.6 uses 256

> in input.h
> 	#define KEY_MAX		0x1ff
> in keyboard.h
> 	#define NR_KEYS		(KEY_MAX+1)
> 
> NR_KEYS is 512...  Or we should use 256, you mean?

Yes, I think so.

Maybe Vojtech can tell us why he wrote 512, but I just see a
large amount of wasted space (and, as you already pointed out,
the need for new ioctls) if one uses 512.

As far as I can see, everything works with 256.
Indeed, everything seems to assume 256.

Andries


  reply	other threads:[~2003-09-17 17:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-14  3:51 2.6.0-test5 vs. Japanese keyboards Norman Diamond
2003-09-14 10:20 ` Andries Brouwer
2003-09-14 11:14   ` 2.6.0-test5 vs. Japanese keyboards [1] Norman Diamond
2003-09-14 11:15   ` 2.6.0-test5 vs. Japanese keyboards [2] Norman Diamond
2003-09-14 11:21   ` 2.6.0-test5 vs. Japanese keyboards [3] Norman Diamond
2003-09-16 13:43     ` Andries Brouwer
2003-09-17 12:35       ` OGAWA Hirofumi
2003-09-17 17:22         ` Andries Brouwer [this message]
2003-09-18 16:15           ` OGAWA Hirofumi
2003-09-21 11:06       ` Vojtech Pavlik
2003-09-21 12:39         ` Andries Brouwer
2003-09-21 12:48           ` Vojtech Pavlik
2003-09-21 14:49             ` Andries Brouwer
2003-09-21 17:07               ` Vojtech Pavlik
2003-09-21 17:42                 ` Andries Brouwer
2003-09-21 17:52                   ` Vojtech Pavlik
2003-09-22 12:22                 ` Norman Diamond
2003-09-24 10:02               ` Pavel Machek
     [not found]     ` <fa.gddv2je.1jk671u@ifi.uio.no>
2003-09-16 18:11       ` Junio C Hamano
2003-09-21 11:01 ` 2.6.0-test5 vs. Japanese keyboards Vojtech Pavlik
2003-09-21 13:26   ` Norman Diamond
2003-09-21 15:16     ` Andries Brouwer
2003-09-22 12:21       ` Norman Diamond
2003-09-22 20:14         ` Andries Brouwer
2003-09-23 11:44           ` Norman Diamond
2003-09-23 17:22             ` Andries Brouwer
2003-10-15 10:22               ` Norman Diamond
2003-09-21 16:00   ` Andries Brouwer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030917192216.A2164@pclin040.win.tue.nl \
    --to=aebr@win.tue.nl \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ndiamond@wta.att.ne.jp \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.