From: Dave Jones <davej@redhat.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: cpufreq@www.linux.org.uk, linux@brodo.de,
kernel list <linux-kernel@vger.kernel.org>,
paul.devriendt@amd.com
Subject: Re: Cleanups for powernow-k8
Date: Tue, 13 Jan 2004 21:59:18 +0000 [thread overview]
Message-ID: <20040113215918.GK14674@redhat.com> (raw)
In-Reply-To: <20040113215149.GA236@elf.ucw.cz>
On Tue, Jan 13, 2004 at 10:51:49PM +0100, Pavel Machek wrote:
> powernow-k8 uses strange kind of comments
comments part I kinda agree with, though its not critical..
> and is way too verbose.
I agree that something like that output belongs more in x86info,
or a standalone tool, but I think Paul wanted to keep debugging stuff
there for the time being. Maybe silence it, and have it enabled
with a 'debug' module param ? Paul ?
> Also powernow-k7 should just shut up when it is monolithic
> kernel and cpu is not k7.
Agreed, applied.
> @@ -637,6 +629,7 @@
> }
>
> if ((numps <= 1) || (batps <= 1)) {
> + /* FIXME: Is this right? I can see one state on battery, two states total as an usefull config */
> printk(KERN_ERR PFX "only 1 p-state to transition\n");
> return -ENODEV;
> }
> the test probably should be numps <= 1 only, but it does not matter as
> we force numps = batps]
1 state on battery sounds odd. Buggy BIOS ?
Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Jones <davej@redhat.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>,
paul.devriendt@amd.com, cpufreq@www.linux.org.uk, linux@brodo.de
Subject: Re: Cleanups for powernow-k8
Date: Tue, 13 Jan 2004 21:59:18 +0000 [thread overview]
Message-ID: <20040113215918.GK14674@redhat.com> (raw)
In-Reply-To: <20040113215149.GA236@elf.ucw.cz>
On Tue, Jan 13, 2004 at 10:51:49PM +0100, Pavel Machek wrote:
> powernow-k8 uses strange kind of comments
comments part I kinda agree with, though its not critical..
> and is way too verbose.
I agree that something like that output belongs more in x86info,
or a standalone tool, but I think Paul wanted to keep debugging stuff
there for the time being. Maybe silence it, and have it enabled
with a 'debug' module param ? Paul ?
> Also powernow-k7 should just shut up when it is monolithic
> kernel and cpu is not k7.
Agreed, applied.
> @@ -637,6 +629,7 @@
> }
>
> if ((numps <= 1) || (batps <= 1)) {
> + /* FIXME: Is this right? I can see one state on battery, two states total as an usefull config */
> printk(KERN_ERR PFX "only 1 p-state to transition\n");
> return -ENODEV;
> }
> the test probably should be numps <= 1 only, but it does not matter as
> we force numps = batps]
1 state on battery sounds odd. Buggy BIOS ?
Dave
next prev parent reply other threads:[~2004-01-13 22:01 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-13 21:51 Cleanups for powernow-k8 Pavel Machek
2004-01-13 21:59 ` Dave Jones [this message]
2004-01-13 21:59 ` Dave Jones
2004-01-13 23:59 ` Pavel Machek
2004-01-13 22:37 paul.devriendt
2004-01-13 22:37 ` paul.devriendt
2004-01-13 23:06 ` Dave Jones
2004-01-13 23:06 ` Dave Jones
2004-01-14 9:33 ` Ducrot Bruno
2004-01-14 10:10 ` Dominik Brodowski
2004-01-14 10:10 ` Dominik Brodowski
2004-01-14 15:21 ` Dave Jones
2004-01-14 0:03 ` Pavel Machek
2004-01-14 0:03 ` Pavel Machek
2004-01-14 9:17 ` Ducrot Bruno
2004-01-14 9:17 ` Ducrot Bruno
2004-01-14 2:49 paul.devriendt
2004-01-14 2:49 ` paul.devriendt
2004-01-14 3:33 ` Dave Jones
2004-01-14 3:33 ` Dave Jones
2004-01-14 10:24 ` Dominik Brodowski
2004-01-14 10:24 ` Dominik Brodowski
2004-01-14 3:39 paul.devriendt
2004-01-14 3:39 ` paul.devriendt
2004-01-14 3:42 ` Dave Jones
2004-01-14 3:42 ` Dave Jones
2004-01-14 9:01 ` Pavel Machek
2004-01-14 9:25 ` Dominik Brodowski
2004-01-14 9:25 ` Dominik Brodowski
2004-01-14 9:11 ` Dominik Brodowski
2004-01-14 9:11 ` Dominik Brodowski
2004-01-14 14:49 paul.devriendt
2004-01-14 14:49 ` paul.devriendt
2004-01-14 15:08 ` Dominik Brodowski
2004-01-14 15:08 ` Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040113215918.GK14674@redhat.com \
--to=davej@redhat.com \
--cc=cpufreq@www.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@brodo.de \
--cc=paul.devriendt@amd.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.