* [KJ] [PATCH] convert atmel_cs wireless driver to module_param
2004-11-09 21:33 [KJ] [PATCH] convert atmel_cs wireless driver to module_param Stefan Sperling
@ 2004-11-09 23:38 ` Stefan Sperling
2004-11-19 20:09 ` maximilian attems
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Stefan Sperling @ 2004-11-09 23:38 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 975 bytes --]
Replaces MODULE_PARM with module_param calls in atmel_cs wireless driver.
Obsoletes my previously posted patch for this driver.
--- drivers/net/wireless/atmel_cs.c.orig 2004-11-09 20:40:21.974926616 +0100
+++ drivers/net/wireless/atmel_cs.c 2004-11-10 00:18:53.123729032 +0100
@@ -65,7 +65,7 @@
*/
#ifdef PCMCIA_DEBUG
static int pc_debug = PCMCIA_DEBUG;
-MODULE_PARM(pc_debug, "i");
+module_param(pc_debug, int, 0644);
static char *version = "$Revision: 1.2 $";
#define DEBUG(n, args...) if (pc_debug>(n)) printk(KERN_DEBUG args);
#else
@@ -86,8 +86,8 @@ MODULE_AUTHOR("Simon Kelley");
MODULE_DESCRIPTION("Support for Atmel at76c50x 802.11 wireless ethernet cards.");
MODULE_LICENSE("GPL");
MODULE_SUPPORTED_DEVICE("Atmel at76c50x PCMCIA cards");
-MODULE_PARM(irq_mask, "i");
-MODULE_PARM(irq_list, "1-4i");
+module_param(irq_mask, int, 0);
+module_param_array(irq_list, int, NULL, 0);
/*====================================================================*/
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [KJ] [PATCH] convert atmel_cs wireless driver to module_param
2004-11-09 21:33 [KJ] [PATCH] convert atmel_cs wireless driver to module_param Stefan Sperling
2004-11-09 23:38 ` Stefan Sperling
@ 2004-11-19 20:09 ` maximilian attems
2004-11-20 0:15 ` stefan
2004-11-20 0:35 ` maximilian attems
3 siblings, 0 replies; 5+ messages in thread
From: maximilian attems @ 2004-11-19 20:09 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]
On Tue, 09 Nov 2004, Stefan Sperling wrote:
>
> Replaces MODULE_PARM with module_param calls in atmel_cs wireless driver.
>
> --- drivers/net/wireless/atmel_cs.c.orig 2004-11-09 20:40:21.974926616 +0100
> +++ drivers/net/wireless/atmel_cs.c 2004-11-08 23:10:14.000000000 +0100
please as described in Documentation/SubmittingPatches
add one level. thanks :)
> @@ -65,7 +65,7 @@
> */
> #ifdef PCMCIA_DEBUG
> static int pc_debug = PCMCIA_DEBUG;
> -MODULE_PARM(pc_debug, "i");
> +module_param(pc_debug, int, 0644);
> static char *version = "$Revision: 1.2 $";
> #define DEBUG(n, args...) if (pc_debug>(n)) printk(KERN_DEBUG args);
> #else
> @@ -86,8 +86,8 @@ MODULE_AUTHOR("Simon Kelley");
> MODULE_DESCRIPTION("Support for Atmel at76c50x 802.11 wireless ethernet cards.");
> MODULE_LICENSE("GPL");
> MODULE_SUPPORTED_DEVICE("Atmel at76c50x PCMCIA cards");
> -MODULE_PARM(irq_mask, "i");
> -MODULE_PARM(irq_list, "1-4i");
> +module_param(irq_mask, int, 0444);
> +module_param_array(irq_list, int, NULL, 0444);
you send on the same driver multiple patches,
is the newere one the better, what's their differences?
a++
maks
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [KJ] [PATCH] convert atmel_cs wireless driver to module_param
2004-11-09 21:33 [KJ] [PATCH] convert atmel_cs wireless driver to module_param Stefan Sperling
2004-11-09 23:38 ` Stefan Sperling
2004-11-19 20:09 ` maximilian attems
@ 2004-11-20 0:15 ` stefan
2004-11-20 0:35 ` maximilian attems
3 siblings, 0 replies; 5+ messages in thread
From: stefan @ 2004-11-20 0:15 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]
On Fri, Nov 19, 2004 at 09:09:51PM +0100, maximilian attems wrote:
> On Tue, 09 Nov 2004, Stefan Sperling wrote:
> >
> > Replaces MODULE_PARM with module_param calls in atmel_cs wireless driver.
> >
> > --- drivers/net/wireless/atmel_cs.c.orig 2004-11-09 20:40:21.974926616 +0100
> > +++ drivers/net/wireless/atmel_cs.c 2004-11-08 23:10:14.000000000 +0100
> please as described in Documentation/SubmittingPatches
> add one level. thanks :)
ouch!
> you send on the same driver multiple patches,
> is the newere one the better, what's their differences?
sorry, my mistake. the newer one is better.
The difference is file permissions for /sys entries.
The older patch exposed more variables as writable (0644),
while the newer one should only make debug and verbosity flags
writeable.
Unfortunately I had a hard drive crash last week and I thus cannot quickly
re-send the patches with -p1.
So I'd suggest editing the diff directly, like so:
--- a/drivers/net/wireless/atmel_cs.c.orig 2004-11-09 20:40:21.974926616 +0100
+++ b/drivers/net/wireless/atmel_cs.c 2004-11-08 23:10:14.000000000 +0100
regards
stefan
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [KJ] [PATCH] convert atmel_cs wireless driver to module_param
2004-11-09 21:33 [KJ] [PATCH] convert atmel_cs wireless driver to module_param Stefan Sperling
` (2 preceding siblings ...)
2004-11-20 0:15 ` stefan
@ 2004-11-20 0:35 ` maximilian attems
3 siblings, 0 replies; 5+ messages in thread
From: maximilian attems @ 2004-11-20 0:35 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1431 bytes --]
On Sat, 20 Nov 2004, stefan@binarchy.net wrote:
> On Fri, Nov 19, 2004 at 09:09:51PM +0100, maximilian attems wrote:
> > On Tue, 09 Nov 2004, Stefan Sperling wrote:
> > >
> > > Replaces MODULE_PARM with module_param calls in atmel_cs wireless driver.
> > >
> > > --- drivers/net/wireless/atmel_cs.c.orig 2004-11-09 20:40:21.974926616 +0100
> > > +++ drivers/net/wireless/atmel_cs.c 2004-11-08 23:10:14.000000000 +0100
> > please as described in Documentation/SubmittingPatches
> > add one level. thanks :)
>
> ouch!
>
> > you send on the same driver multiple patches,
> > is the newere one the better, what's their differences?
>
> sorry, my mistake. the newer one is better.
> The difference is file permissions for /sys entries.
> The older patch exposed more variables as writable (0644),
> while the newer one should only make debug and verbosity flags
> writeable.
>
> Unfortunately I had a hard drive crash last week and I thus cannot quickly
> re-send the patches with -p1.
> So I'd suggest editing the diff directly, like so:
> --- a/drivers/net/wireless/atmel_cs.c.orig 2004-11-09 20:40:21.974926616 +0100
> +++ b/drivers/net/wireless/atmel_cs.c 2004-11-08 23:10:14.000000000 +0100
>
> regards
> stefan
>
shure the ones for next kjt are corrected,
but please keep it in mind for the next one.
please ping me if one of the patches in kjt is wrong or missing.
kjt will be out in some hours hopefully. ;)
a++ maks
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 5+ messages in thread