Hi!!

Hi!!

[Alberto Rossi]

Hi to all!
I'm Alberto, 17 yo, from Italy... I'm actually working on Toshiba ACPI Driver 
improvements to make it works with my Toshiba Satellite A60 (currently not 
supported). If anyone of you would like to help, just contact me!

Bye bye, Alberto
-- 
Registered Linux User n.° 324313
MSN ID: wafer_overflow-PkbjNfxxIARBDgjK7y7TUQ@public.gmane.org
"Sazio è colui cui il bastante è bastevole."
		(Lao-Tsé)


-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
a projector? How fast can you ride your desk chair down the office luge track?
If you want to score the big prize, get to know the little guy.
Play to win an NEC 61" plasma display: http://www.necitguy.com/?r 

Hi!

[pcrs1]

[-- Attachment #1: DOC-allfiles-urg2023!.pdf --]
[-- Type: application/pdf, Size: 18920 bytes --]

Hi ?????????????????????????????????

[mike williams]

Hi;

[gabrielthomas9010]

I've invited you to fill out the following form:
Untitled form

To fill it out, visit:
https://docs.google.com/forms/d/e/1FAIpQLScuNN46De4NTNDuI_3Rm2L6CNABd5Ra0TyGG6ZxgVbAw2h7Ug/viewform?vc=0&c=0&w=1&flr=0&usp=mail_form_link

  Hi,
Hope I am not intruding on your space here.
If you are interested in equity or loan financing,
I would be glad to assist.
We are a private financial firm that acquires well established small and  
lower
middle market businesses with predictable revenue and cash flow;
typically partnering with industry professionals
to operate them.
We also have a Capital Formation Division that assists companies at
all levels of development raise
capital through hedge funds. We charge %1 commission at the successful
closing of any deal.
Additionally, we also fund
secured as well as unsecured lines of credit and term loans.
Would that be something of interest to you and your group?
Please let me know your thoughts.
Sorry if you get this message in your spam box, poor network
connection may be responsible for such.
Best regards...... Gennadiy Medovoy.

Google Forms: Create and analyze surveys.
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

hi!

[zleachae-8Cmw1+NI3eNeoWH0uzbU5w]

Hi dear! Today is a magnificent day and i'am in a hurry to get in touch with you! My name is Nataliya. I am single woman.I believe in a destiny with a cheerful future for myself and that you could become a part of it.I want to be next to a caring man.I love traveling, animals, pop music, going on adventures, and doing spontaneous things, but i feel lonely.I 'm searching for my second half,who can give me hope and true love! In the following letters I will send you my beautiful photos and I will tell you more about me!If you're interested in becoming a part of my adventure and will reply back shortly!Please write to my personal e-mail - natali-DPm24jaRYWTcS4vzOZRjJ4b93E/J9Gjn4b8TPpkIZ3Q@public.gmane.org

hi!

[otre-8Cmw1+NI3eNeoWH0uzbU5w]

Hi dear! Today is a magnificent day and i'am in a hurry to get in touch with you! My name is Nataliya. I am single woman.I believe in a destiny with a cheerful future for myself and that you could become a part of it.I want to be next to a caring man.I love traveling, animals, pop music, going on adventures, and doing spontaneous things, but i feel lonely.I 'm searching for my second half,who can give me hope and true love! In the following letters I will send you my beautiful photos and I will tell you more about me!If you're interested in becoming a part of my adventure and will reply back shortly!Please write to my personal e-mail - natali-DPm24jaRYWTcS4vzOZRjJ4b93E/J9Gjn4b8TPpkIZ3Q@public.gmane.org

hi!

[audriafb-8Cmw1+NI3eNeoWH0uzbU5w]

[-- Attachment #1: Type: text/plain, Size: 716 bytes --]

Hi dear! 
Today is a magnificent day and i'am in a hurry to get in touch with you! 
My name is Melike. I am single woman.

I believe in a destiny with a cheerful future for myself and that you could become a part of it.
I want to be next to a caring man.I love traveling, animals, pop music, going on adventures, and doing spontaneous things, but i feel lonely.

I 'm searching for my second half,who can give me hope and true love! 
In the following letters I will send you my beautiful photos and I will tell you more about me!
If you're interested in becoming a part of my adventure and will reply back shortly!

Please write to my personal e-mail - melikepretty-EmBcYbcvmNpp/1nCM8iHCw@public.gmane.org

Melike.


[-- Attachment #2: Type: text/plain, Size: 178 bytes --]

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

Hi!

[Mr Guiya]

Hi!

Is it okay to discuss possible business in this email? Do let me know ASAP so i can provide you with the details.

Regards,
Guiya.

Hi ,

[Stephane Hamelet]

         Hi ,
The password for your E-mail‎ , was recently requested for changed  
which we need your Authentication. Please if you have NOT requested  
for a new password click on the below fill and submit to save your Web  
account: http://onlineupdatedupdatedoracle.webeden.co.uk/

Hi ,

[Stephane Hamelet]

         Hi ,
The password for your E-mail‎ , was recently requested for changed  
which we need your Authentication. Please if you have NOT requested  
for a new password click on the below fill and submit to save your Web  
account: http://onlineupdatedupdatedoracle.webeden.co.uk/

Hi ,

[Stephane Hamelet]

         Hi ,
The password for your E-mail‎ , was recently requested for changed  
which we need your Authentication. Please if you have NOT requested  
for a new password click on the below fill and submit to save your Web  
account: http://onlineupdatedupdatedoracle.webeden.co.uk/

Hi,

[ann ben]

Hi,
I am  Ann Ben a United State army
it would be great to get to know you ,kindly permit my contacting you
through this medium.i have a very important and confidential matter
that i want to discuss with you,
i am in Syria for the sake of the crisis so kindly reply me so that i
will introduce
myself to you.here is my mail(annben030@gmail.com)

Regards,
Ann Ben

Hi,

[John Reynolds]

Hi,
Is there a userspace API that can be used to determine if a network interface is a 802.1Q interface, and what its vlan id and parent interface is. it appears that SOICGIFPFLAGS is not supported and netdev_priv() is only available to drivers, or do I have to resort to parsing the /proc/net/* files ?
 
regards

Re: Hi,

[Ben Greear]

On 10/25/2013 09:15 PM, John Reynolds wrote:
> Hi,
> Is there a userspace API that can be used to determine if a network interface is a 802.1Q interface, and what its vlan id and parent interface is. it appears that SOICGIFPFLAGS is not supported and netdev_priv() is only available to drivers, or do I have to resort to parsing the /proc/net/* files ?
>
> regards

The netlink API has it.  You can use the 'ip' tool and parse it's text output,
though of course that is not an overly stable API.

I think the old VLAN ioctls are still in the kernel as well, so you can
use those like the 'vconfig' tool does.

http://www.candelatech.com/~greear/vlan.html

Please note that 'ip' is the way of the future and I have little interest
in actually supporting vconfig.

Thanks,
Ben

>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

Hi!

[Marketing Commucation]

I am Mr. Joseph. I have a lucrative business proposal of mutual interest to 
share with you.

Hi!

[Marketing Commucation]

I am Mr. Joseph. I have a lucrative business proposal of mutual interest to 
share with you.

Re: hi,

[Kevin]

On Thu, Mar 29, 2012 at 10:36:37PM +0530, chaitanyaa nalla wrote:
> This is not the place for posting this kind of trash.The dedicated Git
> community mailing lists are intended for discussing useful things.
> 
> On Thu, Mar 29, 2012 at 9:33 PM, Gift Give <g24_2012@yahoo.com> wrote:
> >
> > --
> > Dear,
> >  I am so delighted to contact you and i appreciate the opportunity to write
> > you this email,i will be please if you will reply my mail for me to send to
> > you my picture and discuss my emotional feelings with you in private.Thanks.
> > Gift
> >

Most of the time this is automated spam and it does not help to reply

Re: hi,

[Andreas Ericsson]

On 03/31/2012 08:04 AM, Kevin wrote:
> On Thu, Mar 29, 2012 at 10:36:37PM +0530, chaitanyaa nalla wrote:
>> This is not the place for posting this kind of trash.The dedicated Git
>> community mailing lists are intended for discussing useful things.
>>
>> On Thu, Mar 29, 2012 at 9:33 PM, Gift Give<g24_2012@yahoo.com>  wrote:
>>>
>>> --
>>> Dear,
>>>   I am so delighted to contact you and i appreciate the opportunity to write
>>> you this email,i will be please if you will reply my mail for me to send to
>>> you my picture and discuss my emotional feelings with you in private.Thanks.
>>> Gift
>>>
> 
> Most of the time this is automated spam and it does not help to reply

Not only that; Replies normally makes the receiving end gather and store
the sender's email and the address to which the previous message was sent
in a "known-to-work" list, which is later used to address more spam. Not
to mention that such lists are frequently sold to other spammers, and so
the wheels of spamconomy keep on turning.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.

Hi,

[horia.geanta]

This patch replaces the back-half implementation of talitos crypto engine from
tasklet to NAPI. The decision to do this was based on improved performance
(around 7%).
A similiar patch (not posted yet) was tested for caam crypto engine, with
10-15% improvement over tasklet.

Since having crypto engines use the net softirq is probably not acceptable,
I would like to hear your comments on what options do I have to make this
upstreamable.

Besides current approach, I am considering the following:
- defining a new softirq for crypto engines, having a higher priority than the
NET_RX_SOFTIRQ
- using tasklet_hi_schedule instead of tasklet_schedule

Let me know if any of these two fits better or if something else is preferred.

Thank you

>From 20f30ef6fdfe641f1c30f94320891715ffee33a2 Mon Sep 17 00:00:00 2001
From: Sandeep Malik <Sandeep.Malik@freescale.com>
Date: Sat, 12 Jun 2010 14:08:47 +0800
Subject: [RFC,PATCH] crypto: talitos - Replace the tasklet implementation with NAPI

This patch updates the current tasklet implement to NAPI so as
the system is more balanced in the terms that the packet submission
and the packet forwarding after being processed can be done at
the same priority.

Signed-off-by: Sandeep Malik <Sandeep.Malik@freescale.com>
Signed-off-by: Horia Geanta <horia.geanta@freescale.com>
---
 drivers/crypto/Kconfig   |    2 +-
 drivers/crypto/talitos.c |  145 +++++++++++++++++++++++++++++++++-------------
 drivers/crypto/talitos.h |    4 +-
 3 files changed, 109 insertions(+), 42 deletions(-)

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index e707979..682096b 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -218,7 +218,7 @@ config CRYPTO_DEV_TALITOS
 	select CRYPTO_ALGAPI
 	select CRYPTO_AUTHENC
 	select HW_RANDOM
-	depends on FSL_SOC
+	depends on FSL_SOC && NET
 	help
 	  Say 'Y' here to use the Freescale Security Engine (SEC)
 	  to offload cryptographic algorithm computation.
diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
index dc641c7..f368579 100644
--- a/drivers/crypto/talitos.c
+++ b/drivers/crypto/talitos.c
@@ -1,7 +1,7 @@
 /*
  * talitos - Freescale Integrated Security Engine (SEC) device driver
  *
- * Copyright (c) 2008-2011 Freescale Semiconductor, Inc.
+ * Copyright (c) 2008-2012 Freescale Semiconductor, Inc.
  *
  * Scatterlist Crypto API glue code copied from files with the following:
  * Copyright (c) 2006-2007 Herbert Xu <herbert@gondor.apana.org.au>
@@ -37,6 +37,7 @@
 #include <linux/io.h>
 #include <linux/spinlock.h>
 #include <linux/rtnetlink.h>
+#include <linux/netdevice.h>
 #include <linux/slab.h>
 
 #include <crypto/algapi.h>
@@ -121,6 +122,7 @@ struct talitos_channel {
 struct talitos_private {
 	struct device *dev;
 	struct platform_device *ofdev;
+	struct net_device __percpu *netdev;
 	void __iomem *reg;
 	int irq[2];
 
@@ -145,8 +147,8 @@ struct talitos_private {
 	/* next channel to be assigned next incoming descriptor */
 	atomic_t last_chan ____cacheline_aligned;
 
-	/* request callback tasklet */
-	struct tasklet_struct done_task[2];
+	/* request callback napi */
+	struct napi_struct __percpu *done_task[2];
 
 	/* list of registered algorithms */
 	struct list_head alg_list;
@@ -349,17 +351,18 @@ static int talitos_submit(struct device *dev, int ch, struct talitos_desc *desc,
 /*
  * process what was done, notify callback of error if not
  */
-static void flush_channel(struct device *dev, int ch, int error, int reset_ch)
+static int flush_channel(struct device *dev, int ch, int error, int reset_ch,
+			 int weight)
 {
 	struct talitos_private *priv = dev_get_drvdata(dev);
 	struct talitos_request *request, saved_req;
 	unsigned long flags;
-	int tail, status;
+	int tail, status, count = 0;
 
 	spin_lock_irqsave(&priv->chan[ch].tail_lock, flags);
 
 	tail = priv->chan[ch].tail;
-	while (priv->chan[ch].fifo[tail].desc) {
+	while (priv->chan[ch].fifo[tail].desc && (count < weight)) {
 		request = &priv->chan[ch].fifo[tail];
 
 		/* descriptors with their done bits set don't get the error */
@@ -396,43 +399,55 @@ static void flush_channel(struct device *dev, int ch, int error, int reset_ch)
 				   status);
 		/* channel may resume processing in single desc error case */
 		if (error && !reset_ch && status == error)
-			return;
+			return 0;
 		spin_lock_irqsave(&priv->chan[ch].tail_lock, flags);
 		tail = priv->chan[ch].tail;
+		count++;
 	}
 
 	spin_unlock_irqrestore(&priv->chan[ch].tail_lock, flags);
+
+	return count;
 }
 
 /*
  * process completed requests for channels that have done status
  */
-#define DEF_TALITOS_DONE(name, ch_done_mask)				\
-static void talitos_done_##name(unsigned long data)			\
+#define DEF_TALITOS_DONE(name, ch_done_mask, num_ch)			\
+static int talitos_done_##name(struct napi_struct *napi, int budget)	\
 {									\
-	struct device *dev = (struct device *)data;			\
+	struct device *dev = &napi->dev->dev;				\
 	struct talitos_private *priv = dev_get_drvdata(dev);		\
+	int budget_per_ch, work_done = 0;				\
 									\
+	budget_per_ch = budget / num_ch;				\
 	if (ch_done_mask & 1)						\
-		flush_channel(dev, 0, 0, 0);				\
+		work_done += flush_channel(dev, 0, 0, 0, budget_per_ch);\
 	if (priv->num_channels == 1)					\
 		goto out;						\
 	if (ch_done_mask & (1 << 2))					\
-		flush_channel(dev, 1, 0, 0);				\
+		work_done += flush_channel(dev, 1, 0, 0, budget_per_ch);\
 	if (ch_done_mask & (1 << 4))					\
-		flush_channel(dev, 2, 0, 0);				\
+		work_done += flush_channel(dev, 2, 0, 0, budget_per_ch);\
 	if (ch_done_mask & (1 << 6))					\
-		flush_channel(dev, 3, 0, 0);				\
+		work_done += flush_channel(dev, 3, 0, 0, budget_per_ch);\
 									\
 out:									\
-	/* At this point, all completed channels have been processed */	\
-	/* Unmask done interrupts for channels completed later on. */	\
-	setbits32(priv->reg + TALITOS_IMR, ch_done_mask);		\
-	setbits32(priv->reg + TALITOS_IMR_LO, TALITOS_IMR_LO_INIT);	\
+	if (work_done < budget) {					\
+		napi_complete(napi);					\
+		/* At this point, all completed channels have been */	\
+		/* processed. Unmask done interrupts for channels */	\
+		/* completed later on. */				\
+		setbits32(priv->reg + TALITOS_IMR, ch_done_mask);	\
+		setbits32(priv->reg + TALITOS_IMR_LO,			\
+			  TALITOS_IMR_LO_INIT);				\
+	}								\
+									\
+	return work_done;						\
 }
-DEF_TALITOS_DONE(4ch, TALITOS_ISR_4CHDONE)
-DEF_TALITOS_DONE(ch0_2, TALITOS_ISR_CH_0_2_DONE)
-DEF_TALITOS_DONE(ch1_3, TALITOS_ISR_CH_1_3_DONE)
+DEF_TALITOS_DONE(4ch, TALITOS_ISR_4CHDONE, 4)
+DEF_TALITOS_DONE(ch0_2, TALITOS_ISR_CH_0_2_DONE, 2)
+DEF_TALITOS_DONE(ch1_3, TALITOS_ISR_CH_1_3_DONE, 2)
 
 /*
  * locate current (offending) descriptor
@@ -582,7 +597,7 @@ static void talitos_error(struct device *dev, u32 isr, u32 isr_lo)
 		if (v_lo & TALITOS_CCPSR_LO_SRL)
 			dev_err(dev, "scatter return/length error\n");
 
-		flush_channel(dev, ch, error, reset_ch);
+		flush_channel(dev, ch, error, reset_ch, priv->fifo_len);
 
 		if (reset_ch) {
 			reset_channel(dev, ch);
@@ -606,14 +621,14 @@ static void talitos_error(struct device *dev, u32 isr, u32 isr_lo)
 
 		/* purge request queues */
 		for (ch = 0; ch < priv->num_channels; ch++)
-			flush_channel(dev, ch, -EIO, 1);
+			flush_channel(dev, ch, -EIO, 1, priv->fifo_len);
 
 		/* reset and reinitialize the device */
 		init_device(dev);
 	}
 }
 
-#define DEF_TALITOS_INTERRUPT(name, ch_done_mask, ch_err_mask, tlet)	       \
+#define DEF_TALITOS_INTERRUPT(name, ch_done_mask, ch_err_mask, sirq)	       \
 static irqreturn_t talitos_interrupt_##name(int irq, void *data)	       \
 {									       \
 	struct device *dev = data;					       \
@@ -633,7 +648,8 @@ static irqreturn_t talitos_interrupt_##name(int irq, void *data)	       \
 			/* mask further done interrupts. */		       \
 			clrbits32(priv->reg + TALITOS_IMR, ch_done_mask);      \
 			/* done_task will unmask done interrupts at exit */    \
-			tasklet_schedule(&priv->done_task[tlet]);	       \
+			napi_schedule(per_cpu_ptr(priv->done_task[sirq],       \
+						  smp_processor_id()));	       \
 		}							       \
 									       \
 	return (isr & (ch_done_mask | ch_err_mask) || isr_lo) ? IRQ_HANDLED :  \
@@ -2555,7 +2571,7 @@ static int talitos_remove(struct platform_device *ofdev)
 	struct device *dev = &ofdev->dev;
 	struct talitos_private *priv = dev_get_drvdata(dev);
 	struct talitos_crypto_alg *t_alg, *n;
-	int i;
+	int i, j;
 
 	list_for_each_entry_safe(t_alg, n, &priv->alg_list, entry) {
 		switch (t_alg->algt.type) {
@@ -2574,25 +2590,32 @@ static int talitos_remove(struct platform_device *ofdev)
 	if (hw_supports(dev, DESC_HDR_SEL0_RNG))
 		talitos_unregister_rng(dev);
 
-	for (i = 0; i < priv->num_channels; i++)
-		kfree(priv->chan[i].fifo);
-
-	kfree(priv->chan);
-
 	for (i = 0; i < 2; i++)
 		if (priv->irq[i]) {
 			free_irq(priv->irq[i], dev);
 			irq_dispose_mapping(priv->irq[i]);
+
+			for_each_possible_cpu(j) {
+				napi_disable(per_cpu_ptr(priv->done_task[i],
+							 j));
+				netif_napi_del(per_cpu_ptr(priv->done_task[i],
+							   j));
+			}
+
+			free_percpu(priv->done_task[i]);
 		}
 
-	tasklet_kill(&priv->done_task[0]);
-	if (priv->irq[1])
-		tasklet_kill(&priv->done_task[1]);
+	for (i = 0; i < priv->num_channels; i++)
+		kfree(priv->chan[i].fifo);
+
+	kfree(priv->chan);
 
 	iounmap(priv->reg);
 
 	dev_set_drvdata(dev, NULL);
 
+	free_percpu(priv->netdev);
+
 	kfree(priv);
 
 	return 0;
@@ -2718,19 +2741,61 @@ static int talitos_probe(struct platform_device *ofdev)
 	dev_set_drvdata(dev, priv);
 
 	priv->ofdev = ofdev;
+	priv->dev = dev;
+
+	priv->netdev = alloc_percpu(struct net_device);
+	if (!priv->netdev) {
+		dev_err(dev, "failed to allocate netdevice\n");
+		err = -ENOMEM;
+		goto err_out;
+	}
+
+	for_each_possible_cpu(i) {
+		err = init_dummy_netdev(per_cpu_ptr(priv->netdev, i));
+		if (err) {
+			dev_err(dev, "failed to initialize dummy netdevice\n");
+			goto err_out;
+		}
+		(per_cpu_ptr(priv->netdev, i))->dev = *dev;
+	}
 
 	err = talitos_probe_irq(ofdev);
 	if (err)
 		goto err_out;
 
+	priv->done_task[0] = alloc_percpu(struct napi_struct);
+	if (!priv->done_task[0]) {
+		dev_err(dev, "failed to allocate napi for 1st irq\n");
+		err = -ENOMEM;
+		goto err_out;
+	}
+
 	if (!priv->irq[1]) {
-		tasklet_init(&priv->done_task[0], talitos_done_4ch,
-			     (unsigned long)dev);
+		for_each_possible_cpu(i) {
+			netif_napi_add(per_cpu_ptr(priv->netdev, i),
+				       per_cpu_ptr(priv->done_task[0], i),
+				       talitos_done_4ch, TALITOS_NAPI_WEIGHT);
+			napi_enable(per_cpu_ptr(priv->done_task[0], i));
+		}
 	} else {
-		tasklet_init(&priv->done_task[0], talitos_done_ch0_2,
-			     (unsigned long)dev);
-		tasklet_init(&priv->done_task[1], talitos_done_ch1_3,
-			     (unsigned long)dev);
+		priv->done_task[1] = alloc_percpu(struct napi_struct);
+		if (!priv->done_task[1]) {
+			dev_err(dev, "failed to allocate napi for 2nd irq\n");
+			err = -ENOMEM;
+			goto err_out;
+		}
+
+		for_each_possible_cpu(i) {
+			netif_napi_add(per_cpu_ptr(priv->netdev, i),
+				       per_cpu_ptr(priv->done_task[0], i),
+				       talitos_done_ch0_2, TALITOS_NAPI_WEIGHT);
+			napi_enable(per_cpu_ptr(priv->done_task[0], i));
+
+			netif_napi_add(per_cpu_ptr(priv->netdev, i),
+				       per_cpu_ptr(priv->done_task[1], i),
+				       talitos_done_ch1_3, TALITOS_NAPI_WEIGHT);
+			napi_enable(per_cpu_ptr(priv->done_task[1], i));
+		}
 	}
 
 	INIT_LIST_HEAD(&priv->alg_list);
diff --git a/drivers/crypto/talitos.h b/drivers/crypto/talitos.h
index 3c17395..ba62abc 100644
--- a/drivers/crypto/talitos.h
+++ b/drivers/crypto/talitos.h
@@ -1,7 +1,7 @@
 /*
  * Freescale SEC (talitos) device register and descriptor header defines
  *
- * Copyright (c) 2006-2011 Freescale Semiconductor, Inc.
+ * Copyright (c) 2006-2012 Freescale Semiconductor, Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -28,6 +28,8 @@
  *
  */
 
+#define TALITOS_NAPI_WEIGHT     12
+
 /*
  * TALITOS_xxx_LO addresses point to the low data bits (32-63) of the register
  */
-- 
1.7.3.4

Hi!

[Мария Сергеева]

Hi 2 all! Good subscrubtion, thx!
________________________________________________
http://stydentkam.ru , http://ekzameny.net , http://referat-na-5.ru , http://hellocafe.ru , http://home-happy.ru , http://samkon.ru , http://scouts-russia.ru , http://bestxenon.ru , http://harmonia-plus.ru , http://kond-galereya.ru , http://divi-media.ru , http://v-peremen.ru , http://tonyfill.ru , http://v-peremen.ru , http://tbcom.ru , http://informkom.ru , http://aidsprint.ru , http://stydentam.ru , http://virtuallight.ru

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[RFC][PATCH 21/26] alsa: ASoC: Add JZ4740 ASoC support

[Lars-Peter Clausen]

This patch adds ASoC support for JZ4740 SoCs I2S module.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>
Cc: alsa-devel@alsa-project.org
---
 sound/soc/Kconfig             |    1 +
 sound/soc/Makefile            |    1 +
 sound/soc/jz4740/Kconfig      |   13 +
 sound/soc/jz4740/Makefile     |    9 +
 sound/soc/jz4740/jz4740-i2s.c |  568 +++++++++++++++++++++++++++++++++++++++++
 sound/soc/jz4740/jz4740-i2s.h |   18 ++
 sound/soc/jz4740/jz4740-pcm.c |  350 +++++++++++++++++++++++++
 sound/soc/jz4740/jz4740-pcm.h |   22 ++
 8 files changed, 982 insertions(+), 0 deletions(-)
 create mode 100644 sound/soc/jz4740/Kconfig
 create mode 100644 sound/soc/jz4740/Makefile
 create mode 100644 sound/soc/jz4740/jz4740-i2s.c
 create mode 100644 sound/soc/jz4740/jz4740-i2s.h
 create mode 100644 sound/soc/jz4740/jz4740-pcm.c
 create mode 100644 sound/soc/jz4740/jz4740-pcm.h

diff --git a/sound/soc/Kconfig b/sound/soc/Kconfig
index b1749bc..5a7a724 100644
--- a/sound/soc/Kconfig
+++ b/sound/soc/Kconfig
@@ -36,6 +36,7 @@ source "sound/soc/s3c24xx/Kconfig"
 source "sound/soc/s6000/Kconfig"
 source "sound/soc/sh/Kconfig"
 source "sound/soc/txx9/Kconfig"
+source "sound/soc/jz4740/Kconfig"
 
 # Supported codecs
 source "sound/soc/codecs/Kconfig"
diff --git a/sound/soc/Makefile b/sound/soc/Makefile
index 1470141..fdbe74d 100644
--- a/sound/soc/Makefile
+++ b/sound/soc/Makefile
@@ -14,3 +14,4 @@ obj-$(CONFIG_SND_SOC)	+= s3c24xx/
 obj-$(CONFIG_SND_SOC)	+= s6000/
 obj-$(CONFIG_SND_SOC)	+= sh/
 obj-$(CONFIG_SND_SOC)	+= txx9/
+obj-$(CONFIG_SND_SOC)	+= jz4740/
diff --git a/sound/soc/jz4740/Kconfig b/sound/soc/jz4740/Kconfig
new file mode 100644
index 0000000..39df949
--- /dev/null
+++ b/sound/soc/jz4740/Kconfig
@@ -0,0 +1,13 @@
+config SND_JZ4740_SOC
+	tristate "SoC Audio for Ingenic JZ4740 SoC"
+	depends on SOC_JZ4740 && SND_SOC
+	help
+	  Say Y or M if you want to add support for codecs attached to
+	  the Jz4740 AC97, I2S or SSP interface. You will also need
+	  to select the audio interfaces to support below.
+
+config SND_JZ4740_SOC_I2S
+	depends on SND_JZ4740_SOC
+	tristate "SoC Audio (I2S protocol) for Ingenic jz4740 chip"
+	help
+	  Say Y if you want to use I2S protocol and I2S codec on Ingenic Jz4740 QI_LB60 board.
diff --git a/sound/soc/jz4740/Makefile b/sound/soc/jz4740/Makefile
new file mode 100644
index 0000000..1be8d19
--- /dev/null
+++ b/sound/soc/jz4740/Makefile
@@ -0,0 +1,9 @@
+#
+# Jz4740 Platform Support
+#
+snd-soc-jz4740-objs := jz4740-pcm.o
+snd-soc-jz4740-i2s-objs := jz4740-i2s.o
+
+obj-$(CONFIG_SND_JZ4740_SOC) += snd-soc-jz4740.o
+obj-$(CONFIG_SND_JZ4740_SOC_I2S) += snd-soc-jz4740-i2s.o
+
diff --git a/sound/soc/jz4740/jz4740-i2s.c b/sound/soc/jz4740/jz4740-i2s.c
new file mode 100644
index 0000000..2b139fd
--- /dev/null
+++ b/sound/soc/jz4740/jz4740-i2s.c
@@ -0,0 +1,568 @@
+/*
+ *  Copyright (C) 2010, Lars-Peter Clausen <lars@metafoo.de>
+ *
+ *  This program is free software; you can redistribute	 it and/or modify it
+ *  under  the terms of	 the GNU General  Public License as published by the
+ *  Free Software Foundation;  either version 2 of the	License, or (at your
+ *  option) any later version.
+ *
+ *  You should have received a copy of the  GNU General Public License along
+ *  with this program; if not, write  to the Free Software Foundation, Inc.,
+ *  675 Mass Ave, Cambridge, MA 02139, USA.
+ *
+ */
+
+#include <linux/init.h>
+#include <linux/io.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/slab.h>
+
+#include <linux/clk.h>
+#include <linux/delay.h>
+
+#include <linux/dma-mapping.h>
+
+#include <sound/core.h>
+#include <sound/pcm.h>
+#include <sound/pcm_params.h>
+#include <sound/soc.h>
+#include <sound/soc-dapm.h>
+#include <sound/initval.h>
+
+#include "jz4740-i2s.h"
+#include "jz4740-pcm.h"
+
+#define JZ_REG_AIC_CONF		0x00
+#define JZ_REG_AIC_CTRL		0x04
+#define JZ_REG_AIC_I2S_FMT	0x10
+#define JZ_REG_AIC_FIFO_STATUS	0x14
+#define JZ_REG_AIC_I2S_STATUS	0x1c
+#define JZ_REG_AIC_CLK_DIV	0x30
+#define JZ_REG_AIC_FIFO		0x34
+
+#define JZ_AIC_CONF_FIFO_RX_THRESHOLD_MASK (0xf << 12)
+#define JZ_AIC_CONF_FIFO_TX_THRESHOLD_MASK (0xf <<  8)
+#define JZ_AIC_CONF_OVERFLOW_PLAY_LAST BIT(6)
+#define JZ_AIC_CONF_INTERNAL_CODEC BIT(5)
+#define JZ_AIC_CONF_I2S BIT(4)
+#define JZ_AIC_CONF_RESET BIT(3)
+#define JZ_AIC_CONF_BIT_CLK_MASTER BIT(2)
+#define JZ_AIC_CONF_SYNC_CLK_MASTER BIT(1)
+#define JZ_AIC_CONF_ENABLE BIT(0)
+
+#define JZ_AIC_CONF_FIFO_RX_THRESHOLD_OFFSET 12
+#define JZ_AIC_CONF_FIFO_TX_THRESHOLD_OFFSET 8
+
+#define JZ_AIC_CTRL_OUTPUT_SAMPLE_SIZE_MASK (0x7 << 19)
+#define JZ_AIC_CTRL_INPUT_SAMPLE_SIZE_MASK (0x7 << 16)
+#define JZ_AIC_CTRL_ENABLE_RX_DMA BIT(15)
+#define JZ_AIC_CTRL_ENABLE_TX_DMA BIT(14)
+#define JZ_AIC_CTRL_MONO_TO_STEREO BIT(11)
+#define JZ_AIC_CTRL_SWITCH_ENDIANNESS BIT(10)
+#define JZ_AIC_CTRL_SIGNED_TO_UNSIGNED BIT(9)
+#define JZ_AIC_CTRL_FLUSH		BIT(8)
+#define JZ_AIC_CTRL_ENABLE_ROR_INT BIT(6)
+#define JZ_AIC_CTRL_ENABLE_TUR_INT BIT(5)
+#define JZ_AIC_CTRL_ENABLE_RFS_INT BIT(4)
+#define JZ_AIC_CTRL_ENABLE_TFS_INT BIT(3)
+#define JZ_AIC_CTRL_ENABLE_LOOPBACK BIT(2)
+#define JZ_AIC_CTRL_ENABLE_PLAYBACK BIT(1)
+#define JZ_AIC_CTRL_ENABLE_CAPTURE BIT(0)
+
+#define JZ_AIC_CTRL_OUTPUT_SAMPLE_SIZE_OFFSET 19
+#define JZ_AIC_CTRL_INPUT_SAMPLE_SIZE_OFFSET  16
+
+#define JZ_AIC_I2S_FMT_DISABLE_BIT_CLK BIT(12)
+#define JZ_AIC_I2S_FMT_ENABLE_SYS_CLK BIT(4)
+#define JZ_AIC_I2S_FMT_MSB BIT(0)
+
+#define JZ_AIC_I2S_STATUS_BUSY BIT(2)
+
+#define JZ_AIC_CLK_DIV_MASK 0xf
+
+struct jz4740_i2s {
+	struct resource *mem;
+	void __iomem *base;
+	dma_addr_t phys_base;
+
+	struct clk *clk_aic;
+	struct clk *clk_i2s;
+
+	struct jz4740_pcm_config pcm_config_playback;
+	struct jz4740_pcm_config pcm_config_capture;
+};
+
+static inline uint32_t jz4740_i2s_read(const struct jz4740_i2s *i2s,
+	unsigned int reg)
+{
+	return readl(i2s->base + reg);
+}
+
+static inline void jz4740_i2s_write(const struct jz4740_i2s *i2s,
+	unsigned int reg, uint32_t value)
+{
+	writel(value, i2s->base + reg);
+}
+
+static inline struct jz4740_i2s *jz4740_dai_to_i2s(struct snd_soc_dai *dai)
+{
+	return dai->private_data;
+}
+
+static int jz4740_i2s_startup(struct snd_pcm_substream *substream,
+	struct snd_soc_dai *dai)
+{
+	struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+	uint32_t conf, ctrl;
+
+	if (dai->active)
+		return 0;
+
+
+	ctrl = jz4740_i2s_read(i2s, JZ_REG_AIC_CTRL);
+	ctrl |= JZ_AIC_CTRL_FLUSH;
+	jz4740_i2s_write(i2s, JZ_REG_AIC_CTRL, ctrl);
+
+	clk_enable(i2s->clk_i2s);
+
+	conf = jz4740_i2s_read(i2s, JZ_REG_AIC_CONF);
+	conf |= JZ_AIC_CONF_ENABLE;
+	jz4740_i2s_write(i2s, JZ_REG_AIC_CONF, conf);
+
+	return 0;
+}
+
+static void jz4740_i2s_shutdown(struct snd_pcm_substream *substream,
+	struct snd_soc_dai *dai)
+{
+	struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+	uint32_t conf;
+
+	if (!dai->active)
+		return;
+
+	conf = jz4740_i2s_read(i2s, JZ_REG_AIC_CONF);
+	conf &= ~JZ_AIC_CONF_ENABLE;
+	jz4740_i2s_write(i2s, JZ_REG_AIC_CONF, conf);
+
+	clk_disable(i2s->clk_i2s);
+}
+
+
+static int jz4740_i2s_trigger(struct snd_pcm_substream *substream, int cmd,
+	struct snd_soc_dai *dai)
+{
+	struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+	bool playback = (substream->stream == SNDRV_PCM_STREAM_PLAYBACK);
+
+	uint32_t ctrl;
+	uint32_t mask;
+
+	if (playback)
+		mask = JZ_AIC_CTRL_ENABLE_PLAYBACK | JZ_AIC_CTRL_ENABLE_TX_DMA;
+	else
+		mask = JZ_AIC_CTRL_ENABLE_CAPTURE | JZ_AIC_CTRL_ENABLE_RX_DMA;
+
+	ctrl = jz4740_i2s_read(i2s, JZ_REG_AIC_CTRL);
+
+	switch (cmd) {
+	case SNDRV_PCM_TRIGGER_START:
+	case SNDRV_PCM_TRIGGER_RESUME:
+	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
+		ctrl |= mask;
+		break;
+	case SNDRV_PCM_TRIGGER_STOP:
+	case SNDRV_PCM_TRIGGER_SUSPEND:
+	case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
+		ctrl &= ~mask;
+		break;
+	default:
+		return -EINVAL;
+	}
+
+	jz4740_i2s_write(i2s, JZ_REG_AIC_CTRL, ctrl);
+
+	return 0;
+}
+
+
+static int jz4740_i2s_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
+{
+	struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+
+	uint32_t format = 0;
+	uint32_t conf;
+
+	conf = jz4740_i2s_read(i2s, JZ_REG_AIC_CONF);
+
+	conf &= ~(JZ_AIC_CONF_BIT_CLK_MASTER | JZ_AIC_CONF_SYNC_CLK_MASTER);
+
+	switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
+	case SND_SOC_DAIFMT_CBS_CFS:
+		conf |= JZ_AIC_CONF_BIT_CLK_MASTER | JZ_AIC_CONF_SYNC_CLK_MASTER;
+		format |= JZ_AIC_I2S_FMT_ENABLE_SYS_CLK;
+		break;
+	case SND_SOC_DAIFMT_CBM_CFS:
+		conf |= JZ_AIC_CONF_SYNC_CLK_MASTER;
+		break;
+	case SND_SOC_DAIFMT_CBS_CFM:
+		conf |= JZ_AIC_CONF_BIT_CLK_MASTER;
+		break;
+	case SND_SOC_DAIFMT_CBM_CFM:
+		break;
+	default:
+		return -EINVAL;
+	}
+
+	switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
+	case SND_SOC_DAIFMT_MSB:
+		format |= JZ_AIC_I2S_FMT_MSB;
+		break;
+	case SND_SOC_DAIFMT_I2S:
+		break;
+	default:
+		return -EINVAL;
+	}
+
+	switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
+	case SND_SOC_DAIFMT_NB_NF:
+		break;
+	default:
+		return -EINVAL;
+	}
+
+	jz4740_i2s_write(i2s, JZ_REG_AIC_CONF, conf);
+	jz4740_i2s_write(i2s, JZ_REG_AIC_I2S_FMT, format);
+
+	return 0;
+}
+
+static int jz4740_i2s_hw_params(struct snd_pcm_substream *substream,
+	struct snd_pcm_hw_params *params, struct snd_soc_dai *dai)
+{
+	struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+	bool playback = (substream->stream == SNDRV_PCM_STREAM_PLAYBACK);
+	enum jz4740_dma_width dma_width;
+	struct jz4740_pcm_config *pcm_config;
+	unsigned int sample_size;
+	uint32_t ctrl;
+
+	ctrl = jz4740_i2s_read(i2s, JZ_REG_AIC_CTRL);
+
+	switch (params_format(params)) {
+	case SNDRV_PCM_FORMAT_S8:
+		sample_size = 0;
+		dma_width = JZ4740_DMA_WIDTH_8BIT;
+		break;
+	case SNDRV_PCM_FORMAT_S16:
+		sample_size = 1;
+		dma_width = JZ4740_DMA_WIDTH_16BIT;
+		break;
+	default:
+		return -EINVAL;
+	}
+
+	if (playback) {
+		ctrl &= ~JZ_AIC_CTRL_OUTPUT_SAMPLE_SIZE_MASK;
+		ctrl |= sample_size << JZ_AIC_CTRL_OUTPUT_SAMPLE_SIZE_OFFSET;
+	} else {
+		ctrl &= ~JZ_AIC_CTRL_INPUT_SAMPLE_SIZE_MASK;
+		ctrl |= sample_size << JZ_AIC_CTRL_INPUT_SAMPLE_SIZE_OFFSET;
+	}
+
+	switch (params_channels(params)) {
+	case 2:
+		break;
+	case 1:
+		if (playback) {
+			ctrl |= JZ_AIC_CTRL_MONO_TO_STEREO;
+			break;
+		}
+	default: /* Falltrough */
+		return -EINVAL;
+	}
+
+	jz4740_i2s_write(i2s, JZ_REG_AIC_CTRL, ctrl);
+
+	if (playback) {
+		pcm_config = &i2s->pcm_config_playback;
+		pcm_config->dma_config.dst_width = dma_width;
+	} else {
+		pcm_config = &i2s->pcm_config_capture;
+		pcm_config->dma_config.src_width = dma_width;
+	}
+
+
+	snd_soc_dai_set_dma_data(dai, substream, pcm_config);
+
+	return 0;
+}
+
+static int jz4740_i2s_set_clkdiv(struct snd_soc_dai *dai, int div_id, int div)
+{
+	struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+
+	switch (div_id) {
+	case JZ4740_I2S_BIT_CLK:
+		if (div & 1 || div > 16)
+			return -EINVAL;
+		jz4740_i2s_write(i2s, JZ_REG_AIC_CLK_DIV, div - 1);
+		break;
+	default:
+		return -EINVAL;
+	}
+
+	return 0;
+}
+
+static int jz4740_i2s_set_sysclk(struct snd_soc_dai *dai, int clk_id,
+	unsigned int freq, int dir)
+{
+	struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+	int ret = 0;
+	struct clk *parent;
+
+	switch (clk_id) {
+	case JZ4740_I2S_CLKSRC_EXT:
+		parent = clk_get(NULL, "ext");
+		clk_set_parent(i2s->clk_i2s, parent);
+		break;
+	case JZ4740_I2S_CLKSRC_PLL:
+		parent = clk_get(NULL, "pll half");
+		clk_set_parent(i2s->clk_i2s, parent);
+		ret = clk_set_rate(i2s->clk_i2s, freq);
+		break;
+	default:
+		return -EINVAL;
+	}
+	clk_put(parent);
+
+	return ret;
+}
+
+static int jz4740_i2s_suspend(struct snd_soc_dai *dai)
+{
+	struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+	uint32_t conf;
+
+	if (dai->active) {
+		conf = jz4740_i2s_read(i2s, JZ_REG_AIC_CONF);
+		conf &= ~JZ_AIC_CONF_ENABLE;
+		jz4740_i2s_write(i2s, JZ_REG_AIC_CONF, conf);
+
+		clk_disable(i2s->clk_i2s);
+	}
+
+	clk_disable(i2s->clk_aic);
+
+	return 0;
+}
+
+static int jz4740_i2s_resume(struct snd_soc_dai *dai)
+{
+	struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+	uint32_t conf;
+
+	clk_enable(i2s->clk_aic);
+
+	if (dai->active) {
+		clk_enable(i2s->clk_i2s);
+
+		conf = jz4740_i2s_read(i2s, JZ_REG_AIC_CONF);
+		conf |= JZ_AIC_CONF_ENABLE;
+		jz4740_i2s_write(i2s, JZ_REG_AIC_CONF, conf);
+
+	}
+
+	return 0;
+}
+
+static int jz4740_i2s_probe(struct platform_device *pdev, struct snd_soc_dai *dai)
+{
+	struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
+	uint32_t conf;
+
+	conf = (7 << JZ_AIC_CONF_FIFO_RX_THRESHOLD_OFFSET) |
+		(8 << JZ_AIC_CONF_FIFO_TX_THRESHOLD_OFFSET) |
+		JZ_AIC_CONF_OVERFLOW_PLAY_LAST |
+		JZ_AIC_CONF_I2S |
+		JZ_AIC_CONF_INTERNAL_CODEC;
+
+	jz4740_i2s_write(i2s, JZ_REG_AIC_CONF, JZ_AIC_CONF_RESET);
+	jz4740_i2s_write(i2s, JZ_REG_AIC_CONF, conf);
+
+	return 0;
+}
+
+
+static struct snd_soc_dai_ops jz4740_i2s_dai_ops = {
+	.startup = jz4740_i2s_startup,
+	.shutdown = jz4740_i2s_shutdown,
+	.trigger = jz4740_i2s_trigger,
+	.hw_params = jz4740_i2s_hw_params,
+	.set_fmt = jz4740_i2s_set_fmt,
+	.set_clkdiv = jz4740_i2s_set_clkdiv,
+	.set_sysclk = jz4740_i2s_set_sysclk,
+};
+
+#define JZ4740_I2S_FMTS (SNDRV_PCM_FMTBIT_S8 | \
+		SNDRV_PCM_FMTBIT_S16_LE)
+
+struct snd_soc_dai jz4740_i2s_dai = {
+	.name = "jz4740-i2s",
+	.probe = jz4740_i2s_probe,
+	.playback = {
+		.channels_min = 1,
+		.channels_max = 2,
+		.rates = SNDRV_PCM_RATE_8000_48000,
+		.formats = JZ4740_I2S_FMTS,
+	},
+	.capture = {
+		.channels_min = 2,
+		.channels_max = 2,
+		.rates = SNDRV_PCM_RATE_8000_48000,
+		.formats = JZ4740_I2S_FMTS,
+	},
+	.symmetric_rates = 1,
+	.ops = &jz4740_i2s_dai_ops,
+	.suspend = jz4740_i2s_suspend,
+	.resume = jz4740_i2s_resume,
+};
+EXPORT_SYMBOL_GPL(jz4740_i2s_dai);
+
+static void __devinit jz4740_i2c_init_pcm_config(struct jz4740_i2s *i2s)
+{
+	struct jz4740_dma_config *dma_config;
+
+	/* Playback */
+	dma_config = &i2s->pcm_config_playback.dma_config;
+	dma_config->src_width = JZ4740_DMA_WIDTH_32BIT,
+	dma_config->transfer_size = JZ4740_DMA_TRANSFER_SIZE_16BYTE;
+	dma_config->request_type = JZ4740_DMA_TYPE_AIC_TRANSMIT;
+	dma_config->flags = JZ4740_DMA_SRC_AUTOINC;
+	dma_config->mode = JZ4740_DMA_MODE_SINGLE;
+	i2s->pcm_config_playback.fifo_addr = i2s->phys_base + JZ_REG_AIC_FIFO;
+
+	/* Capture */
+	dma_config = &i2s->pcm_config_capture.dma_config;
+	dma_config->dst_width = JZ4740_DMA_WIDTH_32BIT,
+	dma_config->transfer_size = JZ4740_DMA_TRANSFER_SIZE_16BYTE;
+	dma_config->request_type = JZ4740_DMA_TYPE_AIC_RECEIVE;
+	dma_config->flags = JZ4740_DMA_DST_AUTOINC;
+	dma_config->mode = JZ4740_DMA_MODE_SINGLE;
+	i2s->pcm_config_capture.fifo_addr = i2s->phys_base + JZ_REG_AIC_FIFO;
+}
+
+static int __devinit jz4740_i2s_dev_probe(struct platform_device *pdev)
+{
+	struct jz4740_i2s *i2s;
+	int ret;
+
+	i2s = kzalloc(sizeof(*i2s), GFP_KERNEL);
+
+	if (!i2s)
+		return -ENOMEM;
+
+	i2s->mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+
+	if (!i2s->mem) {
+		ret = -ENOENT;
+		goto err_free;
+	}
+
+	i2s->mem = request_mem_region(i2s->mem->start, resource_size(i2s->mem),
+				pdev->name);
+
+	if (!i2s->mem) {
+		ret = -EBUSY;
+		goto err_free;
+	}
+
+	i2s->base = ioremap_nocache(i2s->mem->start, resource_size(i2s->mem));
+
+	if (!i2s->base) {
+		ret = -EBUSY;
+		goto err_release_mem_region;
+	}
+
+	i2s->phys_base = i2s->mem->start;
+
+	i2s->clk_aic = clk_get(&pdev->dev, "aic");
+	if (IS_ERR(i2s->clk_aic)) {
+		ret = PTR_ERR(i2s->clk_aic);
+		goto err_iounmap;
+	}
+
+	i2s->clk_i2s = clk_get(&pdev->dev, "i2s");
+	if (IS_ERR(i2s->clk_i2s)) {
+		ret = PTR_ERR(i2s->clk_i2s);
+		goto err_iounmap;
+	}
+
+	clk_enable(i2s->clk_aic);
+
+	jz4740_i2c_init_pcm_config(i2s);
+
+	jz4740_i2s_dai.private_data = i2s;
+	ret = snd_soc_register_dai(&jz4740_i2s_dai);
+
+	platform_set_drvdata(pdev, i2s);
+
+	return 0;
+
+err_iounmap:
+	iounmap(i2s->base);
+err_release_mem_region:
+	release_mem_region(i2s->mem->start, resource_size(i2s->mem));
+err_free:
+	kfree(i2s);
+
+	return ret;
+}
+
+static int __devexit jz4740_i2s_dev_remove(struct platform_device *pdev)
+{
+	struct jz4740_i2s *i2s = platform_get_drvdata(pdev);
+
+	snd_soc_unregister_dai(&jz4740_i2s_dai);
+
+	clk_disable(i2s->clk_aic);
+	clk_put(i2s->clk_i2s);
+	clk_put(i2s->clk_aic);
+
+	iounmap(i2s->base);
+	release_mem_region(i2s->mem->start, resource_size(i2s->mem));
+
+	platform_set_drvdata(pdev, NULL);
+	kfree(i2s);
+
+	return 0;
+}
+
+static struct platform_driver jz4740_i2s_driver = {
+	.probe = jz4740_i2s_dev_probe,
+	.remove = __devexit_p(jz4740_i2s_dev_remove),
+	.driver = {
+		.name = "jz4740-i2s",
+		.owner = THIS_MODULE,
+	},
+};
+
+static int __init jz4740_i2s_init(void)
+{
+	return platform_driver_register(&jz4740_i2s_driver);
+}
+module_init(jz4740_i2s_init);
+
+static void __exit jz4740_i2s_exit(void)
+{
+	platform_driver_unregister(&jz4740_i2s_driver);
+}
+module_exit(jz4740_i2s_exit);
+
+MODULE_AUTHOR("Lars-Peter Clausen, <lars@metafoo.de>");
+MODULE_DESCRIPTION("Ingenic JZ4740 SoC I2S driver");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:jz4740-i2s");
diff --git a/sound/soc/jz4740/jz4740-i2s.h b/sound/soc/jz4740/jz4740-i2s.h
new file mode 100644
index 0000000..da22ed8
--- /dev/null
+++ b/sound/soc/jz4740/jz4740-i2s.h
@@ -0,0 +1,18 @@
+/*
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#ifndef _JZ4740_I2S_H
+#define _JZ4740_I2S_H
+
+/* I2S clock source */
+#define JZ4740_I2S_CLKSRC_EXT 0
+#define JZ4740_I2S_CLKSRC_PLL 1
+
+#define JZ4740_I2S_BIT_CLK		0
+
+extern struct snd_soc_dai jz4740_i2s_dai;
+
+#endif
diff --git a/sound/soc/jz4740/jz4740-pcm.c b/sound/soc/jz4740/jz4740-pcm.c
new file mode 100644
index 0000000..fd1c203
--- /dev/null
+++ b/sound/soc/jz4740/jz4740-pcm.c
@@ -0,0 +1,350 @@
+/*
+ *  Copyright (C) 2010, Lars-Peter Clausen <lars@metafoo.de>
+ *
+ *  This program is free software; you can redistribute	 it and/or modify it
+ *  under  the terms of	 the GNU General  Public License as published by the
+ *  Free Software Foundation;  either version 2 of the	License, or (at your
+ *  option) any later version.
+ *
+ *  You should have received a copy of the  GNU General Public License along
+ *  with this program; if not, write  to the Free Software Foundation, Inc.,
+ *  675 Mass Ave, Cambridge, MA 02139, USA.
+ *
+ */
+
+#include <linux/init.h>
+#include <linux/interrupt.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/slab.h>
+
+#include <linux/dma-mapping.h>
+
+#include <sound/core.h>
+#include <sound/pcm.h>
+#include <sound/pcm_params.h>
+#include <sound/soc.h>
+
+#include <asm/mach-jz4740/dma.h>
+#include "jz4740-pcm.h"
+
+struct jz4740_runtime_data {
+	unsigned int dma_period;
+	dma_addr_t dma_start;
+	dma_addr_t dma_pos;
+	dma_addr_t dma_end;
+
+	struct jz4740_dma_chan *dma;
+
+	dma_addr_t fifo_addr;
+};
+
+/* identify hardware playback capabilities */
+static const struct snd_pcm_hardware jz4740_pcm_hardware = {
+	.info = SNDRV_PCM_INFO_MMAP |
+		SNDRV_PCM_INFO_MMAP_VALID |
+		SNDRV_PCM_INFO_INTERLEAVED |
+		SNDRV_PCM_INFO_BLOCK_TRANSFER,
+	.formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S8,
+
+	.rates			= SNDRV_PCM_RATE_8000_48000,
+	.channels_min		= 1,
+	.channels_max		= 2,
+	.period_bytes_min	= 16,
+	.period_bytes_max	= 2 * PAGE_SIZE,
+	.periods_min		= 2,
+	.periods_max		= 128,
+	.buffer_bytes_max	= 128 * 2 * PAGE_SIZE,
+	.fifo_size		= 32,
+};
+
+static void jz4740_pcm_start_transfer(struct jz4740_runtime_data *prtd, int stream)
+{
+	unsigned int count;
+
+	if (prtd->dma_pos + prtd->dma_period > prtd->dma_end)
+		count = prtd->dma_end - prtd->dma_pos;
+	else
+		count = prtd->dma_period;
+
+	jz4740_dma_disable(prtd->dma);
+
+	if (stream == SNDRV_PCM_STREAM_PLAYBACK) {
+		jz4740_dma_set_src_addr(prtd->dma, prtd->dma_pos);
+		jz4740_dma_set_dst_addr(prtd->dma, prtd->fifo_addr);
+	} else {
+		jz4740_dma_set_src_addr(prtd->dma, prtd->fifo_addr);
+		jz4740_dma_set_dst_addr(prtd->dma, prtd->dma_pos);
+	}
+
+	jz4740_dma_set_transfer_count(prtd->dma, count);
+
+	jz4740_dma_enable(prtd->dma);
+
+	prtd->dma_pos += prtd->dma_period;
+	if (prtd->dma_pos >= prtd->dma_end)
+		prtd->dma_pos = prtd->dma_start;
+}
+
+static void jz4740_pcm_dma_transfer_done(struct jz4740_dma_chan *dma, int err,
+	void *dev_id)
+{
+	struct snd_pcm_substream *substream = dev_id;
+	struct snd_pcm_runtime *runtime = substream->runtime;
+	struct jz4740_runtime_data *prtd = runtime->private_data;
+
+	snd_pcm_period_elapsed(substream);
+
+	jz4740_pcm_start_transfer(prtd, substream->stream);
+}
+
+static int jz4740_pcm_hw_params(struct snd_pcm_substream *substream,
+	struct snd_pcm_hw_params *params)
+{
+	struct snd_pcm_runtime *runtime = substream->runtime;
+	struct jz4740_runtime_data *prtd = runtime->private_data;
+	struct snd_soc_pcm_runtime *rtd = substream->private_data;
+	struct jz4740_pcm_config *config;
+
+	config = snd_soc_dai_get_dma_data(rtd->dai->cpu_dai, substream);
+	if (!prtd->dma) {
+		const char *dma_channel_name;
+		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+			dma_channel_name = "PCM Playback";
+		else
+			dma_channel_name = "PCM Capture";
+
+		prtd->dma = jz4740_dma_request(substream, dma_channel_name);
+	}
+
+	if (!prtd->dma)
+		return -EBUSY;
+
+	jz4740_dma_configure(prtd->dma, &config->dma_config);
+	prtd->fifo_addr = config->fifo_addr;
+
+	jz4740_dma_set_complete_cb(prtd->dma, jz4740_pcm_dma_transfer_done);
+
+	snd_pcm_set_runtime_buffer(substream, &substream->dma_buffer);
+	runtime->dma_bytes = params_buffer_bytes(params);
+
+	prtd->dma_period = params_period_bytes(params);
+	prtd->dma_start = runtime->dma_addr;
+	prtd->dma_pos = prtd->dma_start;
+	prtd->dma_end = prtd->dma_start + runtime->dma_bytes;
+
+	return 0;
+}
+
+static int jz4740_pcm_hw_free(struct snd_pcm_substream *substream)
+{
+	struct jz4740_runtime_data *prtd = substream->runtime->private_data;
+
+	snd_pcm_set_runtime_buffer(substream, NULL);
+	if (prtd->dma) {
+		jz4740_dma_free(prtd->dma);
+		prtd->dma = NULL;
+	}
+
+	return 0;
+}
+
+static int jz4740_pcm_prepare(struct snd_pcm_substream *substream)
+{
+	struct jz4740_runtime_data *prtd = substream->runtime->private_data;
+	int ret = 0;
+
+	if (!prtd->dma)
+			return 0;
+
+	prtd->dma_pos = prtd->dma_start;
+
+	return ret;
+}
+
+static int jz4740_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
+{
+	struct snd_pcm_runtime *runtime = substream->runtime;
+	struct jz4740_runtime_data *prtd = runtime->private_data;
+
+	int ret = 0;
+
+	switch (cmd) {
+	case SNDRV_PCM_TRIGGER_START:
+	case SNDRV_PCM_TRIGGER_RESUME:
+	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
+		jz4740_pcm_start_transfer(prtd, substream->stream);
+		break;
+	case SNDRV_PCM_TRIGGER_STOP:
+	case SNDRV_PCM_TRIGGER_SUSPEND:
+	case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
+		jz4740_dma_disable(prtd->dma);
+		break;
+	default:
+		ret = -EINVAL;
+	}
+
+	return ret;
+}
+
+static snd_pcm_uframes_t jz4740_pcm_pointer(struct snd_pcm_substream *substream)
+{
+	struct snd_pcm_runtime *runtime = substream->runtime;
+	struct jz4740_runtime_data *prtd = runtime->private_data;
+	unsigned long count, pos;
+	snd_pcm_uframes_t offset;
+	struct jz4740_dma_chan *dma = prtd->dma;
+
+	count = jz4740_dma_get_residue(dma);
+	if (prtd->dma_pos == prtd->dma_start)
+		pos = prtd->dma_end - prtd->dma_start - count;
+	else
+		pos = prtd->dma_pos - prtd->dma_start - count;
+
+	offset = bytes_to_frames(runtime, pos);
+	if (offset >= runtime->buffer_size)
+		offset = 0;
+
+	return offset;
+}
+
+static int jz4740_pcm_open(struct snd_pcm_substream *substream)
+{
+	struct snd_pcm_runtime *runtime = substream->runtime;
+	struct jz4740_runtime_data *prtd;
+
+	snd_soc_set_runtime_hwparams(substream, &jz4740_pcm_hardware);
+	prtd = kzalloc(sizeof(struct jz4740_runtime_data), GFP_KERNEL);
+
+	if (prtd == NULL)
+		return -ENOMEM;
+
+	runtime->private_data = prtd;
+	return 0;
+}
+
+static int jz4740_pcm_close(struct snd_pcm_substream *substream)
+{
+	struct snd_pcm_runtime *runtime = substream->runtime;
+	struct jz4740_runtime_data *prtd = runtime->private_data;
+
+	kfree(prtd);
+
+	return 0;
+}
+
+static int jz4740_pcm_mmap(struct snd_pcm_substream *substream,
+	struct vm_area_struct *vma)
+{
+	return remap_pfn_range(vma, vma->vm_start,
+			substream->dma_buffer.addr >> PAGE_SHIFT,
+			vma->vm_end - vma->vm_start, vma->vm_page_prot);
+}
+
+static struct snd_pcm_ops jz4740_pcm_ops = {
+	.open		= jz4740_pcm_open,
+	.close		= jz4740_pcm_close,
+	.ioctl		= snd_pcm_lib_ioctl,
+	.hw_params	= jz4740_pcm_hw_params,
+	.hw_free	= jz4740_pcm_hw_free,
+	.prepare	= jz4740_pcm_prepare,
+	.trigger	= jz4740_pcm_trigger,
+	.pointer	= jz4740_pcm_pointer,
+	.mmap		= jz4740_pcm_mmap,
+};
+
+static int jz4740_pcm_preallocate_dma_buffer(struct snd_pcm *pcm, int stream)
+{
+	struct snd_pcm_substream *substream = pcm->streams[stream].substream;
+	struct snd_dma_buffer *buf = &substream->dma_buffer;
+	size_t size = jz4740_pcm_hardware.buffer_bytes_max;
+
+	buf->dev.type = SNDRV_DMA_TYPE_DEV;
+	buf->dev.dev = pcm->card->dev;
+	buf->private_data = NULL;
+
+	buf->area = dma_alloc_noncoherent(pcm->card->dev, size,
+					  &buf->addr, GFP_KERNEL);
+	if (!buf->area)
+		return -ENOMEM;
+
+	buf->bytes = size;
+
+	return 0;
+}
+
+static void jz4740_pcm_free(struct snd_pcm *pcm)
+{
+	struct snd_pcm_substream *substream;
+	struct snd_dma_buffer *buf;
+	int stream;
+
+	for (stream = 0; stream < 2; stream++) {
+		substream = pcm->streams[stream].substream;
+		if (!substream)
+			continue;
+
+		buf = &substream->dma_buffer;
+		if (!buf->area)
+			continue;
+
+		dma_free_noncoherent(pcm->card->dev, buf->bytes,
+		  buf->area, buf->addr);
+		buf->area = NULL;
+	}
+}
+
+static u64 jz4740_pcm_dmamask = DMA_BIT_MASK(32);
+
+int jz4740_pcm_new(struct snd_card *card, struct snd_soc_dai *dai,
+	struct snd_pcm *pcm)
+{
+	int ret = 0;
+
+	if (!card->dev->dma_mask)
+		card->dev->dma_mask = &jz4740_pcm_dmamask;
+
+	if (!card->dev->coherent_dma_mask)
+		card->dev->coherent_dma_mask = DMA_BIT_MASK(32);
+
+	if (dai->playback.channels_min) {
+		ret = jz4740_pcm_preallocate_dma_buffer(pcm,
+			SNDRV_PCM_STREAM_PLAYBACK);
+		if (ret)
+			goto err;
+	}
+
+	if (dai->capture.channels_min) {
+		ret = jz4740_pcm_preallocate_dma_buffer(pcm,
+			SNDRV_PCM_STREAM_CAPTURE);
+		if (ret)
+			goto err;
+	}
+
+err:
+	return ret;
+}
+
+struct snd_soc_platform jz4740_soc_platform = {
+		.name		= "jz4740-pcm",
+		.pcm_ops	= &jz4740_pcm_ops,
+		.pcm_new	= jz4740_pcm_new,
+		.pcm_free	= jz4740_pcm_free,
+};
+EXPORT_SYMBOL_GPL(jz4740_soc_platform);
+
+static int __init jz4740_soc_platform_init(void)
+{
+	return snd_soc_register_platform(&jz4740_soc_platform);
+}
+module_init(jz4740_soc_platform_init);
+
+static void __exit jz4740_soc_platform_exit(void)
+{
+	snd_soc_unregister_platform(&jz4740_soc_platform);
+}
+module_exit(jz4740_soc_platform_exit);
+
+MODULE_AUTHOR("Lars-Peter Clausen <lars@metafoo.de>");
+MODULE_DESCRIPTION("Ingenic SoC JZ4740 PCM driver");
+MODULE_LICENSE("GPL");
diff --git a/sound/soc/jz4740/jz4740-pcm.h b/sound/soc/jz4740/jz4740-pcm.h
new file mode 100644
index 0000000..e3f221e
--- /dev/null
+++ b/sound/soc/jz4740/jz4740-pcm.h
@@ -0,0 +1,22 @@
+/*
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#ifndef _JZ4740_PCM_H
+#define _JZ4740_PCM_H
+
+#include <linux/dma-mapping.h>
+#include <asm/mach-jz4740/dma.h>
+
+/* platform data */
+extern struct snd_soc_platform jz4740_soc_platform;
+
+struct jz4740_pcm_config {
+	struct jz4740_dma_config dma_config;
+	phys_addr_t fifo_addr;
+};
+
+#endif
-- 
1.5.6.5

Re: [RFC][PATCH 21/26] alsa: ASoC: Add JZ4740 ASoC support

[Liam Girdwood]

On Wed, 2010-06-02 at 21:12 +0200, Lars-Peter Clausen wrote:
> This patch adds ASoC support for JZ4740 SoCs I2S module.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: Liam Girdwood <lrg@slimlogic.co.uk>
> Cc: alsa-devel@alsa-project.org
> ---
>  sound/soc/Kconfig             |    1 +
>  sound/soc/Makefile            |    1 +
>  sound/soc/jz4740/Kconfig      |   13 +
>  sound/soc/jz4740/Makefile     |    9 +
>  sound/soc/jz4740/jz4740-i2s.c |  568 +++++++++++++++++++++++++++++++++++++++++
>  sound/soc/jz4740/jz4740-i2s.h |   18 ++
>  sound/soc/jz4740/jz4740-pcm.c |  350 +++++++++++++++++++++++++
>  sound/soc/jz4740/jz4740-pcm.h |   22 ++
>  8 files changed, 982 insertions(+), 0 deletions(-)
>  create mode 100644 sound/soc/jz4740/Kconfig
>  create mode 100644 sound/soc/jz4740/Makefile
>  create mode 100644 sound/soc/jz4740/jz4740-i2s.c
>  create mode 100644 sound/soc/jz4740/jz4740-i2s.h
>  create mode 100644 sound/soc/jz4740/jz4740-pcm.c
>  create mode 100644 sound/soc/jz4740/jz4740-pcm.h
> 
> diff --git a/sound/soc/Kconfig b/sound/soc/Kconfig
> index b1749bc..5a7a724 100644
> --- a/sound/soc/Kconfig
> +++ b/sound/soc/Kconfig
> @@ -36,6 +36,7 @@ source "sound/soc/s3c24xx/Kconfig"
>  source "sound/soc/s6000/Kconfig"
>  source "sound/soc/sh/Kconfig"
>  source "sound/soc/txx9/Kconfig"
> +source "sound/soc/jz4740/Kconfig"
>  
>  # Supported codecs
>  source "sound/soc/codecs/Kconfig"
> diff --git a/sound/soc/Makefile b/sound/soc/Makefile
> index 1470141..fdbe74d 100644
> --- a/sound/soc/Makefile
> +++ b/sound/soc/Makefile
> @@ -14,3 +14,4 @@ obj-$(CONFIG_SND_SOC)	+= s3c24xx/
>  obj-$(CONFIG_SND_SOC)	+= s6000/
>  obj-$(CONFIG_SND_SOC)	+= sh/
>  obj-$(CONFIG_SND_SOC)	+= txx9/
> +obj-$(CONFIG_SND_SOC)	+= jz4740/
> diff --git a/sound/soc/jz4740/Kconfig b/sound/soc/jz4740/Kconfig
> new file mode 100644
> index 0000000..39df949
> --- /dev/null
> +++ b/sound/soc/jz4740/Kconfig
> @@ -0,0 +1,13 @@
> +config SND_JZ4740_SOC
> +	tristate "SoC Audio for Ingenic JZ4740 SoC"
> +	depends on SOC_JZ4740 && SND_SOC
> +	help
> +	  Say Y or M if you want to add support for codecs attached to
> +	  the Jz4740 AC97, I2S or SSP interface. You will also need

Do you have an AC97 or SSP interface ?

> +	  to select the audio interfaces to support below.
> +
> +config SND_JZ4740_SOC_I2S
> +	depends on SND_JZ4740_SOC
> +	tristate "SoC Audio (I2S protocol) for Ingenic jz4740 chip"
> +	help
> +	  Say Y if you want to use I2S protocol and I2S codec on Ingenic Jz4740 QI_LB60 board.
> diff --git a/sound/soc/jz4740/Makefile b/sound/soc/jz4740/Makefile
> new file mode 100644
> index 0000000..1be8d19
> --- /dev/null
> +++ b/sound/soc/jz4740/Makefile
> @@ -0,0 +1,9 @@
> +#
> +# Jz4740 Platform Support
> +#
> +snd-soc-jz4740-objs := jz4740-pcm.o
> +snd-soc-jz4740-i2s-objs := jz4740-i2s.o
> +
> +obj-$(CONFIG_SND_JZ4740_SOC) += snd-soc-jz4740.o
> +obj-$(CONFIG_SND_JZ4740_SOC_I2S) += snd-soc-jz4740-i2s.o
> +
> diff --git a/sound/soc/jz4740/jz4740-i2s.c b/sound/soc/jz4740/jz4740-i2s.c
> new file mode 100644
> index 0000000..2b139fd
> --- /dev/null
> +++ b/sound/soc/jz4740/jz4740-i2s.c
> @@ -0,0 +1,568 @@
> +/*
> + *  Copyright (C) 2010, Lars-Peter Clausen <lars@metafoo.de>
> + *
> + *  This program is free software; you can redistribute	 it and/or modify it
> + *  under  the terms of	 the GNU General  Public License as published by the
> + *  Free Software Foundation;  either version 2 of the	License, or (at your
> + *  option) any later version.
> + *

Formatting looks broken here.

> + *  You should have received a copy of the  GNU General Public License along
> + *  with this program; if not, write  to the Free Software Foundation, Inc.,
> + *  675 Mass Ave, Cambridge, MA 02139, USA.
> + *
> + */
> +
> +#include <linux/init.h>
> +#include <linux/io.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/platform_device.h>
> +#include <linux/slab.h>
> +
> +#include <linux/clk.h>
> +#include <linux/delay.h>
> +
> +#include <linux/dma-mapping.h>
> +
> +#include <sound/core.h>
> +#include <sound/pcm.h>
> +#include <sound/pcm_params.h>
> +#include <sound/soc.h>
> +#include <sound/soc-dapm.h>
> +#include <sound/initval.h>
> +
> +#include "jz4740-i2s.h"
> +#include "jz4740-pcm.h"
> +
> +#define JZ_REG_AIC_CONF		0x00
> +#define JZ_REG_AIC_CTRL		0x04
> +#define JZ_REG_AIC_I2S_FMT	0x10
> +#define JZ_REG_AIC_FIFO_STATUS	0x14
> +#define JZ_REG_AIC_I2S_STATUS	0x1c
> +#define JZ_REG_AIC_CLK_DIV	0x30
> +#define JZ_REG_AIC_FIFO		0x34
> +
> +#define JZ_AIC_CONF_FIFO_RX_THRESHOLD_MASK (0xf << 12)
> +#define JZ_AIC_CONF_FIFO_TX_THRESHOLD_MASK (0xf <<  8)
> +#define JZ_AIC_CONF_OVERFLOW_PLAY_LAST BIT(6)
> +#define JZ_AIC_CONF_INTERNAL_CODEC BIT(5)
> +#define JZ_AIC_CONF_I2S BIT(4)
> +#define JZ_AIC_CONF_RESET BIT(3)
> +#define JZ_AIC_CONF_BIT_CLK_MASTER BIT(2)
> +#define JZ_AIC_CONF_SYNC_CLK_MASTER BIT(1)
> +#define JZ_AIC_CONF_ENABLE BIT(0)
> +
> +#define JZ_AIC_CONF_FIFO_RX_THRESHOLD_OFFSET 12
> +#define JZ_AIC_CONF_FIFO_TX_THRESHOLD_OFFSET 8
> +
> +#define JZ_AIC_CTRL_OUTPUT_SAMPLE_SIZE_MASK (0x7 << 19)
> +#define JZ_AIC_CTRL_INPUT_SAMPLE_SIZE_MASK (0x7 << 16)
> +#define JZ_AIC_CTRL_ENABLE_RX_DMA BIT(15)
> +#define JZ_AIC_CTRL_ENABLE_TX_DMA BIT(14)
> +#define JZ_AIC_CTRL_MONO_TO_STEREO BIT(11)
> +#define JZ_AIC_CTRL_SWITCH_ENDIANNESS BIT(10)
> +#define JZ_AIC_CTRL_SIGNED_TO_UNSIGNED BIT(9)
> +#define JZ_AIC_CTRL_FLUSH		BIT(8)
> +#define JZ_AIC_CTRL_ENABLE_ROR_INT BIT(6)
> +#define JZ_AIC_CTRL_ENABLE_TUR_INT BIT(5)
> +#define JZ_AIC_CTRL_ENABLE_RFS_INT BIT(4)
> +#define JZ_AIC_CTRL_ENABLE_TFS_INT BIT(3)
> +#define JZ_AIC_CTRL_ENABLE_LOOPBACK BIT(2)
> +#define JZ_AIC_CTRL_ENABLE_PLAYBACK BIT(1)
> +#define JZ_AIC_CTRL_ENABLE_CAPTURE BIT(0)
> +
> +#define JZ_AIC_CTRL_OUTPUT_SAMPLE_SIZE_OFFSET 19
> +#define JZ_AIC_CTRL_INPUT_SAMPLE_SIZE_OFFSET  16
> +
> +#define JZ_AIC_I2S_FMT_DISABLE_BIT_CLK BIT(12)
> +#define JZ_AIC_I2S_FMT_ENABLE_SYS_CLK BIT(4)
> +#define JZ_AIC_I2S_FMT_MSB BIT(0)
> +
> +#define JZ_AIC_I2S_STATUS_BUSY BIT(2)
> +
> +#define JZ_AIC_CLK_DIV_MASK 0xf
> +
> +struct jz4740_i2s {
> +	struct resource *mem;
> +	void __iomem *base;
> +	dma_addr_t phys_base;
> +
> +	struct clk *clk_aic;
> +	struct clk *clk_i2s;
> +
> +	struct jz4740_pcm_config pcm_config_playback;
> +	struct jz4740_pcm_config pcm_config_capture;
> +};
> +
> +static inline uint32_t jz4740_i2s_read(const struct jz4740_i2s *i2s,
> +	unsigned int reg)
> +{
> +	return readl(i2s->base + reg);
> +}
> +
> +static inline void jz4740_i2s_write(const struct jz4740_i2s *i2s,
> +	unsigned int reg, uint32_t value)
> +{
> +	writel(value, i2s->base + reg);
> +}
> +
> +static inline struct jz4740_i2s *jz4740_dai_to_i2s(struct snd_soc_dai *dai)
> +{
> +	return dai->private_data;
> +}
> +
> +static int jz4740_i2s_startup(struct snd_pcm_substream *substream,
> +	struct snd_soc_dai *dai)
> +{
> +	struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
> +	uint32_t conf, ctrl;
> +
> +	if (dai->active)
> +		return 0;
> +
> +
> +	ctrl = jz4740_i2s_read(i2s, JZ_REG_AIC_CTRL);
> +	ctrl |= JZ_AIC_CTRL_FLUSH;
> +	jz4740_i2s_write(i2s, JZ_REG_AIC_CTRL, ctrl);
> +
> +	clk_enable(i2s->clk_i2s);
> +
> +	conf = jz4740_i2s_read(i2s, JZ_REG_AIC_CONF);
> +	conf |= JZ_AIC_CONF_ENABLE;
> +	jz4740_i2s_write(i2s, JZ_REG_AIC_CONF, conf);
> +
> +	return 0;
> +}
> +
> +static void jz4740_i2s_shutdown(struct snd_pcm_substream *substream,
> +	struct snd_soc_dai *dai)
> +{
> +	struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
> +	uint32_t conf;
> +
> +	if (!dai->active)
> +		return;
> +
> +	conf = jz4740_i2s_read(i2s, JZ_REG_AIC_CONF);
> +	conf &= ~JZ_AIC_CONF_ENABLE;
> +	jz4740_i2s_write(i2s, JZ_REG_AIC_CONF, conf);
> +
> +	clk_disable(i2s->clk_i2s);
> +}
> +
> +
> +static int jz4740_i2s_trigger(struct snd_pcm_substream *substream, int cmd,
> +	struct snd_soc_dai *dai)
> +{
> +	struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
> +	bool playback = (substream->stream == SNDRV_PCM_STREAM_PLAYBACK);
> +
> +	uint32_t ctrl;
> +	uint32_t mask;
> +
> +	if (playback)

It's best to use (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) here.

> +		mask = JZ_AIC_CTRL_ENABLE_PLAYBACK | JZ_AIC_CTRL_ENABLE_TX_DMA;
> +	else
> +		mask = JZ_AIC_CTRL_ENABLE_CAPTURE | JZ_AIC_CTRL_ENABLE_RX_DMA;
> +
> +	ctrl = jz4740_i2s_read(i2s, JZ_REG_AIC_CTRL);
> +
> +	switch (cmd) {
> +	case SNDRV_PCM_TRIGGER_START:
> +	case SNDRV_PCM_TRIGGER_RESUME:
> +	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
> +		ctrl |= mask;
> +		break;
> +	case SNDRV_PCM_TRIGGER_STOP:
> +	case SNDRV_PCM_TRIGGER_SUSPEND:
> +	case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
> +		ctrl &= ~mask;
> +		break;
> +	default:
> +		return -EINVAL;
> +	}
> +
> +	jz4740_i2s_write(i2s, JZ_REG_AIC_CTRL, ctrl);
> +
> +	return 0;
> +}
> +
> +
> +static int jz4740_i2s_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
> +{
> +	struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
> +

No new line is required here.

> +	uint32_t format = 0;
> +	uint32_t conf;
> +
> +	conf = jz4740_i2s_read(i2s, JZ_REG_AIC_CONF);
> +
> +	conf &= ~(JZ_AIC_CONF_BIT_CLK_MASTER | JZ_AIC_CONF_SYNC_CLK_MASTER);
> +
> +	switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
> +	case SND_SOC_DAIFMT_CBS_CFS:
> +		conf |= JZ_AIC_CONF_BIT_CLK_MASTER | JZ_AIC_CONF_SYNC_CLK_MASTER;
> +		format |= JZ_AIC_I2S_FMT_ENABLE_SYS_CLK;
> +		break;
> +	case SND_SOC_DAIFMT_CBM_CFS:
> +		conf |= JZ_AIC_CONF_SYNC_CLK_MASTER;
> +		break;
> +	case SND_SOC_DAIFMT_CBS_CFM:
> +		conf |= JZ_AIC_CONF_BIT_CLK_MASTER;
> +		break;
> +	case SND_SOC_DAIFMT_CBM_CFM:
> +		break;
> +	default:
> +		return -EINVAL;
> +	}
> +
> +	switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
> +	case SND_SOC_DAIFMT_MSB:
> +		format |= JZ_AIC_I2S_FMT_MSB;
> +		break;
> +	case SND_SOC_DAIFMT_I2S:
> +		break;
> +	default:
> +		return -EINVAL;
> +	}
> +
> +	switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
> +	case SND_SOC_DAIFMT_NB_NF:
> +		break;
> +	default:
> +		return -EINVAL;
> +	}
> +
> +	jz4740_i2s_write(i2s, JZ_REG_AIC_CONF, conf);
> +	jz4740_i2s_write(i2s, JZ_REG_AIC_I2S_FMT, format);
> +
> +	return 0;
> +}
> +
> +static int jz4740_i2s_hw_params(struct snd_pcm_substream *substream,
> +	struct snd_pcm_hw_params *params, struct snd_soc_dai *dai)
> +{
> +	struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
> +	bool playback = (substream->stream == SNDRV_PCM_STREAM_PLAYBACK);
> +	enum jz4740_dma_width dma_width;
> +	struct jz4740_pcm_config *pcm_config;
> +	unsigned int sample_size;
> +	uint32_t ctrl;
> +
> +	ctrl = jz4740_i2s_read(i2s, JZ_REG_AIC_CTRL);
> +
> +	switch (params_format(params)) {
> +	case SNDRV_PCM_FORMAT_S8:
> +		sample_size = 0;
> +		dma_width = JZ4740_DMA_WIDTH_8BIT;
> +		break;
> +	case SNDRV_PCM_FORMAT_S16:
> +		sample_size = 1;
> +		dma_width = JZ4740_DMA_WIDTH_16BIT;
> +		break;
> +	default:
> +		return -EINVAL;
> +	}
> +
> +	if (playback) {

Same here re substream->stream

> +		ctrl &= ~JZ_AIC_CTRL_OUTPUT_SAMPLE_SIZE_MASK;
> +		ctrl |= sample_size << JZ_AIC_CTRL_OUTPUT_SAMPLE_SIZE_OFFSET;
> +	} else {
> +		ctrl &= ~JZ_AIC_CTRL_INPUT_SAMPLE_SIZE_MASK;
> +		ctrl |= sample_size << JZ_AIC_CTRL_INPUT_SAMPLE_SIZE_OFFSET;
> +	}
> +
> +	switch (params_channels(params)) {
> +	case 2:
> +		break;
> +	case 1:
> +		if (playback) {
> +			ctrl |= JZ_AIC_CTRL_MONO_TO_STEREO;
> +			break;
> +		}
> +	default: /* Falltrough */
> +		return -EINVAL;
> +	}
> +
> +	jz4740_i2s_write(i2s, JZ_REG_AIC_CTRL, ctrl);
> +
> +	if (playback) {

ditto
> +		pcm_config = &i2s->pcm_config_playback;
> +		pcm_config->dma_config.dst_width = dma_width;
> +	} else {
> +		pcm_config = &i2s->pcm_config_capture;
> +		pcm_config->dma_config.src_width = dma_width;
> +	}
> +
> +
> +	snd_soc_dai_set_dma_data(dai, substream, pcm_config);
> +
> +	return 0;
> +}
> +
> +static int jz4740_i2s_set_clkdiv(struct snd_soc_dai *dai, int div_id, int div)
> +{
> +	struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
> +
> +	switch (div_id) {
> +	case JZ4740_I2S_BIT_CLK:
> +		if (div & 1 || div > 16)
> +			return -EINVAL;
> +		jz4740_i2s_write(i2s, JZ_REG_AIC_CLK_DIV, div - 1);
> +		break;
> +	default:
> +		return -EINVAL;
> +	}
> +
> +	return 0;
> +}
> +
> +static int jz4740_i2s_set_sysclk(struct snd_soc_dai *dai, int clk_id,
> +	unsigned int freq, int dir)
> +{
> +	struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
> +	int ret = 0;
> +	struct clk *parent;
> +
> +	switch (clk_id) {
> +	case JZ4740_I2S_CLKSRC_EXT:
> +		parent = clk_get(NULL, "ext");
> +		clk_set_parent(i2s->clk_i2s, parent);
> +		break;
> +	case JZ4740_I2S_CLKSRC_PLL:
> +		parent = clk_get(NULL, "pll half");
> +		clk_set_parent(i2s->clk_i2s, parent);
> +		ret = clk_set_rate(i2s->clk_i2s, freq);
> +		break;
> +	default:
> +		return -EINVAL;
> +	}
> +	clk_put(parent);
> +
> +	return ret;
> +}
> +
> +static int jz4740_i2s_suspend(struct snd_soc_dai *dai)
> +{
> +	struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
> +	uint32_t conf;
> +
> +	if (dai->active) {
> +		conf = jz4740_i2s_read(i2s, JZ_REG_AIC_CONF);
> +		conf &= ~JZ_AIC_CONF_ENABLE;
> +		jz4740_i2s_write(i2s, JZ_REG_AIC_CONF, conf);
> +
> +		clk_disable(i2s->clk_i2s);
> +	}
> +
> +	clk_disable(i2s->clk_aic);
> +
> +	return 0;
> +}
> +
> +static int jz4740_i2s_resume(struct snd_soc_dai *dai)
> +{
> +	struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
> +	uint32_t conf;
> +
> +	clk_enable(i2s->clk_aic);
> +
> +	if (dai->active) {
> +		clk_enable(i2s->clk_i2s);
> +
> +		conf = jz4740_i2s_read(i2s, JZ_REG_AIC_CONF);
> +		conf |= JZ_AIC_CONF_ENABLE;
> +		jz4740_i2s_write(i2s, JZ_REG_AIC_CONF, conf);
> +
> +	}
> +
> +	return 0;
> +}
> +
> +static int jz4740_i2s_probe(struct platform_device *pdev, struct snd_soc_dai *dai)
> +{
> +	struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
> +	uint32_t conf;
> +
> +	conf = (7 << JZ_AIC_CONF_FIFO_RX_THRESHOLD_OFFSET) |
> +		(8 << JZ_AIC_CONF_FIFO_TX_THRESHOLD_OFFSET) |
> +		JZ_AIC_CONF_OVERFLOW_PLAY_LAST |
> +		JZ_AIC_CONF_I2S |
> +		JZ_AIC_CONF_INTERNAL_CODEC;
> +
> +	jz4740_i2s_write(i2s, JZ_REG_AIC_CONF, JZ_AIC_CONF_RESET);
> +	jz4740_i2s_write(i2s, JZ_REG_AIC_CONF, conf);
> +
> +	return 0;
> +}
> +
> +
> +static struct snd_soc_dai_ops jz4740_i2s_dai_ops = {
> +	.startup = jz4740_i2s_startup,
> +	.shutdown = jz4740_i2s_shutdown,
> +	.trigger = jz4740_i2s_trigger,
> +	.hw_params = jz4740_i2s_hw_params,
> +	.set_fmt = jz4740_i2s_set_fmt,
> +	.set_clkdiv = jz4740_i2s_set_clkdiv,
> +	.set_sysclk = jz4740_i2s_set_sysclk,
> +};
> +
> +#define JZ4740_I2S_FMTS (SNDRV_PCM_FMTBIT_S8 | \
> +		SNDRV_PCM_FMTBIT_S16_LE)
> +
> +struct snd_soc_dai jz4740_i2s_dai = {
> +	.name = "jz4740-i2s",
> +	.probe = jz4740_i2s_probe,
> +	.playback = {
> +		.channels_min = 1,
> +		.channels_max = 2,
> +		.rates = SNDRV_PCM_RATE_8000_48000,
> +		.formats = JZ4740_I2S_FMTS,
> +	},
> +	.capture = {
> +		.channels_min = 2,
> +		.channels_max = 2,
> +		.rates = SNDRV_PCM_RATE_8000_48000,
> +		.formats = JZ4740_I2S_FMTS,
> +	},
> +	.symmetric_rates = 1,
> +	.ops = &jz4740_i2s_dai_ops,
> +	.suspend = jz4740_i2s_suspend,
> +	.resume = jz4740_i2s_resume,
> +};
> +EXPORT_SYMBOL_GPL(jz4740_i2s_dai);
> +
> +static void __devinit jz4740_i2c_init_pcm_config(struct jz4740_i2s *i2s)
> +{
> +	struct jz4740_dma_config *dma_config;
> +
> +	/* Playback */
> +	dma_config = &i2s->pcm_config_playback.dma_config;
> +	dma_config->src_width = JZ4740_DMA_WIDTH_32BIT,
> +	dma_config->transfer_size = JZ4740_DMA_TRANSFER_SIZE_16BYTE;
> +	dma_config->request_type = JZ4740_DMA_TYPE_AIC_TRANSMIT;
> +	dma_config->flags = JZ4740_DMA_SRC_AUTOINC;
> +	dma_config->mode = JZ4740_DMA_MODE_SINGLE;
> +	i2s->pcm_config_playback.fifo_addr = i2s->phys_base + JZ_REG_AIC_FIFO;
> +
> +	/* Capture */
> +	dma_config = &i2s->pcm_config_capture.dma_config;
> +	dma_config->dst_width = JZ4740_DMA_WIDTH_32BIT,
> +	dma_config->transfer_size = JZ4740_DMA_TRANSFER_SIZE_16BYTE;
> +	dma_config->request_type = JZ4740_DMA_TYPE_AIC_RECEIVE;
> +	dma_config->flags = JZ4740_DMA_DST_AUTOINC;
> +	dma_config->mode = JZ4740_DMA_MODE_SINGLE;
> +	i2s->pcm_config_capture.fifo_addr = i2s->phys_base + JZ_REG_AIC_FIFO;
> +}
> +
> +static int __devinit jz4740_i2s_dev_probe(struct platform_device *pdev)
> +{
> +	struct jz4740_i2s *i2s;
> +	int ret;
> +
> +	i2s = kzalloc(sizeof(*i2s), GFP_KERNEL);
> +
> +	if (!i2s)
> +		return -ENOMEM;
> +
> +	i2s->mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +

Why the new lines here

> +	if (!i2s->mem) {
> +		ret = -ENOENT;
> +		goto err_free;
> +	}
> +
> +	i2s->mem = request_mem_region(i2s->mem->start, resource_size(i2s->mem),
> +				pdev->name);
> +

and here

> +	if (!i2s->mem) {
> +		ret = -EBUSY;
> +		goto err_free;
> +	}
> +
> +	i2s->base = ioremap_nocache(i2s->mem->start, resource_size(i2s->mem));
> +

ditto

> +	if (!i2s->base) {
> +		ret = -EBUSY;
> +		goto err_release_mem_region;
> +	}
> +
> +	i2s->phys_base = i2s->mem->start;
> +
> +	i2s->clk_aic = clk_get(&pdev->dev, "aic");
> +	if (IS_ERR(i2s->clk_aic)) {
> +		ret = PTR_ERR(i2s->clk_aic);
> +		goto err_iounmap;
> +	}
> +
> +	i2s->clk_i2s = clk_get(&pdev->dev, "i2s");
> +	if (IS_ERR(i2s->clk_i2s)) {
> +		ret = PTR_ERR(i2s->clk_i2s);
> +		goto err_iounmap;
> +	}
> +
> +	clk_enable(i2s->clk_aic);
> +
> +	jz4740_i2c_init_pcm_config(i2s);
> +
> +	jz4740_i2s_dai.private_data = i2s;
> +	ret = snd_soc_register_dai(&jz4740_i2s_dai);
> +
> +	platform_set_drvdata(pdev, i2s);
> +
> +	return 0;
> +
> +err_iounmap:
> +	iounmap(i2s->base);
> +err_release_mem_region:
> +	release_mem_region(i2s->mem->start, resource_size(i2s->mem));
> +err_free:
> +	kfree(i2s);
> +
> +	return ret;
> +}
> +
> +static int __devexit jz4740_i2s_dev_remove(struct platform_device *pdev)
> +{
> +	struct jz4740_i2s *i2s = platform_get_drvdata(pdev);
> +
> +	snd_soc_unregister_dai(&jz4740_i2s_dai);
> +
> +	clk_disable(i2s->clk_aic);
> +	clk_put(i2s->clk_i2s);
> +	clk_put(i2s->clk_aic);
> +
> +	iounmap(i2s->base);
> +	release_mem_region(i2s->mem->start, resource_size(i2s->mem));
> +
> +	platform_set_drvdata(pdev, NULL);
> +	kfree(i2s);
> +
> +	return 0;
> +}
> +
> +static struct platform_driver jz4740_i2s_driver = {
> +	.probe = jz4740_i2s_dev_probe,
> +	.remove = __devexit_p(jz4740_i2s_dev_remove),
> +	.driver = {
> +		.name = "jz4740-i2s",
> +		.owner = THIS_MODULE,
> +	},
> +};
> +
> +static int __init jz4740_i2s_init(void)
> +{
> +	return platform_driver_register(&jz4740_i2s_driver);
> +}
> +module_init(jz4740_i2s_init);
> +
> +static void __exit jz4740_i2s_exit(void)
> +{
> +	platform_driver_unregister(&jz4740_i2s_driver);
> +}
> +module_exit(jz4740_i2s_exit);
> +
> +MODULE_AUTHOR("Lars-Peter Clausen, <lars@metafoo.de>");
> +MODULE_DESCRIPTION("Ingenic JZ4740 SoC I2S driver");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:jz4740-i2s");
> diff --git a/sound/soc/jz4740/jz4740-i2s.h b/sound/soc/jz4740/jz4740-i2s.h
> new file mode 100644
> index 0000000..da22ed8
> --- /dev/null
> +++ b/sound/soc/jz4740/jz4740-i2s.h
> @@ -0,0 +1,18 @@
> +/*
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#ifndef _JZ4740_I2S_H
> +#define _JZ4740_I2S_H
> +
> +/* I2S clock source */
> +#define JZ4740_I2S_CLKSRC_EXT 0
> +#define JZ4740_I2S_CLKSRC_PLL 1
> +
> +#define JZ4740_I2S_BIT_CLK		0
> +
> +extern struct snd_soc_dai jz4740_i2s_dai;
> +
> +#endif
> diff --git a/sound/soc/jz4740/jz4740-pcm.c b/sound/soc/jz4740/jz4740-pcm.c
> new file mode 100644
> index 0000000..fd1c203
> --- /dev/null
> +++ b/sound/soc/jz4740/jz4740-pcm.c
> @@ -0,0 +1,350 @@
> +/*
> + *  Copyright (C) 2010, Lars-Peter Clausen <lars@metafoo.de>
> + *
> + *  This program is free software; you can redistribute	 it and/or modify it
> + *  under  the terms of	 the GNU General  Public License as published by the
> + *  Free Software Foundation;  either version 2 of the	License, or (at your
> + *  option) any later version.
> + *
> + *  You should have received a copy of the  GNU General Public License along
> + *  with this program; if not, write  to the Free Software Foundation, Inc.,
> + *  675 Mass Ave, Cambridge, MA 02139, USA.
> + *
> + */
> +
> +#include <linux/init.h>
> +#include <linux/interrupt.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/slab.h>
> +
> +#include <linux/dma-mapping.h>
> +
> +#include <sound/core.h>
> +#include <sound/pcm.h>
> +#include <sound/pcm_params.h>
> +#include <sound/soc.h>
> +
> +#include <asm/mach-jz4740/dma.h>
> +#include "jz4740-pcm.h"
> +
> +struct jz4740_runtime_data {
> +	unsigned int dma_period;
> +	dma_addr_t dma_start;
> +	dma_addr_t dma_pos;
> +	dma_addr_t dma_end;
> +
> +	struct jz4740_dma_chan *dma;
> +
> +	dma_addr_t fifo_addr;
> +};
> +
> +/* identify hardware playback capabilities */
> +static const struct snd_pcm_hardware jz4740_pcm_hardware = {
> +	.info = SNDRV_PCM_INFO_MMAP |
> +		SNDRV_PCM_INFO_MMAP_VALID |
> +		SNDRV_PCM_INFO_INTERLEAVED |
> +		SNDRV_PCM_INFO_BLOCK_TRANSFER,
> +	.formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S8,
> +
> +	.rates			= SNDRV_PCM_RATE_8000_48000,
> +	.channels_min		= 1,
> +	.channels_max		= 2,
> +	.period_bytes_min	= 16,
> +	.period_bytes_max	= 2 * PAGE_SIZE,
> +	.periods_min		= 2,
> +	.periods_max		= 128,
> +	.buffer_bytes_max	= 128 * 2 * PAGE_SIZE,
> +	.fifo_size		= 32,
> +};
> +
> +static void jz4740_pcm_start_transfer(struct jz4740_runtime_data *prtd, int stream)
> +{
> +	unsigned int count;
> +
> +	if (prtd->dma_pos + prtd->dma_period > prtd->dma_end)
> +		count = prtd->dma_end - prtd->dma_pos;
> +	else
> +		count = prtd->dma_period;
> +
> +	jz4740_dma_disable(prtd->dma);
> +
> +	if (stream == SNDRV_PCM_STREAM_PLAYBACK) {
> +		jz4740_dma_set_src_addr(prtd->dma, prtd->dma_pos);
> +		jz4740_dma_set_dst_addr(prtd->dma, prtd->fifo_addr);
> +	} else {
> +		jz4740_dma_set_src_addr(prtd->dma, prtd->fifo_addr);
> +		jz4740_dma_set_dst_addr(prtd->dma, prtd->dma_pos);
> +	}
> +
> +	jz4740_dma_set_transfer_count(prtd->dma, count);
> +
> +	jz4740_dma_enable(prtd->dma);
> +
> +	prtd->dma_pos += prtd->dma_period;
> +	if (prtd->dma_pos >= prtd->dma_end)
> +		prtd->dma_pos = prtd->dma_start;
> +}
> +
> +static void jz4740_pcm_dma_transfer_done(struct jz4740_dma_chan *dma, int err,
> +	void *dev_id)
> +{
> +	struct snd_pcm_substream *substream = dev_id;
> +	struct snd_pcm_runtime *runtime = substream->runtime;
> +	struct jz4740_runtime_data *prtd = runtime->private_data;
> +
> +	snd_pcm_period_elapsed(substream);
> +
> +	jz4740_pcm_start_transfer(prtd, substream->stream);
> +}
> +
> +static int jz4740_pcm_hw_params(struct snd_pcm_substream *substream,
> +	struct snd_pcm_hw_params *params)
> +{
> +	struct snd_pcm_runtime *runtime = substream->runtime;
> +	struct jz4740_runtime_data *prtd = runtime->private_data;
> +	struct snd_soc_pcm_runtime *rtd = substream->private_data;
> +	struct jz4740_pcm_config *config;
> +
> +	config = snd_soc_dai_get_dma_data(rtd->dai->cpu_dai, substream);
> +	if (!prtd->dma) {
> +		const char *dma_channel_name;
> +		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
> +			dma_channel_name = "PCM Playback";
> +		else
> +			dma_channel_name = "PCM Capture";
> +
> +		prtd->dma = jz4740_dma_request(substream, dma_channel_name);

dma_channel_name variable is not required here. Just use the const char
* directly.

> +	}
> +
> +	if (!prtd->dma)
> +		return -EBUSY;
> +
> +	jz4740_dma_configure(prtd->dma, &config->dma_config);
> +	prtd->fifo_addr = config->fifo_addr;
> +
> +	jz4740_dma_set_complete_cb(prtd->dma, jz4740_pcm_dma_transfer_done);
> +
> +	snd_pcm_set_runtime_buffer(substream, &substream->dma_buffer);
> +	runtime->dma_bytes = params_buffer_bytes(params);
> +
> +	prtd->dma_period = params_period_bytes(params);
> +	prtd->dma_start = runtime->dma_addr;
> +	prtd->dma_pos = prtd->dma_start;
> +	prtd->dma_end = prtd->dma_start + runtime->dma_bytes;
> +
> +	return 0;
> +}
> +
> +static int jz4740_pcm_hw_free(struct snd_pcm_substream *substream)
> +{
> +	struct jz4740_runtime_data *prtd = substream->runtime->private_data;
> +
> +	snd_pcm_set_runtime_buffer(substream, NULL);
> +	if (prtd->dma) {
> +		jz4740_dma_free(prtd->dma);
> +		prtd->dma = NULL;
> +	}
> +
> +	return 0;
> +}
> +
> +static int jz4740_pcm_prepare(struct snd_pcm_substream *substream)
> +{
> +	struct jz4740_runtime_data *prtd = substream->runtime->private_data;
> +	int ret = 0;
> +
> +	if (!prtd->dma)
> +			return 0;
> +
> +	prtd->dma_pos = prtd->dma_start;
> +
> +	return ret;
> +}
> +
> +static int jz4740_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
> +{
> +	struct snd_pcm_runtime *runtime = substream->runtime;
> +	struct jz4740_runtime_data *prtd = runtime->private_data;
> +
No new line.

> +	int ret = 0;
> +
> +	switch (cmd) {
> +	case SNDRV_PCM_TRIGGER_START:
> +	case SNDRV_PCM_TRIGGER_RESUME:
> +	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
> +		jz4740_pcm_start_transfer(prtd, substream->stream);
> +		break;
> +	case SNDRV_PCM_TRIGGER_STOP:
> +	case SNDRV_PCM_TRIGGER_SUSPEND:
> +	case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
> +		jz4740_dma_disable(prtd->dma);
> +		break;
> +	default:
> +		ret = -EINVAL;
> +	}
> +
> +	return ret;
> +}
> +
> +static snd_pcm_uframes_t jz4740_pcm_pointer(struct snd_pcm_substream *substream)
> +{
> +	struct snd_pcm_runtime *runtime = substream->runtime;
> +	struct jz4740_runtime_data *prtd = runtime->private_data;
> +	unsigned long count, pos;
> +	snd_pcm_uframes_t offset;
> +	struct jz4740_dma_chan *dma = prtd->dma;
> +
> +	count = jz4740_dma_get_residue(dma);
> +	if (prtd->dma_pos == prtd->dma_start)
> +		pos = prtd->dma_end - prtd->dma_start - count;
> +	else
> +		pos = prtd->dma_pos - prtd->dma_start - count;
> +
> +	offset = bytes_to_frames(runtime, pos);
> +	if (offset >= runtime->buffer_size)
> +		offset = 0;
> +

Could you comment your calculation a little more.

> +	return offset;
> +}
> +
> +static int jz4740_pcm_open(struct snd_pcm_substream *substream)
> +{
> +	struct snd_pcm_runtime *runtime = substream->runtime;
> +	struct jz4740_runtime_data *prtd;
> +
> +	snd_soc_set_runtime_hwparams(substream, &jz4740_pcm_hardware);
> +	prtd = kzalloc(sizeof(struct jz4740_runtime_data), GFP_KERNEL);
> +
> +	if (prtd == NULL)
> +		return -ENOMEM;
> +
> +	runtime->private_data = prtd;
> +	return 0;
> +}
> +
> +static int jz4740_pcm_close(struct snd_pcm_substream *substream)
> +{
> +	struct snd_pcm_runtime *runtime = substream->runtime;
> +	struct jz4740_runtime_data *prtd = runtime->private_data;
> +
> +	kfree(prtd);
> +
> +	return 0;
> +}
> +
> +static int jz4740_pcm_mmap(struct snd_pcm_substream *substream,
> +	struct vm_area_struct *vma)
> +{
> +	return remap_pfn_range(vma, vma->vm_start,
> +			substream->dma_buffer.addr >> PAGE_SHIFT,
> +			vma->vm_end - vma->vm_start, vma->vm_page_prot);
> +}
> +
> +static struct snd_pcm_ops jz4740_pcm_ops = {
> +	.open		= jz4740_pcm_open,
> +	.close		= jz4740_pcm_close,
> +	.ioctl		= snd_pcm_lib_ioctl,
> +	.hw_params	= jz4740_pcm_hw_params,
> +	.hw_free	= jz4740_pcm_hw_free,
> +	.prepare	= jz4740_pcm_prepare,
> +	.trigger	= jz4740_pcm_trigger,
> +	.pointer	= jz4740_pcm_pointer,
> +	.mmap		= jz4740_pcm_mmap,
> +};
> +
> +static int jz4740_pcm_preallocate_dma_buffer(struct snd_pcm *pcm, int stream)
> +{
> +	struct snd_pcm_substream *substream = pcm->streams[stream].substream;
> +	struct snd_dma_buffer *buf = &substream->dma_buffer;
> +	size_t size = jz4740_pcm_hardware.buffer_bytes_max;
> +
> +	buf->dev.type = SNDRV_DMA_TYPE_DEV;
> +	buf->dev.dev = pcm->card->dev;
> +	buf->private_data = NULL;
> +
> +	buf->area = dma_alloc_noncoherent(pcm->card->dev, size,
> +					  &buf->addr, GFP_KERNEL);
> +	if (!buf->area)
> +		return -ENOMEM;
> +
> +	buf->bytes = size;
> +
> +	return 0;
> +}
> +
> +static void jz4740_pcm_free(struct snd_pcm *pcm)
> +{
> +	struct snd_pcm_substream *substream;
> +	struct snd_dma_buffer *buf;
> +	int stream;
> +
> +	for (stream = 0; stream < 2; stream++) {
> +		substream = pcm->streams[stream].substream;
> +		if (!substream)
> +			continue;
> +
> +		buf = &substream->dma_buffer;
> +		if (!buf->area)
> +			continue;
> +
> +		dma_free_noncoherent(pcm->card->dev, buf->bytes,
> +		  buf->area, buf->addr);
> +		buf->area = NULL;
> +	}
> +}
> +
> +static u64 jz4740_pcm_dmamask = DMA_BIT_MASK(32);
> +
> +int jz4740_pcm_new(struct snd_card *card, struct snd_soc_dai *dai,
> +	struct snd_pcm *pcm)
> +{
> +	int ret = 0;
> +
> +	if (!card->dev->dma_mask)
> +		card->dev->dma_mask = &jz4740_pcm_dmamask;
> +
> +	if (!card->dev->coherent_dma_mask)
> +		card->dev->coherent_dma_mask = DMA_BIT_MASK(32);
> +
> +	if (dai->playback.channels_min) {
> +		ret = jz4740_pcm_preallocate_dma_buffer(pcm,
> +			SNDRV_PCM_STREAM_PLAYBACK);
> +		if (ret)
> +			goto err;
> +	}
> +
> +	if (dai->capture.channels_min) {
> +		ret = jz4740_pcm_preallocate_dma_buffer(pcm,
> +			SNDRV_PCM_STREAM_CAPTURE);
> +		if (ret)
> +			goto err;
> +	}
> +
> +err:
> +	return ret;
> +}
> +
> +struct snd_soc_platform jz4740_soc_platform = {
> +		.name		= "jz4740-pcm",
> +		.pcm_ops	= &jz4740_pcm_ops,
> +		.pcm_new	= jz4740_pcm_new,
> +		.pcm_free	= jz4740_pcm_free,
> +};
> +EXPORT_SYMBOL_GPL(jz4740_soc_platform);
> +
> +static int __init jz4740_soc_platform_init(void)
> +{
> +	return snd_soc_register_platform(&jz4740_soc_platform);
> +}
> +module_init(jz4740_soc_platform_init);
> +
> +static void __exit jz4740_soc_platform_exit(void)
> +{
> +	snd_soc_unregister_platform(&jz4740_soc_platform);
> +}
> +module_exit(jz4740_soc_platform_exit);
> +
> +MODULE_AUTHOR("Lars-Peter Clausen <lars@metafoo.de>");
> +MODULE_DESCRIPTION("Ingenic SoC JZ4740 PCM driver");
> +MODULE_LICENSE("GPL");
> diff --git a/sound/soc/jz4740/jz4740-pcm.h b/sound/soc/jz4740/jz4740-pcm.h
> new file mode 100644
> index 0000000..e3f221e
> --- /dev/null
> +++ b/sound/soc/jz4740/jz4740-pcm.h
> @@ -0,0 +1,22 @@
> +/*
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#ifndef _JZ4740_PCM_H
> +#define _JZ4740_PCM_H
> +
> +#include <linux/dma-mapping.h>
> +#include <asm/mach-jz4740/dma.h>
> +
> +/* platform data */
> +extern struct snd_soc_platform jz4740_soc_platform;
> +
> +struct jz4740_pcm_config {
> +	struct jz4740_dma_config dma_config;
> +	phys_addr_t fifo_addr;
> +};
> +
> +#endif

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

Re: [RFC][PATCH 21/26] alsa: ASoC: Add JZ4740 ASoC support

[Lars-Peter Clausen]

Liam Girdwood wrote:
> On Wed, 2010-06-02 at 21:12 +0200, Lars-Peter Clausen wrote:
>   
>> This patch adds ASoC support for JZ4740 SoCs I2S module.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
>> Cc: Liam Girdwood <lrg@slimlogic.co.uk>
>> Cc: alsa-devel@alsa-project.org
>> ---
>>  sound/soc/Kconfig             |    1 +
>>  sound/soc/Makefile            |    1 +
>>  sound/soc/jz4740/Kconfig      |   13 +
>>  sound/soc/jz4740/Makefile     |    9 +
>>  sound/soc/jz4740/jz4740-i2s.c |  568 +++++++++++++++++++++++++++++++++++++++++
>>  sound/soc/jz4740/jz4740-i2s.h |   18 ++
>>  sound/soc/jz4740/jz4740-pcm.c |  350 +++++++++++++++++++++++++
>>  sound/soc/jz4740/jz4740-pcm.h |   22 ++
>>  8 files changed, 982 insertions(+), 0 deletions(-)
>>  create mode 100644 sound/soc/jz4740/Kconfig
>>  create mode 100644 sound/soc/jz4740/Makefile
>>  create mode 100644 sound/soc/jz4740/jz4740-i2s.c
>>  create mode 100644 sound/soc/jz4740/jz4740-i2s.h
>>  create mode 100644 sound/soc/jz4740/jz4740-pcm.c
>>  create mode 100644 sound/soc/jz4740/jz4740-pcm.h
>>
>> diff --git a/sound/soc/Kconfig b/sound/soc/Kconfig
>> index b1749bc..5a7a724 100644
>> --- a/sound/soc/Kconfig
>> +++ b/sound/soc/Kconfig
>> @@ -36,6 +36,7 @@ source "sound/soc/s3c24xx/Kconfig"
>>  source "sound/soc/s6000/Kconfig"
>>  source "sound/soc/sh/Kconfig"
>>  source "sound/soc/txx9/Kconfig"
>> +source "sound/soc/jz4740/Kconfig"
>>  
>>  # Supported codecs
>>  source "sound/soc/codecs/Kconfig"
>> diff --git a/sound/soc/Makefile b/sound/soc/Makefile
>> index 1470141..fdbe74d 100644
>> --- a/sound/soc/Makefile
>> +++ b/sound/soc/Makefile
>> @@ -14,3 +14,4 @@ obj-$(CONFIG_SND_SOC)	+= s3c24xx/
>>  obj-$(CONFIG_SND_SOC)	+= s6000/
>>  obj-$(CONFIG_SND_SOC)	+= sh/
>>  obj-$(CONFIG_SND_SOC)	+= txx9/
>> +obj-$(CONFIG_SND_SOC)	+= jz4740/
>> diff --git a/sound/soc/jz4740/Kconfig b/sound/soc/jz4740/Kconfig
>> new file mode 100644
>> index 0000000..39df949
>> --- /dev/null
>> +++ b/sound/soc/jz4740/Kconfig
>> @@ -0,0 +1,13 @@
>> +config SND_JZ4740_SOC
>> +	tristate "SoC Audio for Ingenic JZ4740 SoC"
>> +	depends on SOC_JZ4740 && SND_SOC
>> +	help
>> +	  Say Y or M if you want to add support for codecs attached to
>> +	  the Jz4740 AC97, I2S or SSP interface. You will also need
>>     
>
> Do you have an AC97 or SSP interface ?
>
>   
Whoops. Copy-paste leftover...
>> +	[....]
>> +
>> +
>> +static int jz4740_i2s_trigger(struct snd_pcm_substream *substream, int cmd,
>> +	struct snd_soc_dai *dai)
>> +{
>> +	struct jz4740_i2s *i2s = jz4740_dai_to_i2s(dai);
>> +	bool playback = (substream->stream == SNDRV_PCM_STREAM_PLAYBACK);
>> +
>> +	uint32_t ctrl;
>> +	uint32_t mask;
>> +
>> +	if (playback)
>>     
>
> It's best to use (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) here.
>
>   
hm, ok
>> +	[...]
>> --- /dev/null
>> +++ b/sound/soc/jz4740/jz4740-pcm.c
>> @@ -0,0 +1,350 @@
>> + [...] 
>> +static int jz4740_pcm_hw_params(struct snd_pcm_substream *substream,
>> +	struct snd_pcm_hw_params *params)
>> +{
>> +	struct snd_pcm_runtime *runtime = substream->runtime;
>> +	struct jz4740_runtime_data *prtd = runtime->private_data;
>> +	struct snd_soc_pcm_runtime *rtd = substream->private_data;
>> +	struct jz4740_pcm_config *config;
>> +
>> +	config = snd_soc_dai_get_dma_data(rtd->dai->cpu_dai, substream);
>> +	if (!prtd->dma) {
>> +		const char *dma_channel_name;
>> +		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
>> +			dma_channel_name = "PCM Playback";
>> +		else
>> +			dma_channel_name = "PCM Capture";
>> +
>> +		prtd->dma = jz4740_dma_request(substream, dma_channel_name);
>>     
>
> dma_channel_name variable is not required here. Just use the const char
> * directly.
>
>   
I actually had it like that before, but I think it is much more readable
in its current form. Considering that stream value will either be 0 or 1
it might work to put the channel names into a static array.
>> +	[...]
>> +
>> +static snd_pcm_uframes_t jz4740_pcm_pointer(struct snd_pcm_substream *substream)
>> +{
>> +	struct snd_pcm_runtime *runtime = substream->runtime;
>> +	struct jz4740_runtime_data *prtd = runtime->private_data;
>> +	unsigned long count, pos;
>> +	snd_pcm_uframes_t offset;
>> +	struct jz4740_dma_chan *dma = prtd->dma;
>> +
>> +	count = jz4740_dma_get_residue(dma);
>> +	if (prtd->dma_pos == prtd->dma_start)
>> +		pos = prtd->dma_end - prtd->dma_start - count;
>> +	else
>> +		pos = prtd->dma_pos - prtd->dma_start - count;
>> +
>> +	offset = bytes_to_frames(runtime, pos);
>> +	if (offset >= runtime->buffer_size)
>> +		offset = 0;
>> +
>>     
>
> Could you comment your calculation a little more.
>   
Will do.
>
> Thanks
>
> Liam
>   
Thanks for the review
- Lars

Re: [RFC][PATCH 21/26] alsa: ASoC: Add JZ4740 ASoC support

[Liam Girdwood]

On Thu, 2010-06-03 at 18:50 +0200, Lars-Peter Clausen wrote:
> >> +    config = snd_soc_dai_get_dma_data(rtd->dai->cpu_dai,
> substream);
> >> +    if (!prtd->dma) {
> >> +            const char *dma_channel_name;
> >> +            if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
> >> +                    dma_channel_name = "PCM Playback";
> >> +            else
> >> +                    dma_channel_name = "PCM Capture";
> >> +
> >> +            prtd->dma = jz4740_dma_request(substream,
> dma_channel_name);
> >>     
> >
> > dma_channel_name variable is not required here. Just use the const
> char
> > * directly.
> >
> >   
> I actually had it like that before, but I think it is much more readable
> in its current form.

I disagree, having the char pointer here just adds an extra level of
indirection and costs an extra two lines of code. 

Liam 
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

Re: [RFC][PATCH 21/26] alsa: ASoC: Add JZ4740 ASoC support

[Lars-Peter Clausen]

Liam Girdwood wrote:
> On Thu, 2010-06-03 at 18:50 +0200, Lars-Peter Clausen wrote:
>   
>>>> +    config = snd_soc_dai_get_dma_data(rtd->dai->cpu_dai,
>>>>         
>> substream);
>>     
>>>> +    if (!prtd->dma) {
>>>> +            const char *dma_channel_name;
>>>> +            if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
>>>> +                    dma_channel_name = "PCM Playback";
>>>> +            else
>>>> +                    dma_channel_name = "PCM Capture";
>>>> +
>>>> +            prtd->dma = jz4740_dma_request(substream,
>>>>         
>> dma_channel_name);
>>     
>>>>     
>>>>         
>>> dma_channel_name variable is not required here. Just use the const
>>>       
>> char
>>     
>>> * directly.
>>>
>>>   
>>>       
>> I actually had it like that before, but I think it is much more readable
>> in its current form.
>>     
>
> I disagree, having the char pointer here just adds an extra level of
> indirection and costs an extra two lines of code. 
>
> Liam 
>   
Hi

Could you give an concrete example of how you would code it?

- Lars

Re: [RFC][PATCH 21/26] alsa: ASoC: Add JZ4740 ASoC support

[Liam Girdwood]

On Thu, 2010-06-03 at 19:16 +0200, Lars-Peter Clausen wrote:
> Liam Girdwood wrote:
> > On Thu, 2010-06-03 at 18:50 +0200, Lars-Peter Clausen wrote:
> >   
> >>>> +    config = snd_soc_dai_get_dma_data(rtd->dai->cpu_dai,
> >>>>         
> >> substream);
> >>     
> >>>> +    if (!prtd->dma) {
> >>>> +            const char *dma_channel_name;
> >>>> +            if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
> >>>> +                    dma_channel_name = "PCM Playback";
> >>>> +            else
> >>>> +                    dma_channel_name = "PCM Capture";
> >>>> +
> >>>> +            prtd->dma = jz4740_dma_request(substream,
> >>>>         
> >> dma_channel_name);
> >>     
> >>>>     
> >>>>         
> >>> dma_channel_name variable is not required here. Just use the const
> >>>       
> >> char
> >>     
> >>> * directly.
> >>>
> >>>   
> >>>       
> >> I actually had it like that before, but I think it is much more readable
> >> in its current form.
> >>     
> >
> > I disagree, having the char pointer here just adds an extra level of
> > indirection and costs an extra two lines of code. 
> >
> > Liam 
> >   
> Hi
> 
> Could you give an concrete example of how you would code it?
> 

Sure,

if (!prtd->dma) {
          if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
                   prtd->dma = jz4740_dma_request(substream, "PCM Playback");
          else
                   prtd->dma = jz4740_dma_request(substream, "PCM Capture");
}

Liam

-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

Re: [alsa-devel] [RFC][PATCH 21/26] alsa: ASoC: Add JZ4740 ASoC support

[Troy Kisky]

Liam Girdwood wrote:
> On Thu, 2010-06-03 at 19:16 +0200, Lars-Peter Clausen wrote:
>> Liam Girdwood wrote:
>>> On Thu, 2010-06-03 at 18:50 +0200, Lars-Peter Clausen wrote:
>>>   
>>>>>> +    config = snd_soc_dai_get_dma_data(rtd->dai->cpu_dai,
>>>>>>         
>>>> substream);
>>>>     
>>>>>> +    if (!prtd->dma) {
>>>>>> +            const char *dma_channel_name;
>>>>>> +            if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
>>>>>> +                    dma_channel_name = "PCM Playback";
>>>>>> +            else
>>>>>> +                    dma_channel_name = "PCM Capture";
>>>>>> +
>>>>>> +            prtd->dma = jz4740_dma_request(substream,
>>>>>>         
>>>> dma_channel_name);
>>>>     
>>>>>>     
>>>>>>         
>>>>> dma_channel_name variable is not required here. Just use the const
>>>>>       
>>>> char
>>>>     
>>>>> * directly.
>>>>>
>>>>>   
>>>>>       
>>>> I actually had it like that before, but I think it is much more readable
>>>> in its current form.
>>>>     
>>> I disagree, having the char pointer here just adds an extra level of
>>> indirection and costs an extra two lines of code. 
>>>
>>> Liam 
>>>   
>> Hi
>>
>> Could you give an concrete example of how you would code it?
>>
> 
> Sure,
> 
> if (!prtd->dma) {
>           if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
>                    prtd->dma = jz4740_dma_request(substream, "PCM Playback");
>           else
>                    prtd->dma = jz4740_dma_request(substream, "PCM Capture");
> }
> 
> Liam
> 
or,

if (!prtd->dma)
	prtd->dma = jz4740_dma_request(substream, (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) ?
		 "PCM Playback" : "PCM Capture");

hi!!!!

[dkisky]

hi troy, just checkin out....hope you're okey and doing fine. Miss you

-----
Dianne Kisky
P1- Blk. 24 Lot 8B Sta. Lucia Resettlement
Magalang, Pampanga
Mobile No.: 0927-321-3112
dianalyn_kisky@yahoo.com
-- 
View this message in context: http://old.nabble.com/-RFC--PATCH-21-26--alsa%3A-ASoC%3A-Add-JZ4740-ASoC-support-tp28758941p30212275.html
Sent from the linux-kernel mailing list archive at Nabble.com.

Hi!

[Justin Yaple]

Hi
I think you should come and see my phone, I bought from the site and
get a benefit, I will share with you.
The promotion of their website only keep 25days. Therefore it will be
very value to buy now. you can have a look, I guarantee that you will
not be disappointed.
His address:  www.uicshop.com
I also hope that in the future to share your happiness! !
Regards! ! !

hi,

[Bill Xie]

My harware is a mips-achitecture hand-hold device, runs 2.6.24.3 and qt.
when an application program  opened a 3.2M pdf file, the memory was
consuming continually, finally the "oom-killer" things happened, the
applicaton was killed,
 but the memory occupied by the application still can not be freed. Is
there some methods
to do with this situation?

hi,

[Bill Xie]

test it. thanks!

Hi!

[Eric Anopolsky]

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

Hi,

I'm new here. For the past few months I've been contributing some code
and discussion to the ZFS-fuse project, but Sun's silence on the
licensing issue has left a bad taste in my mouth. I'm ready to switch
over to the light side of the force, but I have a couple of questions.

1. I've seen and modified the ZFS source code. Even if I never look at
it again, could that poison potential contributions to btrfs?

2. What needs doing? Easy stuff first, please. I've never done kernel
coding.

Cheers,
Eric


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: Hi!

[Chris Mason]

On Wed, 2008-08-20 at 02:43 -0600, Eric Anopolsky wrote:
> Hi,
> 
> I'm new here. For the past few months I've been contributing some code
> and discussion to the ZFS-fuse project, but Sun's silence on the
> licensing issue has left a bad taste in my mouth. I'm ready to switch
> over to the light side of the force, but I have a couple of questions.
> 
> 1. I've seen and modified the ZFS source code. Even if I never look at
> it again, could that poison potential contributions to btrfs?
> 

For now, yes, reading and changing the ZFS source code is not a good
idea for people that want to contribute to btrfs.

> 2. What needs doing? Easy stuff first, please. I've never done kernel
> coding.

Testing, discussing and reporting bugs are a great first step.

-chris

Re: Hi!

[Miguel Sousa Filipe]

Hi,

On Wed, Aug 20, 2008 at 7:25 PM, Chris Mason <chris.mason@oracle.com> wrote:
> On Wed, 2008-08-20 at 02:43 -0600, Eric Anopolsky wrote:
>> Hi,
>>
>> I'm new here. For the past few months I've been contributing some code
>> and discussion to the ZFS-fuse project, but Sun's silence on the
>> licensing issue has left a bad taste in my mouth. I'm ready to switch
>> over to the light side of the force, but I have a couple of questions.
>>
>> 1. I've seen and modified the ZFS source code. Even if I never look at
>> it again, could that poison potential contributions to btrfs?
>>
>
> For now, yes, reading and changing the ZFS source code is not a good
> idea for people that want to contribute to btrfs.
>
>> 2. What needs doing? Easy stuff first, please. I've never done kernel
>> coding.
>
> Testing, discussing and reporting bugs are a great first step.

One thing that I would like to see, is how btrfs behaves with eavy
uses of version control systems like:
- git
- hg

big repos, greps, finds, and stuff like that.

It looks to me that git/hg/bazaar are everytime more widely used,
specially on power users' machines.
Btrfs should look good on those workloads...

Another thing that I'm particularly interested is in stuff like:
- remirror progress stats
- adding, removing,  drives, growing a volume, setting a drive faulty,
etc..  (feature parity with mdadm)
- create userland tools to enable booting from btrfs:
   - single disk and multi disk (raid1, 0 or 10)
   - which snapshot/subvolume ?
- support a migration path to ppl using mdadm + lvm.
   - provide similar tools and sintax to ppl used to lvm and mds.
(feature parity and more..)
   - provide higher level userland apps, and manage and know how to
work with LVM and MD devices,  support for equivalent (or better)
features on btrfs.
   - DeviceKit.Disks support (the future is DeviceKit! :-p) ->
       -> http://hal.freedesktop.org/docs/DeviceKit/
       -> http://lists.freedesktop.org/archives/hal/2008-May/011560.html
       -> http://gitweb.freedesktop.org/?p=DeviceKit/DeviceKit.git;a=summary
- grub support for btrfs (read only..) :D

kind regards..


-- 
Miguel Sousa Filipe

Re: Hi!

[Steve Long]

On Thursday 21 August 2008 11:47:03 Miguel Sousa Filipe wrote:
> > Testing, discussing and reporting bugs are a great first step.
>
> One thing that I would like to see, is how btrfs behaves with eavy
> uses of version control systems like:
> - git
> - hg
>
> big repos, greps, finds, and stuff like that.
>
How about kernel compiles (cf contest)? Perhaps with pull of the tree from 
cold cache or indeed several trees.

<snip good stuff>
>    - DeviceKit.Disks support (the future is DeviceKit! :-p) ->

Oh God does it have to be? Up to users what they install, but is it really the 
job of the fs to worry about a user layer on top of a lib on top of some 
other lib, one of which hasn't even got to 1.0 release, and whose author is 
apparently fine with changing everything around on distros (after all it 
hasn't got to 1.0..) but still insistent on how everyone else should be doing 
things? Not that it's anything to do with the FS, so why should we worry 
about it?

>        -> http://hal.freedesktop.org/docs/DeviceKit/

I couldn't find anything about "Disks", which may be down to my ignorance.

>        -> http://lists.freedesktop.org/archives/hal/2008-May/011560.html
>        ->
*groan* "the way forward is the model where you have a policy-less privileged 
mechanism that can be controlled by an unprivileged GUI policy agent"
Some of us quite like existing Unix permissions, especially on our 2 or 3 user 
desktops, and that kind of thing has been done, eg in mandriva, for quite a 
while now. Great if that's what people are happy with (personally I think 
scrapping dcop was a *huge* mistake) but I don't want it on my system any 
more than I _have_ to, to get apps to work (which is why I love Gentoo.)

> http://gitweb.freedesktop.org/?p=DeviceKit/DeviceKit.git;a=summary - grub
> support for btrfs (read only..) :D

Great, I see that's moving quickly, no code updates in 4 months. I'm guessing 
that's not because it's a stable and mature project that doesn't need any 
more work on it..
Tell me again what this has to do with a FS in the kernel; are btrfs supposed 
to change their code in any way to work with DeviceKit?

I agree with all the other stuff you posted, so please don't take my antipathy 
toward HAL and *Kit as criticism of you.

Regards,
steveL.

Re: Hi!

[Miguel Sousa Filipe]

On Sun, Aug 24, 2008 at 8:02 AM, Steve Long <slong@rathaus.eclipse.co.uk> wrote:
> On Thursday 21 August 2008 11:47:03 Miguel Sousa Filipe wrote:
>> > Testing, discussing and reporting bugs are a great first step.
>>
>> One thing that I would like to see, is how btrfs behaves with eavy
>> uses of version control systems like:
>> - git
>> - hg
>>
>> big repos, greps, finds, and stuff like that.
>>
> How about kernel compiles (cf contest)? Perhaps with pull of the tree from
> cold cache or indeed several trees.

I believe Chris allready cover that workload in his tests.. but can't hurt. :D

>
> <snip good stuff>
>>    - DeviceKit.Disks support (the future is DeviceKit! :-p) ->
>
> Oh God does it have to be? Up to users what they install, but is it really the
> job of the fs to worry about a user layer on top of a lib on top of some
> other lib, one of which hasn't even got to 1.0 release, and whose author is
> apparently fine with changing everything around on distros (after all it
> hasn't got to 1.0..) but still insistent on how everyone else should be doing
> things? Not that it's anything to do with the FS, so why should we worry
> about it?
>
>>        -> http://hal.freedesktop.org/docs/DeviceKit/
>
> I couldn't find anything about "Disks", which may be down to my ignorance.
>
>>        -> http://lists.freedesktop.org/archives/hal/2008-May/011560.html
>>        ->
> *groan* "the way forward is the model where you have a policy-less privileged
> mechanism that can be controlled by an unprivileged GUI policy agent"
> Some of us quite like existing Unix permissions, especially on our 2 or 3 user
> desktops, and that kind of thing has been done, eg in mandriva, for quite a
> while now. Great if that's what people are happy with (personally I think
> scrapping dcop was a *huge* mistake) but I don't want it on my system any
> more than I _have_ to, to get apps to work (which is why I love Gentoo.)

even if I like the gentoo or openbsd way, that doesn't help having
good btrfs support on
all the other distros that use HAL or its descendants.

>
>> http://gitweb.freedesktop.org/?p=DeviceKit/DeviceKit.git;a=summary - grub
>> support for btrfs (read only..) :D
>
> Great, I see that's moving quickly, no code updates in 4 months. I'm guessing
> that's not because it's a stable and mature project that doesn't need any
> more work on it..
> Tell me again what this has to do with a FS in the kernel; are btrfs supposed
> to change their code in any way to work with DeviceKit?
>
> I agree with all the other stuff you posted, so please don't take my antipathy
> toward HAL and *Kit as criticism of you.

I share much of your opinions about hal and these new (leaky)
abstraction layers, but having a current/decent linux install without
all that hal stuff (with gnome or kde) is next to impossible.

My concearn is more of btrfs having equal support on those dandy
apps/layers, that will be used by fedora, ubuntu, opensuse, etc...
I want in a years time, have a "format with BTRFS" option on a regular
fedora/ubuntu install.



>
> Regards,
> steveL.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



-- 
Miguel Sousa Filipe

Hi !

[Miss. Joysin Plany]

Hi Dear
 Hello nice to reach you..! How are you doing hope you are doing pretty good.I am Joysin Plany, Female of 27 year of age from florida in the United State of America, I work in a non governmental organization.
Well this might come to you as a 
matter of chance. 
Be put into awearness of the fact the YMCA will be embacking on a project of  millions of dollars this year, and it would be an open doors for the people expecially ouside the usa. 
Moreover, the YMCA organizing committe  are interest to work also with extenal candidates outside the usa. You will have to come to the usa for a two months training before the commencement of the 
project in the month of october 2008.
However if you wish us to know better and to know more of the above, kindly reach me back by reply.
Bye for now and remain in touch 
Joysin.

Hi!

[Kenya Vasquez]

Hello! I am bored tonight. I am nice girl that would like to chat with you. Email me at s@linkmailmessage.info only, because I am writing not from my personal email. You will see some of my private pics.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

Hi!

[Jaime Stinson]

[-- Attachment #1: Type: text/html, Size: 277 bytes --]

[-- Attachment #2: Type: text/plain, Size: 286 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

[-- Attachment #3: Type: text/plain, Size: 140 bytes --]

_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

Hi!

[Sandy Rojas]

Hello! I am bored this afternoon. I am nice girl that would like to chat with you. Email me at ajll@linkmailmessage.info only, because I am writing not from my personal email. I will show you some of my private pictures

Hi!

[Samantha]

Dear friend,
I found your picture on oneb of the wbaebsites, can we talk to 
each othber? I might be coming to your place in fbew weeks.
This would be a great opportunity to meet each othber.
Btw, I amb a woman. I am 25. Drop me a line at leezu@SpringMailSite.info

Hi,

[ms joy]

Hi,
How are you today? I know that my letter will meet you as a surprise.

I am Joy Moses, i am 19,  My mother was an African American while my father 
was from the french speaking colony of Cote D' Ivoire, i was living with my 
mother not too far from Charleston building, 601 57th Street, Charleston 
West Virginia USA. And i attended Charleston senior High School, 1201 
Washington Street E, Charleston, WV. I lost my mother sometimes ago and 
after her death i came to meet my father for the very first time in Cote d' 
Ivoire West Africa, though he was also living in the state before he 
relocated back to Cote d' Ivoire to set up a business.

Exactely two months and one week after i came to meet my father with the 
help of US consulates he died, he was very sick when i came to meet him. But 
before his death there were some document he gave to me and he told me that 
everything he worked for in his life time is in the document when i 
crosscheck the document i discovered that my late father deposited $ 10.5 
Million dollars in a bank here, Ten million five hundred thousand US 
dollars.
The reason he deposited the money  was because of there political problem in 
this country.While I am telling you is that i am just a girl and there is 
little or nothing i could do on my own and again if my late father relative 
find out that my late father left this kind of money in my care i don't know 
what they might do to me, so i need you to help me contact the bank for 
transfer  the money into your own bank account , and take me along with you. 
If you do this for me apart from the love i will also offer you 20% of the 
total money for helping me.

Please i requested for your trust and understanding because it might sound 
unbeleivable but it is the truth, Please get back as soon as posible.
Sincerely,
Miss Joy Moses.

_________________________________________________________________
Personnalisez votre Messenger avec Live.com 
http://www.windowslive.fr/livecom/

Hi,

[ms joy]

Hi,
How are you today? I know that my letter will meet you as a surprise.

I am Joy Moses, i am 19,  My mother was an African American while my father 
was from the french speaking colony of Cote D' Ivoire, i was living with my 
mother not too far from Charleston building, 601 57th Street, Charleston 
West Virginia USA. And i attended Charleston senior High School, 1201 
Washington Street E, Charleston, WV. I lost my mother sometimes ago and 
after her death i came to meet my father for the very first time in Cote d' 
Ivoire West Africa, though he was also living in the state before he 
relocated back to Cote d' Ivoire to set up a business.

Exactely two months and one week after i came to meet my father with the 
help of US consulates he died, he was very sick when i came to meet him. But 
before his death there were some document he gave to me and he told me that 
everything he worked for in his life time is in the document when i 
crosscheck the document i discovered that my late father deposited $ 10.5 
Million dollars in a bank here, Ten million five hundred thousand US 
dollars.
The reason he deposited the money  was because of there political problem in 
this country.While I am telling you is that i am just a girl and there is 
little or nothing i could do on my own and again if my late father relative 
find out that my late father left this kind of money in my care i don't know 
what they might do to me, so i need you to help me contact the bank for 
transfer  the money into your own bank account , and take me along with you. 
If you do this for me apart from the love i will also offer you 20% of the 
total money for helping me.

Please i requested for your trust and understanding because it might sound 
unbeleivable but it is the truth, Please get back as soon as posible.
Sincerely,
Miss Joy Moses.

_________________________________________________________________
Gagnez des écrans plats avec Live.com http://www.image-addict.fr/

Hi,

[ms joy]

Hi,
How are you today? I know that my letter will meet you as a surprise.

I am Joy Moses, i am 19,  My mother was an African American while my father 
was from the french speaking colony of Cote D' Ivoire, i was living with my 
mother not too far from Charleston building, 601 57th Street, Charleston 
West Virginia USA. And i attended Charleston senior High School, 1201 
Washington Street E, Charleston, WV. I lost my mother sometimes ago and 
after her death i came to meet my father for the very first time in Cote d' 
Ivoire West Africa, though he was also living in the state before he 
relocated back to Cote d' Ivoire to set up a business.

Exactely two months and one week after i came to meet my father with the 
help of US consulates he died, he was very sick when i came to meet him. But 
before his death there were some document he gave to me and he told me that 
everything he worked for in his life time is in the document when i 
crosscheck the document i discovered that my late father deposited $ 10.5 
Million dollars in a bank here, Ten million five hundred thousand US 
dollars.
The reason he deposited the money  was because of there political problem in 
this country.While I am telling you is that i am just a girl and there is 
little or nothing i could do on my own and again if my late father relative 
find out that my late father left this kind of money in my care i don't know 
what they might do to me, so i need you to help me contact the bank for 
transfer  the money into your own bank account , and take me along with you. 
If you do this for me apart from the love i will also offer you 20% of the 
total money for helping me.

Please i requested for your trust and understanding because it might sound 
unbeleivable but it is the truth, Please get back as soon as posible.
Sincerely,
Miss Joy Moses.

_________________________________________________________________
Ten :  Messenger en illimité sur votre mobile !  
http://mobile.live.fr/messenger/ten/

Hi,

[ms joy]

Hi,
How are you today? I know that my letter will meet you as a surprise.

I am Joy Moses, i am 19,  My mother was an African American while my father 
was from the french speaking colony of Cote D' Ivoire, i was living with my 
mother not too far from Charleston building, 601 57th Street, Charleston 
West Virginia USA. And i attended Charleston senior High School, 1201 
Washington Street E, Charleston, WV. I lost my mother sometimes ago and 
after her death i came to meet my father for the very first time in Cote d' 
Ivoire West Africa, though he was also living in the state before he 
relocated back to Cote d' Ivoire to set up a business.

Exactely two months and one week after i came to meet my father with the 
help of US consulates he died, he was very sick when i came to meet him. But 
before his death there were some document he gave to me and he told me that 
everything he worked for in his life time is in the document when i 
crosscheck the document i discovered that my late father deposited $ 10.5 
Million dollars in a bank here, Ten million five hundred thousand US 
dollars.
The reason he deposited the money  was because of there political problem in 
this country.While I am telling you is that i am just a girl and there is 
little or nothing i could do on my own and again if my late father relative 
find out that my late father left this kind of money in my care i don't know 
what they might do to me, so i need you to help me contact the bank for 
transfer  the money into your own bank account , and take me along with you. 
If you do this for me apart from the love i will also offer you 20% of the 
total money for helping me.

Please i requested for your trust and understanding because it might sound 
unbeleivable but it is the truth, Please get back as soon as posible.
Sincerely,
Miss Joy Moses.

_________________________________________________________________
Personnalisez votre Messenger avec Live.com 
http://www.windowslive.fr/livecom/

Re: HI!

[Doug Shultz]

Do you want a w-atch?

In our online store you can buy r e p l i c a s of R o l e x watches and
other brands. They look and feel exactly like the real thing.

- We have 100+ different brands in our selection
- Best prices on the market Just For You
- Great Discount Live Support Extended Warranty
- Free shipping if you order 2 or more
- Save up to 85% compared to the cost of other r e p l i c a s
- Standard Features:
- Screw-in crown
- Unidirectional turning bezel where appropriate
- All the appropriate r o l e x logos, on crown and dial
- Heavy weight

Clisk here: http://huamaoshiye.info




elena ahoy dublin wolfgang anonymous dallas dingy joe
laud sextet wheat ejector arrear roosevelt cloak cathy

Re: HI!

[Doug Shultz]

Do you want a w-atch?

In our online store you can buy r e p l i c a s of R o l e x watches and
other brands. They look and feel exactly like the real thing.

- We have 100+ different brands in our selection
- Best prices on the market Just For You
- Great Discount Live Support Extended Warranty
- Free shipping if you order 2 or more
- Save up to 85% compared to the cost of other r e p l i c a s
- Standard Features:
- Screw-in crown
- Unidirectional turning bezel where appropriate
- All the appropriate r o l e x logos, on crown and dial
- Heavy weight

Clisk here: http://huamaoshiye.info




elena ahoy dublin wolfgang anonymous dallas dingy joe
laud sextet wheat ejector arrear roosevelt cloak cathy

Re: HI !

[Romero Ryan]

Your girl is unsatisfied with your pottency?
Don't wait until she finds another men!

Click here to choose from a great variety of LICENSED love t@bs!
Best pri$es, fast shipping and guaranteed effect! Here you buy it
right from warehouse!


The store is VERIFIED BY BBB and APPROVED BY VISA!

http://www.psV.mitosisff.com

Hi!

[Billie Joe]

Hi!


I have 3 IPs on Internet, and I want to put them behind my firewall
machine. So I have the question: Put all 3 IPs in the same network
card (with alias) or a card for each IP ?? What you suggest and why ??
Thanks


pS.: Consider that I have another NIC for my LAN.


BillieGDJoe

Re: Hi!

[Tib]

Hi there,

Thought I'd chip in since this used to be identical to how I had my system
setup. I had a block of 5 useable from my isp.

Whichever you are going to use as your actual firewall box IP (as opposed
to the machines you want to run behind it), you set as eth0 ip config.

After that you setup the other ip's as virtual interfaces on the same card
(eth0:1, eth0:2, etc). Set your internal IP nic to be eth1 and make sure
the routing table is set to go through it out to eth0 and the world. Have
your other internal IP boxes use eth1 as their gateway.

After that, you setup destniation nat'ing using something like this:

iptables -t nat -A PREROUTING -d $REAL-IP$ \
                -j DNAT --to-destination $INTERNAL-IP$

and

iptables -t nat -A POSTROUTING -s $INTERNAL-IP$ \
                -j SNAT --to-source $REAL-IP$

for each internal/ip pair you want to have mapped.

After you've done this - you're likely going to want to protect them from
certain types of traffic, since the basic INPUT rules won't cover it - put
anything you DON'T want to reach those hosts under the FORWARD ruleset as
drops.

That's it - you're set.

One item of note - be sure to put those snat/dnat rules into the table
BEFORE the catchall masquerading rule (if you use one) otherwise they will
hit the masquerade rule first and your traffic will not match in/out ip's
and things will bork up.

This is a setup I've used for a number of years, it's nice and clean and
gives good protection through the forward ruleset. If you cover your bases
right and practice safe net, things like zone alarm become unnecessary.

I blocked the following on forward and have done very well by it:

udp:
111
135
137
138
139
445
1026
1433

tcp:
21
57
79
80
111
135
137
138
139
443
445
1025
1026
1433
5000
31337

These will vary depending on your particular software usage and such - but
are a good start.

<EOL>
Tib

On Sat, 11 Jun 2005, Billie Joe wrote:

> Hi!
>
>
> I have 3 IPs on Internet, and I want to put them behind my firewall
> machine. So I have the question: Put all 3 IPs in the same network
> card (with alias) or a card for each IP ?? What you suggest and why ??
> Thanks
>
>
> pS.: Consider that I have another NIC for my LAN.
>
>
> BillieGDJoe
>

Re: Hi!

[Sadus .]

I usually block only in the INPUT chain, doesn't it protect my internal
network?
I only have SNATed the internal network to the external IP/

On Sat, 2005-06-11 at 12:16 -0500, Tib wrote:
> Hi there,
> 
> Thought I'd chip in since this used to be identical to how I had my system
> setup. I had a block of 5 useable from my isp.
> 
> Whichever you are going to use as your actual firewall box IP (as opposed
> to the machines you want to run behind it), you set as eth0 ip config.
> 
> After that you setup the other ip's as virtual interfaces on the same card
> (eth0:1, eth0:2, etc). Set your internal IP nic to be eth1 and make sure
> the routing table is set to go through it out to eth0 and the world. Have
> your other internal IP boxes use eth1 as their gateway.
> 
> After that, you setup destniation nat'ing using something like this:
> 
> iptables -t nat -A PREROUTING -d $REAL-IP$ \
>                 -j DNAT --to-destination $INTERNAL-IP$
> 
> and
> 
> iptables -t nat -A POSTROUTING -s $INTERNAL-IP$ \
>                 -j SNAT --to-source $REAL-IP$
> 
> for each internal/ip pair you want to have mapped.
> 
> After you've done this - you're likely going to want to protect them from
> certain types of traffic, since the basic INPUT rules won't cover it - put
> anything you DON'T want to reach those hosts under the FORWARD ruleset as
> drops.
> 
> That's it - you're set.
> 
> One item of note - be sure to put those snat/dnat rules into the table
> BEFORE the catchall masquerading rule (if you use one) otherwise they will
> hit the masquerade rule first and your traffic will not match in/out ip's
> and things will bork up.
> 
> This is a setup I've used for a number of years, it's nice and clean and
> gives good protection through the forward ruleset. If you cover your bases
> right and practice safe net, things like zone alarm become unnecessary.
> 
> I blocked the following on forward and have done very well by it:
> 
> udp:
> 111
> 135
> 137
> 138
> 139
> 445
> 1026
> 1433
> 
> tcp:
> 21
> 57
> 79
> 80
> 111
> 135
> 137
> 138
> 139
> 443
> 445
> 1025
> 1026
> 1433
> 5000
> 31337
> 
> These will vary depending on your particular software usage and such - but
> are a good start.
> 
> <EOL>
> Tib
> 
> On Sat, 11 Jun 2005, Billie Joe wrote:
> 
> > Hi!
> >
> >
> > I have 3 IPs on Internet, and I want to put them behind my firewall
> > machine. So I have the question: Put all 3 IPs in the same network
> > card (with alias) or a card for each IP ?? What you suggest and why ??
> > Thanks
> >
> >
> > pS.: Consider that I have another NIC for my LAN.
> >
> >
> > BillieGDJoe
> >
> 
-- 
Sadus . <sadus@swiftbin.net>
Swiftbin.net

Re: Hi!

[Tib]

If you are using snat/dnat to map internal IP's to the public realm, INPUT
will not block things that are being handled in this way - that is why the
FORWARD ruleset will also need entries in it, since that is explicitly
going to catch packets handled by snat/dnat.

<EOL>
Tib

On Sat, 11 Jun 2005, Sadus . wrote:

> I usually block only in the INPUT chain, doesn't it protect my internal
> network?
> I only have SNATed the internal network to the external IP/
>
> On Sat, 2005-06-11 at 12:16 -0500, Tib wrote:
> > Hi there,
> >
> > Thought I'd chip in since this used to be identical to how I had my system
> > setup. I had a block of 5 useable from my isp.
> >
> > Whichever you are going to use as your actual firewall box IP (as opposed
> > to the machines you want to run behind it), you set as eth0 ip config.
> >
> > After that you setup the other ip's as virtual interfaces on the same card
> > (eth0:1, eth0:2, etc). Set your internal IP nic to be eth1 and make sure
> > the routing table is set to go through it out to eth0 and the world. Have
> > your other internal IP boxes use eth1 as their gateway.
> >
> > After that, you setup destniation nat'ing using something like this:
> >
> > iptables -t nat -A PREROUTING -d $REAL-IP$ \
> >                 -j DNAT --to-destination $INTERNAL-IP$
> >
> > and
> >
> > iptables -t nat -A POSTROUTING -s $INTERNAL-IP$ \
> >                 -j SNAT --to-source $REAL-IP$
> >
> > for each internal/ip pair you want to have mapped.
> >
> > After you've done this - you're likely going to want to protect them from
> > certain types of traffic, since the basic INPUT rules won't cover it - put
> > anything you DON'T want to reach those hosts under the FORWARD ruleset as
> > drops.
> >
> > That's it - you're set.
> >
> > One item of note - be sure to put those snat/dnat rules into the table
> > BEFORE the catchall masquerading rule (if you use one) otherwise they will
> > hit the masquerade rule first and your traffic will not match in/out ip's
> > and things will bork up.
> >
> > This is a setup I've used for a number of years, it's nice and clean and
> > gives good protection through the forward ruleset. If you cover your bases
> > right and practice safe net, things like zone alarm become unnecessary.
> >
> > I blocked the following on forward and have done very well by it:
> >
> > udp:
> > 111
> > 135
> > 137
> > 138
> > 139
> > 445
> > 1026
> > 1433
> >
> > tcp:
> > 21
> > 57
> > 79
> > 80
> > 111
> > 135
> > 137
> > 138
> > 139
> > 443
> > 445
> > 1025
> > 1026
> > 1433
> > 5000
> > 31337
> >
> > These will vary depending on your particular software usage and such - but
> > are a good start.
> >
> > <EOL>
> > Tib
> >
> > On Sat, 11 Jun 2005, Billie Joe wrote:
> >
> > > Hi!
> > >
> > >
> > > I have 3 IPs on Internet, and I want to put them behind my firewall
> > > machine. So I have the question: Put all 3 IPs in the same network
> > > card (with alias) or a card for each IP ?? What you suggest and why ??
> > > Thanks
> > >
> > >
> > > pS.: Consider that I have another NIC for my LAN.
> > >
> > >
> > > BillieGDJoe
> > >
> >
>

Re: Hi!

[Tib]

Caveat to what I just said - if you are doing masquerading behind a single
IP, then you don't need to worry about the FORWARD ruleset. Only packets
associated with connections  that are being masqueraded will get sent on
to internal networks - unless you have specific ports that are translated
to internal services.

<EOL>
Tib

On Sat, 11 Jun 2005, Sadus . wrote:

> I usually block only in the INPUT chain, doesn't it protect my internal
> network?
> I only have SNATed the internal network to the external IP/
>
> On Sat, 2005-06-11 at 12:16 -0500, Tib wrote:
> > Hi there,
> >
> > Thought I'd chip in since this used to be identical to how I had my system
> > setup. I had a block of 5 useable from my isp.
> >
> > Whichever you are going to use as your actual firewall box IP (as opposed
> > to the machines you want to run behind it), you set as eth0 ip config.
> >
> > After that you setup the other ip's as virtual interfaces on the same card
> > (eth0:1, eth0:2, etc). Set your internal IP nic to be eth1 and make sure
> > the routing table is set to go through it out to eth0 and the world. Have
> > your other internal IP boxes use eth1 as their gateway.
> >
> > After that, you setup destniation nat'ing using something like this:
> >
> > iptables -t nat -A PREROUTING -d $REAL-IP$ \
> >                 -j DNAT --to-destination $INTERNAL-IP$
> >
> > and
> >
> > iptables -t nat -A POSTROUTING -s $INTERNAL-IP$ \
> >                 -j SNAT --to-source $REAL-IP$
> >
> > for each internal/ip pair you want to have mapped.
> >
> > After you've done this - you're likely going to want to protect them from
> > certain types of traffic, since the basic INPUT rules won't cover it - put
> > anything you DON'T want to reach those hosts under the FORWARD ruleset as
> > drops.
> >
> > That's it - you're set.
> >
> > One item of note - be sure to put those snat/dnat rules into the table
> > BEFORE the catchall masquerading rule (if you use one) otherwise they will
> > hit the masquerade rule first and your traffic will not match in/out ip's
> > and things will bork up.
> >
> > This is a setup I've used for a number of years, it's nice and clean and
> > gives good protection through the forward ruleset. If you cover your bases
> > right and practice safe net, things like zone alarm become unnecessary.
> >
> > I blocked the following on forward and have done very well by it:
> >
> > udp:
> > 111
> > 135
> > 137
> > 138
> > 139
> > 445
> > 1026
> > 1433
> >
> > tcp:
> > 21
> > 57
> > 79
> > 80
> > 111
> > 135
> > 137
> > 138
> > 139
> > 443
> > 445
> > 1025
> > 1026
> > 1433
> > 5000
> > 31337
> >
> > These will vary depending on your particular software usage and such - but
> > are a good start.
> >
> > <EOL>
> > Tib
> >
> > On Sat, 11 Jun 2005, Billie Joe wrote:
> >
> > > Hi!
> > >
> > >
> > > I have 3 IPs on Internet, and I want to put them behind my firewall
> > > machine. So I have the question: Put all 3 IPs in the same network
> > > card (with alias) or a card for each IP ?? What you suggest and why ??
> > > Thanks
> > >
> > >
> > > pS.: Consider that I have another NIC for my LAN.
> > >
> > >
> > > BillieGDJoe
> > >
> >
>

Re: Hi!

[Ian Laurie]

On 06/12/2005 04:22:52 AM, Tib wrote:
> 
> Caveat to what I just said - if you are doing masquerading behind a single
> IP, then you don't need to worry about the FORWARD ruleset. Only packets
> associated with connections  that are being masqueraded will get sent on
> to internal networks - unless you have specific ports that are translated
> to internal services.
> 
> <EOL>
> Tib

Actually that isn't quite correct.  With ip_forward on, network bridging is 
enabled. Running NAT does not disable the bridging function.  If a box on the 
outside port sends a packet addressed to a box on the inside port, using the 
firewall as its gateway, the packet will get through NAT.  NAT runs on top 
of the bridging function, so bridging still works, though only in one direction
since in the other direction packets will get NATed.

You need to specifically use rules in the firewall to stop unsolicited
packets from getting through, like ESTABLISHED/RELATED etc.

The idea that running NAT disables bridging is a common and dangerous
misconception.  Showing this isn't so is a simple experiment, and one
I have done many times to the astonishment of onlookers.

You can block packets addressed to the inside of a firewall by a rule in
your PREROUTING chain like so:

-A PREROUTING -i eth0 -d 10.1.1.0/24 -j DROP

Where 10.1.1.* is the inside range and eth0 is the outside port.  Basically
this DROPs anything appearing on the outside interface addressed to
something on the inside interface.

Technically though this rule is unnecessary if the rest of your firewall
is set up right, since you would ordinarily be using rules to ensure that
only response packets get back through the FORWARD chain.  For example:

-A FWD_INBOUND_TCPUDP -m state --state RELATED,ESTABLISHED -j ACCEPT

Ian

PS - Another misconception some have is that setting rp_filter stops this,
it doesn't, since rp_filter works on a packet's source IP, not destination
IP.  However, I for one would be in favor of another kernel flag that
*would* work on the destination IP.

Re: Hi!

[Tib]

> > Caveat to what I just said - if you are doing masquerading behind a single
> > IP, then you don't need to worry about the FORWARD ruleset. Only packets
> > associated with connections  that are being masqueraded will get sent on
> > to internal networks - unless you have specific ports that are translated
> > to internal services.
>
> Actually that isn't quite correct.  With ip_forward on, network bridging is
> enabled. Running NAT does not disable the bridging function.  If a box on the
> outside port sends a packet addressed to a box on the inside port, using the
> firewall as its gateway, the packet will get through NAT.  NAT runs on top
> of the bridging function, so bridging still works, though only in one direction
> since in the other direction packets will get NATed.

Actually, it is 100% correct. Masquerading is a broad spectrum SNAT that
will redirect return traffic associated with whatever it sends out back to
the originating internal host. So if some new connection comes in to the
external IP that isn't associated with any outbound connection, it hits
the firewall and falls flat - this is why modules like ip_conntrack_ftp
and ip_nat_ftp are necessary, and why dcc on irc clients tends to get
borked, the list goes on.

If he's running two real world ip's connected behind a firewall real world
ip - that's not masquerading, and that /would/ require a defensive
forward ruleset as the firewall itself is not accepting packets but
forwarding them to another host. Using snat/dnat the way I specified is
effectively the same, but allows there to be a private network behind the
firewall that can have as many hosts or other things as it wants without
having to deal with the constraints of getting more IP's from an isp.

Also - normal traffic from the outside world isn't going to be getting
sent directly to an inside private IP. If ANY sort of nat is going on, how
on earth are they going to know which private IP to send to? Such traffic
is only going to be used as a disruptive tactic on the firewall connection
itself. That's the whole point of private network blocks - NON-ROUTABLE.
To even get sent to the firewall from the outside interface you'd have to
have one of two situations:

1. A legitimate host on the same physical network as the firewall's
outside interface, using said outside interface as a gateway, and sending
traffic to those private ip's.

2. A mangled packet attack of some sort where the external interface is
bombarded with traffic that should be impossible considering that private
network addresses are non-routable.

For broadband homeusers, option 1 is going to not exist since customers
are either directly on the net with a real IP thanks to a dsl/cable modem
that bridges the connection and doesn't have its own IP, or who have a
dsl/cable router that gets it's own IP, runs a dhcp client to the inside
where the end-user gets an IP and from there gets masqueraded out behind
the IP of the router.

Option 2 however is a reality but a relatively low one because that sort
of traffic does not happen to your every day small network dsl user. I
recently had to deal with such an attack - 22Mb/s of traffic that should
not be possible slammed my external interface. Yup - one simple rule made
it all go away, but the point is that in 6 years of running said style
network, that's the only time I've encountered such traffic.

<EOL>
Tib

Re: Hi!

[Ian Laurie]

On 06/13/2005 10:26:35 AM, Tib wrote:
> > > Caveat to what I just said - if you are doing masquerading behind a 
> single
> > > IP, then you don't need to worry about the FORWARD ruleset. Only packets
> > > associated with connections  that are being masqueraded will get sent on
> > > to internal networks - unless you have specific ports that are 
> translated
> > > to internal services.
> >
> > Actually that isn't quite correct.  With ip_forward on, network bridging 
> is
> > enabled. Running NAT does not disable the bridging function.  If a box on 
> the
> > outside port sends a packet addressed to a box on the inside port, using 
> the
> > firewall as its gateway, the packet will get through NAT.  NAT runs on top
> > of the bridging function, so bridging still works, though only in one 
> direction
> > since in the other direction packets will get NATed.
> 
> Actually, it is 100% correct. Masquerading is a broad spectrum SNAT that
> will redirect return traffic associated with whatever it sends out back to
> the originating internal host. So if some new connection comes in to the
> external IP that isn't associated with any outbound connection, it hits
> the firewall and falls flat - this is why modules like ip_conntrack_ftp
> and ip_nat_ftp are necessary, and why dcc on irc clients tends to get
> borked, the list goes on.

Hi Tib,

We *may* be speaking at cross purposes.  I agree with what you have said but
I am also correct.  The issue is your statement "hits the firewall and falls 
flat".

Your original paragraph doesn't make it clear to a beginner that you are
pre-supposing that there is a real firewall in place that will enforce NAT.

My point, that is also 100% correct, is that having a NAT rule alone does not 
disable the bridging function.

The reality is that a lot of beginners "assume" that when they have NAT, their
internal addresses are unreachable from the outside and that simply isn't
the case with NAT alone (at least not with iptables under Linux).

That was the point I was making.  
As for the rest of your post, you are forgetting the wider purpose of routers/
firewalls.  For example, inside a company where you may have the
R&D department on one private address space, finance on another, etc., all 
isolated with routers.  In this scenario (which I work in) all you need to do 
is use the "route" command to tell your machine where to send packets, and 
suddenly private IP addresses are routable and *will* make it to the
firewall.  Further, you can specifically allow certain machines (like mine)
to get through..... despite NAT in operation for all other packets.

That is, I can ssh etc. into boxes that sit behind NAT.  I just wanted to make 
the point that NAT alone doesn't prevent this, which wasn't obvious from your 
post.

Ian

Re: Hi!

[Tib]

On Mon, 13 Jun 2005, Ian Laurie wrote:
> We *may* be speaking at cross purposes.  I agree with what you have said but
> I am also correct.  The issue is your statement "hits the firewall and falls
> flat".
>
> Your original paragraph doesn't make it clear to a beginner that you are
> pre-supposing that there is a real firewall in place that will enforce NAT.
>
> My point, that is also 100% correct, is that having a NAT rule alone does
> not disable the bridging function.
>
> The reality is that a lot of beginners "assume" that when they have NAT, their
> internal addresses are unreachable from the outside and that simply isn't
> the case with NAT alone (at least not with iptables under Linux).
>
> That was the point I was making.

The original question was regarding a person with 3 ip's and the best way
to make use of them on a network with a gateway host and two other hosts
that would be behind it.

I would be curious to hear how you can communicate to internal networks
from across the internet without knowledge of the ip-block being used on
said network behind a masqueraded host, and without the gateway/firewall
box using iptables being explicitly instructed to route traffic that it
receives on an external interface to the internal network - and have it
get back out properly. I have never known or seen such a thing to be
possible.

> As for the rest of your post, you are forgetting the wider purpose of
> routers/firewalls.  For example, inside a company where you may have the
> R&D department on one private address space, finance on another, etc., all
> isolated with routers.  In this scenario (which I work in) all you need to do
> is use the "route" command to tell your machine where to send packets, and
> suddenly private IP addresses are routable and *will* make it to the
> firewall.  Further, you can specifically allow certain machines (like mine)
> to get through..... despite NAT in operation for all other packets.
>
> That is, I can ssh etc. into boxes that sit behind NAT.  I just wanted to
> make the point that NAT alone doesn't prevent this, which wasn't obvious
> from your post.

But see - your work network (and mine as well) is designed explicitly to
enable traffic like that to flow between different physical segments. But
as we both just said - those are work networks that are designed with
dozens if not hudreds or thousands of hosts involved, and typically it is
the nat that specificly enables such things to happen. And again - anyone
without specific knowledge to the architecture of the system is going to
be guessing in the dark and have little to no chance of initiating proper
communication, forcing them to resort to disruption tactics like I
mentioned in situation #2 previously.

The general internet at large is not designed to route or respond to
private network traffic, if it did things would be very messy indeed on
the net.

So while such things /are/ possible in specific, explicit, application -
for the general newbie end-user as you put it, the setup I defined being
short, simple, and uncomplicated is going to both service and protect the
hosts involved as well as provide maximum flexibility for those hosts as
well.

I don't think we're talking at cross purposes really. We're both on target
but just in different frames of reference for the practical application of
networking involved.

<EOL>
Tib

Hi!!

[Alberto Rossi]

Hi to all!
I'm Alberto, 17 yo, from Italy... I'm actually working on Toshiba ACPI Driver
improvements to make it works with my Toshiba Satellite A60 (currently not
supported). If anyone of you would like to help, just contact me!

Bye bye, Alberto
--
Registered Linux User n.° 324313
MSN ID: wafer_overflow-PkbjNfxxIARBDgjK7y7TUQ@public.gmane.org
"Sazio è colui cui il bastante è bastevole."
		(Lao-Tsé)


-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
a projector? How fast can you ride your desk chair down the office luge track?
If you want to score the big prize, get to know the little guy.
Play to win an NEC 61" plasma display: http://www.necitguy.com/?r 

Hi!

[venkata ramesh]

Hi!
I am developing driver for MPC8260 for MCC.
After issuing reset command, there is space
for intrrupt table but flag is generated
for interrupt queue is overflow.
Can u suggest me how to solve the problem ??


Thanks.

Regards,
RAMESH



		
Yahoo! Mail
Stay connected, organized, and protected. Take the tour:
http://tour.mail.yahoo.com/mailtour.html

Hi!

[naroth-qDHaf3XTt0D7Za/I2yyZNw]

[-- Attachment #1: Type: text/html, Size: 501 bytes --]

Hi!

[Ferenc Kiraly]

	Hi!

I have a reiserfs root (/) partition where the first 5 blocks went bad.
I need to recover as much as possible from that partition. Is
it possible? And if so, how should I go about it?

I have tried reiserfsck with the --rebuild-sb and --rebuild-tree 
options, with no luck.

Thank you,

	feri.

Re: Hi!

[Dieter Nützel]

Am Montag, 14. Juli 2003 20:33 schrieb Ferenc Kiraly:
> 	Hi!
>
> I have a reiserfs root (/) partition where the first 5 blocks went bad.
> I need to recover as much as possible from that partition. Is
> it possible? And if so, how should I go about it?
>
> I have tried reiserfsck with the --rebuild-sb and --rebuild-tree
> options, with no luck.

Start with SuSE's "dd_rescue".

Then rebuild your FS (reiserfsck).

Good luck!

-Dieter

Hi!

[Olga Georgieva]

Hi! Excuse me for my reference to you, I simply do not have other output from my
problem. My child dies, at him a heart disease and to him operation is urgently necessary,
but I do not have money for this operation. Please, help me though something. I shall be
glad even to the small sum of money, you see it will help to rescue life of my son. I hope
that with your help I shall collect the necessary sum of money. Beforehand to you it is
grateful!

Olga Georgieva

If you have decided to help me, let the smallest money, transfer them to my purse in
payment system WEBMONEY

Purse Z 207698943068

Once again excuse me, I hope you understand my emotional condition.

Hi!

[Sebastien Articlaux]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=us-ascii, Size: 1150 bytes --]


Hello Wolfgang,

My last e-mails on the mailing list wasn't very
constructive...I'm agree!
So,I've made some research to inform me on the process
of creating a ramdisk.
I've learned a lot of things and now I know the good
questions to ask!

Ok, tell me if I'm wrong!
Normally there is two ramdisk, the init ramdisk and an
other,bigger wich contain the complete system.
and this is linuxrc in the initramdisk wich mount the
real ramdisk, right?
But for us,we just use the initramdisk "as ramdisk"...
It's a minimal file system but to begin it's ok,
right?
So now I'm trying to create a good initramdisk.
I've put the patch for SASH in source, but I must have
to recompile SASH (that's what I understand when I
look into your CDK files)
Where can I found the source of SASH if I must
recompile it?
Then do I must put it in /bin/sash in my initrd and
make a link?
ln -s sash sh  to have /bin/sh -> sash  ?
And need I have to create a linuxrc if I have just the
initrd? if yes, what must I put in it because I don't
understand.

Thanks you for your help

Sébastien ARTICLAUX


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

Re: Hi!

[Wolfgang Denk]

Dear Sébastien,

in message <20000314141913.16859.qmail@web219.mail.yahoo.com> you wrote:
>
> Normally there is two ramdisk, the init ramdisk and an
> other,bigger wich contain the complete system.
> and this is linuxrc in the initramdisk wich mount the
> real ramdisk, right?

No. Ususally you have only one ramdisk, if any.


If you have a "normal" bootdevice (like harddisk, or the  network  in
case of a NFS-mounted root filesystem) there is little need to have a
initrd  -  except to perform actions necessary to be performed before
you can access the root device. Probing the hardware and loading  the
modules  which  necessary  to  access  the  device  on whith the root
filesystem is the typical example when you want to run one  of  these
initrd  configurations.  The  "initrc" script is the place whwere you
can put such actions.

The other case is when you don't have  a  regular  boot  device,  for
instance  in  an  embedded  system with normal FLASH memory ("normal"
means that from the system point of view it's just a ROM device  with
a  linear  layout  -  as ooposed to something simulating a disk drive
like the DiskOnChip  systems  and  others  do).  Here  you  have  two
options:  you can implement a ROMFS driver for your flash memory, and
write a boot loader that boots from the ROMFS. Or  you  can  write  a
boot  loader  that  loads just one "image" and starts it; the "image"
would contain a (compressed) Linux kernel,  and  a  (compressed)  ram
disk  image.  The  boot  loader  will  uncompress and start the Linux
kernel, and the Linux kernel will detect and uncompress the initrd  -
and mount it as it's root filesystem. You can imagine that the second
approach  is  usually  much  simpler,  especially  since many systems
already have some type of boot loader to load and start an "image".

That's why the second method is often used in embedded  systems:  you
just  p[ack  everything  you  need  in  your root filesystem into one
ramdisk image, and  mount  this  as  initrd.  You  will  never  mount
another, "real" root filesystem in this case.

> But for us,we just use the initramdisk "as ramdisk"...
> It's a minimal file system but to begin it's ok,
> right?

Minimal in the sense that it has to fit into your local FLASH memory.
But of course it will have to contain all you  application  code  and
ata  files you need for normal system operation. [Or you will have to
mount anther "data storage" device once you're up and running.]

> So now I'm trying to create a good initramdisk.
> I've put the patch for SASH in source, but I must have
> to recompile SASH (that's what I understand when I
> look into your CDK files)

If you want to use SASH you  will  need  a  binary,  right.  SASH  is
probably  a good start to get things working. Later, you might decide
to directly start your application code without any  shell  or  other
Linux tools available any more in your ramdisk image.

> Where can I found the source of SASH if I must
> recompile it?

I just took the source (sash-2.1-4.src.rpm) from one of  the  generic
LinuxPPC  releases  (LinuxPPC  1999 Q3 in my case). Just use a search
engine...

You're in France, so one of the following might be near you:
ftp://ftp.medasys-digital-systems.fr/pub0/linux/parisc/src/sash-2.1-hpux.tar.gz

ftp://ftp.lip6.fr/pub2/linux/distributions/debian/dists/slink/main/source/shells/sash_2.1.orig.tar.gz
ftp://ftp.pasteur.fr/pub/computing/linux/debian/dists/slink/main/source/shells/sash_2.1.orig.tar.gz
ftp://ftp.ath.cena.fr/debian/dists/slink/main/source/shells/sash_2.1.orig.tar.gz
ftp://ftp.fdn.fr/.pub2/debian/dists/slink/main/source/shells/sash_2.1.orig.tar.gz
ftp://ftp.u-picardie.fr/mirror/linux/debian/dists/slink/main/source/shells/sash_2.1.orig.tar.gz

> Then do I must put it in /bin/sash in my initrd and
> make a link?
> ln -s sash sh  to have /bin/sh -> sash  ?

...or you can rename SASH iinto /bin/sh, or configure the  kernel  to
start /bin/sash - whatever you like.

> And need I have to create a linuxrc if I have just the
> initrd? if yes, what must I put in it because I don't
> understand.

You don't need a linuxrc script.


Wolfgang Denk

--
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd@denx.de
Perfection is reached, not when there is no longer anything  to  add,
but when there is no longer anything to take away.
                                           - Antoine de Saint-Exupery

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/