All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: Chen-Yu Tsai <wens@kernel.org>,
	Maxime Ripard <mripard@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	"B.R. Oake" <broake@mailfence.com>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@googlegroups.com, devicetree@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: sun8i: h3: orangepi-plus: Fix Ethernet PHY mode
Date: Mon, 08 Feb 2021 12:27:45 +0100	[thread overview]
Message-ID: <2006991.bPDHmd0WOD@kista> (raw)
In-Reply-To: <1243888060.510560.1612783497400@ichabod.co-bxl>

Dne ponedeljek, 08. februar 2021 ob 12:24:57 CET je B.R. Oake napisal(a):
> Since commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx
> delay config"), Ethernet no longer works on the Orange Pi Plus,
> because that commit sets the RX/TX delay according to the phy-mode
> property in the device tree, which is "rgmii", the wrong setting
> for this board.
> 
> Following the example of others who fixed the same problem for
> many other boards, this patch changes the phy-mode to "rgmii-id"
> which gets Ethernet working again on this board.
> 
> Fixes: 4904337fe34f ("ARM: dts: sunxi: Restore EMAC changes (boards)")
> Fixes: 1dcd0095019a ("ARM: sun8i: orangepi-plus: Enable dwmac-sun8i")
> Signed-off-by: B.R. Oake <broake@mailfence.com>
> ---
>  arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Jernej Skrabec <jernej.skrabec@siol.net>

Thanks!

Best regards,
Jernej

> diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts b/arch/arm/boot/
dts/sun8i-h3-orangepi-plus.dts
> index 97f497854e..d05fa679dc 100644
> --- a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts
> @@ -85,7 +85,7 @@
>  	pinctrl-0 = <&emac_rgmii_pins>;
>  	phy-supply = <&reg_gmac_3v3>;
>  	phy-handle = <&ext_rgmii_phy>;
> -	phy-mode = "rgmii";
> +	phy-mode = "rgmii-id";
>  
>  	status = "okay";
>  };
> -- 
> 2.20.1
> 
> 



WARNING: multiple messages have this Message-ID (diff)
From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: Chen-Yu Tsai <wens@kernel.org>,
	Maxime Ripard <mripard@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	"B.R. Oake" <broake@mailfence.com>
Cc: devicetree@vger.kernel.org, linux-sunxi@googlegroups.com,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: sun8i: h3: orangepi-plus: Fix Ethernet PHY mode
Date: Mon, 08 Feb 2021 12:27:45 +0100	[thread overview]
Message-ID: <2006991.bPDHmd0WOD@kista> (raw)
In-Reply-To: <1243888060.510560.1612783497400@ichabod.co-bxl>

Dne ponedeljek, 08. februar 2021 ob 12:24:57 CET je B.R. Oake napisal(a):
> Since commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx
> delay config"), Ethernet no longer works on the Orange Pi Plus,
> because that commit sets the RX/TX delay according to the phy-mode
> property in the device tree, which is "rgmii", the wrong setting
> for this board.
> 
> Following the example of others who fixed the same problem for
> many other boards, this patch changes the phy-mode to "rgmii-id"
> which gets Ethernet working again on this board.
> 
> Fixes: 4904337fe34f ("ARM: dts: sunxi: Restore EMAC changes (boards)")
> Fixes: 1dcd0095019a ("ARM: sun8i: orangepi-plus: Enable dwmac-sun8i")
> Signed-off-by: B.R. Oake <broake@mailfence.com>
> ---
>  arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Jernej Skrabec <jernej.skrabec@siol.net>

Thanks!

Best regards,
Jernej

> diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts b/arch/arm/boot/
dts/sun8i-h3-orangepi-plus.dts
> index 97f497854e..d05fa679dc 100644
> --- a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts
> @@ -85,7 +85,7 @@
>  	pinctrl-0 = <&emac_rgmii_pins>;
>  	phy-supply = <&reg_gmac_3v3>;
>  	phy-handle = <&ext_rgmii_phy>;
> -	phy-mode = "rgmii";
> +	phy-mode = "rgmii-id";
>  
>  	status = "okay";
>  };
> -- 
> 2.20.1
> 
> 



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-02-08 11:50 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-08 11:24 [PATCH] ARM: dts: sun8i: h3: orangepi-plus: Fix Ethernet PHY mode B.R. Oake
2021-02-08 11:24 ` B.R. Oake
2021-02-08 11:27 ` Jernej Škrabec [this message]
2021-02-08 11:27   ` Jernej Škrabec
2021-02-10 15:01 ` Maxime Ripard
2021-02-10 15:01   ` Maxime Ripard
2021-02-13  6:51   ` B.R. Oake
2021-02-13  6:51     ` B.R. Oake
2021-02-13  8:51     ` Jernej Škrabec
2021-02-13  8:51       ` Jernej Škrabec
2021-05-16 16:58       ` Salvatore Bonaccorso
2021-05-16 16:58         ` Salvatore Bonaccorso
2021-05-16 20:18         ` Vagrant Cascadian
2021-05-16 20:18           ` Vagrant Cascadian
2021-05-18 15:06           ` Maxime Ripard
2021-05-18 15:06             ` Maxime Ripard
2021-05-18 20:25             ` Salvatore Bonaccorso
2021-05-18 20:25               ` Salvatore Bonaccorso
2021-05-18 20:43               ` Salvatore Bonaccorso
2021-05-18 20:43                 ` Salvatore Bonaccorso
2021-05-20 18:24                 ` Vagrant Cascadian
2021-05-20 18:24                   ` Vagrant Cascadian
2021-05-20 18:50                   ` Salvatore Bonaccorso
2021-05-20 18:50                     ` Salvatore Bonaccorso
2021-05-24 11:55                     ` Maxime Ripard
2021-05-24 11:55                       ` Maxime Ripard
2021-05-24 12:26                       ` Salvatore Bonaccorso
2021-05-24 12:26                         ` Salvatore Bonaccorso
2021-06-04  4:19       ` B.R. Oake
2021-06-04  4:19         ` B.R. Oake
2021-06-04  6:49         ` [linux-sunxi] " Julian Calaby
2021-06-04  6:49           ` Julian Calaby
2021-07-05  0:18           ` B.R. Oake
2021-07-05  0:18             ` B.R. Oake
2021-07-05  0:48             ` Julian Calaby
2021-07-05  0:48               ` Julian Calaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2006991.bPDHmd0WOD@kista \
    --to=jernej.skrabec@siol.net \
    --cc=broake@mailfence.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=mripard@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.