All of lore.kernel.org
 help / color / mirror / Atom feed
* + add-delay-around-sl82c105_reset_engine-calls.patch added to -mm tree
@ 2007-02-13  5:38 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2007-02-13  5:38 UTC (permalink / raw)
  To: mm-commits; +Cc: olaf


The patch titled
     add delay around sl82c105_reset_engine calls
has been added to the -mm tree.  Its filename is
     add-delay-around-sl82c105_reset_engine-calls.patch

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

------------------------------------------------------
Subject: add delay around sl82c105_reset_engine calls
From: Olaf Hering <olaf@aepfle.de>

The hald media changed polling does really confuse things.  Noone knows why
the delays are needed, but they give us access to the CD.

An udelay(50) will give reliable access to the drive, but there is still one
(or more) EH reset.  The drive works without EH resets with udelay(100).

Signed-off-by: Olaf Hering <olaf@aepfle.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/ata/pata_sl82c105.c |    3 +++
 1 file changed, 3 insertions(+)

diff -puN drivers/ata/pata_sl82c105.c~add-delay-around-sl82c105_reset_engine-calls drivers/ata/pata_sl82c105.c
--- a/drivers/ata/pata_sl82c105.c~add-delay-around-sl82c105_reset_engine-calls
+++ a/drivers/ata/pata_sl82c105.c
@@ -187,7 +187,9 @@ static void sl82c105_bmdma_start(struct 
 {
 	struct ata_port *ap = qc->ap;
 
+	udelay(100);
 	sl82c105_reset_engine(ap);
+	udelay(100);
 
 	/* Set the clocks for DMA */
 	sl82c105_configure_dmamode(ap, qc->dev);
@@ -216,6 +218,7 @@ static void sl82c105_bmdma_stop(struct a
 
 	ata_bmdma_stop(qc);
 	sl82c105_reset_engine(ap);
+	udelay(100);
 
 	/* This will redo the initial setup of the DMA device to matching
 	   PIO timings */
_

Patches currently in -mm which might be from olaf@aepfle.de are

origin.patch
move-variables-in-drivers-macintosh-to-bss.patch
add-delay-around-sl82c105_reset_engine-calls.patch
cleanup-variable-usage-in-mesh-interrupt-handler.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-02-13  5:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-13  5:38 + add-delay-around-sl82c105_reset_engine-calls.patch added to -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.