All of lore.kernel.org
 help / color / mirror / Atom feed
* x86_64: fix 2.6.18 regression - PTRACE_OLDSETOPTIONS should be accepted
@ 2007-02-15  2:34 ` Paolo 'Blaisorblade' Giarrusso
  0 siblings, 0 replies; 18+ messages in thread
From: Paolo 'Blaisorblade' Giarrusso @ 2007-02-15  2:34 UTC (permalink / raw)
  To: Andrew Morton, stable
  Cc: Andi Kleen, Jeff Dike, linux-kernel, user-mode-linux-devel

Also PTRACE_OLDSETOPTIONS should be accepted, as done by kernel/ptrace.c and
forced by binary compatibility. UML/32bit breaks because of this - since it is wise
enough to use PTRACE_OLDSETOPTIONS to be binary compatible with 2.4 host
kernels.

Until 2.6.17 (commit f0f2d6536e3515b5b1b7ae97dc8f176860c8c2ce) we had:

       default:
                return sys_ptrace(request, pid, addr, data);

Instead here we have:
        case PTRACE_GET_THREAD_AREA:
	case ...:
                return sys_ptrace(request, pid, addr, data);

        default:
                return -EINVAL;

This change was a style change - when a case is added, it must be explicitly
tested this way. In this case, not enough testing was done.

Cc: Andi Kleen <ak@suse.de>
Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Index: linux-2.6.git/arch/x86_64/ia32/ptrace32.c
===================================================================
--- linux-2.6.git.orig/arch/x86_64/ia32/ptrace32.c
+++ linux-2.6.git/arch/x86_64/ia32/ptrace32.c
@@ -246,6 +246,7 @@ asmlinkage long sys32_ptrace(long reques
 	case PTRACE_SINGLESTEP:
 	case PTRACE_DETACH:
 	case PTRACE_SYSCALL:
+	case PTRACE_OLDSETOPTIONS:
 	case PTRACE_SETOPTIONS:
 	case PTRACE_SET_THREAD_AREA:
 	case PTRACE_GET_THREAD_AREA:

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2007-02-17  0:46 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-15  2:34 x86_64: fix 2.6.18 regression - PTRACE_OLDSETOPTIONS should be accepted Paolo 'Blaisorblade' Giarrusso
2007-02-15  2:34 ` [uml-devel] " Paolo 'Blaisorblade' Giarrusso
2007-02-15  2:54 ` Jeff Dike
2007-02-15  2:54   ` [uml-devel] " Jeff Dike
2007-02-15  3:43   ` Blaisorblade
2007-02-15  3:43     ` Blaisorblade
2007-02-15  5:51     ` Andrew Morton
2007-02-15  5:51       ` Andrew Morton
2007-02-15 17:01       ` Jeff Dike
2007-02-15 17:01         ` Jeff Dike
2007-02-15 19:05         ` Blaisorblade
2007-02-15 19:05           ` Blaisorblade
2007-02-16 19:02           ` Jeff Dike
2007-02-16 19:02             ` Jeff Dike
2007-02-17  0:04             ` Blaisorblade
2007-02-17  0:04               ` Blaisorblade
2007-02-17  0:38               ` Jeff Dike
2007-02-17  0:38                 ` Jeff Dike

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.