From: Anton Vorontsov <avorontsov@ru.mvista.com> To: Olof Johansson <olof@lixom.net> Cc: linuxppc-dev@ozlabs.org, linux-ide@vger.kernel.org, Jeff Garzik <jeff@garzik.org>, Arnd Bergmann <arnd@arndb.de>, Paul Mundt <lethal@linux-sh.org> Subject: Re: [PATCH v2 3/4] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes Date: Tue, 4 Dec 2007 22:45:31 +0300 [thread overview] Message-ID: <20071204194531.GA1253@localhost.localdomain> (raw) In-Reply-To: <20071204191657.GB5758@lixom.net> On Tue, Dec 04, 2007 at 01:16:57PM -0600, Olof Johansson wrote: > Hi, > > On Tue, Dec 04, 2007 at 08:07:26PM +0300, Anton Vorontsov wrote: > > diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/boot/dts/mpc8349emitx.dts > > index 5072f6d..c459b0a 100644 [...] > > +static struct of_device_id mpc834x_itx_ids[] = { > > + { .name = "localbus", }, > > + {}, > > +}; > > Please add the "compatible" field here (fsl,pq2pro-localbus should do > just fine), instead of the name. Done, thanks. - - - - From: Anton Vorontsov <avorontsov@ru.mvista.com> Subject: [PATCH v2.1] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes This patch adds localbus and pata nodes to use CF IDE interface on MPC8349E-mITX boards. Patch also adds code to probe localbus. Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> --- arch/powerpc/boot/dts/mpc8349emitx.dts | 18 +++++++++++++++++- arch/powerpc/platforms/83xx/mpc834x_itx.c | 17 +++++++++++++++++ 2 files changed, 34 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/boot/dts/mpc8349emitx.dts index 5072f6d..c459b0a 100644 --- a/arch/powerpc/boot/dts/mpc8349emitx.dts +++ b/arch/powerpc/boot/dts/mpc8349emitx.dts @@ -249,6 +249,22 @@ device_type = "pci"; }; + localbus@e0005000 { + #address-cells = <2>; + #size-cells = <1>; + compatible = "fsl,mpc8349emitx-localbus", + "fsl,mpc8349e-localbus", + "fsl,pq2pro-localbus"; + reg = <e0005000 d8>; + ranges = <3 0 f0000000 210>; - + pata@3,0 { + compatible = "fsl,mpc8349emitx-pata", "ata-generic"; + reg = <3 0 10 3 20c 4>; + reg-shift = <1>; + pio-mode = <6>; + interrupts = <17 8>; + interrupt-parent = <&ipic>; + }; + }; }; diff --git a/arch/powerpc/platforms/83xx/mpc834x_itx.c b/arch/powerpc/platforms/83xx/mpc834x_itx.c index aa76819..4797850 100644 --- a/arch/powerpc/platforms/83xx/mpc834x_itx.c +++ b/arch/powerpc/platforms/83xx/mpc834x_itx.c @@ -23,6 +23,7 @@ #include <linux/delay.h> #include <linux/seq_file.h> #include <linux/root_dev.h> +#include <linux/of_platform.h> #include <asm/system.h> #include <asm/atomic.h> @@ -37,6 +38,22 @@ #include "mpc83xx.h" +static struct of_device_id mpc834x_itx_ids[] = { + { .compatible = "fsl,pq2pro-localbus", }, + {}, +}; + +static int __init mpc834x_itx_declare_of_platform_devices(void) +{ + if (!machine_is(mpc834x_itx)) + return 0; + + of_platform_bus_probe(NULL, mpc834x_itx_ids, NULL); + + return 0; +} +device_initcall(mpc834x_itx_declare_of_platform_devices); + /* ************************************************************************ * * Setup the architecture -- 1.5.2.2
WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <avorontsov@ru.mvista.com> To: Olof Johansson <olof@lixom.net> Cc: linuxppc-dev@ozlabs.org, Paul Mundt <lethal@linux-sh.org>, Arnd Bergmann <arnd@arndb.de>, Jeff Garzik <jeff@garzik.org>, linux-ide@vger.kernel.org Subject: Re: [PATCH v2 3/4] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes Date: Tue, 4 Dec 2007 22:45:31 +0300 [thread overview] Message-ID: <20071204194531.GA1253@localhost.localdomain> (raw) In-Reply-To: <20071204191657.GB5758@lixom.net> On Tue, Dec 04, 2007 at 01:16:57PM -0600, Olof Johansson wrote: > Hi, > > On Tue, Dec 04, 2007 at 08:07:26PM +0300, Anton Vorontsov wrote: > > diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/boot/dts/mpc8349emitx.dts > > index 5072f6d..c459b0a 100644 [...] > > +static struct of_device_id mpc834x_itx_ids[] = { > > + { .name = "localbus", }, > > + {}, > > +}; > > Please add the "compatible" field here (fsl,pq2pro-localbus should do > just fine), instead of the name. Done, thanks. - - - - From: Anton Vorontsov <avorontsov@ru.mvista.com> Subject: [PATCH v2.1] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes This patch adds localbus and pata nodes to use CF IDE interface on MPC8349E-mITX boards. Patch also adds code to probe localbus. Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> --- arch/powerpc/boot/dts/mpc8349emitx.dts | 18 +++++++++++++++++- arch/powerpc/platforms/83xx/mpc834x_itx.c | 17 +++++++++++++++++ 2 files changed, 34 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/boot/dts/mpc8349emitx.dts index 5072f6d..c459b0a 100644 --- a/arch/powerpc/boot/dts/mpc8349emitx.dts +++ b/arch/powerpc/boot/dts/mpc8349emitx.dts @@ -249,6 +249,22 @@ device_type = "pci"; }; + localbus@e0005000 { + #address-cells = <2>; + #size-cells = <1>; + compatible = "fsl,mpc8349emitx-localbus", + "fsl,mpc8349e-localbus", + "fsl,pq2pro-localbus"; + reg = <e0005000 d8>; + ranges = <3 0 f0000000 210>; - + pata@3,0 { + compatible = "fsl,mpc8349emitx-pata", "ata-generic"; + reg = <3 0 10 3 20c 4>; + reg-shift = <1>; + pio-mode = <6>; + interrupts = <17 8>; + interrupt-parent = <&ipic>; + }; + }; }; diff --git a/arch/powerpc/platforms/83xx/mpc834x_itx.c b/arch/powerpc/platforms/83xx/mpc834x_itx.c index aa76819..4797850 100644 --- a/arch/powerpc/platforms/83xx/mpc834x_itx.c +++ b/arch/powerpc/platforms/83xx/mpc834x_itx.c @@ -23,6 +23,7 @@ #include <linux/delay.h> #include <linux/seq_file.h> #include <linux/root_dev.h> +#include <linux/of_platform.h> #include <asm/system.h> #include <asm/atomic.h> @@ -37,6 +38,22 @@ #include "mpc83xx.h" +static struct of_device_id mpc834x_itx_ids[] = { + { .compatible = "fsl,pq2pro-localbus", }, + {}, +}; + +static int __init mpc834x_itx_declare_of_platform_devices(void) +{ + if (!machine_is(mpc834x_itx)) + return 0; + + of_platform_bus_probe(NULL, mpc834x_itx_ids, NULL); + + return 0; +} +device_initcall(mpc834x_itx_declare_of_platform_devices); + /* ************************************************************************ * * Setup the architecture -- 1.5.2.2
next prev parent reply other threads:[~2007-12-04 19:41 UTC|newest] Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-12-04 17:04 [PATCH v2 0/4] OF-platform PATA driver Anton Vorontsov 2007-12-04 17:04 ` Anton Vorontsov 2007-12-04 17:06 ` [PATCH v2 1/4] [libata] pata_platform: make probe and remove functions device type neutral Anton Vorontsov 2007-12-04 17:06 ` Anton Vorontsov 2007-12-04 20:40 ` Olof Johansson 2007-12-04 20:40 ` Olof Johansson 2007-12-05 15:37 ` Anton Vorontsov 2007-12-05 15:37 ` Anton Vorontsov 2007-12-04 17:07 ` [PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver Anton Vorontsov 2007-12-04 17:07 ` Anton Vorontsov 2007-12-04 18:48 ` Olof Johansson 2007-12-04 18:48 ` Olof Johansson 2007-12-04 19:49 ` Anton Vorontsov 2007-12-04 19:49 ` Anton Vorontsov 2007-12-04 20:01 ` Olof Johansson 2007-12-04 20:01 ` Olof Johansson 2007-12-04 20:37 ` Anton Vorontsov 2007-12-04 20:37 ` Anton Vorontsov 2007-12-04 20:39 ` Olof Johansson 2007-12-04 20:39 ` Olof Johansson 2007-12-05 0:48 ` Paul Mundt 2007-12-05 0:48 ` Paul Mundt 2007-12-05 3:26 ` Olof Johansson 2007-12-05 3:26 ` Olof Johansson 2007-12-05 18:39 ` Scott Wood 2007-12-05 18:39 ` Scott Wood 2007-12-14 8:23 ` Olof Johansson 2007-12-14 8:23 ` Olof Johansson 2007-12-14 16:09 ` Scott Wood 2007-12-14 16:09 ` Scott Wood 2007-12-14 16:33 ` Olof Johansson 2007-12-14 16:33 ` Olof Johansson 2007-12-04 17:07 ` [PATCH v2 3/4] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes Anton Vorontsov 2007-12-04 17:07 ` Anton Vorontsov 2007-12-04 19:16 ` Olof Johansson 2007-12-04 19:16 ` Olof Johansson 2007-12-04 19:23 ` Scott Wood 2007-12-04 19:45 ` Anton Vorontsov [this message] 2007-12-04 19:45 ` Anton Vorontsov 2007-12-04 20:40 ` Olof Johansson 2007-12-04 20:40 ` Olof Johansson 2007-12-04 17:07 ` [PATCH v2 4/4] [libata] pata_platform: s/ioport_shift/reg_shift/g Anton Vorontsov 2007-12-04 17:07 ` Anton Vorontsov 2007-12-04 17:08 ` Sergei Shtylyov 2007-12-04 17:08 ` Sergei Shtylyov 2007-12-05 0:56 ` Paul Mundt 2007-12-05 0:56 ` Paul Mundt 2007-12-04 20:44 ` [PATCH] pata_of_platform: Move electra-ide support over to new framework Olof Johansson 2007-12-04 20:44 ` Olof Johansson 2007-12-04 20:50 ` Jeff Garzik 2007-12-04 20:50 ` Jeff Garzik 2007-12-04 21:03 ` Olof Johansson 2007-12-04 21:03 ` Olof Johansson 2007-12-20 3:53 ` Paul Mackerras 2007-12-20 3:53 ` Paul Mackerras 2007-12-20 15:33 ` Olof Johansson 2007-12-20 15:33 ` Olof Johansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20071204194531.GA1253@localhost.localdomain \ --to=avorontsov@ru.mvista.com \ --cc=arnd@arndb.de \ --cc=jeff@garzik.org \ --cc=lethal@linux-sh.org \ --cc=linux-ide@vger.kernel.org \ --cc=linuxppc-dev@ozlabs.org \ --cc=olof@lixom.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.