From: Olof Johansson <olof@lixom.net>
To: Paul Mundt <lethal@linux-sh.org>
Cc: linux-ide@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Jeff Garzik <jeff@garzik.org>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver
Date: Tue, 4 Dec 2007 21:26:57 -0600 [thread overview]
Message-ID: <20071205032657.GB13906@lixom.net> (raw)
In-Reply-To: <20071205004841.GA25905@linux-sh.org>
On Wed, Dec 05, 2007 at 09:48:41AM +0900, Paul Mundt wrote:
> On Tue, Dec 04, 2007 at 02:01:21PM -0600, Olof Johansson wrote:
> > On Tue, Dec 04, 2007 at 10:49:21PM +0300, Anton Vorontsov wrote:
> > > tristate "Generic platform device PATA support"
> > > - depends on EMBEDDED || ARCH_RPC
> > > + depends on EMBEDDED || ARCH_PPC
> >
> > It needs to be || PPC, not || ARCH_PPC.
> >
> Wrong. It needs to be EMBEDDED || ARCH_RPC || PPC.
>
> ARCH_RPC is not a typo, it's an ARM platform. Please grep first :-)
I'm sorry, but seeing ARCH_RPC and not having an arch/rpc made me
suspect it being a typo. It surprises me that the ARM guys chose such
a generic prefix as ARCH_ for their specific platforms. (powerpc uses
PPC_<platform>).
Anyway, thanks for catching it.
-Olof
WARNING: multiple messages have this Message-ID (diff)
From: Olof Johansson <olof@lixom.net>
To: Paul Mundt <lethal@linux-sh.org>
Cc: linux-ide@vger.kernel.org, Jeff Garzik <jeff@garzik.org>,
Arnd Bergmann <arnd@arndb.de>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver
Date: Tue, 4 Dec 2007 21:26:57 -0600 [thread overview]
Message-ID: <20071205032657.GB13906@lixom.net> (raw)
In-Reply-To: <20071205004841.GA25905@linux-sh.org>
On Wed, Dec 05, 2007 at 09:48:41AM +0900, Paul Mundt wrote:
> On Tue, Dec 04, 2007 at 02:01:21PM -0600, Olof Johansson wrote:
> > On Tue, Dec 04, 2007 at 10:49:21PM +0300, Anton Vorontsov wrote:
> > > tristate "Generic platform device PATA support"
> > > - depends on EMBEDDED || ARCH_RPC
> > > + depends on EMBEDDED || ARCH_PPC
> >
> > It needs to be || PPC, not || ARCH_PPC.
> >
> Wrong. It needs to be EMBEDDED || ARCH_RPC || PPC.
>
> ARCH_RPC is not a typo, it's an ARM platform. Please grep first :-)
I'm sorry, but seeing ARCH_RPC and not having an arch/rpc made me
suspect it being a typo. It surprises me that the ARM guys chose such
a generic prefix as ARCH_ for their specific platforms. (powerpc uses
PPC_<platform>).
Anyway, thanks for catching it.
-Olof
next prev parent reply other threads:[~2007-12-05 3:22 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 17:04 [PATCH v2 0/4] OF-platform PATA driver Anton Vorontsov
2007-12-04 17:04 ` Anton Vorontsov
2007-12-04 17:06 ` [PATCH v2 1/4] [libata] pata_platform: make probe and remove functions device type neutral Anton Vorontsov
2007-12-04 17:06 ` Anton Vorontsov
2007-12-04 20:40 ` Olof Johansson
2007-12-04 20:40 ` Olof Johansson
2007-12-05 15:37 ` Anton Vorontsov
2007-12-05 15:37 ` Anton Vorontsov
2007-12-04 17:07 ` [PATCH v2 2/4] [libata] pata_of_platform: OF-Platform PATA device driver Anton Vorontsov
2007-12-04 17:07 ` Anton Vorontsov
2007-12-04 18:48 ` Olof Johansson
2007-12-04 18:48 ` Olof Johansson
2007-12-04 19:49 ` Anton Vorontsov
2007-12-04 19:49 ` Anton Vorontsov
2007-12-04 20:01 ` Olof Johansson
2007-12-04 20:01 ` Olof Johansson
2007-12-04 20:37 ` Anton Vorontsov
2007-12-04 20:37 ` Anton Vorontsov
2007-12-04 20:39 ` Olof Johansson
2007-12-04 20:39 ` Olof Johansson
2007-12-05 0:48 ` Paul Mundt
2007-12-05 0:48 ` Paul Mundt
2007-12-05 3:26 ` Olof Johansson [this message]
2007-12-05 3:26 ` Olof Johansson
2007-12-05 18:39 ` Scott Wood
2007-12-05 18:39 ` Scott Wood
2007-12-14 8:23 ` Olof Johansson
2007-12-14 8:23 ` Olof Johansson
2007-12-14 16:09 ` Scott Wood
2007-12-14 16:09 ` Scott Wood
2007-12-14 16:33 ` Olof Johansson
2007-12-14 16:33 ` Olof Johansson
2007-12-04 17:07 ` [PATCH v2 3/4] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes Anton Vorontsov
2007-12-04 17:07 ` Anton Vorontsov
2007-12-04 19:16 ` Olof Johansson
2007-12-04 19:16 ` Olof Johansson
2007-12-04 19:23 ` Scott Wood
2007-12-04 19:45 ` Anton Vorontsov
2007-12-04 19:45 ` Anton Vorontsov
2007-12-04 20:40 ` Olof Johansson
2007-12-04 20:40 ` Olof Johansson
2007-12-04 17:07 ` [PATCH v2 4/4] [libata] pata_platform: s/ioport_shift/reg_shift/g Anton Vorontsov
2007-12-04 17:07 ` Anton Vorontsov
2007-12-04 17:08 ` Sergei Shtylyov
2007-12-04 17:08 ` Sergei Shtylyov
2007-12-05 0:56 ` Paul Mundt
2007-12-05 0:56 ` Paul Mundt
2007-12-04 20:44 ` [PATCH] pata_of_platform: Move electra-ide support over to new framework Olof Johansson
2007-12-04 20:44 ` Olof Johansson
2007-12-04 20:50 ` Jeff Garzik
2007-12-04 20:50 ` Jeff Garzik
2007-12-04 21:03 ` Olof Johansson
2007-12-04 21:03 ` Olof Johansson
2007-12-20 3:53 ` Paul Mackerras
2007-12-20 3:53 ` Paul Mackerras
2007-12-20 15:33 ` Olof Johansson
2007-12-20 15:33 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071205032657.GB13906@lixom.net \
--to=olof@lixom.net \
--cc=arnd@arndb.de \
--cc=jeff@garzik.org \
--cc=lethal@linux-sh.org \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.