From: Andrew Morton <akpm@linux-foundation.org>
To: Jean Pihet <jpihet@mvista.com>
Cc: tony@atomide.com, ext-adrian.hunter@nokia.com,
linux-arm-kernel@lists.arm.linux.org.uk,
linux-omap@vger.kernel.org, jarkko.lavinen@nokia.com,
drzeus-mmc@drzeus.cx, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] OMAP: MMC: recover from transfer failures - Resend
Date: Thu, 5 Feb 2009 12:10:45 -0800 [thread overview]
Message-ID: <20090205121045.4022c319.akpm@linux-foundation.org> (raw)
In-Reply-To: <200902031505.58697.jpihet@mvista.com>
On Tue, 3 Feb 2009 15:05:58 +0100
Jean Pihet <jpihet@mvista.com> wrote:
> + while (OMAP_HSMMC_READ(host->base,
> + SYSCTL) & SRD)
> + ;
Is a __raw_readl() sufficient to prevent the cpu from burning up here,
or should we add cpu_relax()?
An infinite loop which assumes the hardware is perfect is always a
worry. But I see the driver already does that, so we're no worse off..
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Jean Pihet <jpihet@mvista.com>
Cc: tony@atomide.com, ext-adrian.hunter@nokia.com,
linux-arm-kernel@lists.arm.linux.org.uk,
linux-omap@vger.kernel.org, jarkko.lavinen@nokia.com,
drzeus-mmc@drzeus.cx, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] OMAP: MMC: recover from transfer failures - Resend
Date: Thu, 5 Feb 2009 12:10:45 -0800 [thread overview]
Message-ID: <20090205121045.4022c319.akpm@linux-foundation.org> (raw)
In-Reply-To: <200902031505.58697.jpihet@mvista.com>
On Tue, 3 Feb 2009 15:05:58 +0100
Jean Pihet <jpihet@mvista.com> wrote:
> + while (OMAP_HSMMC_READ(host->base,
> + SYSCTL) & SRD)
> + ;
Is a __raw_readl() sufficient to prevent the cpu from burning up here,
or should we add cpu_relax()?
An infinite loop which assumes the hardware is perfect is always a
worry. But I see the driver already does that, so we're no worse off..
-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php
next prev parent reply other threads:[~2009-02-05 20:18 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-07 21:45 [PATCH 0/5] Omap MMC init updates and new controller for 2.6.29 merge window Tony Lindgren
2008-12-07 21:46 ` [PATCH 1/5] omap mmc: Remove broken MMC init code Tony Lindgren
2008-12-07 21:47 ` [PATCH 2/5] omap mmc: Add better MMC low-level init Tony Lindgren
2009-01-10 22:49 ` Ladislav Michl
2009-01-10 23:00 ` Ladislav Michl
2009-01-13 13:43 ` Tony Lindgren
2009-03-23 17:47 ` Ladislav Michl
2009-03-24 20:04 ` [APPLIED] " Tony Lindgren
2009-01-10 23:03 ` Ladislav Michl
2008-12-07 21:49 ` [PATCH 3/5] omap mmc: Add low-level initialization for hsmmc controller Tony Lindgren
2008-12-07 21:50 ` [PATCH 4/5] omap mmc: force MMC module reset on boot Tony Lindgren
2008-12-07 21:51 ` [PATCH 5/5] omap mmc: Add new omap hsmmc controller for 2430 and 34xx Tony Lindgren
2008-12-21 16:17 ` Pierre Ossman
2008-12-29 16:55 ` Tony Lindgren
2008-12-30 8:36 ` Tony Lindgren
2008-12-31 17:59 ` Pierre Ossman
2009-01-07 10:18 ` Tony Lindgren
2009-01-07 10:28 ` [PATCH] OMAP: MMC: recover from transfer failures (was: Re: [PATCH 5/5] omap mmc: Add new omap hsmmc controller for 2430 and 34xx) Jean Pihet
2009-01-07 15:40 ` Tony Lindgren
2009-01-08 9:02 ` [PATCH] OMAP: MMC: recover from transfer failures Adrian Hunter
2009-01-08 11:49 ` Jean Pihet
2009-01-08 12:17 ` Adrian Hunter
2009-02-02 8:46 ` Jean Pihet
2009-02-02 19:05 ` Tony Lindgren
2009-02-03 14:05 ` [PATCH] OMAP: MMC: recover from transfer failures - Resend Jean Pihet
2009-02-03 14:05 ` Jean Pihet
2009-02-05 20:10 ` Andrew Morton [this message]
2009-02-05 20:10 ` Andrew Morton
2009-02-05 20:32 ` Paul Walmsley
2009-02-06 13:22 ` Jean Pihet
2009-02-06 13:53 ` Pierre Ossman
2009-02-06 15:53 ` [PATCH] OMAP: MMC: replace infinite loops with timeouts (was Re: [PATCH] OMAP: MMC: recover from transfer failures - Resend) Jean Pihet
2009-02-09 15:58 ` Adrian Hunter
2009-02-09 15:58 ` Adrian Hunter
2009-02-11 9:41 ` Jean Pihet
2009-02-11 9:41 ` Jean Pihet
2009-02-09 17:58 ` [PATCH] OMAP: MMC: recover from transfer failures - Resend Jarkko Lavinen
2009-02-09 17:58 ` Jarkko Lavinen
2009-02-09 18:46 ` Tony Lindgren
2009-02-09 18:46 ` Tony Lindgren
2009-02-10 0:09 ` Paul Walmsley
2009-02-08 20:27 ` David Brownell
2009-02-08 20:27 ` David Brownell
2008-12-15 22:26 ` git pull request for omap mmc init changes (Re: [PATCH 0/5] Omap MMC init updates and new controller for 2.6.29 merge window) Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090205121045.4022c319.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=drzeus-mmc@drzeus.cx \
--cc=ext-adrian.hunter@nokia.com \
--cc=jarkko.lavinen@nokia.com \
--cc=jpihet@mvista.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.