All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Mundt <lethal@linux-sh.org>
To: linux-next@vger.kernel.org
Cc: Benny Halevy <bhalevy@panasas.com>,
	Andy Adamson <andros@netapp.com>,
	Trond Myklebust <Trond.Myklebust@netapp.com>
Subject: [PATCH -next] lib: Move find_last_bit.o to obj-y to enable use by modules.
Date: Thu, 16 Apr 2009 12:07:04 +0900	[thread overview]
Message-ID: <20090416030704.GH16961@linux-sh.org> (raw)

Caught with the sh allmodconfig:

	ERROR: "find_last_bit" [fs/nfs/nfs.ko] undefined!
	make[2]: *** [__modpost] Error 1
	make[1]: *** [modules] Error 2
	make: *** [sub-make] Error 2

find_last_bit.o is currently built with lib-y, which ends up breaking
the nfs module build after the ("nfs41: free slot") commit. Move it
to obj-y so the EXPORT_SYMBOL() actually has some effect.

Signed-off-by: Paul Mundt <lethal@linux-sh.org>
Cc: Benny Halevy <bhalevy@panasas.com>
Cc: Andy Adamson <andros@netapp.com>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>

---

diff --git a/lib/Makefile b/lib/Makefile
index d6edd67..33a40e4 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -38,7 +38,7 @@ lib-$(CONFIG_RWSEM_GENERIC_SPINLOCK) += rwsem-spinlock.o
 lib-$(CONFIG_RWSEM_XCHGADD_ALGORITHM) += rwsem.o
 lib-$(CONFIG_GENERIC_FIND_FIRST_BIT) += find_next_bit.o
 lib-$(CONFIG_GENERIC_FIND_NEXT_BIT) += find_next_bit.o
-lib-$(CONFIG_GENERIC_FIND_LAST_BIT) += find_last_bit.o
+obj-$(CONFIG_GENERIC_FIND_LAST_BIT) += find_last_bit.o
 obj-$(CONFIG_GENERIC_HWEIGHT) += hweight.o
 obj-$(CONFIG_LOCK_KERNEL) += kernel_lock.o
 obj-$(CONFIG_DEBUG_PREEMPT) += smp_processor_id.o

             reply	other threads:[~2009-04-16  3:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-16  3:07 Paul Mundt [this message]
2009-04-16  8:11 ` [PATCH -next] lib: Move find_last_bit.o to obj-y to enable use by modules Benny Halevy
2009-04-23  6:50   ` Paul Mundt
2009-04-23 10:12     ` Benny Halevy
2009-04-23 10:29       ` Paul Mundt
2009-04-23 12:59         ` Trond Myklebust
2009-04-23 13:18           ` Benny Halevy
2009-04-23 13:25           ` Paul Mundt
2009-04-23 13:59             ` Trond Myklebust
2009-04-23 14:12               ` Paul Mundt
2009-04-23 16:38                 ` Trond Myklebust
2009-04-26 12:49                   ` Rusty Russell
2009-04-26 16:42                     ` Ingo Molnar
2009-04-26 17:29                       ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090416030704.GH16961@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=Trond.Myklebust@netapp.com \
    --cc=andros@netapp.com \
    --cc=bhalevy@panasas.com \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.