From: Benny Halevy <bhalevy@panasas.com>
To: Paul Mundt <lethal@linux-sh.org>,
Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: linux-next@vger.kernel.org, Andy Adamson <andros@netapp.com>,
Fredric Isaman <iisaman@citi.umich.edu>
Subject: Re: [PATCH -next] lib: Move find_last_bit.o to obj-y to enable use by modules.
Date: Thu, 16 Apr 2009 11:11:02 +0300 [thread overview]
Message-ID: <49E6E816.8010709@panasas.com> (raw)
In-Reply-To: <20090416030704.GH16961@linux-sh.org>
On Apr. 16, 2009, 6:07 +0300, Paul Mundt <lethal@linux-sh.org> wrote:
> Caught with the sh allmodconfig:
>
> ERROR: "find_last_bit" [fs/nfs/nfs.ko] undefined!
> make[2]: *** [__modpost] Error 1
> make[1]: *** [modules] Error 2
> make: *** [sub-make] Error 2
>
> find_last_bit.o is currently built with lib-y, which ends up breaking
> the nfs module build after the ("nfs41: free slot") commit. Move it
> to obj-y so the EXPORT_SYMBOL() actually has some effect.
>
> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
> Cc: Benny Halevy <bhalevy@panasas.com>
ACK. and thanks!
FYI, Fred's original patch can be found here:
http://patchwork.kernel.org/patch/14572/
It is also queued in the linux-pnfs tree:
http://git.linux-nfs.org/?p=bhalevy/linux-pnfs.git;a=commitdiff;h=1e3a7552d9de2ba101b76deed99605f0145fc4d5
but I haven't submitted it to Trond since I expected
it to get upstream (and to -next) via linux-kbuild.
Trond, would you like to pull this change to your nfsv41 branch?
(should appear before "nfs41: free slot" as Paul noticed)
Benny
> Cc: Andy Adamson <andros@netapp.com>
> Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
>
> ---
>
> diff --git a/lib/Makefile b/lib/Makefile
> index d6edd67..33a40e4 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -38,7 +38,7 @@ lib-$(CONFIG_RWSEM_GENERIC_SPINLOCK) += rwsem-spinlock.o
> lib-$(CONFIG_RWSEM_XCHGADD_ALGORITHM) += rwsem.o
> lib-$(CONFIG_GENERIC_FIND_FIRST_BIT) += find_next_bit.o
> lib-$(CONFIG_GENERIC_FIND_NEXT_BIT) += find_next_bit.o
> -lib-$(CONFIG_GENERIC_FIND_LAST_BIT) += find_last_bit.o
> +obj-$(CONFIG_GENERIC_FIND_LAST_BIT) += find_last_bit.o
> obj-$(CONFIG_GENERIC_HWEIGHT) += hweight.o
> obj-$(CONFIG_LOCK_KERNEL) += kernel_lock.o
> obj-$(CONFIG_DEBUG_PREEMPT) += smp_processor_id.o
next prev parent reply other threads:[~2009-04-16 8:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 3:07 [PATCH -next] lib: Move find_last_bit.o to obj-y to enable use by modules Paul Mundt
2009-04-16 8:11 ` Benny Halevy [this message]
2009-04-23 6:50 ` Paul Mundt
2009-04-23 10:12 ` Benny Halevy
2009-04-23 10:29 ` Paul Mundt
2009-04-23 12:59 ` Trond Myklebust
2009-04-23 13:18 ` Benny Halevy
2009-04-23 13:25 ` Paul Mundt
2009-04-23 13:59 ` Trond Myklebust
2009-04-23 14:12 ` Paul Mundt
2009-04-23 16:38 ` Trond Myklebust
2009-04-26 12:49 ` Rusty Russell
2009-04-26 16:42 ` Ingo Molnar
2009-04-26 17:29 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E6E816.8010709@panasas.com \
--to=bhalevy@panasas.com \
--cc=Trond.Myklebust@netapp.com \
--cc=andros@netapp.com \
--cc=iisaman@citi.umich.edu \
--cc=lethal@linux-sh.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.