All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitri Belimov <d.belimov@gmail.com>
To: Andy Walls <awalls@radix.net>
Cc: video4linux-list@redhat.com, linux-media@vger.kernel.org
Subject: Re: [PATCH] FM1216ME_MK3 some changes
Date: Thu, 23 Apr 2009 20:36:18 +1000	[thread overview]
Message-ID: <20090423203618.4ac2bc6f@glory.loctelecom.ru> (raw)
In-Reply-To: <1240452534.3232.70.camel@palomino.walls.org>

Hi Andy

> Dmitri,
> 
> 
> On Wed, 2009-04-22 at 17:48 +1000, Dmitri Belimov wrote:
> > Hi All
> > 
> > 1. Change middle band. In the end of the middle band the
> > sensitivity of receiver not good. If we switch to higher band,
> > sensitivity more better. Hardware trick.
> 
> This concerns me slightly as it does not match the datasheet (hence
> the design objectives) of the FM1236ME_MK3.

Yes, I know.

> How are you measuring sensitivity?  Do you know if it really is the
> middle-band preselector filter (and PLL and Mixer) or is it a problem
> with the input signal?  How do you know it is not manufacturing
> variations in the preselector filters with the particular tuner
> assembly you are testing?

Several years a go your customers write some messages about bad quality of TV
if frequency of TV is the end of band. It can be low band or middle. Our
hardware engeneer make some tests with hardware TV generator and our TV tuners.

If we set default frequency range for low and middle band, quality of TV signal 
on 159MHz and 442 MHz is bad. When we make our changes with moving end of bands
the quality of TV much better. And our system programmer for OS Windows use changed
bands for drivers. Customers be happy.

You can test it if in your placement available TV programm on 159MHz or 442MHz. This trick
can be usefull for other tuners.

> Also, as an alternative to using a different frequency for the
> bandswitch, have you considered setting the Auxillary Byte in the
> tuner chip (Infineon TUA6030?) to use external AGC and experimented
> with changing the tuner AGC take-over point (TOP) in the TDA9887?
> 
> By maximizing the gain in the tuner chip, but avoiding clipping, with
> the proper TOP setting, you minimize the contributions by the rest of
> the receive chain to the overall receiver Noise Figure:
> 
> http://en.wikipedia.org/wiki/Friis_formulas_for_noise
> 
> This may be a way to improve receiver sensitivity that does not
> conflict with the data sheet specification.
> 
> 
> 
> 
> > 2. Set correct highest freq of the higher band.
> 
> :)
> 
> This bothers me too; all the tuners in tuner-types.c have it set too
> high (999.0 MHz).  I think I rememeber at time when all the
> tuner_range definitions had a real value there.
> 
> It would be nice to have a real value there for all the tuners.  The
> function tuner-simple.c:simple_config_lookup() would then prevent
> attempts to tune to an unsupported frequnecy.
> 
> 
> 
> > 3. Set charge pump bit
> 
> This will improve the time to initially tune to a frequency, but will
> likely add some noise as the PLL continues to maintain lock on the
> signal.  If there is no way to turn off the CP after the lock bit is
> set in the tuner, it's probably better to leave it off for lower
> noise and just live with slower tuning.

We discuss with our windows system programmer about it. He sad that
in analog TV mode noise from PLL don't give any problem. But in digital TV mode
noise from PLL decreased BER.

> Leaving the CP bit set should be especially noticable ad FM noise when
> set to tune to FM radio stations.  From the FM1236ME_MK3 datasheet:
> "It is recommended to set CP=0 in the FM mode at all times."
> But the VHF low band control byte is also used when setting FM radio
> (AFAICT with a quick look at the code.)

Yes. You are right. We can swith CP off in FM mode.

With my best regards, Dmitry.

> 
> Regards,
> Andy
> 
> > diff -r 43dbc8ebb5a2 linux/drivers/media/common/tuners/tuner-types.c
> > --- a/linux/drivers/media/common/tuners/tuner-types.c	Tue
> > Jan 27 23:47:50 2009 -0200 +++
> > b/linux/drivers/media/common/tuners/tuner-types.c	Tue Apr 21
> > 09:44:38 2009 +1000 @@ -557,9 +557,9 @@ /* ------------
> > TUNER_PHILIPS_FM1216ME_MK3 - Philips PAL ------------ */ 
> >  static struct tuner_range tuner_fm1216me_mk3_pal_ranges[] = {
> > -	{ 16 * 158.00 /*MHz*/, 0x8e, 0x01, },
> > -	{ 16 * 442.00 /*MHz*/, 0x8e, 0x02, },
> > -	{ 16 * 999.99        , 0x8e, 0x04, },
> > +	{ 16 * 158.00 /*MHz*/, 0xc6, 0x01, },
> > +	{ 16 * 441.00 /*MHz*/, 0xc6, 0x02, },
> > +	{ 16 * 864.00        , 0xc6, 0x04, },
> >  };
> >  
> > 
> > 
> > Signed-off-by: Beholder Intl. Ltd. Dmitry Belimov
> > <d.belimov@gmail.com>
> > 
> > With my best regards, Dmitry.
> > --
> > video4linux-list mailing list
> > Unsubscribe
> > mailto:video4linux-list-request@redhat.com?subject=unsubscribe
> > https://www.redhat.com/mailman/listinfo/video4linux-list
> 

  parent reply	other threads:[~2009-04-23 10:34 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-22  7:48 [PATCH] FM1216ME_MK3 some changes Dmitri Belimov
2009-04-23  2:08 ` Andy Walls
2009-04-23  1:52   ` hermann pitton
2009-04-23 10:36   ` Dmitri Belimov [this message]
2009-04-24  1:43     ` Andy Walls
2009-04-24  1:06       ` hermann pitton
2009-04-24  1:34         ` hermann pitton
2009-04-26 13:58       ` Dmitri Belimov
2009-04-27  4:45         ` hermann pitton
2009-04-27  9:29       ` Dmitri Belimov
2009-04-28  0:11         ` hermann pitton
2009-04-27 10:42           ` Dmitri Belimov
2009-04-28  0:57             ` hermann pitton
2009-04-28  0:20           ` hermann pitton
2009-04-28 18:18         ` Mauro Carvalho Chehab
2009-04-28  9:59           ` Dmitri Belimov
2009-04-29  3:10             ` hermann pitton
2009-04-29 10:12               ` Dmitri Belimov
2009-04-30  0:15                 ` hermann pitton
2009-05-05 18:42                   ` Dmitri Belimov
2009-05-07  0:01                     ` hermann pitton
2009-05-07  3:03                       ` Andy Walls
2009-05-06 23:05                         ` Dmitri Belimov
2009-05-08  0:08                         ` hermann pitton
2009-05-09  2:01                           ` Andy Walls
2009-05-09  2:27                             ` hermann pitton
2009-05-10  0:43                               ` hermann pitton
2009-05-09 22:52                                 ` Dmitri Belimov
2009-05-11  3:35                                   ` hermann pitton
2009-05-11 10:19                                     ` Mauro Carvalho Chehab
2009-05-12 21:21                                       ` Dmitri Belimov
2009-05-11 10:58                                     ` Dmitri Belimov
     [not found]                                     ` <20090513073757.6177c42e@glory.loctelecom.ru>
2009-05-13 23:44                                       ` hermann pitton
     [not found]                                         ` <20090514101758.04665ab4@glory.loctelecom.ru>
2009-05-14  1:10                                           ` hermann pitton
2009-05-22  0:51                                             ` hermann pitton
2009-04-30  1:14                 ` Andy Walls
2009-05-01  5:18                   ` hermann pitton
2009-05-01 23:55                     ` hermann pitton
2009-05-02  0:52                       ` Andy Walls
2009-05-02  2:05                         ` hermann pitton
2009-05-03  0:29                           ` hermann pitton
2009-05-06 22:58                   ` Dmitri Belimov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090423203618.4ac2bc6f@glory.loctelecom.ru \
    --to=d.belimov@gmail.com \
    --cc=awalls@radix.net \
    --cc=linux-media@vger.kernel.org \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.