Re: [PATCH] FM1216ME_MK3 some changes

[Mauro Carvalho Chehab <mchehab@redhat.com>]

>> 1. AGC TOP of RF part - I think need support for MK3
>> 2. Changing to 441MHz is not critical. We can write some information about this case to Wiki or docs.
> 
> for 2.: Discussed to the end if you stay at 441MHz. If you still want to
> have it in, just send  a patch and no more info is needed. (Likely Andy
> is giving only examples for more difficult cases, sorry.)
> 
> for 1.: I would like to be absolutely sure, that we are talking about
> the same tuner. I want to have the exact filters on it at least.

I 
would 
also 
say 
that, 
if 
we 
need 
to 
implement 
AGC 
TOP 
control, 
it 
would 
be 
better 
to
add 
it 
at 
struct 
v4l2_tuner 
(VIDIOC_G_TUNER 
and 
VIDIOC_S_TUNER), 
instead 
of 
adding 
it
as a 
control.

> 
> 3.: That is what Andy noted. Following the Philips datasheet for TOP, it
> should be added for negative modulation, positive modulation and FM
> accordingly. (2 and 3 are out of discussion)
> 
> If you still have some sort of Secam fire and can improve it, we must
> know the tuner you are on "exactly". If it is the original Philips,
> without any such TOP suggestions over the full range in recent
> datasheets (???), I assume you might have them, I would say you can
> proceed, if you have shown that you are really still on the same tuner.
> 
> Cheers,
> Hermann
> 
> 
> 
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html