All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitri Belimov <d.belimov@gmail.com>
To: Andy Walls <awalls@radix.net>
Cc: hermann pitton <hermann-pitton@arcor.de>,
	Mauro Carvalho Chehab <mchehab@infradead.org>,
	video4linux-list@redhat.com, linux-media@vger.kernel.org
Subject: Re: [PATCH] FM1216ME_MK3 some changes
Date: Thu, 7 May 2009 09:05:06 +1000	[thread overview]
Message-ID: <20090507090506.79f293db@glory.loctelecom.ru> (raw)
In-Reply-To: <1241665384.3147.53.camel@palomino.walls.org>

Hi Andy

> On Thu, 2009-05-07 at 02:01 +0200, hermann pitton wrote:
> > Hi,
> > 
> > Am Mittwoch, den 06.05.2009, 04:42 +1000 schrieb Dmitri Belimov:
> > > Hi Hermann
> > > 
> > > > Hi Dmitry,
> > > > 
> > > > Am Mittwoch, den 29.04.2009, 20:12 +1000 schrieb Dmitri Belimov:
> > > > > Hi,
> > > > >  
> > > > > > Am Dienstag, den 28.04.2009, 19:59 +1000 schrieb Dmitri
> > > > > > Belimov:
> > > > > > > On Tue, 28 Apr 2009 15:18:32 -0300
> > > > > > > Mauro Carvalho Chehab <mchehab@infradead.org> wrote:
> > > > > > > 
> > > > > > > > On Mon, 27 Apr 2009 19:29:05 +1000
> > > > > > > > Dmitri Belimov <d.belimov@gmail.com> wrote:
> > > > > > > > 
> > > > > > > > > Hi All
> > > > > > > > > 
> > > > > > > > > Step by step.
> > > > > > > > > 
> > > > > > > > > This is patch for change only range of FM1216ME_MK3.
> > > > > > > > > Slow tunning is not a big problem.
> > > > > > > > 
> > > > > > > > Dmitri,
> > > > > > > > 
> > > > > > > > I'll mark those patches as RFC at patchwork until the
> > > > > > > > end of those discussions. After that, please send it
> > > > > > > > again into a new thread.
> > > > > > > 
> > > > > > > You mark patch with TOP AGC not this.
> > > > > > > 
> > > > > > > I think need discuss about FM1216ME_MK3 because I'll have
> > > > > > > a big patch for support control TOP AGC (sensitivity) of
> > > > > > > this tuner. It can be bad for compatible tuners.
> > > > > > 
> > > > > > hmm, in Europe, that TOP AGC did not ever made much
> > > > > > difference and it is an insmod option since ever.
> > 
> > >From the tda9887_3 datasheet.
> > 
> > 8.2  Tuner AGC and VIF-AGC
> > 
> > This block adapts the voltages, generated at the VIF-AGC
> > and SIF-AGC detectors, to the internal signal processing
> > at the VIF and SIF amplifiers and performs the tuner AGC
> > control current generation. The onset of the tuner AGC
> > control current generation can be set either via the I2C-bus
> > (see Table 13) or optionally by a potentiometer at pin TOP
> > (in case that the I2C-bus information cannot be stored).
> > The presence of a potentiometer is automatically detected
> > and the I2C-bus setting is disabled.
> > 
> > Reads for me that on some tuners, like NTSC only, the tuner AGC is
> > fix.
> > 
> > To change it per channel is not needed at all.
> 
> I've started looking at the photographs of the tuner that Hermann
> sent. Looking at the TDA9887 v4 datasheet, I can see how the TOP
> related pins are (not) wired to the 1st stage oscillator/mixer chip.
> 
> Pin 9 (TOP) is supposed to either be tied to ground through a resistor
> or left open.  This design has the pin connected to a white SMT
> capacitor(?) which I will assume the TDA9887 will see as an open
> circuit.  This means the TOP in the TDA9887 should be programmable via
> I2C.
> 
> Pin 14 (TAGC) looks like it is unconnected.  This means the TDA9887
> TAGC output is not actively taking over gain control of the 1st stage
> RF mixer/oscialltor chip.
> 
> 
> So this answers a question I had posed to Dmitry: Is this tuner wired
> up so the TDA9887 can adjust the gain of the 1st stage?  That answer
> is no.
> 
> 
> That means, that in this tuner, the AGC's in the two chips are
> operating independently and need their TOP's set in a coordinated
> manner that takes into account the IF filter losses and the
> modulation.  Since the FM1216ME data sheet makes recommendations for
> TOP values for both chips:
> 
> 
> RF mixer/osc chip:
>   109 dBμV Recommended for negative modulation
>   106 dBμV Recommended for positive modulation
> 
>   It is recommended to set the TOP at 109 dBμV for PAL B/G, D/K, I 
>   For system L/L’, it is recommended to set the TOP at 106 dBμV.
>   For FM radio, it is also recommended to set the TOP to 109 dBμV
> 
> IF demod chip:
>   C4-C0 = 10000 [0 dB, 17 mV (RMS) according to the TDA9887 datasheet]
>     for all FM modes and B/G D/K I L and L' systems
> 
> 
> it is probably best to use those.  I can try and look at the IF filter
> from the picutres Hermann sent, but I'm not sure I'd be able to figure
> out the loss and come up with better TOP setting recommendations than
> the manufacturer's datasheet.
> 
> 
> > > > > > 
> > > > > > I can't tell for Sibiria and initially that tuner had no
> > > > > > SECAM-DK support officially at all. There are no
> > > > > > good/much_better tuners for FTA at all and never have
> > > > > > been ;)
> > > > > > 
> > > > > > Some examples, user success reports, to make it more easily
> > > > > > to understand? I think it can only change some _very
> > > > > > little_ under already worst conditions.
> > > > > 
> > > > > This is my idea for RFC about TOP AGC:
> > > > 
> > > > what about to create a new FM1216ME MK3 tuner type for testing?
> > > 
> > > Yes. Can you do it?
> > > 
> > > I start add MK5 tuner.
> > 
> > Yes, if really needed, but I see no hint anywhere that it should be
> > useful to have TOP settings per channel for user applications and
> > will stay away from it.
> 
> 
> Right now, I don't think the tuner-simple.c code adjusts the TOP value
> based on the video system or FM mode.  It probably should.
> 
> I don't think a user control will be very useful.
> 
> 
> > For the change of UHF start I don't see any problem.
> 
> If you're talking about the frequency for the bandswitch, I don't see
> a problem either in general.  It may cause a problem for clones of the
> FM1216ME MK3 that don't have the same filter performance near the
> cutover, but use the same tuner defintion as the FM1216ME MK3 in
> tuner-types.c.
> 
> It may be best to point any clones to a new entry that looks like the
> current FM1216ME MK3 entry unmodified.
> 
> Regards,
> Andy
> 
> > SECAM_DK is never mentioned explicitly in the old datasheet we have
> > at ivtvdriver.org. Maybe we miss something here, but you try to
> > change over the full range and simply 109 dB is recommended for
> > negative demodulation. (page 13 for recommended TOP settings)
> > http://dl.ivtvdriver.org/datasheets/tuners
> > 
> > Maybe we are really talking about different tuner
> > versions/revisions.
> > 
> > Can you have a look at the tuner pictures I did send?
> > 
> > > > It is for sure maybe the best tuner around and likely is also
> > > > the best for tweaks in countries with huge lands to cover, not
> > > > restricted to Russia, Australia or Canada.
> > > 
> > > All our tuners tested with all standarts SECAM, PAL, NTSC because
> > > big country, some people want receive TV from Korea and Japan.
> > > For tests, our hardware engineer has hardware TV generator.
> > 
> > That confuses me a lot :)
> > 
> > You mean you test that tuner with its PAL/SECAM SAW filters on
> > NTSC_KR and NTSC_JP ?

The has 1216 3 SAW - 5.5, 6.0 and 6.5 (BG, I, DK)
The has 1236/1286 1 SAW - 4.5 (M/N)

This is one more trick.
1. Set SAW to 5.5MHz
2. Decode sound via SIF. The saa713x can decode M sound channel.

Of course need make a workaround for this.

With my best regards, Dmitry.

> > > 
> > > > I would like to have also Hans' opinion on it, since he did
> > > > some final steps to get them right.
> > > > 
> > 
> > Andy might have a look too. Please wait a little for more opinions.
> > 
> > Cheers,
> > Hermann
> > 
> > > > 
> > > > > 1. Add gain variable to tuner structure.
> > > > > 2. Add V4L2_CID_GAIN control to saa7134 and disable this
> > > > > control. 3. Add workaround to simple_post_tune function for
> > > > > write sensitivity level to the tuner. 4. Enable V4L2_CID_GAIN
> > > > > control when module load if card is right.
> > > > > 
> > > > > My expirience not so good, step 4 segfault the kernel. How to
> > > > > we can make it?
> > > > > 
> > > > > Our windows end-user programm control the sensitivity of each
> > > > > TV channel and change when channel changed.
> > > > > 
> > > > > What you think about it??
> > > > > 
> > > > > If TV card is not touch V4L2_CTRL_FLAG_DISABLED in this
> > > > > control. The programm can't change AGC TOP. And write default
> > > > > value to AGC TOP like now.
> > > > > 
> > > > > diff -r 43dbc8ebb5a2
> > > > > linux/drivers/media/common/tuners/tuner-simple.c ---
> > > > > a/linux/drivers/media/common/tuners/tuner-simple.c	Tue
> > > > > Jan 27 23:47:50 2009 -0200 +++
> > > > > b/linux/drivers/media/common/tuners/tuner-simple.c	Tue
> > > > > Apr 21 09:44:38 2009 +1000 @@ -116,6 +116,7 @@ u32 frequency;
> > > > >  	u32 bandwidth;
> > > > > +	signed int gain;
> > > > >  };
> > > > >  
> > > > >  /*
> > > > > ----------------------------------------------------------------------
> > > > > */ @@ -495,15 +507,57 @@ "(should be 4)\n", rc);
> > > > >  		break;
> > > > >  	}
> > > > > +	case TUNER_PHILIPS_FM1216ME_MK3:
> > > > > +	{
> > > > > +		buffer[2] = 0xDE; /* T2 = 0, T1 = 1 and T0 =
> > > > > 1 */
> > > > > +		switch (priv->gain) {
> > > > > +		case 0:
> > > > > +			/* TOP = External AGC, ATC = OFF */
> > > > > +			buffer[3] = 0x60;
> > > > > +			break;
> > > > > +		case 1:
> > > > > +			/* TOP = 118 dB, ATC = OFF */
> > > > > +			buffer[3] = 0x00;
> > > > > +			break;
> > > > > +		case 2:
> > > > > +			/* TOP = 115 dB, ATC = OFF */
> > > > > +			buffer[3] = 0x10;
> > > > > +			break;
> > > > > +		case 3:
> > > > > +			/* TOP = 112 dB, ATC = OFF */
> > > > > +			buffer[3] = 0x20;
> > > > > +			break;
> > > > > +		case 4:
> > > > > +			/* TOP = 109 dB, ATC = OFF */
> > > > > +			buffer[3] = 0x30;
> > > > > +			break;
> > > > > +		case 5:
> > > > > +			/* TOP = 106 dB, ATC = OFF */
> > > > > +			buffer[3] = 0x40;
> > > > > +			break;
> > > > > +		case 6:
> > > > > +			/* TOP = 103 dB, ATC = OFF */
> > > > > +			buffer[3] = 0x50;
> > > > > +			break;
> > > > > +		default:
> > > > > +			/* TOP = 112 dB, ATC = OFF */
> > > > > +			buffer[3] = 0x20;
> > > > > +			break;
> > > > > +		}
> > > > > +
> > > > > +		tuner_dbg("tv 0x%02x 0x%02x 0x%02x 0x%02x\n",
> > > > > +			  buffer[0], buffer[1], buffer[2],
> > > > > buffer[3]); +
> > > > > +		rc = tuner_i2c_xfer_send(&priv->i2c_props,
> > > > > buffer, 4);
> > > > > +		if (4 != rc)
> > > > > +			tuner_warn("i2c i/o error: rc == %d "
> > > > > +				   "(should be 4)\n", rc);
> > > > > +
> > > > > +		break;
> > > > >  	}
> > > > > -
> > > > > +	}
> > > > >  	return 0;
> > > > >  }
> > > > >  
> > > > > diff -r 43dbc8ebb5a2
> > > > > linux/drivers/media/video/saa7134/saa7134-cards.c ---
> > > > > a/linux/drivers/media/video/saa7134/saa7134-cards.c
> > > > > Tue Jan 27 23:47:50 2009 -0200 +++
> > > > > b/linux/drivers/media/video/saa7134/saa7134-cards.c
> > > > > Tue Apr 21 09:44:38 2009 +1000 @@ -6506,6 +6806,20 @@
> > > > > saa_call_all(dev, tuner, s_config, &tea5767_cfg); break; }
> > > > > +	case SAA7134_BOARD_BEHOLD_M6_EXTRA:
> > > > > +	{
> > > > > +		struct v4l2_queryctrl *ctl;
> > > > > +		struct saa7134_fh *fh;
> > > > > +		struct file *fl;
> > > > > +
> > > > > +		ctl->id = V4L2_CID_GAIN;
> > > > > +		if (saa7134_queryctrl(fl, fh, ctl) == 0)
> > > > > {                /* BUG here */
> > > > > +			/* enable this control */
> > > > > +			ctl->flags &=
> > > > > ~(V4L2_CTRL_FLAG_DISABLED);
> > > > > +		}
> > > > > +	}
> > > > >  	} /* switch() */
> > > > >  
> > > > >  	saa7134_tuner_setup(dev);
> > > > > diff -r 43dbc8ebb5a2
> > > > > linux/drivers/media/video/saa7134/saa7134-video.c ---
> > > > > a/linux/drivers/media/video/saa7134/saa7134-video.c
> > > > > Tue Jan 27 23:47:50 2009 -0200 +++
> > > > > b/linux/drivers/media/video/saa7134/saa7134-video.c
> > > > > Tue Apr 21 09:44:38 2009 +1000 @@ -417,6 +417,15
> > > > > @@ .step          = 1, .default_value = 0, .type          =
> > > > > V4L2_CTRL_TYPE_INTEGER,
> > > > > +	}, {
> > > > > +		.id 		= V4L2_CID_GAIN,
> > > > > +		.name 		= "Gain",
> > > > > +		.minimum 	= 0,
> > > > > +		.maximum 	= 6,
> > > > > +		.step 		= 1,
> > > > > +		.default_value 	= 3,
> > > > > +		.type 		=
> > > > > V4L2_CTRL_TYPE_INTEGER,
> > > > > +		.flags 		=
> > > > > V4L2_CTRL_FLAG_DISABLED, },{
> > > > >  		.id            = V4L2_CID_HFLIP,
> > > > >  		.name          = "Mirror",
> > > > > @@ -1129,6 +1138,9 @@
> > > > >  	case V4L2_CID_HUE:
> > > > >  		c->value = dev->ctl_hue;
> > > > >  		break;
> > > > > +	case V4L2_CID_GAIN:
> > > > > +		c->value = dev->ctl_gain;
> > > > > +		break;
> > > > >  	case V4L2_CID_CONTRAST:
> > > > >  		c->value = dev->ctl_contrast;
> > > > >  		break;
> > > > > @@ -1214,6 +1226,10 @@
> > > > >  	case V4L2_CID_HUE:
> > > > >  		dev->ctl_hue = c->value;
> > > > >  		saa_writeb(SAA7134_DEC_CHROMA_HUE,
> > > > > dev->ctl_hue);
> > > > > +		break;
> > > > > +	case V4L2_CID_GAIN:
> > > > > +		dev->ctl_gain = c->value;
> > > > > +
> > > > >  		break;
> > > > >  	case V4L2_CID_CONTRAST:
> > > > >  		dev->ctl_contrast = c->value;
> > > > > @@ -2502,6 +2518,7 @@
> > > > >  	dev->ctl_bright     =
> > > > > ctrl_by_id(V4L2_CID_BRIGHTNESS)->default_value;
> > > > > dev->ctl_contrast =
> > > > > ctrl_by_id(V4L2_CID_CONTRAST)->default_value; dev->ctl_hue =
> > > > > ctrl_by_id(V4L2_CID_HUE)->default_value;
> > > > > +	dev->ctl_gain       =
> > > > > ctrl_by_id(V4L2_CID_GAIN)->default_value; dev->ctl_saturation
> > > > > = ctrl_by_id(V4L2_CID_SATURATION)->default_value;
> > > > > dev->ctl_volume =
> > > > > ctrl_by_id(V4L2_CID_AUDIO_VOLUME)->default_value;
> > > > > dev->ctl_mute       = 1; //
> > > > > ctrl_by_id(V4L2_CID_AUDIO_MUTE)->default_value; diff -r
> > > > > 43dbc8ebb5a2 linux/drivers/media/video/saa7134/saa7134.h ---
> > > > > a/linux/drivers/media/video/saa7134/saa7134.h	Tue Jan
> > > > > 27 23:47:50 2009 -0200 +++
> > > > > b/linux/drivers/media/video/saa7134/saa7134.h	Tue Apr
> > > > > 21 09:44:38 2009 +1000 @@ -548,6 +558,7 @@ int ctl_bright;
> > > > > int                        ctl_contrast;
> > > > > int                        ctl_hue;
> > > > > +	int                        ctl_gain;             /*
> > > > > gain */ int                        ctl_saturation;
> > > > >  	int                        ctl_freq;
> > > > >  	int                        ctl_mute;             /*
> > > > > audio */
> > > > > 
> > > > > 
> > > > > With my best regards, Dmitry.
> > > > > 
> > > > > > Cheers,
> > > > > > Hermann
> > > > > > 
> > > > > > > With my best regards, Dmitry.
> > > > > > > 
> > > > > > > > 
> > > > > > > > Cheers,
> > > > > > > > Mauro.
> > > > > > > > 
> > > > > > > > > 
> > > > > > > > > diff -r b40d628f830d
> > > > > > > > > linux/drivers/media/common/tuners/tuner-types.c ---
> > > > > > > > > a/linux/drivers/media/common/tuners/tuner-types.c
> > > > > > > > > Fri Apr 24 01:46:41 2009 -0300 +++
> > > > > > > > > b/linux/drivers/media/common/tuners/tuner-types.c
> > > > > > > > > Tue Apr 28 03:35:42 2009 +1000 @@ -558,8 +558,8 @@
> > > > > > > > > static struct tuner_range
> > > > > > > > > tuner_fm1216me_mk3_pal_ranges[] = { { 16 *
> > > > > > > > > 158.00 /*MHz*/, 0x8e, 0x01, },
> > > > > > > > > -	{ 16 * 442.00 /*MHz*/, 0x8e, 0x02, },
> > > > > > > > > -	{ 16 * 999.99        , 0x8e, 0x04, },
> > > > > > > > > +	{ 16 * 441.00 /*MHz*/, 0x8e, 0x02, },
> > > > > > > > > +	{ 16 * 864.00        , 0x8e, 0x04, },
> > > > > > > > >  };
> > > > > > > > >  
> > > > > > > > >  static struct tuner_params
> > > > > > > > > tuner_fm1216me_mk3_params[] = {
> > > > > > > > > 
> > > > > > > > > Signed-off-by: Beholder Intl. Ltd. Dmitry Belimov
> > > > > > > > > <d.belimov@gmail.com>
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > With my best regards, Dmitry.
> > > > > > > > > 
> > > > > > > > > > Hi Dmitri,
> > > > > > > > > > 
> > > > > > > > > > Thank you for you responses.
> > > > > > > > > > 
> > > > > > > > > > Just a few more comments...
> > > > > > > > > > 
> > > > > > > > > > On Thu, 2009-04-23 at 20:36 +1000, Dmitri Belimov
> > > > > > > > > > wrote:
> > > > > > > > > > > Hi Andy
> > > > > > > > > > > 
> > > > > > > > > > > > Dmitri,
> > > > > > > > > > > > 
> > > > > > > > > > > > 
> > > > > > > > > > > > On Wed, 2009-04-22 at 17:48 +1000, Dmitri
> > > > > > > > > > > > Belimov wrote:
> > > > > > > > > > > > > Hi All
> > > > > > > > > > > > > 
> > > > > > > > > > > > > 1. Change middle band. In the end of the
> > > > > > > > > > > > > middle band the sensitivity of receiver not
> > > > > > > > > > > > > good. If we switch to higher band,
> > > > > > > > > > > > > sensitivity more better. Hardware trick.
> > > > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > > Several years a go your customers write some
> > > > > > > > > > > messages about bad quality of TV if frequency of
> > > > > > > > > > > TV is the end of band. It can be low band or
> > > > > > > > > > > middle. Our hardware engeneer make some tests
> > > > > > > > > > > with hardware TV generator and our TV tuners.
> > > > > > > > > > > 
> > > > > > > > > > > If we set default frequency range for low and
> > > > > > > > > > > middle band, quality of TV signal on 159MHz and
> > > > > > > > > > > 442 MHz is bad. When we make our changes with
> > > > > > > > > > > moving end of bands the quality of TV much
> > > > > > > > > > > better. And our system programmer for OS Windows
> > > > > > > > > > > use changed bands for drivers. Customers be happy.
> > > > > > > > > > 
> > > > > > > > > > OK.  A properly run experiment wins over theory
> > > > > > > > > > every time. :)
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > > You can test it if in your placement available TV
> > > > > > > > > > > programm on 159MHz or 442MHz. This trick can be
> > > > > > > > > > > usefull for other tuners.
> > > > > > > > > > 
> > > > > > > > > > If you look at tveeprom.c, a number of other tuners
> > > > > > > > > > are using that tuner definition:
> > > > > > > > > > 
> > > > > > > > > > $ grep FM1216ME_MK3 tveeprom.c
> > > > > > > > > > 	{ TUNER_PHILIPS_FM1216ME_MK3,
> > > > > > > > > > 	"Philips FQ1216ME MK3"},
> > > > > > > > > > { TUNER_PHILIPS_FM1216ME_MK3, "Philips FM1216 ME
> > > > > > > > > > MK3"}, { TUNER_PHILIPS_FM1216ME_MK3, 	"LG
> > > > > > > > > > S001D MK3"}, { TUNER_PHILIPS_FM1216ME_MK3,
> > > > > > > > > > 	"LG S701D MK3"},
> > > > > > > > > > { TUNER_PHILIPS_FM1216ME_MK3, 	"Philips
> > > > > > > > > > FQ1216LME MK3"}, { TUNER_PHILIPS_FM1216ME_MK3,
> > > > > > > > > > 	"TCL MFPE05 2"},
> > > > > > > > > > { TUNER_PHILIPS_FM1216ME_MK3, 	"TCL
> > > > > > > > > > MPE05-2"}, { TUNER_PHILIPS_FM1216ME_MK3,
> > > > > > > > > > 	"Philips FM1216ME MK5"},
> > > > > > > > > > 
> > > > > > > > > > If your change makes things bad for the other
> > > > > > > > > > tuners, we'll probably have to create an alternate
> > > > > > > > > > entry for the other tuners instead of using the
> > > > > > > > > > FM1216ME_MK3 defintion.  I suspect most of them are
> > > > > > > > > > clones of the FM1216ME MK3 however, so it probably
> > > > > > > > > > won't matter.
> > > > > > > > > > 
> > > > > > > > > > > > > 3. Set charge pump bit
> > > > > > > > > > > > 
> > > > > > > > > > > > This will improve the time to initially tune to
> > > > > > > > > > > > a frequency, but will likely add some noise as
> > > > > > > > > > > > the PLL continues to maintain lock on the
> > > > > > > > > > > > signal.  If there is no way to turn off the CP
> > > > > > > > > > > > after the lock bit is set in the tuner, it's
> > > > > > > > > > > > probably better to leave it off for lower noise
> > > > > > > > > > > > and just live with slower tuning.
> > > > > > > > > > > 
> > > > > > > > > > > We discuss with our windows system programmer
> > > > > > > > > > > about it. He sad that in analog TV mode noise
> > > > > > > > > > > from PLL don't give any problem.
> > > > > > > > > > 
> > > > > > > > > > I would be concerned about phase noise affecting the
> > > > > > > > > > colors or any FM sound carriers.  If the noise isn't
> > > > > > > > > > noticably affecting colors to the human eye (do
> > > > > > > > > > color bars look OK?), or sound to the human ear,
> > > > > > > > > > then OK.
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > >  But in digital TV mode
> > > > > > > > > > > noise from PLL decreased BER.
> > > > > > > > > > 
> > > > > > > > > > I thought the FM1216ME MK3 was an analog only
> > > > > > > > > > tuner.  I guess I don't know DVB-T or cable in
> > > > > > > > > > Europe well enough.
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > > > Leaving the CP bit set should be especially
> > > > > > > > > > > > noticable ad FM noise when set to tune to FM
> > > > > > > > > > > > radio stations. From the FM1236ME_MK3
> > > > > > > > > > > > datasheet: "It is recommended to set CP=0 in
> > > > > > > > > > > > the FM mode at all times." But the VHF low band
> > > > > > > > > > > > control byte is also used when setting FM radio
> > > > > > > > > > > > (AFAICT with a quick look at the code.)
> > > > > > > > > > > 
> > > > > > > > > > > Yes. You are right. We can swith CP off in FM
> > > > > > > > > > > mode.
> > > > > > > > > > 
> > > > > > > > > > OK.  Thank you.
> > > > > > > > > > 
> > > > > > > > > > > With my best regards, Dmitry.
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > Regards,
> > > > > > > > > > Andy
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > Cheers,
> > > > > > > > Mauro
> > > > > > 
> > > > > > 
> > > > 
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> > linux-media" in the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> 

  reply	other threads:[~2009-05-07 13:04 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-22  7:48 [PATCH] FM1216ME_MK3 some changes Dmitri Belimov
2009-04-23  2:08 ` Andy Walls
2009-04-23  1:52   ` hermann pitton
2009-04-23 10:36   ` Dmitri Belimov
2009-04-24  1:43     ` Andy Walls
2009-04-24  1:06       ` hermann pitton
2009-04-24  1:34         ` hermann pitton
2009-04-26 13:58       ` Dmitri Belimov
2009-04-27  4:45         ` hermann pitton
2009-04-27  9:29       ` Dmitri Belimov
2009-04-28  0:11         ` hermann pitton
2009-04-27 10:42           ` Dmitri Belimov
2009-04-28  0:57             ` hermann pitton
2009-04-28  0:20           ` hermann pitton
2009-04-28 18:18         ` Mauro Carvalho Chehab
2009-04-28  9:59           ` Dmitri Belimov
2009-04-29  3:10             ` hermann pitton
2009-04-29 10:12               ` Dmitri Belimov
2009-04-30  0:15                 ` hermann pitton
2009-05-05 18:42                   ` Dmitri Belimov
2009-05-07  0:01                     ` hermann pitton
2009-05-07  3:03                       ` Andy Walls
2009-05-06 23:05                         ` Dmitri Belimov [this message]
2009-05-08  0:08                         ` hermann pitton
2009-05-09  2:01                           ` Andy Walls
2009-05-09  2:27                             ` hermann pitton
2009-05-10  0:43                               ` hermann pitton
2009-05-09 22:52                                 ` Dmitri Belimov
2009-05-11  3:35                                   ` hermann pitton
2009-05-11 10:19                                     ` Mauro Carvalho Chehab
2009-05-12 21:21                                       ` Dmitri Belimov
2009-05-11 10:58                                     ` Dmitri Belimov
     [not found]                                     ` <20090513073757.6177c42e@glory.loctelecom.ru>
2009-05-13 23:44                                       ` hermann pitton
     [not found]                                         ` <20090514101758.04665ab4@glory.loctelecom.ru>
2009-05-14  1:10                                           ` hermann pitton
2009-05-22  0:51                                             ` hermann pitton
2009-04-30  1:14                 ` Andy Walls
2009-05-01  5:18                   ` hermann pitton
2009-05-01 23:55                     ` hermann pitton
2009-05-02  0:52                       ` Andy Walls
2009-05-02  2:05                         ` hermann pitton
2009-05-03  0:29                           ` hermann pitton
2009-05-06 22:58                   ` Dmitri Belimov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090507090506.79f293db@glory.loctelecom.ru \
    --to=d.belimov@gmail.com \
    --cc=awalls@radix.net \
    --cc=hermann-pitton@arcor.de \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.