From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Sachin Sant <sachinp@in.ibm.com>
Cc: Jiri Pirko <jpirko@redhat.com>,
David Miller <davem@davemloft.net>,
linux-next@vger.kernel.org, linuxppc-dev@ozlabs.org,
netdev@vger.kernel.org
Subject: Re: [PowerPC] Next May 8 boot failure: OOPS during ibmveth moduleinit
Date: Tue, 12 May 2009 17:04:58 +1000 [thread overview]
Message-ID: <20090512170458.39c4ffb7.sfr@canb.auug.org.au> (raw)
In-Reply-To: <4A085B3D.5000806@in.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1381 bytes --]
Hi all,
On Mon, 11 May 2009 22:37:09 +0530 Sachin Sant <sachinp@in.ibm.com> wrote:
>
> Jiri Pirko wrote:
> > Fri, May 08, 2009 at 09:57:22PM CEST, davem@davemloft.net wrote:
> >
> >> From: Sachin Sant <sachinp@in.ibm.com>
> >> Date: Fri, 08 May 2009 18:22:48 +0530
> >>
> >>
> >>> Todays Next failed to boot on a Power6 JS22 blade with following oops.
> >>>
> >> Jiri, I suspect this might be your address list changes.
> >>
> >> Although that's just a guess. But please take a look.
> >>
> >
> > Hmm, only thing I see might cause the problem would be if calling __hw_addr_add
> > in dev_addr_init fails, then dev->dev_addr would contain zeroes (which looks
> > this is not the case). But in this case the oops would appear earlier (in
> > ibmveth_probe dev_addr memcpy).
> >
> > Will do the patch which checks the result to behave correctly in case of oom
> > but this imho this wouldn't help. Strange, I will dig into this more tomorrow.
Bisected down to:
commit f001fde5eadd915f4858d22ed70d7040f48767cf
Author: Jiri Pirko <jpirko@redhat.com>
Date: Tue May 5 02:48:28 2009 +0000
net: introduce a list of device addresses dev_addr_list (v6)
I can reproduce this at will on the last three linux-next trees.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Sachin Sant <sachinp@in.ibm.com>
Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org,
linux-next@vger.kernel.org, David Miller <davem@davemloft.net>,
Jiri Pirko <jpirko@redhat.com>
Subject: Re: [PowerPC] Next May 8 boot failure: OOPS during ibmveth moduleinit
Date: Tue, 12 May 2009 17:04:58 +1000 [thread overview]
Message-ID: <20090512170458.39c4ffb7.sfr@canb.auug.org.au> (raw)
In-Reply-To: <4A085B3D.5000806@in.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1381 bytes --]
Hi all,
On Mon, 11 May 2009 22:37:09 +0530 Sachin Sant <sachinp@in.ibm.com> wrote:
>
> Jiri Pirko wrote:
> > Fri, May 08, 2009 at 09:57:22PM CEST, davem@davemloft.net wrote:
> >
> >> From: Sachin Sant <sachinp@in.ibm.com>
> >> Date: Fri, 08 May 2009 18:22:48 +0530
> >>
> >>
> >>> Todays Next failed to boot on a Power6 JS22 blade with following oops.
> >>>
> >> Jiri, I suspect this might be your address list changes.
> >>
> >> Although that's just a guess. But please take a look.
> >>
> >
> > Hmm, only thing I see might cause the problem would be if calling __hw_addr_add
> > in dev_addr_init fails, then dev->dev_addr would contain zeroes (which looks
> > this is not the case). But in this case the oops would appear earlier (in
> > ibmveth_probe dev_addr memcpy).
> >
> > Will do the patch which checks the result to behave correctly in case of oom
> > but this imho this wouldn't help. Strange, I will dig into this more tomorrow.
Bisected down to:
commit f001fde5eadd915f4858d22ed70d7040f48767cf
Author: Jiri Pirko <jpirko@redhat.com>
Date: Tue May 5 02:48:28 2009 +0000
net: introduce a list of device addresses dev_addr_list (v6)
I can reproduce this at will on the last three linux-next trees.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-05-12 7:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 8:02 linux-next: Tree for May 8 Stephen Rothwell
2009-05-08 12:52 ` [PowerPC] Next May 8 boot failure: OOPS during ibmveth module init Sachin Sant
2009-05-08 12:52 ` Sachin Sant
2009-05-08 19:57 ` David Miller
2009-05-08 19:57 ` David Miller
2009-05-08 22:33 ` Jiri Pirko
2009-05-08 22:33 ` Jiri Pirko
2009-05-11 17:07 ` [PowerPC] Next May 8 boot failure: OOPS during ibmveth moduleinit Sachin Sant
2009-05-11 17:07 ` Sachin Sant
2009-05-12 7:04 ` Stephen Rothwell [this message]
2009-05-12 7:04 ` Stephen Rothwell
2009-05-12 7:44 ` Stephen Rothwell
2009-05-12 7:44 ` Stephen Rothwell
2009-05-12 8:16 ` Jiri Pirko
2009-05-12 8:17 ` Wei Yongjun
2009-05-12 8:17 ` Wei Yongjun
2009-05-13 6:39 ` Stephen Rothwell
2009-05-13 6:39 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090512170458.39c4ffb7.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=davem@davemloft.net \
--cc=jpirko@redhat.com \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=sachinp@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.