From: Stephen Rothwell <sfr@canb.auug.org.au> To: David Miller <davem@davemloft.net> Cc: Sachin Sant <sachinp@in.ibm.com>, Jiri Pirko <jpirko@redhat.com>, linux-next@vger.kernel.org, linuxppc-dev@ozlabs.org, netdev@vger.kernel.org Subject: Re: [PowerPC] Next May 8 boot failure: OOPS during ibmveth moduleinit Date: Tue, 12 May 2009 17:44:51 +1000 [thread overview] Message-ID: <20090512174451.eeed4126.sfr@canb.auug.org.au> (raw) In-Reply-To: <20090512170458.39c4ffb7.sfr@canb.auug.org.au> Hi Dave, This fixes it (I wonder if this bug is lurking in any other drivers): From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Tue, 12 May 2009 17:24:02 +1000 Subject: [PATCH] net/ibmveth: fix panic in probe netdev->dev_addr changed from being an array to being a pointer, so we should not take its address for memcpy(). Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> --- drivers/net/ibmveth.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c index 7902e5e..8daffad 100644 --- a/drivers/net/ibmveth.c +++ b/drivers/net/ibmveth.c @@ -1285,7 +1285,7 @@ static int __devinit ibmveth_probe(struct vio_dev *dev, const struct vio_device_ netdev->features |= NETIF_F_LLTX; spin_lock_init(&adapter->stats_lock); - memcpy(&netdev->dev_addr, &adapter->mac_addr, netdev->addr_len); + memcpy(netdev->dev_addr, &adapter->mac_addr, netdev->addr_len); for(i = 0; i<IbmVethNumBufferPools; i++) { struct kobject *kobj = &adapter->rx_buff_pool[i].kobj; -- 1.6.3 -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Rothwell <sfr@canb.auug.org.au> To: David Miller <davem@davemloft.net> Cc: linuxppc-dev@ozlabs.org, linux-next@vger.kernel.org, netdev@vger.kernel.org, Jiri Pirko <jpirko@redhat.com> Subject: Re: [PowerPC] Next May 8 boot failure: OOPS during ibmveth moduleinit Date: Tue, 12 May 2009 17:44:51 +1000 [thread overview] Message-ID: <20090512174451.eeed4126.sfr@canb.auug.org.au> (raw) In-Reply-To: <20090512170458.39c4ffb7.sfr@canb.auug.org.au> Hi Dave, This fixes it (I wonder if this bug is lurking in any other drivers): From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Tue, 12 May 2009 17:24:02 +1000 Subject: [PATCH] net/ibmveth: fix panic in probe netdev->dev_addr changed from being an array to being a pointer, so we should not take its address for memcpy(). Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> --- drivers/net/ibmveth.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c index 7902e5e..8daffad 100644 --- a/drivers/net/ibmveth.c +++ b/drivers/net/ibmveth.c @@ -1285,7 +1285,7 @@ static int __devinit ibmveth_probe(struct vio_dev *dev, const struct vio_device_ netdev->features |= NETIF_F_LLTX; spin_lock_init(&adapter->stats_lock); - memcpy(&netdev->dev_addr, &adapter->mac_addr, netdev->addr_len); + memcpy(netdev->dev_addr, &adapter->mac_addr, netdev->addr_len); for(i = 0; i<IbmVethNumBufferPools; i++) { struct kobject *kobj = &adapter->rx_buff_pool[i].kobj; -- 1.6.3 -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/
next prev parent reply other threads:[~2009-05-12 7:44 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-05-08 8:02 linux-next: Tree for May 8 Stephen Rothwell 2009-05-08 12:52 ` [PowerPC] Next May 8 boot failure: OOPS during ibmveth module init Sachin Sant 2009-05-08 12:52 ` Sachin Sant 2009-05-08 19:57 ` David Miller 2009-05-08 19:57 ` David Miller 2009-05-08 22:33 ` Jiri Pirko 2009-05-08 22:33 ` Jiri Pirko 2009-05-11 17:07 ` [PowerPC] Next May 8 boot failure: OOPS during ibmveth moduleinit Sachin Sant 2009-05-11 17:07 ` Sachin Sant 2009-05-12 7:04 ` Stephen Rothwell 2009-05-12 7:04 ` Stephen Rothwell 2009-05-12 7:44 ` Stephen Rothwell [this message] 2009-05-12 7:44 ` Stephen Rothwell 2009-05-12 8:16 ` Jiri Pirko 2009-05-12 8:17 ` Wei Yongjun 2009-05-12 8:17 ` Wei Yongjun 2009-05-13 6:39 ` Stephen Rothwell 2009-05-13 6:39 ` Stephen Rothwell
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090512174451.eeed4126.sfr@canb.auug.org.au \ --to=sfr@canb.auug.org.au \ --cc=davem@davemloft.net \ --cc=jpirko@redhat.com \ --cc=linux-next@vger.kernel.org \ --cc=linuxppc-dev@ozlabs.org \ --cc=netdev@vger.kernel.org \ --cc=sachinp@in.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.