All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Julia Lawall <julia@diku.dk>
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
	linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/8] arch/mips/txx9: introduce missing kfree, iounmap
Date: Mon, 14 Sep 2009 16:56:18 +0200	[thread overview]
Message-ID: <20090914145618.GB1934@linux-mips.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0909132113520.31000@ask.diku.dk>

On Sun, Sep 13, 2009 at 09:15:18PM +0200, Julia Lawall wrote:

> From: Julia Lawall <julia@diku.dk>
> 
> Error handling code following a kzalloc should free the allocated data.
> Error handling code following an ioremap should iounmap the allocated data.
> 
> The semantic match that finds the first problem is as follows:
> (http://www.emn.fr/x-info/coccinelle/)

Guess this one looks right, applied.

Thanks,

  Ralf

WARNING: multiple messages have this Message-ID (diff)
From: Ralf Baechle <ralf@linux-mips.org>
To: Julia Lawall <julia@diku.dk>
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
	linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/8] arch/mips/txx9: introduce missing kfree, iounmap
Date: Mon, 14 Sep 2009 14:56:18 +0000	[thread overview]
Message-ID: <20090914145618.GB1934@linux-mips.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0909132113520.31000@ask.diku.dk>

On Sun, Sep 13, 2009 at 09:15:18PM +0200, Julia Lawall wrote:

> From: Julia Lawall <julia@diku.dk>
> 
> Error handling code following a kzalloc should free the allocated data.
> Error handling code following an ioremap should iounmap the allocated data.
> 
> The semantic match that finds the first problem is as follows:
> (http://www.emn.fr/x-info/coccinelle/)

Guess this one looks right, applied.

Thanks,

  Ralf

  reply	other threads:[~2009-09-14 14:55 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-11 16:21 [PATCH 1/8] arch/mips/txx9: introduce missing kfree, iounmap Julia Lawall
2009-09-11 16:21 ` Julia Lawall
2009-09-13 14:25 ` Atsushi Nemoto
2009-09-13 14:25   ` Atsushi Nemoto
2009-09-13 15:14   ` Julia Lawall
2009-09-13 15:14     ` Julia Lawall
2009-09-13 15:33     ` Atsushi Nemoto
2009-09-13 15:33       ` Atsushi Nemoto
2009-09-13 15:49       ` Julia Lawall
2009-09-13 15:49         ` Julia Lawall
2009-09-13 19:15       ` Julia Lawall
2009-09-13 19:15         ` Julia Lawall
2009-09-14 14:56         ` Ralf Baechle [this message]
2009-09-14 14:56           ` Ralf Baechle
2009-09-15  5:03         ` Julia Lawall
2009-09-15  5:03           ` Julia Lawall
2009-09-15 15:45           ` Atsushi Nemoto
2009-09-15 15:45             ` Atsushi Nemoto
2009-09-15 15:47             ` Julia Lawall
2009-09-15 15:47               ` Julia Lawall
2009-09-15 15:56             ` Julia Lawall
2009-09-15 15:56               ` Julia Lawall
2009-09-15 14:02         ` Ralf Rösch
2009-09-15 14:02           ` Ralf Rösch
2009-09-15 14:35           ` Julia Lawall
2009-09-15 14:35             ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090914145618.GB1934@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=anemo@mba.ocn.ne.jp \
    --cc=julia@diku.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.