From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: rpurdie@rpsys.net, lenz@cs.wisc.edu,
kernel list <linux-kernel@vger.kernel.org>,
Dirk@Opfer-Online.de, arminlitzel@web.de,
Cyril Hrubis <metan@ucw.cz>,
thommycheck@gmail.com,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
dbaryshkov@gmail.com, omegamoon@gmail.com, eric.y.miao@gmail.com,
utx@penguin.cz, linux-input@vger.kernel.org,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: 32-rc1 aka 32-rc2: warning at manage.c:361 (set_irq_wake), matrix-keypad related?
Date: Tue, 6 Oct 2009 21:36:04 -0700 [thread overview]
Message-ID: <20091007043603.GC10204@core.coreip.homeip.net> (raw)
In-Reply-To: <20091006075816.GA1362@ucw.cz>
On Tue, Oct 06, 2009 at 09:58:17AM +0200, Pavel Machek wrote:
> Hi!
>
> On Mon 2009-10-05 22:06:50, Dmitry Torokhov wrote:
> > On Wed, Sep 30, 2009 at 10:07:46PM +0200, Pavel Machek wrote:
> > >
> > > It complains about unbalanced irq 113 wake disable. That one belongs
> > > to matrix-keypad...
> >
> > I guess some of enable_irq_wake()s fail on your box. Do you see it if
> > you apply the patch below?
>
> I'll do short test. But... if you are right, your patch will just make
> your machine refuse to suspend... right?
>
> Ungood.
It was just a debug patch.
>
> Actually, it seems to break suspend (returns -EINVAL while refusing
> to suspend), warnings are still there, and keyboard is dead after
> failed suspend... double plus ungood.
>
> Aha, so warning is solved: the one in the log is from gpio_buttons.
>
OK, so it looks like your box refuses to set up one of the GPIOs as a
wakeup source... Hmm, either your box is wrong ;) or matrix_keypad
driver needs to maintain a separate list of wakeup GPIOs.
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
thommycheck@gmail.com, dbaryshkov@gmail.com,
Cyril Hrubis <metan@ucw.cz>,
arminlitzel@web.de, kernel list <linux-kernel@vger.kernel.org>,
Dirk@Opfer-Online.de, utx@penguin.cz, lenz@cs.wisc.edu,
rpurdie@rpsys.net, omegamoon@gmail.com,
linux-input@vger.kernel.org, eric.y.miao@gmail.com,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: 32-rc1 aka 32-rc2: warning at manage.c:361 (set_irq_wake), matrix-keypad related?
Date: Tue, 6 Oct 2009 21:36:04 -0700 [thread overview]
Message-ID: <20091007043603.GC10204@core.coreip.homeip.net> (raw)
In-Reply-To: <20091006075816.GA1362@ucw.cz>
On Tue, Oct 06, 2009 at 09:58:17AM +0200, Pavel Machek wrote:
> Hi!
>
> On Mon 2009-10-05 22:06:50, Dmitry Torokhov wrote:
> > On Wed, Sep 30, 2009 at 10:07:46PM +0200, Pavel Machek wrote:
> > >
> > > It complains about unbalanced irq 113 wake disable. That one belongs
> > > to matrix-keypad...
> >
> > I guess some of enable_irq_wake()s fail on your box. Do you see it if
> > you apply the patch below?
>
> I'll do short test. But... if you are right, your patch will just make
> your machine refuse to suspend... right?
>
> Ungood.
It was just a debug patch.
>
> Actually, it seems to break suspend (returns -EINVAL while refusing
> to suspend), warnings are still there, and keyboard is dead after
> failed suspend... double plus ungood.
>
> Aha, so warning is solved: the one in the log is from gpio_buttons.
>
OK, so it looks like your box refuses to set up one of the GPIOs as a
wakeup source... Hmm, either your box is wrong ;) or matrix_keypad
driver needs to maintain a separate list of wakeup GPIOs.
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
To: linux-arm-kernel@lists.infradead.org
Subject: 32-rc1 aka 32-rc2: warning at manage.c:361 (set_irq_wake), matrix-keypad related?
Date: Tue, 6 Oct 2009 21:36:04 -0700 [thread overview]
Message-ID: <20091007043603.GC10204@core.coreip.homeip.net> (raw)
In-Reply-To: <20091006075816.GA1362@ucw.cz>
On Tue, Oct 06, 2009 at 09:58:17AM +0200, Pavel Machek wrote:
> Hi!
>
> On Mon 2009-10-05 22:06:50, Dmitry Torokhov wrote:
> > On Wed, Sep 30, 2009 at 10:07:46PM +0200, Pavel Machek wrote:
> > >
> > > It complains about unbalanced irq 113 wake disable. That one belongs
> > > to matrix-keypad...
> >
> > I guess some of enable_irq_wake()s fail on your box. Do you see it if
> > you apply the patch below?
>
> I'll do short test. But... if you are right, your patch will just make
> your machine refuse to suspend... right?
>
> Ungood.
It was just a debug patch.
>
> Actually, it seems to break suspend (returns -EINVAL while refusing
> to suspend), warnings are still there, and keyboard is dead after
> failed suspend... double plus ungood.
>
> Aha, so warning is solved: the one in the log is from gpio_buttons.
>
OK, so it looks like your box refuses to set up one of the GPIOs as a
wakeup source... Hmm, either your box is wrong ;) or matrix_keypad
driver needs to maintain a separate list of wakeup GPIOs.
--
Dmitry
next prev parent reply other threads:[~2009-10-07 4:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 20:07 32-rc1 aka 32-rc2: warning at manage.c:361 (set_irq_wake), matrix-keypad related? Pavel Machek
2009-09-30 20:07 ` Pavel Machek
2009-09-30 20:07 ` Pavel Machek
2009-10-06 5:06 ` Dmitry Torokhov
2009-10-06 5:06 ` Dmitry Torokhov
2009-10-06 5:06 ` Dmitry Torokhov
2009-10-06 7:58 ` Pavel Machek
2009-10-06 7:58 ` Pavel Machek
2009-10-07 4:36 ` Dmitry Torokhov [this message]
2009-10-07 4:36 ` Dmitry Torokhov
2009-10-07 4:36 ` Dmitry Torokhov
2009-10-07 14:42 ` Eric Miao
2009-10-07 14:42 ` Eric Miao
2009-10-07 14:42 ` Eric Miao
2009-10-07 16:33 ` Dmitry Torokhov
2009-10-07 16:33 ` Dmitry Torokhov
2009-10-07 16:33 ` Dmitry Torokhov
2009-10-07 21:12 ` Pavel Machek
2009-10-07 21:12 ` Pavel Machek
2009-10-07 21:12 ` Pavel Machek
2009-12-03 3:17 ` Dmitry Torokhov
2009-12-03 3:17 ` Dmitry Torokhov
2010-01-02 13:56 ` Pavel Machek
2010-01-02 13:56 ` Pavel Machek
2010-01-02 15:27 ` Pavel Machek
2010-01-02 15:27 ` Pavel Machek
2010-01-02 21:06 ` Pavel Machek
2010-01-02 21:06 ` Pavel Machek
2010-01-03 7:57 ` Dmitry Torokhov
2010-01-03 7:57 ` Dmitry Torokhov
2010-01-03 8:00 ` Pavel Machek
2010-01-03 8:00 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091007043603.GC10204@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=Dirk@Opfer-Online.de \
--cc=arminlitzel@web.de \
--cc=dbaryshkov@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=lenz@cs.wisc.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=metan@ucw.cz \
--cc=omegamoon@gmail.com \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=rpurdie@rpsys.net \
--cc=thommycheck@gmail.com \
--cc=utx@penguin.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.