All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Eric Miao <eric.y.miao@gmail.com>,
	rpurdie@rpsys.net, lenz@cs.wisc.edu,
	kernel list <linux-kernel@vger.kernel.org>,
	Dirk@opfer-online.de, arminlitzel@web.de,
	Cyril Hrubis <metan@ucw.cz>,
	thommycheck@gmail.com,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	dbaryshkov@gmail.com, omegamoon@gmail.com, utx@penguin.cz,
	linux-input@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: 32-rc1 aka 32-rc2: warning at manage.c:361 (set_irq_wake), matrix-keypad related?
Date: Wed, 7 Oct 2009 23:12:26 +0200	[thread overview]
Message-ID: <20091007211225.GB17805@elf.ucw.cz> (raw)
In-Reply-To: <20091007163327.GA12053@core.coreip.homeip.net>


> > > OK, so it looks like your box refuses to set up one of the GPIOs as a
> > > wakeup source... Hmm, either your box is wrong ;) or matrix_keypad
> > > driver needs to maintain a separate list of wakeup GPIOs.
> > >
> > 
> > This is due to the nature of PXA processor, where not every GPIO can
> > be configured as a wakeup source. Mmm.... we can either return a
> > pseudo value indicating setting wakeup on that GPIO is OK (which
> > doesn't sound like a good idea), or we can just ignore the failure of
> > enable_irq_wake() in matrix_keypad?
> 
> We ignore the failure right now in the mainline but that causes stack
> traces on resume as we trying to disable not enabled wakeup GPIOs. That
> was original Pavel's complaint.

Yep...

I'd say that BUG() simply should not trigger if wakeup can not be
enabled/disabled for particular source...?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	Eric Miao <eric.y.miao@gmail.com>,
	dbaryshkov@gmail.com, Cyril Hrubis <metan@ucw.cz>,
	arminlitzel@web.de, kernel list <linux-kernel@vger.kernel.org>,
	Dirk@opfer-online.de, utx@penguin.cz, lenz@cs.wisc.edu,
	rpurdie@rpsys.net, omegamoon@gmail.com,
	linux-input@vger.kernel.org, thommycheck@gmail.com,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: 32-rc1 aka 32-rc2: warning at manage.c:361 (set_irq_wake), matrix-keypad related?
Date: Wed, 7 Oct 2009 23:12:26 +0200	[thread overview]
Message-ID: <20091007211225.GB17805@elf.ucw.cz> (raw)
In-Reply-To: <20091007163327.GA12053@core.coreip.homeip.net>


> > > OK, so it looks like your box refuses to set up one of the GPIOs as a
> > > wakeup source... Hmm, either your box is wrong ;) or matrix_keypad
> > > driver needs to maintain a separate list of wakeup GPIOs.
> > >
> > 
> > This is due to the nature of PXA processor, where not every GPIO can
> > be configured as a wakeup source. Mmm.... we can either return a
> > pseudo value indicating setting wakeup on that GPIO is OK (which
> > doesn't sound like a good idea), or we can just ignore the failure of
> > enable_irq_wake() in matrix_keypad?
> 
> We ignore the failure right now in the mainline but that causes stack
> traces on resume as we trying to disable not enabled wakeup GPIOs. That
> was original Pavel's complaint.

Yep...

I'd say that BUG() simply should not trigger if wakeup can not be
enabled/disabled for particular source...?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: 32-rc1 aka 32-rc2: warning at manage.c:361 (set_irq_wake), matrix-keypad related?
Date: Wed, 7 Oct 2009 23:12:26 +0200	[thread overview]
Message-ID: <20091007211225.GB17805@elf.ucw.cz> (raw)
In-Reply-To: <20091007163327.GA12053@core.coreip.homeip.net>


> > > OK, so it looks like your box refuses to set up one of the GPIOs as a
> > > wakeup source... Hmm, either your box is wrong ;) or matrix_keypad
> > > driver needs to maintain a separate list of wakeup GPIOs.
> > >
> > 
> > This is due to the nature of PXA processor, where not every GPIO can
> > be configured as a wakeup source. Mmm.... we can either return a
> > pseudo value indicating setting wakeup on that GPIO is OK (which
> > doesn't sound like a good idea), or we can just ignore the failure of
> > enable_irq_wake() in matrix_keypad?
> 
> We ignore the failure right now in the mainline but that causes stack
> traces on resume as we trying to disable not enabled wakeup GPIOs. That
> was original Pavel's complaint.

Yep...

I'd say that BUG() simply should not trigger if wakeup can not be
enabled/disabled for particular source...?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2009-10-07 21:13 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-30 20:07 32-rc1 aka 32-rc2: warning at manage.c:361 (set_irq_wake), matrix-keypad related? Pavel Machek
2009-09-30 20:07 ` Pavel Machek
2009-09-30 20:07 ` Pavel Machek
2009-10-06  5:06 ` Dmitry Torokhov
2009-10-06  5:06   ` Dmitry Torokhov
2009-10-06  5:06   ` Dmitry Torokhov
2009-10-06  7:58   ` Pavel Machek
2009-10-06  7:58     ` Pavel Machek
2009-10-07  4:36     ` Dmitry Torokhov
2009-10-07  4:36       ` Dmitry Torokhov
2009-10-07  4:36       ` Dmitry Torokhov
2009-10-07 14:42       ` Eric Miao
2009-10-07 14:42         ` Eric Miao
2009-10-07 14:42         ` Eric Miao
2009-10-07 16:33         ` Dmitry Torokhov
2009-10-07 16:33           ` Dmitry Torokhov
2009-10-07 16:33           ` Dmitry Torokhov
2009-10-07 21:12           ` Pavel Machek [this message]
2009-10-07 21:12             ` Pavel Machek
2009-10-07 21:12             ` Pavel Machek
2009-12-03  3:17             ` Dmitry Torokhov
2009-12-03  3:17               ` Dmitry Torokhov
2010-01-02 13:56               ` Pavel Machek
2010-01-02 13:56                 ` Pavel Machek
2010-01-02 15:27                 ` Pavel Machek
2010-01-02 15:27                   ` Pavel Machek
2010-01-02 21:06                   ` Pavel Machek
2010-01-02 21:06                     ` Pavel Machek
2010-01-03  7:57                 ` Dmitry Torokhov
2010-01-03  7:57                   ` Dmitry Torokhov
2010-01-03  8:00                   ` Pavel Machek
2010-01-03  8:00                     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091007211225.GB17805@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=Dirk@opfer-online.de \
    --cc=arminlitzel@web.de \
    --cc=dbaryshkov@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=eric.y.miao@gmail.com \
    --cc=lenz@cs.wisc.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=metan@ucw.cz \
    --cc=omegamoon@gmail.com \
    --cc=rjw@sisk.pl \
    --cc=rpurdie@rpsys.net \
    --cc=thommycheck@gmail.com \
    --cc=utx@penguin.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.