All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH  kernel 2.6.32-rc5] pcnet_cs: add cis of PreMax PE-200 ethernet pcmcia card
@ 2009-10-25  2:10 Ken Kawasaki
  2009-10-25  2:13 ` Ben Hutchings
  2010-03-05  0:02 ` Ben Hutchings
  0 siblings, 2 replies; 11+ messages in thread
From: Ken Kawasaki @ 2009-10-25  2:10 UTC (permalink / raw)
  To: netdev; +Cc: ben

Hi,

>> > Random question: are CIS files copyrightable?  
>> 
>> The CIS contains the IRQ, ioport-range, voltage information etc
>> like the PCI config space.
>> So I think it is not copyrightable.
>> but Sierra Wireless provided this CIS by GPL.
>[...]

>If it is subject to copyright - which apparently they think it is - then
>when redistributing under GPL we must be able to provide the 'preferred
>form for modification'.  So that leads to the question, is this blob or
>hex file the preferred form?


(1)The CIS contains data only,
    does not contain the code to be executed.
(2)Sierra Wireless provided the binary of the CIS only.
(3)These CIS are stable and does not need to be modified.
(3)The content of the CIS can be seen by the dump_cis utility.

So if someone want to modify the CIS , I think it is OK
to use hex editor.

Best Regards
Ken


^ permalink raw reply	[flat|nested] 11+ messages in thread
* [PATCH]  axnet_cs: fix phy_id detection for bogus Asix chip.
@ 2009-04-05  0:49 Ken Kawasaki
  2009-04-18 23:44 ` [PATCH] pcnet_cs: add cis(firmware) of the Allied Telesis LA-PCM Ken Kawasaki
  0 siblings, 1 reply; 11+ messages in thread
From: Ken Kawasaki @ 2009-04-05  0:49 UTC (permalink / raw)
  To: netdev



axnet_cs:

(1) Some Asix phy return bogus value except 0 or 0xffff.
    Skip this phy_id.

(2) Some Asix chip need to set "select Internal PHY" bit
    at AX88190_init.

Signed-off-by: Ken Kawasaki <ken_kawasaki@spring.nifty.jp>

---

--- linux-2.6.29-git1/drivers/net/pcmcia/axnet_cs.c.orig	2009-03-29 11:55:26.000000000 +0900
+++ linux-2.6.29-git1/drivers/net/pcmcia/axnet_cs.c	2009-03-29 12:01:40.000000000 +0900
@@ -339,7 +339,7 @@ static int axnet_config(struct pcmcia_de
 {
     struct net_device *dev = link->priv;
     axnet_dev_t *info = PRIV(dev);
-    int i, j, last_ret, last_fn;
+    int i, j, j2, last_ret, last_fn;
 
     DEBUG(0, "axnet_config(0x%p)\n", link);
 
@@ -388,6 +388,8 @@ static int axnet_config(struct pcmcia_de
 
     for (i = 0; i < 32; i++) {
 	j = mdio_read(dev->base_addr + AXNET_MII_EEP, i, 1);
+	j2 = mdio_read(dev->base_addr + AXNET_MII_EEP, i, 2);
+	if (j == j2) continue;
 	if ((j != 0) && (j != 0xffff)) break;
     }
 
@@ -398,6 +400,8 @@ static int axnet_config(struct pcmcia_de
  	pcmcia_access_configuration_register(link, &reg);
 	for (i = 0; i < 32; i++) {
 	    j = mdio_read(dev->base_addr + AXNET_MII_EEP, i, 1);
+	    j2 = mdio_read(dev->base_addr + AXNET_MII_EEP, i, 2);
+	    if (j == j2) continue;
 	    if ((j != 0) && (j != 0xffff)) break;
 	}
     }
@@ -1767,6 +1771,9 @@ static void AX88190_init(struct net_devi
 	ei_local->tx1 = ei_local->tx2 = 0;
 	ei_local->txing = 0;
 
+	if (info->flags & IS_AX88790)	/* select Internal PHY */
+		outb(0x10, e8390_base + AXNET_GPIO);
+
 	if (startp) 
 	{
 		outb_p(0xff,  e8390_base + EN0_ISR);



^ permalink raw reply	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2010-03-05 12:46 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-25  2:10 [PATCH kernel 2.6.32-rc5] pcnet_cs: add cis of PreMax PE-200 ethernet pcmcia card Ken Kawasaki
2009-10-25  2:13 ` Ben Hutchings
2010-03-05  0:02 ` Ben Hutchings
2010-03-05 11:21   ` Ken Kawasaki
2010-03-05 12:01     ` Ken Kawasaki
2010-03-05 12:46       ` Ben Hutchings
  -- strict thread matches above, loose matches on Subject: below --
2009-04-05  0:49 [PATCH] axnet_cs: fix phy_id detection for bogus Asix chip Ken Kawasaki
2009-04-18 23:44 ` [PATCH] pcnet_cs: add cis(firmware) of the Allied Telesis LA-PCM Ken Kawasaki
2009-04-26  7:29   ` [PATCH] 3c589_cs: add cis(firmware) of 3Com multifunction pcmcia card Ken Kawasaki
2009-09-13  8:22     ` [PATCH kernel 2.6.31] pcnet_cs: add cis of Linksys " Ken Kawasaki
2009-10-03 22:32       ` [PATCH kernel 2.6.32-rc1] pcnet_cs: add cis of National Semicondoctor's " Ken Kawasaki
2009-10-18  1:39         ` [PATCH kernel 2.6.32-rc5] pcnet_cs: add cis of PreMax PE-200 ethernet " Ken Kawasaki
2009-10-21 19:18           ` Dan Williams
2009-10-22 11:10             ` Ken Kawasaki
2009-10-24 20:33               ` Ben Hutchings
2009-10-30  5:51           ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.