From: Rusty Russell <rusty@rustcorp.com.au>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Hollis Blanchard <hollisb@us.ibm.com>,
Jan Beulich <JBeulich@novell.com>,
akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org,
kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org
Subject: Re: [PATCH] BUILD_BUG_ON: make it handle more cases
Date: Fri, 6 Nov 2009 17:00:26 +1030 [thread overview]
Message-ID: <200911061700.27493.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20091105173842.c94ba501.sfr@canb.auug.org.au>
On Thu, 5 Nov 2009 05:08:42 pm Stephen Rothwell wrote:
> Hi Rusty,
>
> On Thu, 5 Nov 2009 16:58:36 +1030 Rusty Russell <rusty@rustcorp.com.au> wrote:
> >
> > Huh? virtio_has_feature does:
> >
> > if (__builtin_constant_p(fbit))
> > BUILD_BUG_ON(fbit >= 32);
> > else
> > BUG_ON(fbit >= 32);
>
> In Linus' tree (and linux-next) it looks like this:
Ah. My patch series fixes that as part of removing MAYBE_BUILD_BUG_ON.
I've put both in for linux-next.
Cheers,
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
To: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
Cc: Hollis Blanchard
<hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>,
Jan Beulich <JBeulich-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org>,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] BUILD_BUG_ON: make it handle more cases
Date: Fri, 6 Nov 2009 17:00:26 +1030 [thread overview]
Message-ID: <200911061700.27493.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20091105173842.c94ba501.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
On Thu, 5 Nov 2009 05:08:42 pm Stephen Rothwell wrote:
> Hi Rusty,
>
> On Thu, 5 Nov 2009 16:58:36 +1030 Rusty Russell <rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org> wrote:
> >
> > Huh? virtio_has_feature does:
> >
> > if (__builtin_constant_p(fbit))
> > BUILD_BUG_ON(fbit >= 32);
> > else
> > BUG_ON(fbit >= 32);
>
> In Linus' tree (and linux-next) it looks like this:
Ah. My patch series fixes that as part of removing MAYBE_BUILD_BUG_ON.
I've put both in for linux-next.
Cheers,
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Hollis Blanchard <hollisb@us.ibm.com>,
linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org,
linux-next@vger.kernel.org, Jan Beulich <JBeulich@novell.com>,
akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] BUILD_BUG_ON: make it handle more cases
Date: Fri, 6 Nov 2009 17:00:26 +1030 [thread overview]
Message-ID: <200911061700.27493.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20091105173842.c94ba501.sfr@canb.auug.org.au>
On Thu, 5 Nov 2009 05:08:42 pm Stephen Rothwell wrote:
> Hi Rusty,
>
> On Thu, 5 Nov 2009 16:58:36 +1030 Rusty Russell <rusty@rustcorp.com.au> wrote:
> >
> > Huh? virtio_has_feature does:
> >
> > if (__builtin_constant_p(fbit))
> > BUILD_BUG_ON(fbit >= 32);
> > else
> > BUG_ON(fbit >= 32);
>
> In Linus' tree (and linux-next) it looks like this:
Ah. My patch series fixes that as part of removing MAYBE_BUILD_BUG_ON.
I've put both in for linux-next.
Cheers,
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Hollis Blanchard <hollisb@us.ibm.com>,
Jan Beulich <JBeulich@novell.com>,
akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org,
kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org
Subject: Re: [PATCH] BUILD_BUG_ON: make it handle more cases
Date: Fri, 06 Nov 2009 06:42:26 +0000 [thread overview]
Message-ID: <200911061700.27493.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20091105173842.c94ba501.sfr@canb.auug.org.au>
On Thu, 5 Nov 2009 05:08:42 pm Stephen Rothwell wrote:
> Hi Rusty,
>
> On Thu, 5 Nov 2009 16:58:36 +1030 Rusty Russell <rusty@rustcorp.com.au> wrote:
> >
> > Huh? virtio_has_feature does:
> >
> > if (__builtin_constant_p(fbit))
> > BUILD_BUG_ON(fbit >= 32);
> > else
> > BUG_ON(fbit >= 32);
>
> In Linus' tree (and linux-next) it looks like this:
Ah. My patch series fixes that as part of removing MAYBE_BUILD_BUG_ON.
I've put both in for linux-next.
Cheers,
Rusty.
next prev parent reply other threads:[~2009-11-06 6:30 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-29 9:28 linux-next: tree build failure Jan Beulich
2009-09-29 9:28 ` Jan Beulich
2009-09-29 9:28 ` Jan Beulich
2009-09-29 9:28 ` Jan Beulich
2009-09-29 9:51 ` roel kluin
2009-09-29 9:51 ` roel kluin
2009-09-29 9:51 ` roel kluin
2009-09-29 9:51 ` roel kluin
2009-09-30 6:29 ` Jan Beulich
2009-09-30 6:29 ` Jan Beulich
2009-09-30 6:29 ` Jan Beulich
2009-09-30 6:29 ` Jan Beulich
2009-09-29 23:39 ` Hollis Blanchard
2009-09-29 23:39 ` Hollis Blanchard
2009-09-29 23:39 ` Hollis Blanchard
2009-09-29 23:39 ` Hollis Blanchard
2009-09-30 6:35 ` Jan Beulich
2009-09-30 6:35 ` Jan Beulich
2009-09-30 6:35 ` Jan Beulich
2009-09-30 6:35 ` Jan Beulich
2009-10-02 15:48 ` Hollis Blanchard
2009-10-02 15:48 ` Hollis Blanchard
2009-10-02 15:48 ` Hollis Blanchard
2009-10-02 15:48 ` Hollis Blanchard
2009-10-05 6:58 ` Jan Beulich
2009-10-05 6:58 ` Jan Beulich
2009-10-05 6:58 ` Jan Beulich
2009-10-05 6:58 ` Jan Beulich
2009-10-09 19:14 ` Hollis Blanchard
2009-10-09 19:14 ` Hollis Blanchard
2009-10-09 19:14 ` Hollis Blanchard
2009-10-14 22:57 ` Hollis Blanchard
2009-10-14 22:57 ` Hollis Blanchard
2009-10-14 22:57 ` Hollis Blanchard
2009-10-15 7:27 ` Jan Beulich
2009-10-15 7:27 ` Jan Beulich
2009-10-15 7:27 ` Jan Beulich
2009-10-15 7:27 ` Jan Beulich
2009-10-19 18:19 ` Hollis Blanchard
2009-10-19 18:19 ` Hollis Blanchard
2009-10-19 18:19 ` Hollis Blanchard
2009-10-20 1:12 ` Rusty Russell
2009-10-20 1:24 ` Rusty Russell
2009-10-20 1:12 ` Rusty Russell
2009-10-20 1:29 ` Hollis Blanchard
2009-10-20 1:29 ` Hollis Blanchard
2009-10-20 1:29 ` Hollis Blanchard
2009-10-20 1:29 ` Hollis Blanchard
2009-10-20 3:45 ` [PATCH] BUILD_BUG_ON: make it handle more cases Rusty Russell
2009-10-20 3:57 ` Rusty Russell
2009-10-20 3:45 ` Rusty Russell
2009-10-20 3:45 ` Rusty Russell
2009-10-20 13:58 ` Américo Wang
2009-10-20 13:58 ` Américo Wang
2009-10-20 13:58 ` Américo Wang
2009-10-20 14:43 ` Alan Jenkins
2009-10-20 14:43 ` Alan Jenkins
2009-10-20 14:43 ` Alan Jenkins
2009-10-23 1:50 ` Américo Wang
2009-10-23 1:50 ` Américo Wang
2009-10-23 1:50 ` Américo Wang
2009-10-23 1:50 ` Américo Wang
2009-10-22 21:04 ` Hollis Blanchard
2009-10-22 21:04 ` Hollis Blanchard
2009-10-22 21:04 ` Hollis Blanchard
2009-10-22 21:04 ` Hollis Blanchard
2009-10-29 21:30 ` Hollis Blanchard
2009-10-29 21:30 ` Hollis Blanchard
2009-10-29 21:30 ` Hollis Blanchard
2009-11-05 0:20 ` Stephen Rothwell
2009-11-05 0:20 ` Stephen Rothwell
2009-11-05 0:20 ` Stephen Rothwell
2009-11-05 0:20 ` Stephen Rothwell
2009-11-05 6:28 ` Rusty Russell
2009-11-05 6:40 ` Rusty Russell
2009-11-05 6:28 ` Rusty Russell
2009-11-05 6:37 ` Rusty Russell
2009-11-05 6:49 ` Rusty Russell
2009-11-05 6:37 ` Rusty Russell
2009-11-05 6:37 ` Rusty Russell
2009-11-05 6:38 ` Stephen Rothwell
2009-11-05 6:38 ` Stephen Rothwell
2009-11-05 6:38 ` Stephen Rothwell
2009-11-06 6:30 ` Rusty Russell [this message]
2009-11-06 6:42 ` Rusty Russell
2009-11-06 6:30 ` Rusty Russell
2009-11-06 6:30 ` Rusty Russell
2009-11-05 6:01 ` Benjamin Herrenschmidt
2009-11-05 6:01 ` Benjamin Herrenschmidt
2009-11-05 6:01 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2009-09-24 5:21 linux-next: tree build failure Stephen Rothwell
2009-09-24 5:21 ` Stephen Rothwell
2009-09-24 5:21 ` Stephen Rothwell
2009-09-29 0:00 ` Hollis Blanchard
2009-09-29 0:00 ` Hollis Blanchard
2009-09-29 0:00 ` Hollis Blanchard
2009-09-29 0:00 ` Hollis Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911061700.27493.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=JBeulich@novell.com \
--cc=akpm@linux-foundation.org \
--cc=hollisb@us.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.