Re: [RFC,PATCH 14/14] utrace core

[Oleg Nesterov <oleg@redhat.com>]

On 12/08, Peter Zijlstra wrote:
>
> On Tue, 2009-12-08 at 16:04 +0100, Oleg Nesterov wrote:
> > The
> > problem is, this code was developed out-of-tree. That is why we would
> > like to merge it asap, then do other changes which could be easily
> > reviewed.
> >
> > Now, do you really mean we should throw out the working code, rewrite
> > it avoiding these barriers, and resubmit? Sure, everything is possible.
> > But this means another round of out-of-tree development with unclear
> > results.
>
> Out-of-tree development is bad, it having taken lot of effort is no
> excuse for merging ugly.
>
> Now, I'm not against barriers at all, but code that is as barrier heavy
> as this, with such bad comments and no clear indication it was actually
> worth using so many barriers make me wonder.

Well. First of all, I agree at least partly. If you ask me, I feel
that in any case utrace needs more cleanups (in fact, like almost
any code in kernel) even if we forget about the barriers. In no
way utrace is finished or perfect. I think that Roland won't argue ;)

But. It would be much easier to do the futher development step by
step, patch by patch, which the changelogs, with the possibilty to
have the review. And it is much easier to change the code which is
already used by people. And, cleanups/simplifications are the most
hard part of the development.

However, of course I can't "prove" that the current code is "good
enough" for merging.

> Barriers aren't free either, and having multiple such things in quick
> succession isn't nessecarily faster than a lock, but much less obvious.

It is hardly possible to argue.

Oleg.