From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> To: Wu Fengguang <fengguang.wu@intel.com> Cc: "Zheng, Shaohui" <shaohui.zheng@intel.com>, "linux-mm@kvack.org" <linux-mm@kvack.org>, "akpm@linux-foundation.org" <akpm@linux-foundation.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "ak@linux.intel.com" <ak@linux.intel.com>, "y-goto@jp.fujitsu.com" <y-goto@jp.fujitsu.com>, Dave Hansen <haveblue@us.ibm.com>, "x86@kernel.org" <x86@kernel.org> Subject: Re: [PATCH - resend] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel(v1) Date: Tue, 12 Jan 2010 11:39:03 +0900 [thread overview] Message-ID: <20100112113903.89163c46.kamezawa.hiroyu@jp.fujitsu.com> (raw) In-Reply-To: <20100112023307.GA16661@localhost> On Tue, 12 Jan 2010 10:33:08 +0800 Wu Fengguang <fengguang.wu@intel.com> wrote: > Sure, here it is :) > --- > x86: use the generic page_is_ram() > > The generic resource based page_is_ram() works better with memory > hotplug/hotremove. So switch the x86 e820map based code to it. > > CC: Andi Kleen <andi@firstfloor.org> > CC: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > Signed-off-by: Wu Fengguang <fengguang.wu@intel.com> Ack. > +#ifdef CONFIG_X86 > + /* > + * A special case is the first 4Kb of memory; > + * This is a BIOS owned area, not kernel ram, but generally > + * not listed as such in the E820 table. > + */ > + if (pfn == 0) > + return 0; > + > + /* > + * Second special case: Some BIOSen report the PC BIOS > + * area (640->1Mb) as ram even though it is not. > + */ > + if (pfn >= (BIOS_BEGIN >> PAGE_SHIFT) && > + pfn < (BIOS_END >> PAGE_SHIFT)) > + return 0; > +#endif I'm glad if this part is sorted out in clean way ;) Thanks, -Kame
WARNING: multiple messages have this Message-ID (diff)
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> To: Wu Fengguang <fengguang.wu@intel.com> Cc: "Zheng, Shaohui" <shaohui.zheng@intel.com>, "linux-mm@kvack.org" <linux-mm@kvack.org>, "akpm@linux-foundation.org" <akpm@linux-foundation.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "ak@linux.intel.com" <ak@linux.intel.com>, "y-goto@jp.fujitsu.com" <y-goto@jp.fujitsu.com>, Dave Hansen <haveblue@us.ibm.com>, "x86@kernel.org" <x86@kernel.org> Subject: Re: [PATCH - resend] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel(v1) Date: Tue, 12 Jan 2010 11:39:03 +0900 [thread overview] Message-ID: <20100112113903.89163c46.kamezawa.hiroyu@jp.fujitsu.com> (raw) In-Reply-To: <20100112023307.GA16661@localhost> On Tue, 12 Jan 2010 10:33:08 +0800 Wu Fengguang <fengguang.wu@intel.com> wrote: > Sure, here it is :) > --- > x86: use the generic page_is_ram() > > The generic resource based page_is_ram() works better with memory > hotplug/hotremove. So switch the x86 e820map based code to it. > > CC: Andi Kleen <andi@firstfloor.org> > CC: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > Signed-off-by: Wu Fengguang <fengguang.wu@intel.com> Ack. > +#ifdef CONFIG_X86 > + /* > + * A special case is the first 4Kb of memory; > + * This is a BIOS owned area, not kernel ram, but generally > + * not listed as such in the E820 table. > + */ > + if (pfn == 0) > + return 0; > + > + /* > + * Second special case: Some BIOSen report the PC BIOS > + * area (640->1Mb) as ram even though it is not. > + */ > + if (pfn >= (BIOS_BEGIN >> PAGE_SHIFT) && > + pfn < (BIOS_END >> PAGE_SHIFT)) > + return 0; > +#endif I'm glad if this part is sorted out in clean way ;) Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-01-12 2:42 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-01-08 3:32 [PATCH - resend] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel(v1) Zheng, Shaohui 2010-01-08 5:02 ` H. Peter Anvin 2010-01-08 5:02 ` H. Peter Anvin 2010-01-08 5:18 ` Zheng, Shaohui 2010-01-08 5:18 ` Zheng, Shaohui 2010-01-08 19:47 ` Andi Kleen 2010-01-08 19:47 ` Andi Kleen 2010-01-12 0:58 ` KAMEZAWA Hiroyuki 2010-01-12 0:58 ` KAMEZAWA Hiroyuki 2010-01-08 12:48 ` Wu Fengguang 2010-01-08 12:48 ` Wu Fengguang 2010-01-11 2:20 ` Zheng, Shaohui 2010-01-11 2:20 ` Zheng, Shaohui 2010-01-11 12:43 ` Wu Fengguang 2010-01-11 12:43 ` Wu Fengguang 2010-01-12 0:30 ` KAMEZAWA Hiroyuki 2010-01-12 0:30 ` KAMEZAWA Hiroyuki 2010-01-12 1:38 ` Andi Kleen 2010-01-12 1:38 ` Andi Kleen 2010-01-12 1:39 ` KAMEZAWA Hiroyuki 2010-01-12 1:39 ` KAMEZAWA Hiroyuki 2010-01-12 1:50 ` KAMEZAWA Hiroyuki 2010-01-12 1:50 ` KAMEZAWA Hiroyuki 2010-01-12 2:45 ` Wu Fengguang 2010-01-12 2:45 ` Wu Fengguang 2010-01-12 2:33 ` Wu Fengguang 2010-01-12 2:33 ` Wu Fengguang 2010-01-12 2:39 ` KAMEZAWA Hiroyuki [this message] 2010-01-12 2:39 ` KAMEZAWA Hiroyuki 2010-01-12 13:35 ` Wu Fengguang 2010-01-12 13:35 ` Wu Fengguang 2010-01-12 23:01 ` Yinghai Lu 2010-01-12 23:01 ` Yinghai Lu 2010-01-13 2:29 ` Wu Fengguang 2010-01-13 2:29 ` Wu Fengguang 2010-01-12 5:45 ` Zheng, Shaohui 2010-01-12 5:45 ` Zheng, Shaohui 2010-01-12 5:51 ` Zheng, Shaohui 2010-01-12 5:51 ` Zheng, Shaohui
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100112113903.89163c46.kamezawa.hiroyu@jp.fujitsu.com \ --to=kamezawa.hiroyu@jp.fujitsu.com \ --cc=ak@linux.intel.com \ --cc=akpm@linux-foundation.org \ --cc=fengguang.wu@intel.com \ --cc=haveblue@us.ibm.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=shaohui.zheng@intel.com \ --cc=x86@kernel.org \ --cc=y-goto@jp.fujitsu.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.