From: Andi Kleen <ak@linux.intel.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>,
"Zheng, Shaohui" <shaohui.zheng@intel.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"y-goto@jp.fujitsu.com" <y-goto@jp.fujitsu.com>,
Dave Hansen <haveblue@us.ibm.com>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH - resend] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel(v1)
Date: Tue, 12 Jan 2010 02:38:09 +0100 [thread overview]
Message-ID: <4B4BD281.4080009@linux.intel.com> (raw)
In-Reply-To: <20100112093031.0fc6877f.kamezawa.hiroyu@jp.fujitsu.com>
> Hmmm....could you rewrite /dev/mem to use kernel/resource.c other than
> modifing e820 maps. ?
Sorry but responding to bug fixes with "could you please rewrite ..." is
not considered fair. Shaohui is just trying to fix a bug here, not redesigning
a subsystem.
> Two reasons.
> - e820map is considerted to be stable, read-only after boot.
> - We don't need to add more x86 special codes.
We need working memory hotadd.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@linux.intel.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>,
"Zheng, Shaohui" <shaohui.zheng@intel.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"y-goto@jp.fujitsu.com" <y-goto@jp.fujitsu.com>,
Dave Hansen <haveblue@us.ibm.com>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH - resend] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel(v1)
Date: Tue, 12 Jan 2010 02:38:09 +0100 [thread overview]
Message-ID: <4B4BD281.4080009@linux.intel.com> (raw)
In-Reply-To: <20100112093031.0fc6877f.kamezawa.hiroyu@jp.fujitsu.com>
> Hmmm....could you rewrite /dev/mem to use kernel/resource.c other than
> modifing e820 maps. ?
Sorry but responding to bug fixes with "could you please rewrite ..." is
not considered fair. Shaohui is just trying to fix a bug here, not redesigning
a subsystem.
> Two reasons.
> - e820map is considerted to be stable, read-only after boot.
> - We don't need to add more x86 special codes.
We need working memory hotadd.
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-01-12 1:38 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-08 3:32 [PATCH - resend] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel(v1) Zheng, Shaohui
2010-01-08 5:02 ` H. Peter Anvin
2010-01-08 5:02 ` H. Peter Anvin
2010-01-08 5:18 ` Zheng, Shaohui
2010-01-08 5:18 ` Zheng, Shaohui
2010-01-08 19:47 ` Andi Kleen
2010-01-08 19:47 ` Andi Kleen
2010-01-12 0:58 ` KAMEZAWA Hiroyuki
2010-01-12 0:58 ` KAMEZAWA Hiroyuki
2010-01-08 12:48 ` Wu Fengguang
2010-01-08 12:48 ` Wu Fengguang
2010-01-11 2:20 ` Zheng, Shaohui
2010-01-11 2:20 ` Zheng, Shaohui
2010-01-11 12:43 ` Wu Fengguang
2010-01-11 12:43 ` Wu Fengguang
2010-01-12 0:30 ` KAMEZAWA Hiroyuki
2010-01-12 0:30 ` KAMEZAWA Hiroyuki
2010-01-12 1:38 ` Andi Kleen [this message]
2010-01-12 1:38 ` Andi Kleen
2010-01-12 1:39 ` KAMEZAWA Hiroyuki
2010-01-12 1:39 ` KAMEZAWA Hiroyuki
2010-01-12 1:50 ` KAMEZAWA Hiroyuki
2010-01-12 1:50 ` KAMEZAWA Hiroyuki
2010-01-12 2:45 ` Wu Fengguang
2010-01-12 2:45 ` Wu Fengguang
2010-01-12 2:33 ` Wu Fengguang
2010-01-12 2:33 ` Wu Fengguang
2010-01-12 2:39 ` KAMEZAWA Hiroyuki
2010-01-12 2:39 ` KAMEZAWA Hiroyuki
2010-01-12 13:35 ` Wu Fengguang
2010-01-12 13:35 ` Wu Fengguang
2010-01-12 23:01 ` Yinghai Lu
2010-01-12 23:01 ` Yinghai Lu
2010-01-13 2:29 ` Wu Fengguang
2010-01-13 2:29 ` Wu Fengguang
2010-01-12 5:45 ` Zheng, Shaohui
2010-01-12 5:45 ` Zheng, Shaohui
2010-01-12 5:51 ` Zheng, Shaohui
2010-01-12 5:51 ` Zheng, Shaohui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4BD281.4080009@linux.intel.com \
--to=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=haveblue@us.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shaohui.zheng@intel.com \
--cc=x86@kernel.org \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.