All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gleb Natapov <gleb@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	kvm@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, avi@redhat.com, mingo@elte.hu,
	tglx@linutronix.de, riel@redhat.com, cl@linux-foundation.org
Subject: Re: [PATCH v3 04/12] Add "handle page fault" PV helper.
Date: Tue, 19 Jan 2010 19:44:38 +0200	[thread overview]
Message-ID: <20100119174438.GA19450@redhat.com> (raw)
In-Reply-To: <4B55E5D8.1070402@zytor.com>

On Tue, Jan 19, 2010 at 09:03:20AM -0800, H. Peter Anvin wrote:
> On 01/18/2010 10:55 PM, Gleb Natapov wrote:
> >>
> >> What I mean is that vector 14 is page faults -- that's what it is all
> >> about.  Why on Earth do you need another vector?
> >>
> > Because this is not usual pagefault that tell the OS that page is not
> > mapped. This is a notification to a guest OS that the page it is trying
> > to access is swapped out by the host OS. There is nothing guest can do
> > about it except schedule another task. So the guest should handle both
> > type of exceptions: usual #PF when page is not mapped by the guest and
> > new type of notifications. Ideally we would use one of unused exception
> > vectors for new type of notifications.
> > 
> 
> Ah, this kind of stuff.  We have talked about this in the past, and the
> right way to do that is to have the guest OS pick a vector our of the
> standard 0x20-0xff range, and then notify the hypervisor via a hypercall
> which vector to use.
> 
> In Linux this means marking it as a system vector.  Note that there are
> real hardware system vectors which will be mutually exclusive with this,
> e.g. the UV one.

Yes it can be done this way and I'll look into it once more. Using
exception vector is more convenient for three reasons: it allows to pass
additional data in error code, it doesn't require guest to issue EOI,
exception can be injected when interrupts are disabled by a guest. The
last one is not important for now since host doesn't inject notifications
when interrupts are disabled currently. Having Intel allocate one
exception vector for hypervisor use would be really nice though.

--
			Gleb.

WARNING: multiple messages have this Message-ID (diff)
From: Gleb Natapov <gleb@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	kvm@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, avi@redhat.com, mingo@elte.hu,
	tglx@linutronix.de, riel@redhat.com, cl@linux-foundation.org
Subject: Re: [PATCH v3 04/12] Add "handle page fault" PV helper.
Date: Tue, 19 Jan 2010 19:44:38 +0200	[thread overview]
Message-ID: <20100119174438.GA19450@redhat.com> (raw)
In-Reply-To: <4B55E5D8.1070402@zytor.com>

On Tue, Jan 19, 2010 at 09:03:20AM -0800, H. Peter Anvin wrote:
> On 01/18/2010 10:55 PM, Gleb Natapov wrote:
> >>
> >> What I mean is that vector 14 is page faults -- that's what it is all
> >> about.  Why on Earth do you need another vector?
> >>
> > Because this is not usual pagefault that tell the OS that page is not
> > mapped. This is a notification to a guest OS that the page it is trying
> > to access is swapped out by the host OS. There is nothing guest can do
> > about it except schedule another task. So the guest should handle both
> > type of exceptions: usual #PF when page is not mapped by the guest and
> > new type of notifications. Ideally we would use one of unused exception
> > vectors for new type of notifications.
> > 
> 
> Ah, this kind of stuff.  We have talked about this in the past, and the
> right way to do that is to have the guest OS pick a vector our of the
> standard 0x20-0xff range, and then notify the hypervisor via a hypercall
> which vector to use.
> 
> In Linux this means marking it as a system vector.  Note that there are
> real hardware system vectors which will be mutually exclusive with this,
> e.g. the UV one.

Yes it can be done this way and I'll look into it once more. Using
exception vector is more convenient for three reasons: it allows to pass
additional data in error code, it doesn't require guest to issue EOI,
exception can be injected when interrupts are disabled by a guest. The
last one is not important for now since host doesn't inject notifications
when interrupts are disabled currently. Having Intel allocate one
exception vector for hypervisor use would be really nice though.

--
			Gleb.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2010-01-19 17:46 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-05 14:12 [PATCH v3 00/12] KVM: Add host swap event notifications for PV guest Gleb Natapov
2010-01-05 14:12 ` Gleb Natapov
2010-01-05 14:12 ` [PATCH v3 01/12] Move kvm_smp_prepare_boot_cpu() from kvmclock.c to kvm.c Gleb Natapov
2010-01-05 14:12   ` Gleb Natapov
2010-01-05 14:12 ` [PATCH v3 02/12] Add PV MSR to enable asynchronous page faults delivery Gleb Natapov
2010-01-05 14:12   ` Gleb Natapov
2010-01-06  9:57   ` [Qemu-devel] Fw: " Dor Laor
2010-01-06 10:04     ` [Qemu-devel] " Gleb Natapov
2010-01-06 10:28       ` Gerd Hoffmann
2010-01-06 13:20       ` Anthony Liguori
2010-01-05 14:12 ` [PATCH v3 03/12] Add async PF initialization to PV guest Gleb Natapov
2010-01-05 14:12   ` Gleb Natapov
2010-01-05 14:12 ` [PATCH v3 04/12] Add "handle page fault" PV helper Gleb Natapov
2010-01-05 14:12   ` Gleb Natapov
2010-01-14 17:31   ` Peter Zijlstra
2010-01-14 17:31     ` Peter Zijlstra
2010-01-14 17:31     ` Peter Zijlstra
2010-01-17 14:44     ` Gleb Natapov
2010-01-17 14:44       ` Gleb Natapov
2010-01-17 15:09       ` Peter Zijlstra
2010-01-17 15:09         ` Peter Zijlstra
2010-01-17 15:09         ` Peter Zijlstra
2010-01-17 15:12         ` Gleb Natapov
2010-01-17 15:12           ` Gleb Natapov
2010-01-18  9:53         ` Andi Kleen
2010-01-18  9:53           ` Andi Kleen
2010-01-18  9:53           ` Andi Kleen
2010-01-18  8:34       ` H. Peter Anvin
2010-01-18  8:34         ` H. Peter Anvin
2010-01-18  8:50         ` Gleb Natapov
2010-01-18  8:50           ` Gleb Natapov
2010-01-19  1:53           ` H. Peter Anvin
2010-01-19  1:53             ` H. Peter Anvin
2010-01-19  6:55             ` Gleb Natapov
2010-01-19  6:55               ` Gleb Natapov
2010-01-19 17:03               ` H. Peter Anvin
2010-01-19 17:03                 ` H. Peter Anvin
2010-01-19 17:44                 ` Gleb Natapov [this message]
2010-01-19 17:44                   ` Gleb Natapov
2010-01-19 20:10                   ` H. Peter Anvin
2010-01-19 20:10                     ` H. Peter Anvin
2010-01-20 10:02                     ` Gleb Natapov
2010-01-20 10:02                       ` Gleb Natapov
2010-01-20 12:00                       ` Avi Kivity
2010-01-20 12:00                         ` Avi Kivity
2010-01-20 17:18                         ` Rik van Riel
2010-01-20 17:18                           ` Rik van Riel
2010-01-21  8:56                           ` Avi Kivity
2010-01-21  8:56                             ` Avi Kivity
2010-01-20 18:45                         ` H. Peter Anvin
2010-01-20 18:45                           ` H. Peter Anvin
2010-01-21  8:58                           ` Avi Kivity
2010-01-21  8:58                             ` Avi Kivity
2010-01-20 17:43                       ` H. Peter Anvin
2010-01-20 17:43                         ` H. Peter Anvin
2010-01-21  9:02                         ` Avi Kivity
2010-01-21  9:02                           ` Avi Kivity
2010-01-21  9:04                           ` Gleb Natapov
2010-01-21  9:04                             ` Gleb Natapov
2010-01-21  9:05                             ` Avi Kivity
2010-01-21  9:05                               ` Avi Kivity
2010-01-21 15:47                           ` H. Peter Anvin
2010-01-21 15:47                             ` H. Peter Anvin
2010-01-22  7:25                             ` Gleb Natapov
2010-01-22  7:25                               ` Gleb Natapov
2010-01-05 14:12 ` [PATCH v3 05/12] Export __get_user_pages_fast Gleb Natapov
2010-01-05 14:12   ` Gleb Natapov
2010-01-17 15:46   ` Christoph Hellwig
2010-01-17 15:46     ` Christoph Hellwig
2010-01-05 14:12 ` [PATCH v3 06/12] Add get_user_pages() variant that fails if major fault is required Gleb Natapov
2010-01-05 14:12   ` Gleb Natapov
2010-01-17 15:43   ` Christoph Hellwig
2010-01-17 15:43     ` Christoph Hellwig
2010-01-05 14:12 ` [PATCH v3 07/12] Maintain memslot version number Gleb Natapov
2010-01-05 14:12   ` Gleb Natapov
2010-01-05 14:12 ` [PATCH v3 08/12] Inject asynchronous page fault into a guest if page is swapped out Gleb Natapov
2010-01-05 14:12   ` Gleb Natapov
2010-01-05 14:12 ` [PATCH v3 09/12] Retry fault before vmentry Gleb Natapov
2010-01-05 14:12   ` Gleb Natapov
2010-01-05 14:12 ` [PATCH v3 10/12] Handle async PF in non preemptable context Gleb Natapov
2010-01-05 14:12   ` Gleb Natapov
2010-01-05 14:12 ` [PATCH v3 11/12] Let host know whether the guest can handle async PF in non-userspace context Gleb Natapov
2010-01-05 14:12   ` Gleb Natapov
2010-01-05 14:12 ` [PATCH v3 12/12] Send async PF when guest is not in userspace too Gleb Natapov
2010-01-05 14:12   ` Gleb Natapov
2010-01-05 15:05 ` [PATCH v3 00/12] KVM: Add host swap event notifications for PV guest Jun Koi
2010-01-05 15:05   ` Jun Koi
2010-01-05 15:59   ` Rik van Riel
2010-01-05 15:59     ` Rik van Riel
2010-01-05 16:04   ` Avi Kivity
2010-01-05 16:04     ` Avi Kivity
2010-01-06 10:17     ` Jun Koi
2010-01-06 10:17       ` Jun Koi
2010-01-06 10:21       ` Gleb Natapov
2010-01-06 10:21         ` Gleb Natapov
2010-01-08 16:18 ` Marcelo Tosatti
2010-01-08 16:18   ` Marcelo Tosatti
2010-01-08 16:47   ` Gleb Natapov
2010-01-08 16:47     ` Gleb Natapov
2010-01-08 19:24   ` Rik van Riel
2010-01-08 19:24     ` Rik van Riel
2010-01-08 19:30     ` Bryan Donlan
2010-01-08 19:30       ` Bryan Donlan
2010-01-08 19:55       ` Rik van Riel
2010-01-08 19:55         ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100119174438.GA19450@redhat.com \
    --to=gleb@redhat.com \
    --cc=avi@redhat.com \
    --cc=cl@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.