From: Avi Kivity <avi@redhat.com> To: "H. Peter Anvin" <hpa@zytor.com> Cc: Gleb Natapov <gleb@redhat.com>, Peter Zijlstra <peterz@infradead.org>, kvm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mingo@elte.hu, tglx@linutronix.de, riel@redhat.com, cl@linux-foundation.org Subject: Re: [PATCH v3 04/12] Add "handle page fault" PV helper. Date: Thu, 21 Jan 2010 10:58:58 +0200 [thread overview] Message-ID: <4B581752.6080701@redhat.com> (raw) In-Reply-To: <4B574F2E.8080402@zytor.com> On 01/20/2010 08:45 PM, H. Peter Anvin wrote: > On 01/20/2010 04:00 AM, Avi Kivity wrote: > >> On 01/20/2010 12:02 PM, Gleb Natapov wrote: >> >>> I can inject the event as HW interrupt on vector greater then 32 but not >>> go through APIC so EOI will not be required. This sounds >>> non-architectural >>> and I am not sure kernel has entry point code for this kind of event, it >>> has one for exception and one for interrupts that goes through __do_IRQ() >>> which assumes that interrupts should be ACKed. >>> >>> >> Further, we start to interact with the TPR; Linux doesn't use the TPR or >> cr8 but if it does one day we don't want it interfering with apf. >> >> > I don't think the TPR would be involved unless you involve the APIC > (which you absolutely don't want to do.) What I'm trying to figure out > is if you could inject this vector as "external interrupt" and still > have it deliver if IF=0, or if it would cause any other funnies. > No, and it poses problems further down the line if the hardware virtualizes more and more of the APIC as seems likely to happen. External interrupts are asynchronous events, so they're likely not to be guaranteed to be delivered on an instruction boundary like exceptions. Things like interrupt shadow will affect them as well. > As that point, you do not want to go through the do_IRQ path but rather > through your own exception vector entry point (it would be an entry > point which doesn't get an error code, like #UD.) > An error code would actually be useful. -- error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com> To: "H. Peter Anvin" <hpa@zytor.com> Cc: Gleb Natapov <gleb@redhat.com>, Peter Zijlstra <peterz@infradead.org>, kvm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mingo@elte.hu, tglx@linutronix.de, riel@redhat.com, cl@linux-foundation.org Subject: Re: [PATCH v3 04/12] Add "handle page fault" PV helper. Date: Thu, 21 Jan 2010 10:58:58 +0200 [thread overview] Message-ID: <4B581752.6080701@redhat.com> (raw) In-Reply-To: <4B574F2E.8080402@zytor.com> On 01/20/2010 08:45 PM, H. Peter Anvin wrote: > On 01/20/2010 04:00 AM, Avi Kivity wrote: > >> On 01/20/2010 12:02 PM, Gleb Natapov wrote: >> >>> I can inject the event as HW interrupt on vector greater then 32 but not >>> go through APIC so EOI will not be required. This sounds >>> non-architectural >>> and I am not sure kernel has entry point code for this kind of event, it >>> has one for exception and one for interrupts that goes through __do_IRQ() >>> which assumes that interrupts should be ACKed. >>> >>> >> Further, we start to interact with the TPR; Linux doesn't use the TPR or >> cr8 but if it does one day we don't want it interfering with apf. >> >> > I don't think the TPR would be involved unless you involve the APIC > (which you absolutely don't want to do.) What I'm trying to figure out > is if you could inject this vector as "external interrupt" and still > have it deliver if IF=0, or if it would cause any other funnies. > No, and it poses problems further down the line if the hardware virtualizes more and more of the APIC as seems likely to happen. External interrupts are asynchronous events, so they're likely not to be guaranteed to be delivered on an instruction boundary like exceptions. Things like interrupt shadow will affect them as well. > As that point, you do not want to go through the do_IRQ path but rather > through your own exception vector entry point (it would be an entry > point which doesn't get an error code, like #UD.) > An error code would actually be useful. -- error compiling committee.c: too many arguments to function -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-01-21 8:59 UTC|newest] Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-01-05 14:12 [PATCH v3 00/12] KVM: Add host swap event notifications for PV guest Gleb Natapov 2010-01-05 14:12 ` Gleb Natapov 2010-01-05 14:12 ` [PATCH v3 01/12] Move kvm_smp_prepare_boot_cpu() from kvmclock.c to kvm.c Gleb Natapov 2010-01-05 14:12 ` Gleb Natapov 2010-01-05 14:12 ` [PATCH v3 02/12] Add PV MSR to enable asynchronous page faults delivery Gleb Natapov 2010-01-05 14:12 ` Gleb Natapov 2010-01-06 9:57 ` [Qemu-devel] Fw: " Dor Laor 2010-01-06 10:04 ` [Qemu-devel] " Gleb Natapov 2010-01-06 10:28 ` Gerd Hoffmann 2010-01-06 13:20 ` Anthony Liguori 2010-01-05 14:12 ` [PATCH v3 03/12] Add async PF initialization to PV guest Gleb Natapov 2010-01-05 14:12 ` Gleb Natapov 2010-01-05 14:12 ` [PATCH v3 04/12] Add "handle page fault" PV helper Gleb Natapov 2010-01-05 14:12 ` Gleb Natapov 2010-01-14 17:31 ` Peter Zijlstra 2010-01-14 17:31 ` Peter Zijlstra 2010-01-14 17:31 ` Peter Zijlstra 2010-01-17 14:44 ` Gleb Natapov 2010-01-17 14:44 ` Gleb Natapov 2010-01-17 15:09 ` Peter Zijlstra 2010-01-17 15:09 ` Peter Zijlstra 2010-01-17 15:09 ` Peter Zijlstra 2010-01-17 15:12 ` Gleb Natapov 2010-01-17 15:12 ` Gleb Natapov 2010-01-18 9:53 ` Andi Kleen 2010-01-18 9:53 ` Andi Kleen 2010-01-18 9:53 ` Andi Kleen 2010-01-18 8:34 ` H. Peter Anvin 2010-01-18 8:34 ` H. Peter Anvin 2010-01-18 8:50 ` Gleb Natapov 2010-01-18 8:50 ` Gleb Natapov 2010-01-19 1:53 ` H. Peter Anvin 2010-01-19 1:53 ` H. Peter Anvin 2010-01-19 6:55 ` Gleb Natapov 2010-01-19 6:55 ` Gleb Natapov 2010-01-19 17:03 ` H. Peter Anvin 2010-01-19 17:03 ` H. Peter Anvin 2010-01-19 17:44 ` Gleb Natapov 2010-01-19 17:44 ` Gleb Natapov 2010-01-19 20:10 ` H. Peter Anvin 2010-01-19 20:10 ` H. Peter Anvin 2010-01-20 10:02 ` Gleb Natapov 2010-01-20 10:02 ` Gleb Natapov 2010-01-20 12:00 ` Avi Kivity 2010-01-20 12:00 ` Avi Kivity 2010-01-20 17:18 ` Rik van Riel 2010-01-20 17:18 ` Rik van Riel 2010-01-21 8:56 ` Avi Kivity 2010-01-21 8:56 ` Avi Kivity 2010-01-20 18:45 ` H. Peter Anvin 2010-01-20 18:45 ` H. Peter Anvin 2010-01-21 8:58 ` Avi Kivity [this message] 2010-01-21 8:58 ` Avi Kivity 2010-01-20 17:43 ` H. Peter Anvin 2010-01-20 17:43 ` H. Peter Anvin 2010-01-21 9:02 ` Avi Kivity 2010-01-21 9:02 ` Avi Kivity 2010-01-21 9:04 ` Gleb Natapov 2010-01-21 9:04 ` Gleb Natapov 2010-01-21 9:05 ` Avi Kivity 2010-01-21 9:05 ` Avi Kivity 2010-01-21 15:47 ` H. Peter Anvin 2010-01-21 15:47 ` H. Peter Anvin 2010-01-22 7:25 ` Gleb Natapov 2010-01-22 7:25 ` Gleb Natapov 2010-01-05 14:12 ` [PATCH v3 05/12] Export __get_user_pages_fast Gleb Natapov 2010-01-05 14:12 ` Gleb Natapov 2010-01-17 15:46 ` Christoph Hellwig 2010-01-17 15:46 ` Christoph Hellwig 2010-01-05 14:12 ` [PATCH v3 06/12] Add get_user_pages() variant that fails if major fault is required Gleb Natapov 2010-01-05 14:12 ` Gleb Natapov 2010-01-17 15:43 ` Christoph Hellwig 2010-01-17 15:43 ` Christoph Hellwig 2010-01-05 14:12 ` [PATCH v3 07/12] Maintain memslot version number Gleb Natapov 2010-01-05 14:12 ` Gleb Natapov 2010-01-05 14:12 ` [PATCH v3 08/12] Inject asynchronous page fault into a guest if page is swapped out Gleb Natapov 2010-01-05 14:12 ` Gleb Natapov 2010-01-05 14:12 ` [PATCH v3 09/12] Retry fault before vmentry Gleb Natapov 2010-01-05 14:12 ` Gleb Natapov 2010-01-05 14:12 ` [PATCH v3 10/12] Handle async PF in non preemptable context Gleb Natapov 2010-01-05 14:12 ` Gleb Natapov 2010-01-05 14:12 ` [PATCH v3 11/12] Let host know whether the guest can handle async PF in non-userspace context Gleb Natapov 2010-01-05 14:12 ` Gleb Natapov 2010-01-05 14:12 ` [PATCH v3 12/12] Send async PF when guest is not in userspace too Gleb Natapov 2010-01-05 14:12 ` Gleb Natapov 2010-01-05 15:05 ` [PATCH v3 00/12] KVM: Add host swap event notifications for PV guest Jun Koi 2010-01-05 15:05 ` Jun Koi 2010-01-05 15:59 ` Rik van Riel 2010-01-05 15:59 ` Rik van Riel 2010-01-05 16:04 ` Avi Kivity 2010-01-05 16:04 ` Avi Kivity 2010-01-06 10:17 ` Jun Koi 2010-01-06 10:17 ` Jun Koi 2010-01-06 10:21 ` Gleb Natapov 2010-01-06 10:21 ` Gleb Natapov 2010-01-08 16:18 ` Marcelo Tosatti 2010-01-08 16:18 ` Marcelo Tosatti 2010-01-08 16:47 ` Gleb Natapov 2010-01-08 16:47 ` Gleb Natapov 2010-01-08 19:24 ` Rik van Riel 2010-01-08 19:24 ` Rik van Riel 2010-01-08 19:30 ` Bryan Donlan 2010-01-08 19:30 ` Bryan Donlan 2010-01-08 19:55 ` Rik van Riel 2010-01-08 19:55 ` Rik van Riel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4B581752.6080701@redhat.com \ --to=avi@redhat.com \ --cc=cl@linux-foundation.org \ --cc=gleb@redhat.com \ --cc=hpa@zytor.com \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mingo@elte.hu \ --cc=peterz@infradead.org \ --cc=riel@redhat.com \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.