All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] imxfb: add support for i.MX25
Date: Wed, 10 Feb 2010 08:15:13 +0000	[thread overview]
Message-ID: <20100210081512.GA29489@jasper.tkos.co.il> (raw)
In-Reply-To: <20100210075007.GA10185@pengutronix.de>

Hi Uwe,

On Wed, Feb 10, 2010 at 08:50:07AM +0100, Uwe Kleine-König wrote:
> On Wed, Feb 10, 2010 at 09:25:18AM +0200, Baruch Siach wrote:
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> >  drivers/video/Kconfig |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> > index 5a5c303..7ff9acc 100644
> > --- a/drivers/video/Kconfig
> > +++ b/drivers/video/Kconfig
> > @@ -402,7 +402,7 @@ config FB_SA1100
> >  
> >  config FB_IMX
> >  	tristate "Motorola i.MX LCD support"
> > -	depends on FB && (ARCH_MX1 || ARCH_MX2)
> > +	depends on FB && (ARCH_MX1 || ARCH_MX2 || ARCH_MX25)
> Can we make this
> 
> 	depends on FB && HAVE_FB_IMX
> 
> and let the archs select HAVE_FB_IMX?

I just wanted to do the minimal working change. Do you want me to send a patch 
updating each ARCH's Kconfig?

> And is "FB" really necessary?  The snipplet above is in an
> 
> 	menuconfig FB
> 		...
> 	endmenu
> 
> block.  (And there are many other items depending explicitly on FB.)

I don't know. As above, I'd rather do the minimal change.

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

WARNING: multiple messages have this Message-ID (diff)
From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] imxfb: add support for i.MX25
Date: Wed, 10 Feb 2010 10:15:13 +0200	[thread overview]
Message-ID: <20100210081512.GA29489@jasper.tkos.co.il> (raw)
In-Reply-To: <20100210075007.GA10185@pengutronix.de>

Hi Uwe,

On Wed, Feb 10, 2010 at 08:50:07AM +0100, Uwe Kleine-K?nig wrote:
> On Wed, Feb 10, 2010 at 09:25:18AM +0200, Baruch Siach wrote:
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> >  drivers/video/Kconfig |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> > index 5a5c303..7ff9acc 100644
> > --- a/drivers/video/Kconfig
> > +++ b/drivers/video/Kconfig
> > @@ -402,7 +402,7 @@ config FB_SA1100
> >  
> >  config FB_IMX
> >  	tristate "Motorola i.MX LCD support"
> > -	depends on FB && (ARCH_MX1 || ARCH_MX2)
> > +	depends on FB && (ARCH_MX1 || ARCH_MX2 || ARCH_MX25)
> Can we make this
> 
> 	depends on FB && HAVE_FB_IMX
> 
> and let the archs select HAVE_FB_IMX?

I just wanted to do the minimal working change. Do you want me to send a patch 
updating each ARCH's Kconfig?

> And is "FB" really necessary?  The snipplet above is in an
> 
> 	menuconfig FB
> 		...
> 	endmenu
> 
> block.  (And there are many other items depending explicitly on FB.)

I don't know. As above, I'd rather do the minimal change.

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2010-02-10  8:15 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-10  7:25 [PATCH 0/3] mx25: framebuffer support Baruch Siach
2010-02-10  7:25 ` Baruch Siach
2010-02-10  7:25 ` [PATCH 1/3] imxfb: add support for i.MX25 Baruch Siach
2010-02-10  7:25   ` Baruch Siach
2010-02-10  7:50   ` 
2010-02-10  7:50     ` Uwe Kleine-König
2010-02-10  8:15     ` Baruch Siach [this message]
2010-02-10  8:15       ` Baruch Siach
2010-02-10  8:26       ` 
2010-02-10  8:26         ` Uwe Kleine-König
2010-02-10 12:52         ` [PATCH v2] " Baruch Siach
2010-02-10 12:52           ` Baruch Siach
2010-02-10 16:29           ` 
2010-02-10 16:29             ` Uwe Kleine-König
2010-02-11  6:04             ` Baruch Siach
2010-02-11  6:04               ` Baruch Siach
2010-02-11  6:37             ` [PATCH] " Baruch Siach
2010-02-11  6:37               ` Baruch Siach
2010-02-10  7:25 ` [PATCH 2/3] mx25: add platform support for imxfb Baruch Siach
2010-02-10  7:25   ` Baruch Siach
2010-02-10  7:53   ` 
2010-02-10  7:53     ` Uwe Kleine-König
2010-02-10  8:33     ` Baruch Siach
2010-02-10  8:33       ` Baruch Siach
2010-02-10 12:25       ` Baruch Siach
2010-02-10 12:25         ` Baruch Siach
2010-02-10  7:25 ` [PATCH 3/3] mx25pdk: add LCD support Baruch Siach
2010-02-10  7:25   ` Baruch Siach
2010-02-16 15:14 ` [PATCH 0/3] mx25: framebuffer support Baruch Siach
2010-02-16 15:14   ` Baruch Siach
2010-02-16 15:38   ` Florian Tobias Schandinat
2010-02-16 15:38     ` Florian Tobias Schandinat
2010-02-17  9:43   ` Sascha Hauer
2010-02-17  9:43     ` Sascha Hauer
2010-02-17 10:33     ` [PATCH 1/3] imxfb: add support for i.MX25 Baruch Siach
2010-02-17 10:33       ` Baruch Siach
2010-02-17 10:33     ` [PATCH 2/3] mx25: add platform support for imxfb Baruch Siach
2010-02-17 10:33       ` Baruch Siach
2010-02-17 10:33     ` [PATCH 3/3] mx25pdk: add LCD support Baruch Siach
2010-02-17 10:33       ` Baruch Siach
2010-02-17 10:35     ` [PATCH 0/3] mx25: framebuffer support Baruch Siach
2010-02-17 10:35       ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100210081512.GA29489@jasper.tkos.co.il \
    --to=baruch@tkos.co.il \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.