All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] mx25: add platform support for imxfb
Date: Wed, 10 Feb 2010 12:25:30 +0000	[thread overview]
Message-ID: <20100210122530.GD29489@jasper.tkos.co.il> (raw)
In-Reply-To: <20100210083331.GB29489@jasper.tkos.co.il>

Hi Uwe,

On Wed, Feb 10, 2010 at 10:33:31AM +0200, Baruch Siach wrote:
> On Wed, Feb 10, 2010 at 08:53:15AM +0100, Uwe Kleine-König wrote:
> > On Wed, Feb 10, 2010 at 09:25:19AM +0200, Baruch Siach wrote:
> > > @@ -233,6 +242,9 @@ int __init mx25_clocks_init(void)
> > >  	__raw_writel((0xf << 16) | (3 << 26), CRM_BASE + CCM_CGCR1);
> > >  	__raw_writel((1 << 5), CRM_BASE + CCM_CGCR2);
> > >  
> > > +	/* Clock source for lcdc is upll */
> > > +	__raw_writel(__raw_readl(CRM_BASE+0x64) | (1 << 7), CRM_BASE + 0x64);
> > > +
> > Note I didn't look in the hardware manual, but I wonder if that should
> > better go in the enable routine for lcdc?
> 
> OK. I'll do it there.

Oops. I now see that the mx25 DEFINE_CLOCK() macro doesn't allow you currently 
to set an arbitrary .enable routine (following the mx27/mx31/mx35 clock 
implementation). So this gets a little tricky, and I'm not sure it worth the 
trouble. What do you think?

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

WARNING: multiple messages have this Message-ID (diff)
From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] mx25: add platform support for imxfb
Date: Wed, 10 Feb 2010 14:25:30 +0200	[thread overview]
Message-ID: <20100210122530.GD29489@jasper.tkos.co.il> (raw)
In-Reply-To: <20100210083331.GB29489@jasper.tkos.co.il>

Hi Uwe,

On Wed, Feb 10, 2010 at 10:33:31AM +0200, Baruch Siach wrote:
> On Wed, Feb 10, 2010 at 08:53:15AM +0100, Uwe Kleine-K?nig wrote:
> > On Wed, Feb 10, 2010 at 09:25:19AM +0200, Baruch Siach wrote:
> > > @@ -233,6 +242,9 @@ int __init mx25_clocks_init(void)
> > >  	__raw_writel((0xf << 16) | (3 << 26), CRM_BASE + CCM_CGCR1);
> > >  	__raw_writel((1 << 5), CRM_BASE + CCM_CGCR2);
> > >  
> > > +	/* Clock source for lcdc is upll */
> > > +	__raw_writel(__raw_readl(CRM_BASE+0x64) | (1 << 7), CRM_BASE + 0x64);
> > > +
> > Note I didn't look in the hardware manual, but I wonder if that should
> > better go in the enable routine for lcdc?
> 
> OK. I'll do it there.

Oops. I now see that the mx25 DEFINE_CLOCK() macro doesn't allow you currently 
to set an arbitrary .enable routine (following the mx27/mx31/mx35 clock 
implementation). So this gets a little tricky, and I'm not sure it worth the 
trouble. What do you think?

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2010-02-10 12:25 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-10  7:25 [PATCH 0/3] mx25: framebuffer support Baruch Siach
2010-02-10  7:25 ` Baruch Siach
2010-02-10  7:25 ` [PATCH 1/3] imxfb: add support for i.MX25 Baruch Siach
2010-02-10  7:25   ` Baruch Siach
2010-02-10  7:50   ` 
2010-02-10  7:50     ` Uwe Kleine-König
2010-02-10  8:15     ` Baruch Siach
2010-02-10  8:15       ` Baruch Siach
2010-02-10  8:26       ` 
2010-02-10  8:26         ` Uwe Kleine-König
2010-02-10 12:52         ` [PATCH v2] " Baruch Siach
2010-02-10 12:52           ` Baruch Siach
2010-02-10 16:29           ` 
2010-02-10 16:29             ` Uwe Kleine-König
2010-02-11  6:04             ` Baruch Siach
2010-02-11  6:04               ` Baruch Siach
2010-02-11  6:37             ` [PATCH] " Baruch Siach
2010-02-11  6:37               ` Baruch Siach
2010-02-10  7:25 ` [PATCH 2/3] mx25: add platform support for imxfb Baruch Siach
2010-02-10  7:25   ` Baruch Siach
2010-02-10  7:53   ` 
2010-02-10  7:53     ` Uwe Kleine-König
2010-02-10  8:33     ` Baruch Siach
2010-02-10  8:33       ` Baruch Siach
2010-02-10 12:25       ` Baruch Siach [this message]
2010-02-10 12:25         ` Baruch Siach
2010-02-10  7:25 ` [PATCH 3/3] mx25pdk: add LCD support Baruch Siach
2010-02-10  7:25   ` Baruch Siach
2010-02-16 15:14 ` [PATCH 0/3] mx25: framebuffer support Baruch Siach
2010-02-16 15:14   ` Baruch Siach
2010-02-16 15:38   ` Florian Tobias Schandinat
2010-02-16 15:38     ` Florian Tobias Schandinat
2010-02-17  9:43   ` Sascha Hauer
2010-02-17  9:43     ` Sascha Hauer
2010-02-17 10:33     ` [PATCH 1/3] imxfb: add support for i.MX25 Baruch Siach
2010-02-17 10:33       ` Baruch Siach
2010-02-17 10:33     ` [PATCH 2/3] mx25: add platform support for imxfb Baruch Siach
2010-02-17 10:33       ` Baruch Siach
2010-02-17 10:33     ` [PATCH 3/3] mx25pdk: add LCD support Baruch Siach
2010-02-17 10:33       ` Baruch Siach
2010-02-17 10:35     ` [PATCH 0/3] mx25: framebuffer support Baruch Siach
2010-02-17 10:35       ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100210122530.GD29489@jasper.tkos.co.il \
    --to=baruch@tkos.co.il \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.