From: "Bruno Prémont" <bonbons@linux-vserver.org> To: Jiri Kosina <jkosina@suse.cz> Cc: linux-input@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Rick L. Vinyard Jr." <rvinyard@cs.nmsu.edu>, Nicu Pavel <npavel@ituner.com>, Oliver Neukum <oliver@neukum.org>, Jaya Kumar <jayakumar.lkml@gmail.com>, Dmitry Torokhov <dmitry.torokhov@gmail.com> Subject: [PATCH v3 0/6] hid: new driver for PicoLCD device Date: Wed, 24 Mar 2010 23:37:07 +0100 [thread overview] Message-ID: <20100324233707.7243b04d@neptune.home> (raw) This series adds support for PicoLCD USB HID device adding support for the various features in different patches so each patch concentrates on a device class. Changes since revision 2: - drop most inline keywords - use mutex to protect question-wait-for-answer requests - use mutex to protect flash erase+write+write sequence - add support for simulated 8-bit mode (advertised grayscale and translated by "pixel & 0x80 ? 1 : 0" Explaining Jaya's curiosity about my choice, there seem to be (near) no userspace application willing to operate on a 1bpp framebuffer. Simulated 8bpp tested with links (dfbsee has unrelated? issues, fbv seems to always want color map for 8bpp even for grayscale...) Is it correct to call "8bpp grayscale" TRUECOLOR? If not, what's the right FB_VISUAL_* name? - fix a couple checkpatch warnings/errors (there are multiple "longer than 80 char" lines left though I don't think it's worth/readable to kill them all) - extract version check into a separate function - do direct keycode lookup - replace sysfs_{create,remove}_file with device_{create,remove}_file - correct initial update of framebuffer I've not changed the Kconfig part from v2 as an attempt to add sub-options which would select FB, LCD_CLASS, BACKLIGHT_CLASS or LEDS_CLASS ended up in kbuild to complain about a dependency loop for FB. I'm wondering why I didn't get such a loop for first revision when HID_PICOLCD did select everything... As this is build-cosmetic it can be looked into at a later time. The series depends on my previous patch adding HID suspend support (I've not yet looked at improving it). Except that one the series is on top of 2.6.34-rc2. Note that debugfs registration is wrong on hotplug (a fix for this one is waiting in Jiri's upstream branch: http://git.kernel.org/?p=linux/kernel/git/jikos/hid.git;a=commitdiff;h=4da361b69102cdffe73006771eae7504d2cb8736 ) Bruno
WARNING: multiple messages have this Message-ID (diff)
From: "Bruno Prémont" <bonbons@linux-vserver.org> To: Jiri Kosina <jkosina@suse.cz> Cc: linux-input@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Rick L. Vinyard Jr." <rvinyard@cs.nmsu.edu>, Nicu Pavel <npavel@ituner.com>, Oliver Neukum <oliver@neukum.org>, Jaya Kumar <jayakumar.lkml@gmail.com>, Dmitry Torokhov <dmitry.torokhov@gmail.com> Subject: [PATCH v3 0/6] hid: new driver for PicoLCD device Date: Wed, 24 Mar 2010 22:37:07 +0000 [thread overview] Message-ID: <20100324233707.7243b04d@neptune.home> (raw) This series adds support for PicoLCD USB HID device adding support for the various features in different patches so each patch concentrates on a device class. Changes since revision 2: - drop most inline keywords - use mutex to protect question-wait-for-answer requests - use mutex to protect flash erase+write+write sequence - add support for simulated 8-bit mode (advertised grayscale and translated by "pixel & 0x80 ? 1 : 0" Explaining Jaya's curiosity about my choice, there seem to be (near) no userspace application willing to operate on a 1bpp framebuffer. Simulated 8bpp tested with links (dfbsee has unrelated? issues, fbv seems to always want color map for 8bpp even for grayscale...) Is it correct to call "8bpp grayscale" TRUECOLOR? If not, what's the right FB_VISUAL_* name? - fix a couple checkpatch warnings/errors (there are multiple "longer than 80 char" lines left though I don't think it's worth/readable to kill them all) - extract version check into a separate function - do direct keycode lookup - replace sysfs_{create,remove}_file with device_{create,remove}_file - correct initial update of framebuffer I've not changed the Kconfig part from v2 as an attempt to add sub-options which would select FB, LCD_CLASS, BACKLIGHT_CLASS or LEDS_CLASS ended up in kbuild to complain about a dependency loop for FB. I'm wondering why I didn't get such a loop for first revision when HID_PICOLCD did select everything... As this is build-cosmetic it can be looked into at a later time. The series depends on my previous patch adding HID suspend support (I've not yet looked at improving it). Except that one the series is on top of 2.6.34-rc2. Note that debugfs registration is wrong on hotplug (a fix for this one is waiting in Jiri's upstream branch: http://git.kernel.org/?p=linux/kernel/git/jikos/hid.git;a=commitdiff;hMa361b69102cdffe73006771eae7504d2cb8736 ) Bruno
next reply other threads:[~2010-03-24 23:01 UTC|newest] Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-03-24 22:37 Bruno Prémont [this message] 2010-03-24 22:37 ` [PATCH v3 0/6] hid: new driver for PicoLCD device Bruno Prémont 2010-03-24 22:40 ` [PATCH v3 1/6] " Bruno Prémont 2010-03-24 22:40 ` Bruno Prémont 2010-03-24 22:40 ` Bruno Prémont 2010-03-26 6:56 ` Dmitry Torokhov 2010-03-26 6:56 ` Dmitry Torokhov 2010-03-26 9:29 ` Bruno Prémont 2010-03-26 9:29 ` Bruno Prémont 2010-03-26 9:29 ` Bruno Prémont 2010-03-26 20:59 ` Jiri Kosina 2010-03-26 20:59 ` Jiri Kosina 2010-03-26 20:59 ` Jiri Kosina 2010-03-26 21:16 ` Dmitry Torokhov 2010-03-26 21:16 ` Dmitry Torokhov 2010-03-26 21:16 ` Dmitry Torokhov 2010-03-26 21:39 ` Bruno Prémont 2010-03-26 21:39 ` Bruno Prémont 2010-03-26 21:39 ` Bruno Prémont 2010-03-27 0:22 ` [PATCH v4 " Bruno Prémont 2010-03-27 0:22 ` Bruno Prémont 2010-03-29 9:47 ` Jiri Kosina 2010-03-29 9:47 ` Jiri Kosina 2010-03-29 9:47 ` Jiri Kosina 2010-03-29 10:16 ` Bruno Prémont 2010-03-29 10:16 ` Bruno Prémont 2010-03-30 8:12 ` Jiri Kosina 2010-03-30 8:12 ` Jiri Kosina 2010-03-30 8:12 ` Jiri Kosina 2010-03-30 20:32 ` [PATCH v6 0/8] " Bruno Prémont 2010-03-30 20:32 ` Bruno Prémont 2010-03-30 20:32 ` Bruno Prémont 2010-03-30 20:33 ` [PATCH v6 1/8] " Bruno Prémont 2010-03-30 20:33 ` Bruno Prémont 2010-03-30 20:33 ` Bruno Prémont 2010-04-01 16:58 ` Oliver Neukum 2010-04-01 16:58 ` Oliver Neukum 2010-04-01 16:58 ` Oliver Neukum 2010-04-25 19:29 ` [PATCH] hid: split picolcd's operation_mode sysfs attribute Bruno Prémont 2010-04-25 19:29 ` Bruno Prémont 2010-04-25 19:29 ` Bruno Prémont 2010-04-27 13:32 ` Jiri Kosina 2010-04-27 13:32 ` Jiri Kosina 2010-04-27 13:32 ` Jiri Kosina 2010-03-30 20:34 ` [PATCH v6 2/8] hid: add framebuffer support to PicoLCD device Bruno Prémont 2010-03-30 20:34 ` Bruno Prémont 2010-03-30 20:35 ` [PATCH v6 3/8] hid: add backlight " Bruno Prémont 2010-03-30 20:35 ` Bruno Prémont 2010-03-30 20:35 ` Bruno Prémont 2010-03-30 20:36 ` [PATCH v6 4/8] hid: add lcd " Bruno Prémont 2010-03-30 20:36 ` Bruno Prémont 2010-03-30 20:36 ` Bruno Prémont 2010-03-30 20:36 ` [PATCH v6 5/8] hid: add GPO (leds) " Bruno Prémont 2010-03-30 20:36 ` Bruno Prémont 2010-03-30 20:36 ` Bruno Prémont 2010-03-30 20:38 ` [PATCH v6 6/8] hid: add experimental access to PicoLCD device's EEPROM and FLASH Bruno Prémont 2010-03-30 20:38 ` [PATCH v6 6/8] hid: add experimental access to PicoLCD device's Bruno Prémont 2010-03-30 20:42 ` [PATCH v6 7/8, needs improvement] hid: add suspend/resume hooks for hid drivers Bruno Prémont 2010-03-30 20:42 ` [PATCH v6 7/8, needs improvement] hid: add suspend/resume hooks for Bruno Prémont 2010-03-31 12:15 ` [PATCH v6 7/8, needs improvement] hid: add suspend/resume hooks for hid drivers Jiri Kosina 2010-03-31 12:15 ` [PATCH v6 7/8, needs improvement] hid: add suspend/resume hooks Jiri Kosina 2010-03-31 12:15 ` [PATCH v6 7/8, needs improvement] hid: add suspend/resume hooks for hid drivers Jiri Kosina 2010-04-11 11:02 ` Bruno Prémont 2010-04-11 11:02 ` Bruno Prémont 2010-04-11 13:38 ` Oliver Neukum 2010-04-11 13:38 ` Oliver Neukum 2010-04-11 18:31 ` Jiri Kosina 2010-04-11 18:31 ` Jiri Kosina 2010-04-11 18:40 ` Bruno Prémont 2010-04-11 20:27 ` Oliver Neukum 2010-04-11 20:27 ` Oliver Neukum 2010-04-12 11:43 ` Jiri Kosina 2010-04-12 16:56 ` Bruno Prémont 2010-04-12 16:56 ` Bruno Prémont 2010-04-12 19:45 ` Oliver Neukum 2010-04-12 19:45 ` Oliver Neukum 2010-03-30 20:43 ` [PATCH v6 8/8] hid: add PM support to PicoLCD device Bruno Prémont 2010-03-30 20:43 ` Bruno Prémont 2010-03-30 20:43 ` Bruno Prémont 2010-03-31 9:28 ` [PATCH v6 0/8] hid: new driver for " Jiri Kosina 2010-03-31 9:28 ` Jiri Kosina 2010-03-31 9:28 ` Jiri Kosina 2010-03-24 22:49 ` [PATCH v3 2/6] hid: add framebuffer support to " Bruno Prémont 2010-03-24 22:49 ` Bruno Prémont 2010-03-24 22:49 ` Bruno Prémont 2010-03-27 0:22 ` [PATCH v4 " Bruno Prémont 2010-03-27 0:22 ` Bruno Prémont 2010-03-29 20:30 ` [PATCH v5 " Bruno Prémont 2010-03-29 20:30 ` Bruno Prémont 2010-03-24 22:51 ` [PATCH v3 3/6] hid: add backlight " Bruno Prémont 2010-03-24 22:51 ` Bruno Prémont 2010-03-24 22:51 ` Bruno Prémont 2010-03-24 22:54 ` [PATCH v3 4/6] hid: add lcd " Bruno Prémont 2010-03-24 22:54 ` Bruno Prémont 2010-03-24 22:54 ` Bruno Prémont 2010-03-24 22:55 ` [PATCH v3 5/6] hid: add GPO (leds) " Bruno Prémont 2010-03-24 22:55 ` Bruno Prémont 2010-03-24 22:55 ` Bruno Prémont 2010-03-24 22:58 ` [PATCH v3 6/6] hid: add experimental access to PicoLCD device's EEPROM and FLASH Bruno Prémont 2010-03-24 22:58 ` [PATCH v3 6/6] hid: add experimental access to PicoLCD device's Bruno Prémont 2010-03-24 22:58 ` [PATCH v3 6/6] hid: add experimental access to PicoLCD device's EEPROM and FLASH Bruno Prémont 2010-03-29 9:44 ` Jiri Kosina 2010-03-29 9:44 ` [PATCH v3 6/6] hid: add experimental access to PicoLCD device's Jiri Kosina 2010-03-29 20:34 ` [PATCH v4 6/6] hid: add experimental access to PicoLCD device's EEPROM and FLASH Bruno Prémont 2010-03-29 20:34 ` [PATCH v4 6/6] hid: add experimental access to PicoLCD device's Bruno Prémont 2010-03-29 20:34 ` [PATCH v4 6/6] hid: add experimental access to PicoLCD device's EEPROM and FLASH Bruno Prémont
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100324233707.7243b04d@neptune.home \ --to=bonbons@linux-vserver.org \ --cc=dmitry.torokhov@gmail.com \ --cc=jayakumar.lkml@gmail.com \ --cc=jkosina@suse.cz \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=npavel@ituner.com \ --cc=oliver@neukum.org \ --cc=rvinyard@cs.nmsu.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.