From: "Bruno Prémont" <bonbons@linux-vserver.org> To: Jiri Kosina <jkosina@suse.cz> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-input@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Rick L. Vinyard Jr." <rvinyard@cs.nmsu.edu>, Nicu Pavel <npavel@ituner.com>, Oliver Neukum <oliver@neukum.org>, Jaya Kumar <jayakumar.lkml@gmail.com> Subject: Re: [PATCH v4 1/6] hid: new driver for PicoLCD device Date: Mon, 29 Mar 2010 12:16:11 +0200 [thread overview] Message-ID: <20100329121611.0c22dcaf@pluto.restena.lu> (raw) In-Reply-To: <alpine.LNX.2.00.1003291144350.24576@pobox.suse.cz> On Mon, 29 Mar 2010 11:47:27 +0200 Jiri Kosina <jkosina@suse.cz> wrote: > On Sat, 27 Mar 2010, Bruno Prémont wrote: > > > +#ifdef CONFIG_PM > > +static int picolcd_suspend(struct hid_device *hdev) > > +{ > > + dbg_hid(PICOLCD_NAME " device ready for suspend\n"); > > + return 0; > > +} > > + > > +static int picolcd_resume(struct hid_device *hdev) > > +{ > > + return 0; > > +} > > + > > +static int picolcd_reset_resume(struct hid_device *hdev) > > +{ > > + int ret; > > + ret = picolcd_reset(hdev); > > + if (ret) > > + dbg_hid(PICOLCD_NAME " resetting our device failed: %d\n", ret); > > + return 0; > > +} > > +#endif > [ ... ] > > +static struct hid_driver picolcd_driver = { > > + .name = "hid-picolcd", > > + .id_table = picolcd_devices, > > + .probe = picolcd_probe, > > + .remove = picolcd_remove, > > + .raw_event = picolcd_raw_event, > > +#ifdef CONFIG_PM > > + .suspend = picolcd_suspend, > > + .resume = picolcd_resume, > > + .reset_resume = picolcd_reset_resume, > > +#endif > > +}; > > struct hid_driver doesn't provide power-management related callbacks. > So I guess that you have either not tested this feature at all, or > you have some extra patch somewhere which adds such callbacks to HID > core, but you haven't sent it out for review? > > In any cases, this will very likely cause compilation failure with > CONFIG_PM turned on. That's the patch I referred to (under series introduction mail) when saying: > The series depends on my previous patch adding HID suspend support > (I've not yet looked at improving it). Link to the patch: http://lkml.org/lkml/2010/2/24/233 Especially the reset-resume part is important as the device has to be reprogrammed with framebuffer content, brightness/contrast in that case. As stated, Oliver didn't like the implementation of the addition of those hooks too much and I have yet to look at improving it. Thanks, Bruno
WARNING: multiple messages have this Message-ID (diff)
From: "Bruno Prémont" <bonbons@linux-vserver.org> To: Jiri Kosina <jkosina@suse.cz> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-input@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Rick L. Vinyard Jr." <rvinyard@cs.nmsu.edu>, Nicu Pavel <npavel@ituner.com>, Oliver Neukum <oliver@neukum.org>, Jaya Kumar <jayakumar.lkml@gmail.com> Subject: Re: [PATCH v4 1/6] hid: new driver for PicoLCD device Date: Mon, 29 Mar 2010 10:16:11 +0000 [thread overview] Message-ID: <20100329121611.0c22dcaf@pluto.restena.lu> (raw) In-Reply-To: <alpine.LNX.2.00.1003291144350.24576@pobox.suse.cz> On Mon, 29 Mar 2010 11:47:27 +0200 Jiri Kosina <jkosina@suse.cz> wrote: > On Sat, 27 Mar 2010, Bruno Prémont wrote: > > > +#ifdef CONFIG_PM > > +static int picolcd_suspend(struct hid_device *hdev) > > +{ > > + dbg_hid(PICOLCD_NAME " device ready for suspend\n"); > > + return 0; > > +} > > + > > +static int picolcd_resume(struct hid_device *hdev) > > +{ > > + return 0; > > +} > > + > > +static int picolcd_reset_resume(struct hid_device *hdev) > > +{ > > + int ret; > > + ret = picolcd_reset(hdev); > > + if (ret) > > + dbg_hid(PICOLCD_NAME " resetting our device failed: %d\n", ret); > > + return 0; > > +} > > +#endif > [ ... ] > > +static struct hid_driver picolcd_driver = { > > + .name = "hid-picolcd", > > + .id_table = picolcd_devices, > > + .probe = picolcd_probe, > > + .remove = picolcd_remove, > > + .raw_event = picolcd_raw_event, > > +#ifdef CONFIG_PM > > + .suspend = picolcd_suspend, > > + .resume = picolcd_resume, > > + .reset_resume = picolcd_reset_resume, > > +#endif > > +}; > > struct hid_driver doesn't provide power-management related callbacks. > So I guess that you have either not tested this feature at all, or > you have some extra patch somewhere which adds such callbacks to HID > core, but you haven't sent it out for review? > > In any cases, this will very likely cause compilation failure with > CONFIG_PM turned on. That's the patch I referred to (under series introduction mail) when saying: > The series depends on my previous patch adding HID suspend support > (I've not yet looked at improving it). Link to the patch: http://lkml.org/lkml/2010/2/24/233 Especially the reset-resume part is important as the device has to be reprogrammed with framebuffer content, brightness/contrast in that case. As stated, Oliver didn't like the implementation of the addition of those hooks too much and I have yet to look at improving it. Thanks, Bruno
next prev parent reply other threads:[~2010-03-29 10:16 UTC|newest] Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-03-24 22:37 [PATCH v3 0/6] hid: new driver for PicoLCD device Bruno Prémont 2010-03-24 22:37 ` Bruno Prémont 2010-03-24 22:40 ` [PATCH v3 1/6] " Bruno Prémont 2010-03-24 22:40 ` Bruno Prémont 2010-03-24 22:40 ` Bruno Prémont 2010-03-26 6:56 ` Dmitry Torokhov 2010-03-26 6:56 ` Dmitry Torokhov 2010-03-26 9:29 ` Bruno Prémont 2010-03-26 9:29 ` Bruno Prémont 2010-03-26 9:29 ` Bruno Prémont 2010-03-26 20:59 ` Jiri Kosina 2010-03-26 20:59 ` Jiri Kosina 2010-03-26 20:59 ` Jiri Kosina 2010-03-26 21:16 ` Dmitry Torokhov 2010-03-26 21:16 ` Dmitry Torokhov 2010-03-26 21:16 ` Dmitry Torokhov 2010-03-26 21:39 ` Bruno Prémont 2010-03-26 21:39 ` Bruno Prémont 2010-03-26 21:39 ` Bruno Prémont 2010-03-27 0:22 ` [PATCH v4 " Bruno Prémont 2010-03-27 0:22 ` Bruno Prémont 2010-03-29 9:47 ` Jiri Kosina 2010-03-29 9:47 ` Jiri Kosina 2010-03-29 9:47 ` Jiri Kosina 2010-03-29 10:16 ` Bruno Prémont [this message] 2010-03-29 10:16 ` Bruno Prémont 2010-03-30 8:12 ` Jiri Kosina 2010-03-30 8:12 ` Jiri Kosina 2010-03-30 8:12 ` Jiri Kosina 2010-03-30 20:32 ` [PATCH v6 0/8] " Bruno Prémont 2010-03-30 20:32 ` Bruno Prémont 2010-03-30 20:32 ` Bruno Prémont 2010-03-30 20:33 ` [PATCH v6 1/8] " Bruno Prémont 2010-03-30 20:33 ` Bruno Prémont 2010-03-30 20:33 ` Bruno Prémont 2010-04-01 16:58 ` Oliver Neukum 2010-04-01 16:58 ` Oliver Neukum 2010-04-01 16:58 ` Oliver Neukum 2010-04-25 19:29 ` [PATCH] hid: split picolcd's operation_mode sysfs attribute Bruno Prémont 2010-04-25 19:29 ` Bruno Prémont 2010-04-25 19:29 ` Bruno Prémont 2010-04-27 13:32 ` Jiri Kosina 2010-04-27 13:32 ` Jiri Kosina 2010-04-27 13:32 ` Jiri Kosina 2010-03-30 20:34 ` [PATCH v6 2/8] hid: add framebuffer support to PicoLCD device Bruno Prémont 2010-03-30 20:34 ` Bruno Prémont 2010-03-30 20:35 ` [PATCH v6 3/8] hid: add backlight " Bruno Prémont 2010-03-30 20:35 ` Bruno Prémont 2010-03-30 20:35 ` Bruno Prémont 2010-03-30 20:36 ` [PATCH v6 4/8] hid: add lcd " Bruno Prémont 2010-03-30 20:36 ` Bruno Prémont 2010-03-30 20:36 ` Bruno Prémont 2010-03-30 20:36 ` [PATCH v6 5/8] hid: add GPO (leds) " Bruno Prémont 2010-03-30 20:36 ` Bruno Prémont 2010-03-30 20:36 ` Bruno Prémont 2010-03-30 20:38 ` [PATCH v6 6/8] hid: add experimental access to PicoLCD device's EEPROM and FLASH Bruno Prémont 2010-03-30 20:38 ` [PATCH v6 6/8] hid: add experimental access to PicoLCD device's Bruno Prémont 2010-03-30 20:42 ` [PATCH v6 7/8, needs improvement] hid: add suspend/resume hooks for hid drivers Bruno Prémont 2010-03-30 20:42 ` [PATCH v6 7/8, needs improvement] hid: add suspend/resume hooks for Bruno Prémont 2010-03-31 12:15 ` [PATCH v6 7/8, needs improvement] hid: add suspend/resume hooks for hid drivers Jiri Kosina 2010-03-31 12:15 ` [PATCH v6 7/8, needs improvement] hid: add suspend/resume hooks Jiri Kosina 2010-03-31 12:15 ` [PATCH v6 7/8, needs improvement] hid: add suspend/resume hooks for hid drivers Jiri Kosina 2010-04-11 11:02 ` Bruno Prémont 2010-04-11 11:02 ` Bruno Prémont 2010-04-11 13:38 ` Oliver Neukum 2010-04-11 13:38 ` Oliver Neukum 2010-04-11 18:31 ` Jiri Kosina 2010-04-11 18:31 ` Jiri Kosina 2010-04-11 18:40 ` Bruno Prémont 2010-04-11 20:27 ` Oliver Neukum 2010-04-11 20:27 ` Oliver Neukum 2010-04-12 11:43 ` Jiri Kosina 2010-04-12 16:56 ` Bruno Prémont 2010-04-12 16:56 ` Bruno Prémont 2010-04-12 19:45 ` Oliver Neukum 2010-04-12 19:45 ` Oliver Neukum 2010-03-30 20:43 ` [PATCH v6 8/8] hid: add PM support to PicoLCD device Bruno Prémont 2010-03-30 20:43 ` Bruno Prémont 2010-03-30 20:43 ` Bruno Prémont 2010-03-31 9:28 ` [PATCH v6 0/8] hid: new driver for " Jiri Kosina 2010-03-31 9:28 ` Jiri Kosina 2010-03-31 9:28 ` Jiri Kosina 2010-03-24 22:49 ` [PATCH v3 2/6] hid: add framebuffer support to " Bruno Prémont 2010-03-24 22:49 ` Bruno Prémont 2010-03-24 22:49 ` Bruno Prémont 2010-03-27 0:22 ` [PATCH v4 " Bruno Prémont 2010-03-27 0:22 ` Bruno Prémont 2010-03-29 20:30 ` [PATCH v5 " Bruno Prémont 2010-03-29 20:30 ` Bruno Prémont 2010-03-24 22:51 ` [PATCH v3 3/6] hid: add backlight " Bruno Prémont 2010-03-24 22:51 ` Bruno Prémont 2010-03-24 22:51 ` Bruno Prémont 2010-03-24 22:54 ` [PATCH v3 4/6] hid: add lcd " Bruno Prémont 2010-03-24 22:54 ` Bruno Prémont 2010-03-24 22:54 ` Bruno Prémont 2010-03-24 22:55 ` [PATCH v3 5/6] hid: add GPO (leds) " Bruno Prémont 2010-03-24 22:55 ` Bruno Prémont 2010-03-24 22:55 ` Bruno Prémont 2010-03-24 22:58 ` [PATCH v3 6/6] hid: add experimental access to PicoLCD device's EEPROM and FLASH Bruno Prémont 2010-03-24 22:58 ` [PATCH v3 6/6] hid: add experimental access to PicoLCD device's Bruno Prémont 2010-03-24 22:58 ` [PATCH v3 6/6] hid: add experimental access to PicoLCD device's EEPROM and FLASH Bruno Prémont 2010-03-29 9:44 ` Jiri Kosina 2010-03-29 9:44 ` [PATCH v3 6/6] hid: add experimental access to PicoLCD device's Jiri Kosina 2010-03-29 20:34 ` [PATCH v4 6/6] hid: add experimental access to PicoLCD device's EEPROM and FLASH Bruno Prémont 2010-03-29 20:34 ` [PATCH v4 6/6] hid: add experimental access to PicoLCD device's Bruno Prémont 2010-03-29 20:34 ` [PATCH v4 6/6] hid: add experimental access to PicoLCD device's EEPROM and FLASH Bruno Prémont
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100329121611.0c22dcaf@pluto.restena.lu \ --to=bonbons@linux-vserver.org \ --cc=dmitry.torokhov@gmail.com \ --cc=jayakumar.lkml@gmail.com \ --cc=jkosina@suse.cz \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=npavel@ituner.com \ --cc=oliver@neukum.org \ --cc=rvinyard@cs.nmsu.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.