From: Al Viro <viro@ZenIV.linux.org.uk> To: Linus Torvalds <torvalds@linux-foundation.org> Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Maciej Rutecki <maciej.rutecki@gmail.com>, Andrew Morton <akpm@linux-foundation.org>, Kernel Testers List <kernel-testers@vger.kernel.org>, Network Development <netdev@vger.kernel.org>, Linux ACPI <linux-acpi@vger.kernel.org>, Linux PM List <linux-pm@lists.linux-foundation.org>, Linux SCSI List <linux-scsi@vger.kernel.org>, Linux Wireless List <linux-wireless@vger.kernel.org>, DRI <dri-devel@lists.sourceforge.net> Subject: Re: 2.6.34-rc3-git6: Reported regressions from 2.6.33 Date: Wed, 7 Apr 2010 23:19:41 +0100 [thread overview] Message-ID: <20100407221941.GL30031@ZenIV.linux.org.uk> (raw) In-Reply-To: <alpine.LFD.2.00.1004071444440.3586@i5.linux-foundation.org> On Wed, Apr 07, 2010 at 03:04:46PM -0700, Linus Torvalds wrote: > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15674 > > Subject : [2.6.34-rc2 NFS4 oops] open error path failure... > > Submitter : Daniel J Blueman <daniel.blueman@gmail.com> > > Date : 2010-03-29 18:36 (10 days old) > > Message-ID : <6278d2221003291136p6481fe8emfb039403343c082@mail.gmail.com> > > References : http://marc.info/?l=linux-kernel&m=126988782722711&w=2 > > This smells like the same LOOKUP_DIRECTORY thing as the first entry, but.. No, it's not the same thing; the fix is to have nfs ->d_revalidate() return an error on failing open attempt (in insane codepath that has ->d_revalidate() handling open()). Confirmed to work by reporter... diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index d79a7b3..fe0cd9e 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -2068,8 +2068,7 @@ nfs4_open_revalidate(struct inode *dir, struct dentry *dentry, int openflags, st case -EDQUOT: case -ENOSPC: case -EROFS: - lookup_instantiate_filp(nd, (struct dentry *)state, NULL); - return 1; + return PTR_ERR(state); default: goto out_drop; }
WARNING: multiple messages have this Message-ID
From: Al Viro <viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org> To: Linus Torvalds <torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> Cc: "Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org>, Linux Kernel Mailing List <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Maciej Rutecki <maciej.rutecki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>, Kernel Testers List <kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Network Development <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Linux ACPI <linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Linux PM List <linux-pm-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>, Linux SCSI List <linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Linux Wireless List <linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, DRI <dri-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> Subject: Re: 2.6.34-rc3-git6: Reported regressions from 2.6.33 Date: Wed, 7 Apr 2010 23:19:41 +0100 [thread overview] Message-ID: <20100407221941.GL30031@ZenIV.linux.org.uk> (raw) In-Reply-To: <alpine.LFD.2.00.1004071444440.3586-GpypE611fyS63QaFMGN2QEqCLAeBNdoH@public.gmane.org> On Wed, Apr 07, 2010 at 03:04:46PM -0700, Linus Torvalds wrote: > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15674 > > Subject : [2.6.34-rc2 NFS4 oops] open error path failure... > > Submitter : Daniel J Blueman <daniel.blueman-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > Date : 2010-03-29 18:36 (10 days old) > > Message-ID : <6278d2221003291136p6481fe8emfb039403343c082-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> > > References : http://marc.info/?l=linux-kernel&m=126988782722711&w=2 > > This smells like the same LOOKUP_DIRECTORY thing as the first entry, but.. No, it's not the same thing; the fix is to have nfs ->d_revalidate() return an error on failing open attempt (in insane codepath that has ->d_revalidate() handling open()). Confirmed to work by reporter... diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index d79a7b3..fe0cd9e 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -2068,8 +2068,7 @@ nfs4_open_revalidate(struct inode *dir, struct dentry *dentry, int openflags, st case -EDQUOT: case -ENOSPC: case -EROFS: - lookup_instantiate_filp(nd, (struct dentry *)state, NULL); - return 1; + return PTR_ERR(state); default: goto out_drop; }
next prev parent reply other threads:[~2010-04-07 22:19 UTC|newest] Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-04-07 21:08 Rafael J. Wysocki 2010-04-07 21:08 ` Rafael J. Wysocki 2010-04-07 21:08 ` [Bug #15480] [regression] Fails to boot properly unless given pci=nocrs Rafael J. Wysocki 2010-04-07 22:02 ` Bjorn Helgaas 2010-04-08 19:54 ` Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15553] Screen backlight doesn't come back on after lid was closed (GM45) Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15505] No more b43 wireless interface since 2.6.34-rc1 Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15518] CONFIG_NO_BOOTMEM=y breaks boot on 32bit Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15551] WARNING: at net/mac80211/work.c:811 ieee80211_work_work+0x7f/0xde8 [mac80211]() Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15600] CONFIG_NO_BOOTMEM woes, 2.6.34-rc1 Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15589] 2.6.34-rc1: Badness at fs/proc/generic.c:316 Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15603] lockdep warning at boot time when determining whether to resume Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15590] 2.6.34-rc1: regression: ^Z no longer stops sound Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15601] [BUG] SLOB breaks Crypto Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15615] NULL pointer deref in task_is_waking Rafael J. Wysocki 2010-04-08 7:16 ` Liang Li 2010-04-08 7:50 ` Yong Zhang 2010-04-08 8:20 ` Liang Li 2010-04-07 21:13 ` [Bug #15611] Failure with the 2.6.34-rc1 kernel Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15610] fsck leads to swapper - BUG: unable to handle kernel NULL pointer dereference & panic Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15619] Regression - Linux 2.6.34-rc1 - i915 - Render error detected Rafael J. Wysocki 2010-04-08 7:32 ` Fabio Comolli 2010-04-08 20:00 ` Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15625] BUG: 2.6.34-rc1, RIP is (null) Rafael J. Wysocki 2010-04-12 3:00 ` Randy Dunlap 2010-04-12 23:09 ` Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15624] [BUG] percpu misaligned allocation Rafael J. Wysocki 2010-04-07 21:59 ` Frederic Weisbecker 2010-04-08 20:02 ` Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15664] Graphics hang and kernel backtrace when starting Azureus with Compiz enabled Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15659] [Regresion] [2.6.34-rc1] [drm:i915_hangcheck_elapsed] *ERROR* Hangcheck timer elapsed... GPU hung Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15655] corrupt ext3 fs and partial freeze Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15661] PROBLEM: crash on halt with 2.6.34-0.16.rc2.git0.fc14.x86_64 Rafael J. Wysocki 2010-04-08 2:29 ` Yong Zhang 2010-04-08 20:04 ` Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15673] 2.6.34-rc2: "ima_dec_counts: open/free imbalance"? Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15669] INFO: suspicious rcu_dereference_check() Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15671] intel graphic card hanging (Hangcheck timer elapsed... GPU hung) Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15668] start_kernel(): bug: interrupts were enabled early Rafael J. Wysocki 2010-04-07 22:32 ` H. Peter Anvin 2010-04-08 20:06 ` Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15672] KVM bug, git bisected Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15711] 2.6.34-rc3, BUG at mm/slab.c:2989 Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15704] [r8169] WARNING: at net/sched/sch_generic.c Rafael J. Wysocki 2010-04-14 10:12 ` Sergey Senozhatsky 2010-04-15 17:16 ` Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15712] [regression] 2.6.34-rc1 to -rc3 on zaurus: no longer boots Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15674] [2.6.34-rc2 NFS4 oops] open error path failure Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15718] File corruption regression on NFS related to commit 1f36f774 Rafael J. Wysocki 2010-04-08 11:56 ` Boaz Harrosh 2010-04-08 20:10 ` Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15716] ata2: lost interrupt with kernel 2.6.34-rc1 Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15717] bluetooth oops Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15713] hackbench regression due to commit 9dfc6e68bfe6e Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15715] vmscan: underflow for get_scan_ratio Rafael J. Wysocki 2010-04-07 22:05 ` Linus Torvalds 2010-04-08 20:09 ` Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15719] virtio_net causing kernel BUG when running under VirtualBox Rafael J. Wysocki 2010-04-12 8:39 ` Thomas Müller 2010-04-12 9:28 ` David Miller 2010-04-12 9:50 ` Thomas Müller 2010-04-13 5:01 ` David Miller 2010-04-07 21:53 ` 2.6.34-rc3-git6: Reported regressions from 2.6.33 John W. Linville 2010-04-07 21:53 ` John W. Linville 2010-04-07 22:04 ` Linus Torvalds 2010-04-07 22:04 ` Linus Torvalds 2010-04-07 22:19 ` Al Viro [this message] 2010-04-07 22:19 ` Al Viro 2010-04-07 22:22 ` Linus Torvalds 2010-04-07 22:22 ` Linus Torvalds 2010-04-07 22:22 ` Linus Torvalds 2010-04-07 23:06 ` Al Viro 2010-04-07 23:06 ` Al Viro 2010-04-07 23:06 ` Al Viro 2010-04-07 22:19 ` Al Viro 2010-04-08 20:24 ` Rafael J. Wysocki 2010-04-08 20:24 ` Rafael J. Wysocki 2010-04-08 20:24 ` Rafael J. Wysocki 2010-04-07 21:08 Rafael J. Wysocki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100407221941.GL30031@ZenIV.linux.org.uk \ --to=viro@zeniv.linux.org.uk \ --cc=akpm@linux-foundation.org \ --cc=dri-devel@lists.sourceforge.net \ --cc=kernel-testers@vger.kernel.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@lists.linux-foundation.org \ --cc=linux-scsi@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=maciej.rutecki@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=rjw@sisk.pl \ --cc=torvalds@linux-foundation.org \ --subject='Re: 2.6.34-rc3-git6: Reported regressions from 2.6.33' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.