From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Joey Lee <jlee@novell.com>
Cc: dri-devel@lists.sourceforge.net, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, Dennis.Jansen@web.de
Subject: Re: [PATCH] Add intel drm blacklist to intel_opregion_present detect
Date: Mon, 12 Jul 2010 16:19:36 +0100 [thread overview]
Message-ID: <20100712151936.GA13235@srcf.ucam.org> (raw)
In-Reply-To: <4C3BBD6D020000230001CD30@novprvlin0050.provo.novell.com>
On Mon, Jul 12, 2010 at 09:12:13AM -0600, Joey Lee wrote:
> M... Follow your suggestion, I am tracing the i915 drm driver and
> Poulsbo drm driver from here:
>
> http://sourceforge.net/mailarchive/message.php?msg_name=49C2ADA8.2090405%40shipmail.org
>
> I am not sure fully understood your suggestion... Did you mean we can
> extract some parts from Poulsbo drm driver and put it to a stub
> backlight control driver for Poulsbo? Where can we put the stub driver?
> Do we still put it in i915 drm?
Pretty much, yeah. You'd need the interrupt handler and the backlight
control and pretty much nothing else. It should be a separate driver
under drivers/gpu and ideally the opregion code would be sufficiently
abstracted to work with it.
> On the other hand, the Poulsbo is a old and stop ship chip, do we still
> want to add a special driver for it?
Yeah, that's my concern. There's millions of things in the wild and
Intel continue to refuse to take responsibility for them, so it's not
clear to me that it's worth putting the effort into writing a "correct"
driver.
> Thank's for your remind, I fully agreed cann't guarantee all poulsbo
> systems have working acpi method. But, I am sure the MSI U110/U115 have
> workable acpi backlight method.
> Do you think it's good to put the special DMI detection in msi-laptop
> driver to enable the the acpi backlight control by call
> acpi_video_register in acpi video? But will cause msi-laptop driver
> dependency to acpi video driver.
Mm. Well, we *know* that opregion won't work on Poulsbo as is (even
Intel's driver doesn't implement it), so there's no way this patch can
make things any worse. On the other hand, if anyone ships an OS with
this hack *and* a native psb driver, I'm going to look sad for some
time.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-07-12 15:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 15:12 [PATCH] Add intel drm blacklist to intel_opregion_present detect Joey Lee
2010-07-12 15:12 ` Joey Lee
2010-07-12 15:19 ` Matthew Garrett [this message]
2010-07-12 15:19 ` Matthew Garrett
-- strict thread matches above, loose matches on Subject: below --
2010-08-25 9:52 Joey Lee
2010-08-25 9:52 ` Joey Lee
2010-08-24 14:51 Joey Lee
2010-08-24 14:51 ` Joey Lee
2010-08-24 10:08 Joey Lee
2010-08-24 10:08 ` Joey Lee
2010-08-24 14:20 ` Matthew Garrett
2010-08-24 14:22 ` Matthew Garrett
2010-08-24 14:51 ` Greg KH
2010-08-24 14:58 ` Matthew Garrett
2010-08-24 21:35 ` Greg KH
2010-08-24 7:03 Joey Lee
2010-08-24 7:03 ` Joey Lee
2010-08-24 4:53 Joey Lee
2010-08-24 4:53 ` Joey Lee
2010-08-23 12:43 Joey Lee
2010-08-23 12:43 ` Joey Lee
2010-08-23 11:40 Lee, Chun-Yi
2010-08-23 11:49 ` Matthew Garrett
2010-08-23 17:53 ` Thomas Renninger
2010-08-23 17:51 ` Matthew Garrett
2010-08-23 14:18 ` Thomas Renninger
2010-07-13 8:13 Joey Lee
2010-07-13 8:13 ` Joey Lee
2010-07-13 8:13 Joey Lee
2010-07-12 15:12 Joey Lee
[not found] <4C3B06C9020000230001CC2C@novprvlin0050.provo.novell.com>
2010-07-12 2:27 ` Matthew Garrett
2010-07-11 0:30 Lee, Chun-Yi
2010-07-11 0:29 Lee, Chun-Yi
2010-07-11 14:27 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100712151936.GA13235@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=Dennis.Jansen@web.de \
--cc=dri-devel@lists.sourceforge.net \
--cc=jlee@novell.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.