All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Joey Lee <jlee@novell.com>,
	trenn@suse.de, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org, Dennis.Jansen@web.de
Subject: Re: [PATCH] Add intel drm blacklist to intel_opregion_present detect
Date: Tue, 24 Aug 2010 07:51:30 -0700	[thread overview]
Message-ID: <20100824145130.GA26232@suse.de> (raw)
In-Reply-To: <20100824142219.GB16200@srcf.ucam.org>

On Tue, Aug 24, 2010 at 03:22:19PM +0100, Matthew Garrett wrote:
> Erm. Sorry about that - I just realised that there's actually a fairly 
> significant problem with it :) Right now you'll perform the register 
> call unconditionally on module load. You need to make sure that there's 
> actually Poulsbo hardware in the system, either by registering as a 
> proper PCI driver and calling acpi_video_register in your probe function 
> (and unregister in your remove function) or walking the PCI device list 
> looking for a psb device.

Ick, don't walk the pci device list, just register a "real" pci device
and do it that way, it's much simpler and plays nicer with the driver
model and the rest of the kernel.

thanks,

greg k-h

  reply	other threads:[~2010-08-24 14:51 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-24 10:08 [PATCH] Add intel drm blacklist to intel_opregion_present detect Joey Lee
2010-08-24 10:08 ` Joey Lee
2010-08-24 14:20 ` Matthew Garrett
2010-08-24 14:22 ` Matthew Garrett
2010-08-24 14:51   ` Greg KH [this message]
2010-08-24 14:58     ` Matthew Garrett
2010-08-24 21:35       ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2010-08-25  9:52 Joey Lee
2010-08-25  9:52 ` Joey Lee
2010-08-24 14:51 Joey Lee
2010-08-24 14:51 ` Joey Lee
2010-08-24  7:03 Joey Lee
2010-08-24  7:03 ` Joey Lee
2010-08-24  4:53 Joey Lee
2010-08-24  4:53 ` Joey Lee
2010-08-23 12:43 Joey Lee
2010-08-23 12:43 ` Joey Lee
2010-08-23 11:40 Lee, Chun-Yi
2010-08-23 11:49 ` Matthew Garrett
2010-08-23 17:53   ` Thomas Renninger
2010-08-23 17:51     ` Matthew Garrett
2010-08-23 14:18 ` Thomas Renninger
2010-07-13  8:13 Joey Lee
2010-07-13  8:13 ` Joey Lee
2010-07-13  8:13 Joey Lee
2010-07-12 15:12 Joey Lee
2010-07-12 15:12 Joey Lee
2010-07-12 15:12 ` Joey Lee
2010-07-12 15:19 ` Matthew Garrett
2010-07-12 15:19 ` Matthew Garrett
     [not found] <4C3B06C9020000230001CC2C@novprvlin0050.provo.novell.com>
2010-07-12  2:27 ` Matthew Garrett
2010-07-11  0:30 Lee, Chun-Yi
2010-07-11  0:29 Lee, Chun-Yi
2010-07-11 14:27 ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100824145130.GA26232@suse.de \
    --to=gregkh@suse.de \
    --cc=Dennis.Jansen@web.de \
    --cc=jlee@novell.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.