All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Lee, Chun-Yi" <joeyli.kernel@gmail.com>
Cc: linux-kernel@vger.kernel.org, gregkh@suse.de, jlee@novell.com,
	Dennis.Jansen@web.de, linux-acpi@vger.kernel.org, trenn@suse.de
Subject: Re: [PATCH] Add intel drm blacklist to intel_opregion_present detect
Date: Mon, 23 Aug 2010 12:49:38 +0100	[thread overview]
Message-ID: <20100823114938.GA19879@srcf.ucam.org> (raw)
In-Reply-To: <1282563648-21935-1-git-send-email-jlee@novell.com>

On Mon, Aug 23, 2010 at 07:40:48PM +0800, Lee, Chun-Yi wrote:
> There have some machines not support by i915 drm driver, e.g. MSI U110/U150,
> there are use poulsbo chip and drm driver not support it because legal issue.
> Those machines's acpi backlight control actually work fine and don't need apply
> the intel opregion support.
> So, add intel drm blacklist to intel_opregion_present, it can enable the acpi
> brightness interface on Poulsbo/Morrestown.

I'm still kind of reluctant about this - doing the blacklisting here 
means that there's no way for a native driver to inhibit registration 
from occuring until after opregion setup has taken place, and we found 
that that was necessary on some 915 so I suspect it is on gma500 as 
well. Perhaps it should just be done as a module option, and then 
distributions who want to deal with this case could set it by default?

> +	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_MRST_VGA_0) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_MRST_VGA_1) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_MRST_VGA_2) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_MRST_VGA_3) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_MRST_VGA_4) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_MRST_VGA_5) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_MRST_VGA_6) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_MRST_VGA_7) },

Moorestown doesn't have ACPI, so I don't think there's any need to 
include these.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2010-08-23 11:49 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-23 11:40 [PATCH] Add intel drm blacklist to intel_opregion_present detect Lee, Chun-Yi
2010-08-23 11:49 ` Matthew Garrett [this message]
2010-08-23 17:53   ` Thomas Renninger
2010-08-23 17:51     ` Matthew Garrett
2010-08-23 14:18 ` Thomas Renninger
  -- strict thread matches above, loose matches on Subject: below --
2010-08-25  9:52 Joey Lee
2010-08-25  9:52 ` Joey Lee
2010-08-24 14:51 Joey Lee
2010-08-24 14:51 ` Joey Lee
2010-08-24 10:08 Joey Lee
2010-08-24 10:08 ` Joey Lee
2010-08-24 14:20 ` Matthew Garrett
2010-08-24 14:22 ` Matthew Garrett
2010-08-24 14:51   ` Greg KH
2010-08-24 14:58     ` Matthew Garrett
2010-08-24 21:35       ` Greg KH
2010-08-24  7:03 Joey Lee
2010-08-24  7:03 ` Joey Lee
2010-08-24  4:53 Joey Lee
2010-08-24  4:53 ` Joey Lee
2010-08-23 12:43 Joey Lee
2010-08-23 12:43 ` Joey Lee
2010-07-13  8:13 Joey Lee
2010-07-13  8:13 ` Joey Lee
2010-07-13  8:13 Joey Lee
2010-07-12 15:12 Joey Lee
2010-07-12 15:12 Joey Lee
2010-07-12 15:12 ` Joey Lee
2010-07-12 15:19 ` Matthew Garrett
2010-07-12 15:19 ` Matthew Garrett
     [not found] <4C3B06C9020000230001CC2C@novprvlin0050.provo.novell.com>
2010-07-12  2:27 ` Matthew Garrett
2010-07-11  0:30 Lee, Chun-Yi
2010-07-11  0:29 Lee, Chun-Yi
2010-07-11 14:27 ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100823114938.GA19879@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=Dennis.Jansen@web.de \
    --cc=gregkh@suse.de \
    --cc=jlee@novell.com \
    --cc=joeyli.kernel@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.