All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: Dan McGee <dpmcgee@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/3] git-instaweb: Fix custom apache log placement
Date: Thu, 22 Jul 2010 16:42:56 -0700	[thread overview]
Message-ID: <20100722234256.GA19581@dcvr.yhbt.net> (raw)
In-Reply-To: <AANLkTiknXtteX77h8Uy1JuWmGLWSSRkAGkS3INMOHBoJ@mail.gmail.com>

Dan McGee <dpmcgee@gmail.com> wrote:
> On Tue, Jun 29, 2010 at 9:44 PM, Dan McGee <dpmcgee@gmail.com> wrote:
> > 'CustomLog' is provided by mod_log_config so we need to include the module
> > in our generated config. This was added in d94775e1f9a.
> >
> > Signed-off-by: Dan McGee <dpmcgee@gmail.com>
> 
> I noticed this set of patches didn't go anywhere...at least the first
> two were more bug fixes than improvements so I would have expected
> them to get into 1.7.2. Did they get lost in the shuffle?
> 
> 1: http://marc.info/?l=git&m=127786592330110&w=2
> 2: http://marc.info/?l=git&m=127786592030105&w=2
> 3: http://marc.info/?l=git&m=127791591706076&w=2

Hi Dan, can you address Junio's concerns here?

  http://marc.info/?l=git&m=127791382102449&w=2

Thanks.

-- 
Eric Wong

  reply	other threads:[~2010-07-22 23:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-30  2:44 [PATCH 1/3] git-instaweb: Fix custom apache log placement Dan McGee
2010-06-30  2:44 ` [PATCH 2/3] git-instaweb: Fix Apache environment variable passing Dan McGee
2010-06-30  2:45 ` [PATCH 3/3] git-instaweb: Don't assume Apache executable is named apache2 Dan McGee
2010-06-30  7:31   ` Eric Wong
2010-06-30 12:29     ` Dan McGee
2010-06-30 16:03   ` Junio C Hamano
     [not found]     ` <AANLkTikYNVLM9MrmL819__Viap7ucvmrs7faeC4tdDmn@mail.gmail.com>
2010-06-30 16:38       ` Dan McGee
2010-07-23 18:22         ` Eric Wong
2010-07-22 18:01 ` [PATCH 1/3] git-instaweb: Fix custom apache log placement Dan McGee
2010-07-22 23:42   ` Eric Wong [this message]
2010-07-23 13:40     ` Dan McGee
2010-07-23 17:38       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100722234256.GA19581@dcvr.yhbt.net \
    --to=normalperson@yhbt.net \
    --cc=dpmcgee@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.