Re: [PATCH 1/3] git-instaweb: Fix custom apache log placement

[Junio C Hamano <gitster@pobox.com>]

Dan McGee <dpmcgee@gmail.com> writes:

> On Thu, Jul 22, 2010 at 6:42 PM, Eric Wong <normalperson@yhbt.net> wrote:
> ...
>> Hi Dan, can you address Junio's concerns here?
>>
>> http://marc.info/?l=git&m=127791382102449&w=2
>
> I did already, and got no feedback...
> http://marc.info/?l=git&m=127791591706076&w=2

Thanks for a (half-) pointer [*1*]; I didn't see that message til now.

>> I think you are being overcautious. Even in this case, you can specify
>> the real name of the web server through git-config or command line
>> parameters to make sure it picks up the right settings. 

If there is an HTTP server "httpd" that does not understand Apache style
configuration file given via "-f" (use of which is a misconfiguration this
patch will start allowing users to make), we would need to add a new
codepath to the script to generate a configuration file to support that
server.  I do not think we have a mechanism to disambiguate different HTTP
server implementations that claim to be "httpd", so at that point we would
need to add something other than the command name for disambiguation.  But
for now I think your patch suffices.

As you pointed out, the last "case" statement in instaweb explicitly have
rejected servers we did not know about, so my worry was unfounded; nobody
could have been using a daemon whose name is "httpd", be it ArchLinux's
Apache or something incompatible.

Thanks.


[Footnote]

*1* Links to marc do not have an easy way other than re-typing to get to a
usable message-id to find the message to reply to, so while I wanted to
make this as a reply to your message from June 30th, I couldn't, and
instead I am sending this as a reply to the new message, and I had to copy
and paste the parts of the message I responded to.