All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Dan McGee <dpmcgee@gmail.com>
Cc: git@vger.kernel.org, Eric Wong <normalperson@yhbt.net>
Subject: Re: [PATCH 3/3] git-instaweb: Don't assume Apache executable is named apache2
Date: Wed, 30 Jun 2010 09:03:17 -0700	[thread overview]
Message-ID: <7v39w48q4a.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1277865900-25044-3-git-send-email-dpmcgee@gmail.com> (Dan McGee's message of "Tue\, 29 Jun 2010 21\:45\:00 -0500")

Dan McGee <dpmcgee@gmail.com> writes:

> On Arch Linux, we keep the original 'httpd' name for the exectuable and
> don't rename it or the path to the modules.

Sorry, but I cannot parse the last 6 words here.

> Remove some of these assumptions
> and add the httpd name in where it may be required.
> ...
>  resolve_full_httpd () {
>  	case "$httpd" in
> -	*apache2*|*lighttpd*)
> +	*apache2*|*lighttpd*|*httpd*)
> +		# yes, *httpd* covers *lighttpd* above, but it is there for clarity

That may make things work better on Arch but I wonder if there are
platforms that allow users to point at their favorite, non-Apache, http
server with a canonical name "httpd" that gets broken by this change.  Am
I being too paranoid?

Other two patches looked very sane.  Thanks.

  parent reply	other threads:[~2010-06-30 16:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-30  2:44 [PATCH 1/3] git-instaweb: Fix custom apache log placement Dan McGee
2010-06-30  2:44 ` [PATCH 2/3] git-instaweb: Fix Apache environment variable passing Dan McGee
2010-06-30  2:45 ` [PATCH 3/3] git-instaweb: Don't assume Apache executable is named apache2 Dan McGee
2010-06-30  7:31   ` Eric Wong
2010-06-30 12:29     ` Dan McGee
2010-06-30 16:03   ` Junio C Hamano [this message]
     [not found]     ` <AANLkTikYNVLM9MrmL819__Viap7ucvmrs7faeC4tdDmn@mail.gmail.com>
2010-06-30 16:38       ` Dan McGee
2010-07-23 18:22         ` Eric Wong
2010-07-22 18:01 ` [PATCH 1/3] git-instaweb: Fix custom apache log placement Dan McGee
2010-07-22 23:42   ` Eric Wong
2010-07-23 13:40     ` Dan McGee
2010-07-23 17:38       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v39w48q4a.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=dpmcgee@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=normalperson@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.